[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[ https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813769#comment-13813769 ] Mayank Bansal commented on YARN-979: bq. I still have one question w.r.t. the annotations of the getter/setter of GetRequest/Response. Some of them are marked as @Stable, and some are marked as @Unstable. In addition, some setters are marked as @Private, and some are marked as @Public. Do you have special consideration here? Maybe we should mark all as @Unstable for the initial AHS? Fixed the annotations Thanks, Mayank [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol -- Key: YARN-979 URL: https://issues.apache.org/jira/browse/YARN-979 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch, YARN-979-5.patch, YARN-979-6.patch, YARN-979.2.patch ApplicationHistoryProtocol should have the following APIs as well: * getApplicationAttemptReport * getApplicationAttempts * getContainerReport * getContainers The corresponding request and response classes need to be added as well. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813794#comment-13813794
]
Hadoop QA commented on YARN-979:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12612134/YARN-979-6.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2373//console
This message is automatically generated.
[YARN-321] Add more APIs related to ApplicationAttempt and Container in
ApplicationHistoryProtocol
--
Key: YARN-979
URL: https://issues.apache.org/jira/browse/YARN-979
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch,
YARN-979-5.patch, YARN-979-6.patch, YARN-979.2.patch
ApplicationHistoryProtocol should have the following APIs as well:
* getApplicationAttemptReport
* getApplicationAttempts
* getContainerReport
* getContainers
The corresponding request and response classes need to be added as well.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[ https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814076#comment-13814076 ] Zhijie Shen commented on YARN-979: -- +1 [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol -- Key: YARN-979 URL: https://issues.apache.org/jira/browse/YARN-979 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch, YARN-979-5.patch, YARN-979-6.patch, YARN-979.2.patch ApplicationHistoryProtocol should have the following APIs as well: * getApplicationAttemptReport * getApplicationAttempts * getContainerReport * getContainers The corresponding request and response classes need to be added as well. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813089#comment-13813089
]
Zhijie Shen commented on YARN-979:
--
The patch is almost good with the following minor issues:
* The following javadoc is inconsistent with ApplicationAttemptReport (YARN-978)
{code}
+ * lihost - set to N/A/li
+ * liRPC port - set to -1/li
+ * liclient token - set to N/A/li
+ * lidiagnostics - set to N/A/li
+ * litracking URL - set to N/A/li
{code}
* As is mentioned in the other two jiras, please move
GetApplicationAttemptReportRequestProtoOrBuilder p = viaProto ? proto :
builder; later.
{code}
+ @Override
+ public ApplicationAttemptId getApplicationAttemptId() {
+GetApplicationAttemptReportRequestProtoOrBuilder p
+= viaProto ? proto : builder;
+if (this.applicationAttemptId != null) {
+ return this.applicationAttemptId;
+}
+if (!p.hasApplicationAttemptId()) {
+ return null;
+}
+this.applicationAttemptId =
+convertFromProtoFormat(p.getApplicationAttemptId());
+return this.applicationAttemptId;
+ }
{code}
* You need to change hadoop-yarn-api/pom.xml to make
application_history_client.proto to be compiled.
In addition to the patch's issues, I'd like to raise one design issue here,
projecting some future problems. This patch makes different APIs for
application/attempt/container, which is going to be a super set of the APIs of
ApplicationClientProtocol. Now it's OK if we restrict our problem with the AHS
domain. However, probably in the future, we'd like to integrate the
ApplicationHistoryProtocol with ApplicationClientProtocol. In other word, from
the view of users, they may inquiry any application use a client, which makes
it transparent whether the application report is received via
ApplicationClientProtocol if the application is running or via
ApplicationHistoryProtocol if it is done. Then, ApplicationClientProtocol's and
ApplicationHistoryProtocol's APIs mismatch. Users can inquiry finished
attempts/containers, but not the running ones. ApplicationClientProtocol may
need to add the APIs for attempt/container as well.
In addition, another choice of the API design is to still have the only
getApplicationReport(), but have the options to load all attempts/containers
reports or not. Just think it out aloud. Personally, I incline to the current
API design, which is more flexible, but I'm a bit concerned about the future
integration. Thoughts?
[YARN-321] Add more APIs related to ApplicationAttempt and Container in
ApplicationHistoryProtocol
--
Key: YARN-979
URL: https://issues.apache.org/jira/browse/YARN-979
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch,
YARN-979.2.patch
ApplicationHistoryProtocol should have the following APIs as well:
* getApplicationAttemptReport
* getApplicationAttempts
* getContainerReport
* getContainers
The corresponding request and response classes need to be added as well.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[ https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813196#comment-13813196 ] Mayank Bansal commented on YARN-979: [~zjshen] Thanks for the review. bq. You need to change hadoop-yarn-api/pom.xml to make application_history_client.proto to be compiled. Its already there. bq. In addition to the patch's issues, I'd like to raise one design issue here, projecting some future problems. This patch makes different APIs for application/attempt/container, which is going to be a super set of the APIs of ApplicationClientProtocol. Now it's OK if we restrict our problem with the AHS domain. However, probably in the future, we'd like to integrate the ApplicationHistoryProtocol with ApplicationClientProtocol. In other word, from the view of users, they may inquiry any application use a client, which makes it transparent whether the application report is received via ApplicationClientProtocol if the application is running or via ApplicationHistoryProtocol if it is done. Then, ApplicationClientProtocol's and ApplicationHistoryProtocol's APIs mismatch. Users can inquiry finished attempts/containers, but not the running ones. ApplicationClientProtocol may need to add the APIs for attempt/container as well. In addition, another choice of the API design is to still have the only getApplicationReport(), but have the options to load all attempts/containers reports or not. Just think it out aloud. Personally, I incline to the current API design, which is more flexible, but I'm a bit concerned about the future integration. Thoughts? I will create the jira for making applicationclientprotocol similar to applicationHistoryProtocol Thanks, Mayank [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol -- Key: YARN-979 URL: https://issues.apache.org/jira/browse/YARN-979 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch, YARN-979.2.patch ApplicationHistoryProtocol should have the following APIs as well: * getApplicationAttemptReport * getApplicationAttempts * getContainerReport * getContainers The corresponding request and response classes need to be added as well. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[ https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813197#comment-13813197 ] Mayank Bansal commented on YARN-979: Rest of the comments incorporated. Thanks, Mayank [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol -- Key: YARN-979 URL: https://issues.apache.org/jira/browse/YARN-979 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch, YARN-979-5.patch, YARN-979.2.patch ApplicationHistoryProtocol should have the following APIs as well: * getApplicationAttemptReport * getApplicationAttempts * getContainerReport * getContainers The corresponding request and response classes need to be added as well. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813205#comment-13813205
]
Hadoop QA commented on YARN-979:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12612013/YARN-979-5.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2363//console
This message is automatically generated.
[YARN-321] Add more APIs related to ApplicationAttempt and Container in
ApplicationHistoryProtocol
--
Key: YARN-979
URL: https://issues.apache.org/jira/browse/YARN-979
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch,
YARN-979-5.patch, YARN-979.2.patch
ApplicationHistoryProtocol should have the following APIs as well:
* getApplicationAttemptReport
* getApplicationAttempts
* getContainerReport
* getContainers
The corresponding request and response classes need to be added as well.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[ https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813702#comment-13813702 ] Zhijie Shen commented on YARN-979: -- I still have one question w.r.t. the annotations of the getter/setter of GetRequest/Response. Some of them are marked as \@Stable, and some are marked as \@Unstable. In addition, some setters are marked as \@Private, and some are marked as \@Public. Do you have special consideration here? Maybe we should mark all as \@Unstable for the initial AHS? bq. I will create the jira for making applicationclientprotocol similar to applicationHistoryProtocol Thanks for file the ticket. Ideally, we'd like to have to paired ApplicationClientProtocol and ApplicationHistoryProtocol. Then YarnClient can implement to query running application/attempt/container from ApplicationClientProtocol and the finished from ApplicationHistoryProtocol, making it transparent to users. [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol -- Key: YARN-979 URL: https://issues.apache.org/jira/browse/YARN-979 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch, YARN-979-5.patch, YARN-979.2.patch ApplicationHistoryProtocol should have the following APIs as well: * getApplicationAttemptReport * getApplicationAttempts * getContainerReport * getContainers The corresponding request and response classes need to be added as well. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810846#comment-13810846
]
Hadoop QA commented on YARN-979:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12611519/YARN-979-4.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2339//console
This message is automatically generated.
[YARN-321] Add more APIs related to ApplicationAttempt and Container in
ApplicationHistoryProtocol
--
Key: YARN-979
URL: https://issues.apache.org/jira/browse/YARN-979
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch,
YARN-979.2.patch
ApplicationHistoryProtocol should have the following APIs as well:
* getApplicationAttemptReport
* getApplicationAttempts
* getContainerReport
* getContainers
The corresponding request and response classes need to be added as well.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772129#comment-13772129
]
Hadoop QA commented on YARN-979:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12604077/YARN-979-3.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1971//console
This message is automatically generated.
[YARN-321] Add more APIs related to ApplicationAttempt and Container in
ApplicationHistoryProtocol
--
Key: YARN-979
URL: https://issues.apache.org/jira/browse/YARN-979
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-979-1.patch, YARN-979.2.patch, YARN-979-3.patch
ApplicationHistoryProtocol should have the following APIs as well:
* getApplicationAttemptReport
* getApplicationAttempts
* getContainerReport
* getContainers
The corresponding request and response classes need to be added as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[ https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768831#comment-13768831 ] Mayank Bansal commented on YARN-979: Thanks [~zjshen] for updating the patch. Let me reassign this to me and take it forward. Looks like we don't need ApplicationAttemptReport and ContainerReport and those are already covered in seprate jiras. Working on this now. Thanks, Mayank [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol -- Key: YARN-979 URL: https://issues.apache.org/jira/browse/YARN-979 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Zhijie Shen Attachments: YARN-979-1.patch, YARN-979.2.patch ApplicationHistoryProtocol should have the following APIs as well: * getApplicationAttemptReport * getApplicationAttempts * getContainerReport * getContainers The corresponding request and response classes need to be added as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-979) [YARN-321] Add more APIs related to ApplicationAttempt and Container in ApplicationHistoryProtocol
[
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754267#comment-13754267
]
Hadoop QA commented on YARN-979:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600703/YARN-979.2.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1801//console
This message is automatically generated.
[YARN-321] Add more APIs related to ApplicationAttempt and Container in
ApplicationHistoryProtocol
--
Key: YARN-979
URL: https://issues.apache.org/jira/browse/YARN-979
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Zhijie Shen
Attachments: YARN-979-1.patch, YARN-979.2.patch
ApplicationHistoryProtocol should have the following APIs as well:
* getApplicationAttemptReport
* getApplicationAttempts
* getContainerReport
* getContainers
The corresponding request and response classes need to be added as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
