[jira] [Commented] (YARN-979) [YARN-321] Adding application attempt and container to ApplicationHistoryProtocol

2013-08-28 Thread Zhijie Shen (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752669#comment-13752669
 ] 

Zhijie Shen commented on YARN-979:
--

Take it over. Thanks!

> [YARN-321] Adding application attempt and container to 
> ApplicationHistoryProtocol
> -
>
> Key: YARN-979
> URL: https://issues.apache.org/jira/browse/YARN-979
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Zhijie Shen
> Attachments: YARN-979-1.patch
>
>
>  Adding application attempt and container to ApplicationHistoryProtocol
> Thanks,
> Mayank

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-979) [YARN-321] Adding application attempt and container to ApplicationHistoryProtocol

2013-08-13 Thread Zhijie Shen (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738519#comment-13738519
 ] 

Zhijie Shen commented on YARN-979:
--

There're some high-level comments on the patch:

1. To make the protocol work, it is required to define the corresponding protos 
in yarn_service.proto and update pplication_history_service.proto

2. The setter of the request/response APIs should be @Public, shouldn't it?

3. It's required to mark ApplicationHistoryProtocol as well.

> [YARN-321] Adding application attempt and container to 
> ApplicationHistoryProtocol
> -
>
> Key: YARN-979
> URL: https://issues.apache.org/jira/browse/YARN-979
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-979-1.patch
>
>
>  Adding application attempt and container to ApplicationHistoryProtocol
> Thanks,
> Mayank

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-979) [YARN-321] Adding application attempt and container to ApplicationHistoryProtocol

2013-08-09 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735543#comment-13735543
 ] 

Hadoop QA commented on YARN-979:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12597216/YARN-979-1.patch
  against trunk revision .

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1686//console

This message is automatically generated.

> [YARN-321] Adding application attempt and container to 
> ApplicationHistoryProtocol
> -
>
> Key: YARN-979
> URL: https://issues.apache.org/jira/browse/YARN-979
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-979-1.patch
>
>
>  Adding application attempt and container to ApplicationHistoryProtocol
> Thanks,
> Mayank

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira