Siddharth Ahuja created YARN-10075:
--------------------------------------
Summary: historyContext doesn't need to be a class attribute
inside JobHistoryServer
Key: YARN-10075
URL: https://issues.apache.org/jira/browse/YARN-10075
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Siddharth Ahuja
"historyContext" class attribute at
https://github.com/apache/hadoop/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistoryServer.java#L67
is assigned a cast of another class attribute - "jobHistoryService" -
https://github.com/apache/hadoop/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistoryServer.java#L131,
however it does not need to be stored separately because it is only ever used
once in the clas, and that too as an argument while instantiating the
HistoryClientService class at
https://github.com/apache/hadoop/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistoryServer.java#L155.
Therefore, we could just delete the line at
https://github.com/apache/hadoop/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistoryServer.java#L131
completely and instantiate the HistoryClientService as follows:
{code}
@VisibleForTesting
protected HistoryClientService createHistoryClientService() {
return new HistoryClientService((HistoryContext)jobHistoryService,
this.jhsDTSecretManager);
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
