[jira] [Updated] (YARN-3207) secondary filter matches entites which do not have the key being filtered for.

2015-08-31 Thread Vinod Kumar Vavilapalli (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated YARN-3207:
--
Fix Version/s: 2.6.1

Pulled this into 2.6.1. Ran compilation and TestLeveldbTimelineStore, 
TestMemoryTimelineStore, TestTimelineDataManager before the push. Patch applied 
cleanly.



> secondary filter matches entites which do not have the key being filtered for.
> --
>
> Key: YARN-3207
> URL: https://issues.apache.org/jira/browse/YARN-3207
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: timelineserver
>Reporter: Prakash Ramachandran
>Assignee: Zhijie Shen
>  Labels: 2.6.1-candidate
> Fix For: 2.7.0, 2.6.1
>
> Attachments: YARN-3207.1.patch
>
>
> in the leveldb implementation of the TimelineStore the secondary filter 
> matches entities where the key being searched for is not present.
> ex query from tez ui
> http://uvm:8188/ws/v1/timeline/TEZ_DAG_ID/?limit=1=foo:bar
> will match and return the entity even though there is no entity with 
> otherinfo.foo defined.
> the issue seems to be in 
> {code:title=LeveldbTimelineStore:675}
> if (vs != null && !vs.contains(filter.getValue())) {
>   filterPassed = false;
>   break;
> }
> {code}
> this should be IMHO
> vs == null || !vs.contains(filter.getValue())



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (YARN-3207) secondary filter matches entites which do not have the key being filtered for.

2015-07-17 Thread Vinod Kumar Vavilapalli (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated YARN-3207:
--
Labels: 2.6.1-candidate  (was: )

 secondary filter matches entites which do not have the key being filtered for.
 --

 Key: YARN-3207
 URL: https://issues.apache.org/jira/browse/YARN-3207
 Project: Hadoop YARN
  Issue Type: Bug
  Components: timelineserver
Reporter: Prakash Ramachandran
Assignee: Zhijie Shen
  Labels: 2.6.1-candidate
 Fix For: 2.7.0

 Attachments: YARN-3207.1.patch


 in the leveldb implementation of the TimelineStore the secondary filter 
 matches entities where the key being searched for is not present.
 ex query from tez ui
 http://uvm:8188/ws/v1/timeline/TEZ_DAG_ID/?limit=1secondaryFilter=foo:bar
 will match and return the entity even though there is no entity with 
 otherinfo.foo defined.
 the issue seems to be in 
 {code:title=LeveldbTimelineStore:675}
 if (vs != null  !vs.contains(filter.getValue())) {
   filterPassed = false;
   break;
 }
 {code}
 this should be IMHO
 vs == null || !vs.contains(filter.getValue())



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (YARN-3207) secondary filter matches entites which do not have the key being filtered for.

2015-02-17 Thread Zhijie Shen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated YARN-3207:
--
Attachment: YARN-3207.1.patch

Create the patch to fix the issue.

 secondary filter matches entites which do not have the key being filtered for.
 --

 Key: YARN-3207
 URL: https://issues.apache.org/jira/browse/YARN-3207
 Project: Hadoop YARN
  Issue Type: Bug
  Components: timelineserver
Reporter: Prakash Ramachandran
Assignee: Zhijie Shen
 Attachments: YARN-3207.1.patch


 in the leveldb implementation of the TimelineStore the secondary filter 
 matches entities where the key being searched for is not present.
 ex query from tez ui
 http://uvm:8188/ws/v1/timeline/TEZ_DAG_ID/?limit=1secondaryFilter=foo:bar
 will match and return the entity even though there is no entity with 
 otherinfo.foo defined.
 the issue seems to be in 
 {code:title=LeveldbTimelineStore:675}
 if (vs != null  !vs.contains(filter.getValue())) {
   filterPassed = false;
   break;
 }
 {code}
 this should be IMHO
 vs == null || !vs.contains(filter.getValue())



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (YARN-3207) secondary filter matches entites which do not have the key being filtered for.

2015-02-17 Thread Varun Saxena (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated YARN-3207:
---
Assignee: Zhijie Shen  (was: Varun Saxena)

 secondary filter matches entites which do not have the key being filtered for.
 --

 Key: YARN-3207
 URL: https://issues.apache.org/jira/browse/YARN-3207
 Project: Hadoop YARN
  Issue Type: Bug
  Components: timelineserver
Reporter: Prakash Ramachandran
Assignee: Zhijie Shen

 in the leveldb implementation of the TimelineStore the secondary filter 
 matches entities where the key being searched for is not present.
 ex query from tez ui
 http://uvm:8188/ws/v1/timeline/TEZ_DAG_ID/?limit=1secondaryFilter=foo:bar
 will match and return the entity even though there is no entity with 
 otherinfo.foo defined.
 the issue seems to be in 
 {code:title=LeveldbTimelineStore:675}
 if (vs != null  !vs.contains(filter.getValue())) {
   filterPassed = false;
   break;
 }
 {code}
 this should be IMHO
 vs == null || !vs.contains(filter.getValue())



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)