[jira] [Updated] (YARN-3970) REST api support for Application Priority
[ https://issues.apache.org/jira/browse/YARN-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Vasudev updated YARN-3970: Fix Version/s: 2.8.0 > REST api support for Application Priority > - > > Key: YARN-3970 > URL: https://issues.apache.org/jira/browse/YARN-3970 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Affects Versions: 2.7.1 >Reporter: Sunil G >Assignee: Naganarasimha G R > Fix For: 2.8.0 > > Attachments: YARN-3970.20150828-1.patch, YARN-3970.20150829-1.patch, > YARN-3970.20150831-1.patch, YARN-3970.20150901-1.patch, > YARN-3970.20150901-2.patch > > > REST api support for application priority. > - get/set priority of an application > - get default priority of a queue > - get cluster max priority -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3970) REST api support for Application Priority
[ https://issues.apache.org/jira/browse/YARN-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naganarasimha G R updated YARN-3970: Attachment: YARN-3970.20150901-1.patch Thanks [~vvasudev] & [~sunilg], I have updated a new patch with fixes for the comments given . Please take a look > REST api support for Application Priority > - > > Key: YARN-3970 > URL: https://issues.apache.org/jira/browse/YARN-3970 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Affects Versions: 2.7.1 >Reporter: Sunil G >Assignee: Naganarasimha G R > Attachments: YARN-3970.20150828-1.patch, YARN-3970.20150829-1.patch, > YARN-3970.20150831-1.patch, YARN-3970.20150901-1.patch > > > REST api support for application priority. > - get/set priority of an application > - get default priority of a queue > - get cluster max priority -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3970) REST api support for Application Priority
[ https://issues.apache.org/jira/browse/YARN-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naganarasimha G R updated YARN-3970: Attachment: YARN-3970.20150901-2.patch correcting some checkstyle issues and test case failure seems to be unrelated to this jira. > REST api support for Application Priority > - > > Key: YARN-3970 > URL: https://issues.apache.org/jira/browse/YARN-3970 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Affects Versions: 2.7.1 >Reporter: Sunil G >Assignee: Naganarasimha G R > Attachments: YARN-3970.20150828-1.patch, YARN-3970.20150829-1.patch, > YARN-3970.20150831-1.patch, YARN-3970.20150901-1.patch, > YARN-3970.20150901-2.patch > > > REST api support for application priority. > - get/set priority of an application > - get default priority of a queue > - get cluster max priority -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3970) REST api support for Application Priority
[ https://issues.apache.org/jira/browse/YARN-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naganarasimha G R updated YARN-3970: Attachment: YARN-3970.20150831-1.patch Updated the following : # test case name modified to *testUpdateAppPriority* # More information in the console output of Application CLI for updatePriority # Formatting of the logged messages in CapacityScheduler # Set proper error message in the response content when application is not in the desired state for updating the App's priority > REST api support for Application Priority > - > > Key: YARN-3970 > URL: https://issues.apache.org/jira/browse/YARN-3970 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Affects Versions: 2.7.1 >Reporter: Sunil G >Assignee: Naganarasimha G R > Attachments: YARN-3970.20150828-1.patch, YARN-3970.20150829-1.patch, > YARN-3970.20150831-1.patch > > > REST api support for application priority. > - get/set priority of an application > - get default priority of a queue > - get cluster max priority -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3970) REST api support for Application Priority
[
https://issues.apache.org/jira/browse/YARN-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated YARN-3970:
Attachment: YARN-3970.20150829-1.patch
Thanks [~sunilg] for the review comments,
bq. priority.getPriority() != targetPriority.getPriority() We could use
!priority.equals(targetPriority)
targetPriority is of type
org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppPriority and
priority is of type org.apache.hadoop.yarn.api.records.Priority. so it cannot
be compared as per your suggestion.
bq. If app.getApplicationSubmissionContext().getPriority() is NULL, we will get
n NPE here.
Well went through the flow again, i think i have got the if clause wrong here,
what i am trying to check here is, if target priority is same as the current
priority then just return as success, so i can just return back with the target
priority. Also i think i need to additionally validate whether target priority
is not null. So after correction of all this, NPE is not possible here but
other checks i will be adding as follows
{code}
if (targetPriority == null) {
throw new YarnException(Target Priority cannot be null);
}
. . .
Priority priority = app.getApplicationSubmissionContext().getPriority();
if (priority == null
|| priority.getPriority() != targetPriority.getPriority()) {
return modifyApplicationPriority(app, callerUGI,
targetPriority.getPriority());
}
return Response.status(Status.OK).entity(targetPriority).build();
{code}
REST api support for Application Priority
-
Key: YARN-3970
URL: https://issues.apache.org/jira/browse/YARN-3970
Project: Hadoop YARN
Issue Type: Sub-task
Components: webapp
Affects Versions: 2.7.1
Reporter: Sunil G
Assignee: Naganarasimha G R
Attachments: YARN-3970.20150828-1.patch, YARN-3970.20150829-1.patch
REST api support for application priority.
- get/set priority of an application
- get default priority of a queue
- get cluster max priority
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (YARN-3970) REST api support for Application Priority
[ https://issues.apache.org/jira/browse/YARN-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naganarasimha G R updated YARN-3970: Attachment: YARN-3970.20150828-1.patch Hi [~sunilg] [~rohithsharma], Attaching the first patch as per the prev discussion and also there was one issue in CapacityScheduler.updateApplicationPriority, suppose already application is running with the Cluster Max Priority and user specifies some priority greater than MaxPriority, unnecessarily RMStatestore update and queue's treeset is updated with MaxPriority again. REST api support for Application Priority - Key: YARN-3970 URL: https://issues.apache.org/jira/browse/YARN-3970 Project: Hadoop YARN Issue Type: Sub-task Components: webapp Affects Versions: 2.7.1 Reporter: Sunil G Assignee: Naganarasimha G R Attachments: YARN-3970.20150828-1.patch REST api support for application priority. - get/set priority of an application - get default priority of a queue - get cluster max priority -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3970) REST api support for Application Priority
[ https://issues.apache.org/jira/browse/YARN-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil G updated YARN-3970: -- Summary: REST api support for Application Priority (was: REST api support for Application Priorityc) REST api support for Application Priority - Key: YARN-3970 URL: https://issues.apache.org/jira/browse/YARN-3970 Project: Hadoop YARN Issue Type: Sub-task Components: webapp Affects Versions: 2.7.1 Reporter: Sunil G Assignee: Rohith Sharma K S REST api support for application priority. - get/set priority of an application - get default priority of a queue - get cluster max priority -- This message was sent by Atlassian JIRA (v6.3.4#6332)
