[jira] [Updated] (YARN-5350) Ensure LocalScheduler does not lose the sort order of allocatable nodes returned by the RM
[ https://issues.apache.org/jira/browse/YARN-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated YARN-5350: -- Attachment: YARN-5350.003.patch Thanks for the review [~subru]. Updating testcase with your suggestion.. > Ensure LocalScheduler does not lose the sort order of allocatable nodes > returned by the RM > -- > > Key: YARN-5350 > URL: https://issues.apache.org/jira/browse/YARN-5350 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Arun Suresh >Assignee: Arun Suresh > Fix For: 2.9.0 > > Attachments: YARN-5350.001.patch, YARN-5350.002.patch, > YARN-5350.003.patch > > > The LocalScheduler receives an ordered list of nodes from the RM with each > allocate call. This list, which is used by the LocalScheduler to allocate > OPPORTUNISTIC containers, is sorted on the Nodes free capacity (queue length > / wait time). > Unfortunately, the LocalScheduler stores this list in a HashMap thereby > losing the sort order. > The trivial fix would be to replace the HashMap with a LinkedHashMap which > retains the insertion order. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-5350) Ensure LocalScheduler does not lose the sort order of allocatable nodes returned by the RM
[ https://issues.apache.org/jira/browse/YARN-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated YARN-5350: -- Attachment: YARN-5350.002.patch Updating patch with checkstyle fix. The test failure is spurious... > Ensure LocalScheduler does not lose the sort order of allocatable nodes > returned by the RM > -- > > Key: YARN-5350 > URL: https://issues.apache.org/jira/browse/YARN-5350 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Arun Suresh >Assignee: Arun Suresh > Fix For: 2.9.0 > > Attachments: YARN-5350.001.patch, YARN-5350.002.patch > > > The LocalScheduler receives an ordered list of nodes from the RM with each > allocate call. This list, which is used by the LocalScheduler to allocate > OPPORTUNISTIC containers, is sorted on the Nodes free capacity (queue length > / wait time). > Unfortunately, the LocalScheduler stores this list in a HashMap thereby > losing the sort order. > The trivial fix would be to replace the HashMap with a LinkedHashMap which > retains the insertion order. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-5350) Ensure LocalScheduler does not lose the sort order of allocatable nodes returned by the RM
[ https://issues.apache.org/jira/browse/YARN-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated YARN-5350: -- Fix Version/s: 2.9.0 > Ensure LocalScheduler does not lose the sort order of allocatable nodes > returned by the RM > -- > > Key: YARN-5350 > URL: https://issues.apache.org/jira/browse/YARN-5350 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Arun Suresh >Assignee: Arun Suresh > Fix For: 2.9.0 > > Attachments: YARN-5350.001.patch > > > The LocalScheduler receives an ordered list of nodes from the RM with each > allocate call. This list, which is used by the LocalScheduler to allocate > OPPORTUNISTIC containers, is sorted on the Nodes free capacity (queue length > / wait time). > Unfortunately, the LocalScheduler stores this list in a HashMap thereby > losing the sort order. > The trivial fix would be to replace the HashMap with a LinkedHashMap which > retains the insertion order. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-5350) Ensure LocalScheduler does not lose the sort order of allocatable nodes returned by the RM
[ https://issues.apache.org/jira/browse/YARN-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated YARN-5350: -- Attachment: YARN-5350.001.patch Attaching trivial patch. Most of the code changes are in refactoring the testcase. [~subru], can you give it a quick rev ? > Ensure LocalScheduler does not lose the sort order of allocatable nodes > returned by the RM > -- > > Key: YARN-5350 > URL: https://issues.apache.org/jira/browse/YARN-5350 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Arun Suresh >Assignee: Arun Suresh > Attachments: YARN-5350.001.patch > > > The LocalScheduler receives an ordered list of nodes from the RM with each > allocate call. This list, which is used by the LocalScheduler to allocate > OPPORTUNISTIC containers, is sorted on the Nodes free capacity (queue length > / wait time). > Unfortunately, the LocalScheduler stores this list in a HashMap thereby > losing the sort order. > The trivial fix would be to replace the HashMap with a LinkedHashMap which > retains the insertion order. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org