[jira] [Updated] (YARN-8840) Add missing cleanupSSLConfig() call for TestTimelineClient test
[
https://issues.apache.org/jira/browse/YARN-8840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Tanaka updated YARN-8840:
-
Attachment: YARN-8840.003.patch
> Add missing cleanupSSLConfig() call for TestTimelineClient test
> ---
>
> Key: YARN-8840
> URL: https://issues.apache.org/jira/browse/YARN-8840
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test, timelineclient
>Reporter: Aki Tanaka
>Priority: Minor
> Attachments: YARN-8840.001.patch, YARN-8840.002.patch,
> YARN-8840.003.patch
>
>
> Tests that setup SSLConfigs can leave conf-files lingering unless they are
> cleaned up via {{KeyStoreTestUtil.cleanupSSLConfig}} call. TestTimelineClient
> test is missing this call.
> If the cleanup method is not called explicitly, a modified ssl-client.xml is
> left in {{test-classes}}, might affect subsequent test cases.
>
> There was a similar report in HDFS-11042, but looks that we need to fix
> TestTimelineClient test too.
>
> {code:java}
> $ mvn test -Dtest=TestTimelineClient
> $ find .|grep ssl-client.xml$
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-classes/ssl-client.xml
> $ cat
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-classes/ssl-client.xml
>
> ssl.client.truststore.reload.interval1000falseprogrammatically
> ssl.client.truststore.location/Users/tanaka/work/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-dir/trustKS.jksfalseprogrammatically
> ssl.client.keystore.keypasswordclientPfalseprogrammatically
> ssl.client.keystore.location/Users/tanaka/work/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-dir/clientKS.jksfalseprogrammatically
> ssl.client.truststore.passwordtrustPfalseprogrammatically
> ssl.client.keystore.passwordclientPfalseprogrammatically
> {code}
>
> After applying this patch, the ssl-client.xml is not generated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8840) Add missing cleanupSSLConfig() call for TestTimelineClient test
[
https://issues.apache.org/jira/browse/YARN-8840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Tanaka updated YARN-8840:
-
Attachment: YARN-8840.002.patch
> Add missing cleanupSSLConfig() call for TestTimelineClient test
> ---
>
> Key: YARN-8840
> URL: https://issues.apache.org/jira/browse/YARN-8840
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test, timelineclient
>Reporter: Aki Tanaka
>Priority: Minor
> Attachments: YARN-8840.001.patch, YARN-8840.002.patch
>
>
> Tests that setup SSLConfigs can leave conf-files lingering unless they are
> cleaned up via {{KeyStoreTestUtil.cleanupSSLConfig}} call. TestTimelineClient
> test is missing this call.
> If the cleanup method is not called explicitly, a modified ssl-client.xml is
> left in {{test-classes}}, might affect subsequent test cases.
>
> There was a similar report in HDFS-11042, but looks that we need to fix
> TestTimelineClient test too.
>
> {code:java}
> $ mvn test -Dtest=TestTimelineClient
> $ find .|grep ssl-client.xml$
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-classes/ssl-client.xml
> $ cat
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-classes/ssl-client.xml
>
> ssl.client.truststore.reload.interval1000falseprogrammatically
> ssl.client.truststore.location/Users/tanaka/work/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-dir/trustKS.jksfalseprogrammatically
> ssl.client.keystore.keypasswordclientPfalseprogrammatically
> ssl.client.keystore.location/Users/tanaka/work/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-dir/clientKS.jksfalseprogrammatically
> ssl.client.truststore.passwordtrustPfalseprogrammatically
> ssl.client.keystore.passwordclientPfalseprogrammatically
> {code}
>
> After applying this patch, the ssl-client.xml is not generated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
