[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-008.patch > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch, YARN-9266-004.patch, YARN-9266-005.patch, > YARN-9266-006.patch, YARN-9266-007.patch, YARN-9266-008.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class > * checkstyle fixes -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-007.patch > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch, YARN-9266-004.patch, YARN-9266-005.patch, > YARN-9266-006.patch, YARN-9266-007.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class > * checkstyle fixes -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-006.patch > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch, YARN-9266-004.patch, YARN-9266-005.patch, > YARN-9266-006.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class > * checkstyle fixes -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-005.patch > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch, YARN-9266-004.patch, YARN-9266-005.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class > * checkstyle fixes -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Description: Problems identified in this class: * {{InnerShellExecutor}} ignores the timeout parameter * {{configureIP()}} uses printStackTrace() instead of logging * {{configureIP()}} does not log the output of aocl if the exit code != 0 * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class for better testability * {{downloadIP()}} uses {{contains()}} for file name check – this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches) * method name {{downloadIP()}} is misleading – it actually tries to finds the file. Everything is downloaded (localized) at this point. * {{@VisibleForTesting}} methods should be package private * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} class * checkstyle fixes was: Problems identified in this class: * {{InnerShellExecutor}} ignores the timeout parameter * {{configureIP()}} uses printStackTrace() instead of logging * {{configureIP()}} does not log the output of aocl if the exit code != 0 * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class for better testability * {{downloadIP()}} uses {{contains()}} for file name check – this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches) * method name {{downloadIP()}} is misleading – it actually tries to finds the file. Everything is downloaded (localized) at this point. * {{@VisibleForTesting}} methods should be package private * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} class > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch, YARN-9266-004.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class > * checkstyle fixes -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-004.patch > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch, YARN-9266-004.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-003.patch > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-002.patch > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Description: Problems identified in this class: * {{InnerShellExecutor}} ignores the timeout parameter * {{configureIP()}} uses printStackTrace() instead of logging * {{configureIP()}} does not log the output of aocl if the exit code != 0 * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class for better testability * {{downloadIP()}} uses {{contains()}} for file name check – this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches) * method name {{downloadIP()}} is misleading – it actually tries to finds the file. Everything is downloaded (localized) at this point. * {{@VisibleForTesting}} methods should be package private * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} class was: Problems identified in this class: * {{InnerShellExecutor}} ignores the timeout parameter * {{configureIP()}} uses printStackTrace() instead of logging * {{configureIP()}} does not log the output of aocl if the exit code != 0 * {{parseDiagnoseInfo()}} is too heavyweight -- it should be in its own class for better testability * {{downloadIP()}} uses {{contains()}} for file name check -- this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches) * method name {{downloadIP()}} is misleading -- it actually tries to finds the file. Everything is downloaded (localized) at this point. * {{@VisibleForTesting}} methods should be package private > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-001.patch > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight -- it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check -- this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading -- it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Description: Problems identified in this class: * {{InnerShellExecutor}} ignores the timeout parameter * {{configureIP()}} uses printStackTrace() instead of logging * {{configureIP()}} does not log the output of aocl if the exit code != 0 * {{parseDiagnoseInfo()}} is too heavyweight -- it should be in its own class for better testability * {{downloadIP()}} uses {{contains()}} for file name check -- this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches) * method name {{downloadIP()}} is misleading -- it actually tries to finds the file. Everything is downloaded (localized) at this point. * {{@VisibleForTesting}} methods should be package private was: Problems identified in this class: * InnerShellExecutor ignores the timeout parameter * configureIP() uses printStackTrace() instead of logging * configureIP() does not log the output of aocl if the exit code != 0 * parseDiagnoseInfo() is too heavyweight -- it should be in its own class for better testability * downloadIP() uses contains() for file name check -- this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches) * method name downloadIP() is misleading -- it actually tries to finds the file. Everything is downloaded (localized) at this point. * @VisibleForTesting methods should be package private > Various fixes are needed in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Priority: Major > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight -- it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check -- this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading -- it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org