[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[
https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779576#comment-17779576
]
ASF GitHub Bot commented on YARN-11588:
---
hadoop-yetus commented on PR #6222:
URL: https://github.com/apache/hadoop/pull/6222#issuecomment-1779674301
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 25s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 15m 54s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 20m 1s | | trunk passed |
| +1 :green_heart: | compile | 4m 30s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 4m 7s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 1m 14s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 15s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 19s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 2m 8s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 3m 43s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 58s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 12s | | the patch passed |
| +1 :green_heart: | compile | 3m 47s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 3m 47s | | the patch passed |
| +1 :green_heart: | compile | 3m 58s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 3m 58s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 1m 8s |
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6222/1/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
| hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 164 unchanged
- 0 fixed = 166 total (was 164) |
| +1 :green_heart: | mvnsite | 2m 1s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 1s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 57s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 3m 49s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 41s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 0m 57s | | hadoop-yarn-api in the patch
passed. |
| +1 :green_heart: | unit | 4m 51s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 0m 37s | | hadoop-yarn-server-router in
the patch passed. |
| +1 :green_heart: | asflicense | 0m 47s | | The patch does not
generate ASF License warnings. |
| | | 132m 29s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6222/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6222 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
| uname | Linux f75dc89380ff 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19
13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 45701476559d7b849363f17cbb696efdc8b13843 |
| Default Java |
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779534#comment-17779534 ] ASF GitHub Bot commented on YARN-11588: --- slfan1989 opened a new pull request, #6222: URL: https://github.com/apache/hadoop/pull/6222 ### Description of PR JIRA: YARN-11588. [Federation] [Addendum] Fix uncleaned threads in yarn router thread pool executor. ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jeffrey Chang >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11484) [Federation] Router Supports Yarn Client CLI Cmds.
[
https://issues.apache.org/jira/browse/YARN-11484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779669#comment-17779669
]
ASF GitHub Bot commented on YARN-11484:
---
goiri commented on code in PR #6132:
URL: https://github.com/apache/hadoop/pull/6132#discussion_r1372293340
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java:
##
@@ -174,6 +225,63 @@ private int listChildQueues(String parentQueueName) throws
IOException, YarnExce
}
private void printQueueInfo(PrintWriter writer, QueueInfo queueInfo) {
+String schedulerType = queueInfo.getSchedulerType();
+
+if (StringUtils.equals("FairScheduler", schedulerType)) {
+ printFairSchedulerQueue(writer, queueInfo);
+} else {
+ printQueue(writer, queueInfo);
+}
+ }
+
+ /**
+ * Print Queue information of FairScheduler.
+ *
+ * @param writer PrintWriter.
+ * @param queueInfo Queue Information.
+ */
+ private void printFairSchedulerQueue(PrintWriter writer, QueueInfo
queueInfo) {
+if (queueInfo.getSchedulerType() != null) {
+ writer.print("Scheduler Name : ");
+ writer.println(queueInfo.getSchedulerType());
+}
+writer.print("Queue Name : ");
+writer.println(queueInfo.getQueueName());
+writer.print("\tWeight : ");
+DecimalFormat df = new DecimalFormat("0.00");
+writer.println(df.format(queueInfo.getWeight()));
+writer.print("\tState : ");
+writer.println(queueInfo.getQueueState());
+writer.print("\tMinResource : ");
+writer.println(" [Federation] Router Supports Yarn Client CLI Cmds.
> --
>
> Key: YARN-11484
> URL: https://issues.apache.org/jira/browse/YARN-11484
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
> Labels: pull-request-available
>
> This Jira ticket aims to enhance the Router command by adding support for all
> Yarn Client CLI options.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11011) Make YARN Router throw Exception to client clearly
[
https://issues.apache.org/jira/browse/YARN-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779670#comment-17779670
]
ASF GitHub Bot commented on YARN-11011:
---
goiri commented on code in PR #6211:
URL: https://github.com/apache/hadoop/pull/6211#discussion_r1372298017
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##
@@ -859,9 +869,8 @@ Collection invokeConcurrent(ClientMethod request,
Class clazz)
results.put(subClusterId, clazz.cast(result));
} catch (InterruptedException | ExecutionException e) {
Throwable cause = e.getCause();
- LOG.error("Cannot execute {} on {} : {}", request.getMethodName(),
- subClusterId.getId(), cause.getMessage());
- exceptions.put(subClusterId, e);
Review Comment:
I think is good to keep the map even though we just output the values.
> Make YARN Router throw Exception to client clearly
> --
>
> Key: YARN-11011
> URL: https://issues.apache.org/jira/browse/YARN-11011
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
>Affects Versions: 3.3.1
>Reporter: Yuan Luo
>Assignee: Shilun Fan
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: router-error.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When router submits job to yarn, the job is rejected by yarn for some reason.
> Yarn router just throw exception to log and return not enough info to client.
> The router always throws the following non-obvious error to client:
> Exception in thread "main"
> org.apache.hadoop.yarn.server.federation.policies.exceptions.FederationPolicyException:
> No active SubCluster available to submit the request.
> To make it easy for the user to locate the cause of a job submission failure,
> we need to make Router throw the true cause of the error to the client
> clearly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11593) [Federation] Improve command line help information.
[ https://issues.apache.org/jira/browse/YARN-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779701#comment-17779701 ] ASF GitHub Bot commented on YARN-11593: --- slfan1989 commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1780232786 @goiri Thank you very much for your help in reviewing the code! I will continue to follow up on YARN-11594. > [Federation] Improve command line help information. > --- > > Key: YARN-11593 > URL: https://issues.apache.org/jira/browse/YARN-11593 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > Labels: pull-request-available > > This jira will improve the help information of routeradmin so that users can > better understand and use commands. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Resolved] (YARN-11593) [Federation] Improve command line help information.
[ https://issues.apache.org/jira/browse/YARN-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan resolved YARN-11593. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Target Version/s: 3.4.0 Resolution: Fixed > [Federation] Improve command line help information. > --- > > Key: YARN-11593 > URL: https://issues.apache.org/jira/browse/YARN-11593 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > > This jira will improve the help information of routeradmin so that users can > better understand and use commands. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11593) [Federation] Improve command line help information.
[ https://issues.apache.org/jira/browse/YARN-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779700#comment-17779700 ] ASF GitHub Bot commented on YARN-11593: --- slfan1989 merged PR #6199: URL: https://github.com/apache/hadoop/pull/6199 > [Federation] Improve command line help information. > --- > > Key: YARN-11593 > URL: https://issues.apache.org/jira/browse/YARN-11593 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > Labels: pull-request-available > > This jira will improve the help information of routeradmin so that users can > better understand and use commands. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Created] (YARN-11600) After jetty is upgraded to 9.4.51.v20230217, sls cannot load js/css
yanbin.zhang created YARN-11600: --- Summary: After jetty is upgraded to 9.4.51.v20230217, sls cannot load js/css Key: YARN-11600 URL: https://issues.apache.org/jira/browse/YARN-11600 Project: Hadoop YARN Issue Type: Bug Components: yarn Reporter: yanbin.zhang Attachments: image-2023-10-26-09-52-30-975.png !image-2023-10-26-09-52-30-975.png! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11577) Improve FederationInterceptorREST Method Result
[
https://issues.apache.org/jira/browse/YARN-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779735#comment-17779735
]
ASF GitHub Bot commented on YARN-11577:
---
hadoop-yetus commented on PR #6190:
URL: https://github.com/apache/hadoop/pull/6190#issuecomment-1780391620
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 25s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 4 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 20s | | trunk passed |
| +1 :green_heart: | compile | 0m 27s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 0m 25s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 0m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 29s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 0m 44s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 53s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 19s | | the patch passed |
| +1 :green_heart: | compile | 0m 19s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 0m 19s | | the patch passed |
| +1 :green_heart: | compile | 0m 18s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 0m 18s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 13s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 17s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 0m 40s | | the patch passed |
| +1 :green_heart: | shadedclient | 20m 31s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 0m 24s | | hadoop-yarn-server-router in
the patch passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 86m 32s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6190/13/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6190 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
| uname | Linux 123099b1084e 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19
13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f05db8714021cc133cdd0879711c9e8d6297359e |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6190/13/testReport/ |
| Max. process+thread count | 705 (vs. ulimit of 5500) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6190/13/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered
[jira] [Updated] (YARN-11599) Incorrect log4j properties file in SLS sample conf
[
https://issues.apache.org/jira/browse/YARN-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated YARN-11599:
--
Labels: pull-request-available (was: )
> Incorrect log4j properties file in SLS sample conf
> --
>
> Key: YARN-11599
> URL: https://issues.apache.org/jira/browse/YARN-11599
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Junfan Zhang
>Priority: Major
> Labels: pull-request-available
>
> https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-sls/src/main/sample-conf/log4j.properties
>
> log4j.appender.test=org.apache.log4j.ConsoleAppender
> log4j.appender.test.Target=System.out
> log4j.appender.test.layout=org.apache.log4j.PatternLayout
> log4j.appender.test.layout.ConversionPattern=%d\{ABSOLUTE} %5p %c\{1}:%L -
> %m%n
> log4j.logger=NONE, test
>
> This is invalid in current log4j version, if applied this, the test
> performance will be slow!
>
> I think the warn level is enough and required. The level < warn will effect
> performance
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11599) Incorrect log4j properties file in SLS sample conf
[
https://issues.apache.org/jira/browse/YARN-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779410#comment-17779410
]
ASF GitHub Bot commented on YARN-11599:
---
zuston commented on PR #6220:
URL: https://github.com/apache/hadoop/pull/6220#issuecomment-1778792664
PTAL @slfan1989
> Incorrect log4j properties file in SLS sample conf
> --
>
> Key: YARN-11599
> URL: https://issues.apache.org/jira/browse/YARN-11599
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Junfan Zhang
>Priority: Major
> Labels: pull-request-available
>
> https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-sls/src/main/sample-conf/log4j.properties
>
> log4j.appender.test=org.apache.log4j.ConsoleAppender
> log4j.appender.test.Target=System.out
> log4j.appender.test.layout=org.apache.log4j.PatternLayout
> log4j.appender.test.layout.ConversionPattern=%d\{ABSOLUTE} %5p %c\{1}:%L -
> %m%n
> log4j.logger=NONE, test
>
> This is invalid in current log4j version, if applied this, the test
> performance will be slow!
>
> I think the warn level is enough and required. The level < warn will effect
> performance
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11599) Incorrect log4j properties file in SLS sample conf
[
https://issues.apache.org/jira/browse/YARN-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779409#comment-17779409
]
ASF GitHub Bot commented on YARN-11599:
---
zuston opened a new pull request, #6220:
URL: https://github.com/apache/hadoop/pull/6220
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Incorrect log4j properties file in SLS sample conf
> --
>
> Key: YARN-11599
> URL: https://issues.apache.org/jira/browse/YARN-11599
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Junfan Zhang
>Priority: Major
>
> https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-sls/src/main/sample-conf/log4j.properties
>
> log4j.appender.test=org.apache.log4j.ConsoleAppender
> log4j.appender.test.Target=System.out
> log4j.appender.test.layout=org.apache.log4j.PatternLayout
> log4j.appender.test.layout.ConversionPattern=%d\{ABSOLUTE} %5p %c\{1}:%L -
> %m%n
> log4j.logger=NONE, test
>
> This is invalid in current log4j version, if applied this, the test
> performance will be slow!
>
> I think the warn level is enough and required. The level < warn will effect
> performance
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11599) Incorrect log4j properties file in SLS sample conf
[
https://issues.apache.org/jira/browse/YARN-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779455#comment-17779455
]
ASF GitHub Bot commented on YARN-11599:
---
hadoop-yetus commented on PR #6220:
URL: https://github.com/apache/hadoop/pull/6220#issuecomment-1779004347
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 44m 31s | | trunk passed |
| +1 :green_heart: | compile | 0m 28s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | mvnsite | 0m 32s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 33s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | shadedclient | 78m 27s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 21s | | the patch passed |
| +1 :green_heart: | compile | 0m 20s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 0m 20s | | the patch passed |
| +1 :green_heart: | compile | 0m 18s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 0m 18s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 0m 22s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | shadedclient | 33m 10s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 12m 15s | | hadoop-sls in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not
generate ASF License warnings. |
| | | 129m 25s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6220/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6220 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets |
| uname | Linux 0053eeb4ce0e 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20
08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c06a1787617af42a4a52157bef8470a5272302f2 |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6220/1/testReport/ |
| Max. process+thread count | 554 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6220/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Incorrect log4j properties file in SLS sample conf
> --
>
> Key: YARN-11599
> URL: https://issues.apache.org/jira/browse/YARN-11599
> Project: Hadoop YARN
> Issue Type: Bug
>
[jira] [Created] (YARN-11599) Incorrect log4j properties file in SLS sample conf
Junfan Zhang created YARN-11599:
---
Summary: Incorrect log4j properties file in SLS sample conf
Key: YARN-11599
URL: https://issues.apache.org/jira/browse/YARN-11599
Project: Hadoop YARN
Issue Type: Bug
Reporter: Junfan Zhang
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-sls/src/main/sample-conf/log4j.properties
log4j.appender.test=org.apache.log4j.ConsoleAppender
log4j.appender.test.Target=System.out
log4j.appender.test.layout=org.apache.log4j.PatternLayout
log4j.appender.test.layout.ConversionPattern=%d\{ABSOLUTE} %5p %c\{1}:%L - %m%n
log4j.logger=NONE, test
This is invalid in current log4j version, if applied this, the test performance
will be slow!
I think the warn level is enough and required. The level < warn will effect
performance
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
