Re: [yocto] [OE-core][PATCH v2] kernel-dummy: fix executing unexpected tasks
No problem, you can keep the deploy task dependency, like it was. Regards, Andrej > On Thu, 2020-11-26 at 14:44 +, Valek, Andrej wrote: >> No it's not a leftover. I've just copied it from kernel.bbclass, where >> this task is written correctly. But you can change it to previous >> version I guess. > > I'm trying to work out why we need the extra dependencies when the tasks are > empty. > > I can see how adding the inherit would help, I'm less sure how adding the > deploy task after the others does though. > > Cheers, > > Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#51578): https://lists.yoctoproject.org/g/yocto/message/51578 Mute This Topic: https://lists.yoctoproject.org/mt/78504527/21656 Group Owner: yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [yocto] [OE-core][PATCH v2] kernel-dummy: fix executing unexpected tasks
On Thu, 2020-11-26 at 14:44 +, Valek, Andrej wrote: > No it's not a leftover. I've just copied it from kernel.bbclass, > where this task is written correctly. But you can change it to > previous version I guess. I'm trying to work out why we need the extra dependencies when the tasks are empty. I can see how adding the inherit would help, I'm less sure how adding the deploy task after the others does though. Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#51577): https://lists.yoctoproject.org/g/yocto/message/51577 Mute This Topic: https://lists.yoctoproject.org/mt/78504527/21656 Group Owner: yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [yocto] [OE-core][PATCH v2] kernel-dummy: fix executing unexpected tasks
Hello Richard,
No it's not a leftover. I've just copied it from kernel.bbclass, where this
task is written correctly. But you can change it to previous version I guess.
Regards,
Andrej
> On Wed, 2020-11-25 at 18:20 +0100, Andrej Valek wrote:
>> - correctly save files into sstate
>> - fix: ERROR: Task linux-dummy.do_fetch attempted to execute
>> unexpectedly
>>
>> Signed-off-by: Andrej Valek
>> ---
>> meta/recipes-kernel/linux/linux-dummy.bb | 6 --
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/linux/linux-dummy.bb b/meta/recipes-
>> kernel/linux/linux-dummy.bb index 62cf6f5ea6..1498da392c 100644
>> --- a/meta/recipes-kernel/linux/linux-dummy.bb
>> +++ b/meta/recipes-kernel/linux/linux-dummy.bb
>> @@ -5,10 +5,12 @@ where you wish to build the kernel externally from
>> the build system."
>> SECTION = "kernel"
>>
>> LICENSE = "GPLv2"
>> -LIC_FILES_CHKSUM =
>> "file://${WORKDIR}/COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
>> +LIC_FILES_CHKSUM =
>> "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
>>
>> PROVIDES += "virtual/kernel"
>>
>> +inherit deploy
>> +
>> PACKAGES_DYNAMIC += "^kernel-module-.*"
>> PACKAGES_DYNAMIC += "^kernel-image-.*"
>> PACKAGES_DYNAMIC += "^kernel-firmware-.*"
>> @@ -60,6 +62,6 @@ do_deploy() {
>> }
>>
>> addtask bundle_initramfs after do_install before do_deploy -addtask
>> deploy after do_install
>> +addtask deploy after do_populate_sysroot do_packagedata
>
> Is this a leftover from the previous version of the patch? We don't normally
> need those constraints?
>
> Cheers,
>
> Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#51576): https://lists.yoctoproject.org/g/yocto/message/51576
Mute This Topic: https://lists.yoctoproject.org/mt/78504527/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [yocto] [OE-core][PATCH v2] kernel-dummy: fix executing unexpected tasks
On Wed, 2020-11-25 at 18:20 +0100, Andrej Valek wrote:
> - correctly save files into sstate
> - fix: ERROR: Task linux-dummy.do_fetch attempted to execute
> unexpectedly
>
> Signed-off-by: Andrej Valek
> ---
> meta/recipes-kernel/linux/linux-dummy.bb | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-dummy.bb b/meta/recipes-
> kernel/linux/linux-dummy.bb
> index 62cf6f5ea6..1498da392c 100644
> --- a/meta/recipes-kernel/linux/linux-dummy.bb
> +++ b/meta/recipes-kernel/linux/linux-dummy.bb
> @@ -5,10 +5,12 @@ where you wish to build the kernel externally from
> the build system."
> SECTION = "kernel"
>
> LICENSE = "GPLv2"
> -LIC_FILES_CHKSUM =
> "file://${WORKDIR}/COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
> +LIC_FILES_CHKSUM =
> "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
>
> PROVIDES += "virtual/kernel"
>
> +inherit deploy
> +
> PACKAGES_DYNAMIC += "^kernel-module-.*"
> PACKAGES_DYNAMIC += "^kernel-image-.*"
> PACKAGES_DYNAMIC += "^kernel-firmware-.*"
> @@ -60,6 +62,6 @@ do_deploy() {
> }
>
> addtask bundle_initramfs after do_install before do_deploy
> -addtask deploy after do_install
> +addtask deploy after do_populate_sysroot do_packagedata
Is this a leftover from the previous version of the patch? We don't
normally need those constraints?
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#51575): https://lists.yoctoproject.org/g/yocto/message/51575
Mute This Topic: https://lists.yoctoproject.org/mt/78504527/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[yocto] [OE-core][PATCH v2] kernel-dummy: fix executing unexpected tasks
- correctly save files into sstate
- fix: ERROR: Task linux-dummy.do_fetch attempted to execute unexpectedly
Signed-off-by: Andrej Valek
---
meta/recipes-kernel/linux/linux-dummy.bb | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-kernel/linux/linux-dummy.bb
b/meta/recipes-kernel/linux/linux-dummy.bb
index 62cf6f5ea6..1498da392c 100644
--- a/meta/recipes-kernel/linux/linux-dummy.bb
+++ b/meta/recipes-kernel/linux/linux-dummy.bb
@@ -5,10 +5,12 @@ where you wish to build the kernel externally from the build
system."
SECTION = "kernel"
LICENSE = "GPLv2"
-LIC_FILES_CHKSUM =
"file://${WORKDIR}/COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
+LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
PROVIDES += "virtual/kernel"
+inherit deploy
+
PACKAGES_DYNAMIC += "^kernel-module-.*"
PACKAGES_DYNAMIC += "^kernel-image-.*"
PACKAGES_DYNAMIC += "^kernel-firmware-.*"
@@ -60,6 +62,6 @@ do_deploy() {
}
addtask bundle_initramfs after do_install before do_deploy
-addtask deploy after do_install
+addtask deploy after do_populate_sysroot do_packagedata
addtask shared_workdir after do_compile before do_install
addtask compile_kernelmodules
--
2.11.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#51563): https://lists.yoctoproject.org/g/yocto/message/51563
Mute This Topic: https://lists.yoctoproject.org/mt/78504527/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
