Re: [yocto] [meta-rockchip][PATCH] trusted-firmware-a: use 1500000 baud for serial console
On Wed, Apr 7, 2021 at 9:27 AM Joshua Watt wrote: > Please add Upstream-Status: https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating#Patch_Upstreaming -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#53053): https://lists.yoctoproject.org/g/yocto/message/53053 Mute This Topic: https://lists.yoctoproject.org/mt/81904391/21656 Group Owner: yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [yocto] [meta-rockchip][PATCH] trusted-firmware-a: use 1500000 baud for serial console
On 4/6/21 6:47 PM, Yann Dirson wrote:
From: Yann Dirson
TF-A runs between two u-boot stages which both uses 150 baud, it
just makes no sense to use the same UART at a different rate.
Here is a sample session with the successive stages, with TF-A artificially
separated for emphasis:
[20210406-175438.135934] U-Boot TPL 2021.01 (Jan 11 2021 - 18:11:43)
[20210406-175438.135956] Channel 0: DDR3, 933MHz
[20210406-175438.236974] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16
Size=1024MB
[20210406-175438.237000] Channel 1: DDR3, 933MHz
[20210406-175438.237004] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16
Size=1024MB
[20210406-175438.237008] 256B stride
[20210406-175438.237012] Trying to boot from BOOTROM
[20210406-175438.237015] Returning to boot ROM...
[20210406-175438.237018]
[20210406-175438.573394] U-Boot SPL 2021.01 (Jan 11 2021 - 18:11:43 +)
[20210406-175438.573431] Trying to boot from MMC1
[20210406-175438.589254] NOTICE: BL31: v2.3():v2.3-dirty
[20210406-175440.534055] NOTICE: BL31: Built : 15:56:43, Apr 20 2020
[20210406-175441.393423] U-Boot 2021.01 (Jan 11 2021 - 18:11:43 +)
[20210406-175441.393429]
[20210406-175441.393433] SoC: Rockchip rk3399
Very good. TF-A should work "out of the box" in meta-rockchip, so I
think changing it's baudrate to 150 makes sense at this point (at
least until u-boot can pass the DTB)
Signed-off-by: Yann Dirson
---
.../files/serial-console-baudrate.patch | 35 +++
.../trusted-firmware-a_%.bbappend | 5 +++
2 files changed, 40 insertions(+)
create mode 100644
recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
diff --git a/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
new file mode 100644
index 000..10b5a2b
--- /dev/null
+++ b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
@@ -0,0 +1,35 @@
+From 840d6b6420e1fd8cdf6e4de7fa58a6f8de151622 Mon Sep 17 00:00:00 2001
+From: Yann Dirson
+Date: Tue, 6 Apr 2021 17:28:45 +0200
+Subject: [PATCH] Set serial console baudrate back to 150.
+
+TF-A runs between two u-boot stages which both uses 150 baud, it
+just makes no sense to use the same UART at a different rate.
+
+This effectively reverts part of 0c05748bdebfad9fa43a80962186438bb8fbce62.
+Main reason for that change stated in
https://developer.trustedfirmware.org/T762
+is ChromeOS compatibility.
+
+Looks like this patch may become unnecessary in the future, when
+u-boot and TF-A get to communicate this value.
Please add Upstream-Status:
+
+---
+ plat/rockchip/rk3399/rk3399_def.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/plat/rockchip/rk3399/rk3399_def.h
b/plat/rockchip/rk3399/rk3399_def.h
+index ba83242eb..8d6ecfbe6 100644
+--- a/plat/rockchip/rk3399/rk3399_def.h
b/plat/rockchip/rk3399/rk3399_def.h
+@@ -17,7 +17,7 @@
+ /**
+ * UART related constants
+ **/
+-#define RK3399_BAUDRATE 115200
++#define RK3399_BAUDRATE 150
+ #define RK3399_UART_CLOCK 2400
+
+
/**
+--
+2.30.2
+
diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
index 442dee8..1942c17 100644
--- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
+++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
@@ -4,3 +4,8 @@ DEPENDS_append_rk3399 = " virtual/arm-none-eabi-gcc-native"
COMPATIBLE_MACHINE_append_rk3399 = "|rk3399"
COMPATIBLE_MACHINE_append_rk3328 = "|rk3328"
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
+SRC_URI += "\
+file://serial-console-baudrate.patch \
+"
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#53052): https://lists.yoctoproject.org/g/yocto/message/53052
Mute This Topic: https://lists.yoctoproject.org/mt/81904391/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [yocto] [meta-rockchip][PATCH] trusted-firmware-a: use 1500000 baud for serial console
> +-#define RK3399_BAUDRATE 115200
> ++#define RK3399_BAUDRATE 150
> + #define RK3399_UART_CLOCK 2400
Interesting... For years (a few decades) everybody has used 115200 as
the standard setup for UART, as global definition.
Why suddenly somebody changed the UART baud rate to be non-standard?
>From the speed point of view???
Don't think so.
Should U-Boot be adjusted to the standard baud rate of 115200 for RK3399?
My two cent addendum/thinking,
Zee
___
On Wed, Apr 7, 2021 at 1:47 AM Yann Dirson wrote:
>
> From: Yann Dirson
>
> TF-A runs between two u-boot stages which both uses 150 baud, it
> just makes no sense to use the same UART at a different rate.
>
> Here is a sample session with the successive stages, with TF-A artificially
> separated for emphasis:
>
> [20210406-175438.135934] U-Boot TPL 2021.01 (Jan 11 2021 - 18:11:43)
> [20210406-175438.135956] Channel 0: DDR3, 933MHz
> [20210406-175438.236974] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16
> Size=1024MB
> [20210406-175438.237000] Channel 1: DDR3, 933MHz
> [20210406-175438.237004] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16
> Size=1024MB
> [20210406-175438.237008] 256B stride
> [20210406-175438.237012] Trying to boot from BOOTROM
> [20210406-175438.237015] Returning to boot ROM...
> [20210406-175438.237018]
> [20210406-175438.573394] U-Boot SPL 2021.01 (Jan 11 2021 - 18:11:43 +)
> [20210406-175438.573431] Trying to boot from MMC1
>
> [20210406-175438.589254] NOTICE: BL31: v2.3():v2.3-dirty
> [20210406-175440.534055] NOTICE: BL31: Built : 15:56:43, Apr 20 2020
>
> [20210406-175441.393423] U-Boot 2021.01 (Jan 11 2021 - 18:11:43 +)
> [20210406-175441.393429]
> [20210406-175441.393433] SoC: Rockchip rk3399
>
> Signed-off-by: Yann Dirson
> ---
> .../files/serial-console-baudrate.patch | 35 +++
> .../trusted-firmware-a_%.bbappend | 5 +++
> 2 files changed, 40 insertions(+)
> create mode 100644
> recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
>
> diff --git
> a/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
> b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
> new file mode 100644
> index 000..10b5a2b
> --- /dev/null
> +++ b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
> @@ -0,0 +1,35 @@
> +From 840d6b6420e1fd8cdf6e4de7fa58a6f8de151622 Mon Sep 17 00:00:00 2001
> +From: Yann Dirson
> +Date: Tue, 6 Apr 2021 17:28:45 +0200
> +Subject: [PATCH] Set serial console baudrate back to 150.
> +
> +TF-A runs between two u-boot stages which both uses 150 baud, it
> +just makes no sense to use the same UART at a different rate.
> +
> +This effectively reverts part of 0c05748bdebfad9fa43a80962186438bb8fbce62.
> +Main reason for that change stated in
> https://developer.trustedfirmware.org/T762
> +is ChromeOS compatibility.
> +
> +Looks like this patch may become unnecessary in the future, when
> +u-boot and TF-A get to communicate this value.
> +
> +---
> + plat/rockchip/rk3399/rk3399_def.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/plat/rockchip/rk3399/rk3399_def.h
> b/plat/rockchip/rk3399/rk3399_def.h
> +index ba83242eb..8d6ecfbe6 100644
> +--- a/plat/rockchip/rk3399/rk3399_def.h
> b/plat/rockchip/rk3399/rk3399_def.h
> +@@ -17,7 +17,7 @@
> + /**
> + * UART related constants
> + **/
> +-#define RK3399_BAUDRATE 115200
> ++#define RK3399_BAUDRATE 150
> + #define RK3399_UART_CLOCK 2400
> +
> +
> /**
> +--
> +2.30.2
> +
> diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> index 442dee8..1942c17 100644
> --- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> +++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> @@ -4,3 +4,8 @@ DEPENDS_append_rk3399 = " virtual/arm-none-eabi-gcc-native"
>
> COMPATIBLE_MACHINE_append_rk3399 = "|rk3399"
> COMPATIBLE_MACHINE_append_rk3328 = "|rk3328"
> +
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> +SRC_URI += "\
> +file://serial-console-baudrate.patch \
> +"
> --
> 2.30.2
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#53046): https://lists.yoctoproject.org/g/yocto/message/53046
Mute This Topic: https://lists.yoctoproject.org/mt/81904391/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [yocto] [meta-rockchip][PATCH] trusted-firmware-a: use 1500000 baud for serial console
> Sure it is awkward when all tools have come to default > to 115200, but then is the situation so different from > when we transitioned from, say, 9600? These are historical reasons. It started as 600, 1200, then quickly jumped to 9600 (4x), stayed some time there, and then transitioned via 19600 to final 115200. But I also see baud rates of 57600. 115200/9600 = 12 The serial speed transmission was the issue here. > Hopefully someone from Rockchip will answer :) Could not agree more with you on the statement. Hopefully! ;) > When working on this platform everyone now has his tools setup > for 150, because that's the vendor BSP settings. Would we > have good technical reasons to switch back ? Since most of them use 115200. And clock divisors are adjusted to that baud rate, my best guess. Maybe the reason for that is that the base clocking tree frequency for Rockchip could not derive 115200, rather 15?! Zee ___ On Wed, Apr 7, 2021 at 10:55 AM Yann Dirson wrote: > > Le mer. 7 avr. 2021 à 06:07, Zoran Stojsavljevic > a écrit : > > > > > +-#define RK3399_BAUDRATE 115200 > > > ++#define RK3399_BAUDRATE 150 > > > + #define RK3399_UART_CLOCK 2400 > > > > Interesting... For years (a few decades) everybody has used 115200 as > > the standard setup for UART, as global definition. > > Sure it is awkward when all tools have come to default to 115200, but then > is the situation so different form when we transitionned from, say, 9600 ? > > > Why suddenly somebody changed the UART baud rate to be non-standard? > > From the speed point of view??? > > > > Don't think so. > > Hopefully someone from Rockchip will answer :) > > > Should U-Boot be adjusted to the standard baud rate of 115200 for RK3399? > > When working on this platform everyone now has his tools setup for 150, > because that's the vendor BSP settings. Would we have good technical reasons > to switch back ? > > > > > > My two cent addendum/thinking, > > Zee > > ___ > > > > > > On Wed, Apr 7, 2021 at 1:47 AM Yann Dirson > > wrote: > > > > > > From: Yann Dirson > > > > > > TF-A runs between two u-boot stages which both uses 150 baud, it > > > just makes no sense to use the same UART at a different rate. > > > > > > Here is a sample session with the successive stages, with TF-A > > > artificially > > > separated for emphasis: > > > > > > [20210406-175438.135934] U-Boot TPL 2021.01 (Jan 11 2021 - 18:11:43) > > > [20210406-175438.135956] Channel 0: DDR3, 933MHz > > > [20210406-175438.236974] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16 > > > Size=1024MB > > > [20210406-175438.237000] Channel 1: DDR3, 933MHz > > > [20210406-175438.237004] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16 > > > Size=1024MB > > > [20210406-175438.237008] 256B stride > > > [20210406-175438.237012] Trying to boot from BOOTROM > > > [20210406-175438.237015] Returning to boot ROM... > > > [20210406-175438.237018] > > > [20210406-175438.573394] U-Boot SPL 2021.01 (Jan 11 2021 - 18:11:43 > > > +) > > > [20210406-175438.573431] Trying to boot from MMC1 > > > > > > [20210406-175438.589254] NOTICE: BL31: v2.3():v2.3-dirty > > > [20210406-175440.534055] NOTICE: BL31: Built : 15:56:43, Apr 20 2020 > > > > > > [20210406-175441.393423] U-Boot 2021.01 (Jan 11 2021 - 18:11:43 +) > > > [20210406-175441.393429] > > > [20210406-175441.393433] SoC: Rockchip rk3399 > > > > > > Signed-off-by: Yann Dirson > > > --- > > > .../files/serial-console-baudrate.patch | 35 +++ > > > .../trusted-firmware-a_%.bbappend | 5 +++ > > > 2 files changed, 40 insertions(+) > > > create mode 100644 > > > recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch > > > > > > diff --git > > > a/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch > > > b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch > > > new file mode 100644 > > > index 000..10b5a2b > > > --- /dev/null > > > +++ b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch > > > @@ -0,0 +1,35 @@ > > > +From 840d6b6420e1fd8cdf6e4de7fa58a6f8de151622 Mon Sep 17 00:00:00 2001 > > > +From: Yann Dirson > > > +Date: Tue, 6 Apr 2021 17:28:45 +0200 > > > +Subject: [PATCH] Set serial console baudrate back to 150. > > > + > > > +TF-A runs between two u-boot stages which both uses 150 baud, it > > > +just makes no sense to use the same UART at a different rate. > > > + > > > +This effectively reverts part of > > > 0c05748bdebfad9fa43a80962186438bb8fbce62. > > > +Main reason for that change stated in > > > https://developer.trustedfirmware.org/T762 > > > +is ChromeOS compatibility. > > > + > > > +Looks like this patch may become unnecessary in the future, when > > > +u-boot and TF-A get to communicate this value. > > > + > > > +--- > > > + plat/rockchip/rk3399/rk3399_def.h | 2 +- > > > + 1 file changed, 1 insertion(+), 1 deletion(-) > > >
Re: [yocto] [meta-rockchip][PATCH] trusted-firmware-a: use 1500000 baud for serial console
Le mer. 7 avr. 2021 à 06:07, Zoran Stojsavljevic a écrit : > > > +-#define RK3399_BAUDRATE 115200 > > ++#define RK3399_BAUDRATE 150 > > + #define RK3399_UART_CLOCK 2400 > > Interesting... For years (a few decades) everybody has used 115200 as > the standard setup for UART, as global definition. Sure it is awkward when all tools have come to default to 115200, but then is the situation so different form when we transitionned from, say, 9600 ? > Why suddenly somebody changed the UART baud rate to be non-standard? > From the speed point of view??? > > Don't think so. Hopefully someone from Rockchip will answer :) > Should U-Boot be adjusted to the standard baud rate of 115200 for RK3399? When working on this platform everyone now has his tools setup for 150, because that's the vendor BSP settings. Would we have good technical reasons to switch back ? > > My two cent addendum/thinking, > Zee > ___ > > > On Wed, Apr 7, 2021 at 1:47 AM Yann Dirson > wrote: > > > > From: Yann Dirson > > > > TF-A runs between two u-boot stages which both uses 150 baud, it > > just makes no sense to use the same UART at a different rate. > > > > Here is a sample session with the successive stages, with TF-A artificially > > separated for emphasis: > > > > [20210406-175438.135934] U-Boot TPL 2021.01 (Jan 11 2021 - 18:11:43) > > [20210406-175438.135956] Channel 0: DDR3, 933MHz > > [20210406-175438.236974] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16 > > Size=1024MB > > [20210406-175438.237000] Channel 1: DDR3, 933MHz > > [20210406-175438.237004] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16 > > Size=1024MB > > [20210406-175438.237008] 256B stride > > [20210406-175438.237012] Trying to boot from BOOTROM > > [20210406-175438.237015] Returning to boot ROM... > > [20210406-175438.237018] > > [20210406-175438.573394] U-Boot SPL 2021.01 (Jan 11 2021 - 18:11:43 +) > > [20210406-175438.573431] Trying to boot from MMC1 > > > > [20210406-175438.589254] NOTICE: BL31: v2.3():v2.3-dirty > > [20210406-175440.534055] NOTICE: BL31: Built : 15:56:43, Apr 20 2020 > > > > [20210406-175441.393423] U-Boot 2021.01 (Jan 11 2021 - 18:11:43 +) > > [20210406-175441.393429] > > [20210406-175441.393433] SoC: Rockchip rk3399 > > > > Signed-off-by: Yann Dirson > > --- > > .../files/serial-console-baudrate.patch | 35 +++ > > .../trusted-firmware-a_%.bbappend | 5 +++ > > 2 files changed, 40 insertions(+) > > create mode 100644 > > recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch > > > > diff --git > > a/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch > > b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch > > new file mode 100644 > > index 000..10b5a2b > > --- /dev/null > > +++ b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch > > @@ -0,0 +1,35 @@ > > +From 840d6b6420e1fd8cdf6e4de7fa58a6f8de151622 Mon Sep 17 00:00:00 2001 > > +From: Yann Dirson > > +Date: Tue, 6 Apr 2021 17:28:45 +0200 > > +Subject: [PATCH] Set serial console baudrate back to 150. > > + > > +TF-A runs between two u-boot stages which both uses 150 baud, it > > +just makes no sense to use the same UART at a different rate. > > + > > +This effectively reverts part of 0c05748bdebfad9fa43a80962186438bb8fbce62. > > +Main reason for that change stated in > > https://developer.trustedfirmware.org/T762 > > +is ChromeOS compatibility. > > + > > +Looks like this patch may become unnecessary in the future, when > > +u-boot and TF-A get to communicate this value. > > + > > +--- > > + plat/rockchip/rk3399/rk3399_def.h | 2 +- > > + 1 file changed, 1 insertion(+), 1 deletion(-) > > + > > +diff --git a/plat/rockchip/rk3399/rk3399_def.h > > b/plat/rockchip/rk3399/rk3399_def.h > > +index ba83242eb..8d6ecfbe6 100644 > > +--- a/plat/rockchip/rk3399/rk3399_def.h > > b/plat/rockchip/rk3399/rk3399_def.h > > +@@ -17,7 +17,7 @@ > > + > > /** > > + * UART related constants > > + > > **/ > > +-#define RK3399_BAUDRATE 115200 > > ++#define RK3399_BAUDRATE 150 > > + #define RK3399_UART_CLOCK 2400 > > + > > + > > /** > > +-- > > +2.30.2 > > + > > diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend > > b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend > > index 442dee8..1942c17 100644 > > --- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend > > +++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend > > @@ -4,3 +4,8 @@ DEPENDS_append_rk3399 = " virtual/arm-none-eabi-gcc-native" > > > > COMPATIBLE_MACHINE_append_rk3399 = "|rk3399" > >
[yocto] [meta-rockchip][PATCH] trusted-firmware-a: use 1500000 baud for serial console
From: Yann Dirson
TF-A runs between two u-boot stages which both uses 150 baud, it
just makes no sense to use the same UART at a different rate.
Here is a sample session with the successive stages, with TF-A artificially
separated for emphasis:
[20210406-175438.135934] U-Boot TPL 2021.01 (Jan 11 2021 - 18:11:43)
[20210406-175438.135956] Channel 0: DDR3, 933MHz
[20210406-175438.236974] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16
Size=1024MB
[20210406-175438.237000] Channel 1: DDR3, 933MHz
[20210406-175438.237004] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16
Size=1024MB
[20210406-175438.237008] 256B stride
[20210406-175438.237012] Trying to boot from BOOTROM
[20210406-175438.237015] Returning to boot ROM...
[20210406-175438.237018]
[20210406-175438.573394] U-Boot SPL 2021.01 (Jan 11 2021 - 18:11:43 +)
[20210406-175438.573431] Trying to boot from MMC1
[20210406-175438.589254] NOTICE: BL31: v2.3():v2.3-dirty
[20210406-175440.534055] NOTICE: BL31: Built : 15:56:43, Apr 20 2020
[20210406-175441.393423] U-Boot 2021.01 (Jan 11 2021 - 18:11:43 +)
[20210406-175441.393429]
[20210406-175441.393433] SoC: Rockchip rk3399
Signed-off-by: Yann Dirson
---
.../files/serial-console-baudrate.patch | 35 +++
.../trusted-firmware-a_%.bbappend | 5 +++
2 files changed, 40 insertions(+)
create mode 100644
recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
diff --git a/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
new file mode 100644
index 000..10b5a2b
--- /dev/null
+++ b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
@@ -0,0 +1,35 @@
+From 840d6b6420e1fd8cdf6e4de7fa58a6f8de151622 Mon Sep 17 00:00:00 2001
+From: Yann Dirson
+Date: Tue, 6 Apr 2021 17:28:45 +0200
+Subject: [PATCH] Set serial console baudrate back to 150.
+
+TF-A runs between two u-boot stages which both uses 150 baud, it
+just makes no sense to use the same UART at a different rate.
+
+This effectively reverts part of 0c05748bdebfad9fa43a80962186438bb8fbce62.
+Main reason for that change stated in
https://developer.trustedfirmware.org/T762
+is ChromeOS compatibility.
+
+Looks like this patch may become unnecessary in the future, when
+u-boot and TF-A get to communicate this value.
+
+---
+ plat/rockchip/rk3399/rk3399_def.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/plat/rockchip/rk3399/rk3399_def.h
b/plat/rockchip/rk3399/rk3399_def.h
+index ba83242eb..8d6ecfbe6 100644
+--- a/plat/rockchip/rk3399/rk3399_def.h
b/plat/rockchip/rk3399/rk3399_def.h
+@@ -17,7 +17,7 @@
+ /**
+ * UART related constants
+ **/
+-#define RK3399_BAUDRATE 115200
++#define RK3399_BAUDRATE 150
+ #define RK3399_UART_CLOCK 2400
+
+
/**
+--
+2.30.2
+
diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
index 442dee8..1942c17 100644
--- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
+++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
@@ -4,3 +4,8 @@ DEPENDS_append_rk3399 = " virtual/arm-none-eabi-gcc-native"
COMPATIBLE_MACHINE_append_rk3399 = "|rk3399"
COMPATIBLE_MACHINE_append_rk3328 = "|rk3328"
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
+SRC_URI += "\
+file://serial-console-baudrate.patch \
+"
--
2.30.2
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#53037): https://lists.yoctoproject.org/g/yocto/message/53037
Mute This Topic: https://lists.yoctoproject.org/mt/81904391/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
