Re: [yocto] [meta-qt5] How to contribute patches for qtwebengine in meta-qt5?
On Fri, 2019-11-01 at 13:24 +0100, Martin Jansa wrote: > This patch is already included in 5.13.2 upgrade (ready in zeus-next > and master-next branches), so you don't need to do anything. Okay, that's great! > Otherwise like Khem says, submit the change for meta-qt5 repository > like any other layer. > > The meta-qt5/qt* repositories are used to maintain the patches, but > usually only me is updating them to keep in sync with meta-qt5 and > then syncing from them to meta-qt5 with git format-patch --no- > numbered --no-signature when doing bigger rebase like when upgrading > to newer Qt version. Thanks for the information! -- Tanu > On Fri, Nov 1, 2019 at 11:02 AM Tanu Kaskinen wrote: > > Hi all! > > > > The meta-qt5 readme says that contributions should be made by forking > > the meta-qt5 repository on GitHub, but when I look at the qtwebengine > > recipe, it looks like patches are pulled from > > https://github.com/meta-qt5/qtwebengine-chromium, and that repository > > looks like the patches are kept in a particular order so adding a patch > > at the top is perhaps not what I should do. > > > > It's not clear to me how I should submit a patch in this case. The > > patch in question would be a simple backport of this upstream commit: > > https://codereview.qt-project.org/gitweb?p=qt/qtwebengine-chromium.git;a=commitdiff;h=b84e8682b312fb16b16ffb9591415067ceae69f8 > > > > It's needed for not breaking qtwebengine when upgrading PulseAudio to > > 13.0. > > > > -- > > Tanu > > > > https://www.patreon.com/tanuk > > https://liberapay.com/tanuk -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [meta-qt5] How to contribute patches for qtwebengine in meta-qt5?
This patch is already included in 5.13.2 upgrade (ready in zeus-next and master-next branches), so you don't need to do anything. Otherwise like Khem says, submit the change for meta-qt5 repository like any other layer. The meta-qt5/qt* repositories are used to maintain the patches, but usually only me is updating them to keep in sync with meta-qt5 and then syncing from them to meta-qt5 with git format-patch --no-numbered --no-signature when doing bigger rebase like when upgrading to newer Qt version. Regards, On Fri, Nov 1, 2019 at 11:02 AM Tanu Kaskinen wrote: > Hi all! > > The meta-qt5 readme says that contributions should be made by forking > the meta-qt5 repository on GitHub, but when I look at the qtwebengine > recipe, it looks like patches are pulled from > https://github.com/meta-qt5/qtwebengine-chromium, and that repository > looks like the patches are kept in a particular order so adding a patch > at the top is perhaps not what I should do. > > It's not clear to me how I should submit a patch in this case. The > patch in question would be a simple backport of this upstream commit: > > https://codereview.qt-project.org/gitweb?p=qt/qtwebengine-chromium.git;a=commitdiff;h=b84e8682b312fb16b16ffb9591415067ceae69f8 > > It's needed for not breaking qtwebengine when upgrading PulseAudio to > 13.0. > > -- > Tanu > > https://www.patreon.com/tanuk > https://liberapay.com/tanuk > > -- > ___ > yocto mailing list > yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/yocto > -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [meta-qt5] How to contribute patches for qtwebengine in meta-qt5?
On Fri, Nov 1, 2019 at 3:02 AM Tanu Kaskinen wrote: > Hi all! > > The meta-qt5 readme says that contributions should be made by forking > the meta-qt5 repository on GitHub, but when I look at the qtwebengine > recipe, it looks like patches are pulled from > https://github.com/meta-qt5/qtwebengine-chromium, and that repository > looks like the patches are kept in a particular order so adding a patch > at the top is perhaps not what I should do. > Like you would do for any other layer is fine Better if you can maintain the patch ordering > > It's not clear to me how I should submit a patch in this case. The > patch in question would be a simple backport of this upstream commit: > > https://codereview.qt-project.org/gitweb?p=qt/qtwebengine-chromium.git;a=commitdiff;h=b84e8682b312fb16b16ffb9591415067ceae69f8 > > It's needed for not breaking qtwebengine when upgrading PulseAudio to > 13.0. > > -- > Tanu > > https://www.patreon.com/tanuk > https://liberapay.com/tanuk > > -- > ___ > yocto mailing list > yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/yocto > -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-qt5] How to contribute patches for qtwebengine in meta-qt5?
Hi all! The meta-qt5 readme says that contributions should be made by forking the meta-qt5 repository on GitHub, but when I look at the qtwebengine recipe, it looks like patches are pulled from https://github.com/meta-qt5/qtwebengine-chromium, and that repository looks like the patches are kept in a particular order so adding a patch at the top is perhaps not what I should do. It's not clear to me how I should submit a patch in this case. The patch in question would be a simple backport of this upstream commit: https://codereview.qt-project.org/gitweb?p=qt/qtwebengine-chromium.git;a=commitdiff;h=b84e8682b312fb16b16ffb9591415067ceae69f8 It's needed for not breaking qtwebengine when upgrading PulseAudio to 13.0. -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
