Re: [yocto] [PATCH][meta-raspberrypi 1/2] raspberrypi3: serial console

[Trevor Woerner]

On Mon 2016-04-04 @ 08:06:30 AM, Trevor Woerner wrote:
> On Mon 2016-04-04 @ 04:32:41 PM, Gary Thomas wrote:
> > On 04/04/2016 03:24 PM, Trevor Woerner wrote:
> > >The serial console on the Raspberry Pi 3 is located at /dev/ttyS0 and not
> > >/dev/ttyAMA0.
> > >
> > >Signed-off-by: Trevor Woerner 
> > >---
> > >  conf/machine/raspberrypi3.conf | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > >diff --git a/conf/machine/raspberrypi3.conf 
> > >b/conf/machine/raspberrypi3.conf
> > >index 1b73f2f..2c3df41 100644
> > >--- a/conf/machine/raspberrypi3.conf
> > >+++ b/conf/machine/raspberrypi3.conf
> > >@@ -7,3 +7,5 @@ MACHINEOVERRIDES = "raspberrypi2:${MACHINE}"
> > >  MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-brcm43430"
> > >
> > >  include conf/machine/raspberrypi2.conf
> > >+
> > >+SERIAL_CONSOLE_raspberrypi3 = "115200 ttyS0"
> > >
> > 
> > Why the _raspberrypi3 modifier?  Wouldn't SERIAL_CONSOLE = "115200 ttyS0" 
> > do?
> 
> oh, I see what you mean. maybe, let me check

yep, that works too ;-)

v2 to follow

> 
> > 
> > -- 
> > 
> > Gary Thomas |  Consulting for the
> > MLB Associates  |Embedded world
> > 
> > -- 
> > ___
> > yocto mailing list
> > yocto@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/yocto
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [PATCH][meta-raspberrypi 1/2] raspberrypi3: serial console

[Trevor Woerner]

On Mon 2016-04-04 @ 04:32:41 PM, Gary Thomas wrote:
> On 04/04/2016 03:24 PM, Trevor Woerner wrote:
> >The serial console on the Raspberry Pi 3 is located at /dev/ttyS0 and not
> >/dev/ttyAMA0.
> >
> >Signed-off-by: Trevor Woerner 
> >---
> >  conf/machine/raspberrypi3.conf | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> >diff --git a/conf/machine/raspberrypi3.conf b/conf/machine/raspberrypi3.conf
> >index 1b73f2f..2c3df41 100644
> >--- a/conf/machine/raspberrypi3.conf
> >+++ b/conf/machine/raspberrypi3.conf
> >@@ -7,3 +7,5 @@ MACHINEOVERRIDES = "raspberrypi2:${MACHINE}"
> >  MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-brcm43430"
> >
> >  include conf/machine/raspberrypi2.conf
> >+
> >+SERIAL_CONSOLE_raspberrypi3 = "115200 ttyS0"
> >
> 
> Why the _raspberrypi3 modifier?  Wouldn't SERIAL_CONSOLE = "115200 ttyS0" do?

oh, I see what you mean. maybe, let me check

> 
> -- 
> 
> Gary Thomas |  Consulting for the
> MLB Associates  |Embedded world
> 
> -- 
> ___
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [PATCH][meta-raspberrypi 1/2] raspberrypi3: serial console

[Trevor Woerner]

On Mon 2016-04-04 @ 04:32:41 PM, Gary Thomas wrote:
> On 04/04/2016 03:24 PM, Trevor Woerner wrote:
> >The serial console on the Raspberry Pi 3 is located at /dev/ttyS0 and not
> >/dev/ttyAMA0.
> >
> >Signed-off-by: Trevor Woerner 
> >---
> >  conf/machine/raspberrypi3.conf | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> >diff --git a/conf/machine/raspberrypi3.conf b/conf/machine/raspberrypi3.conf
> >index 1b73f2f..2c3df41 100644
> >--- a/conf/machine/raspberrypi3.conf
> >+++ b/conf/machine/raspberrypi3.conf
> >@@ -7,3 +7,5 @@ MACHINEOVERRIDES = "raspberrypi2:${MACHINE}"
> >  MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-brcm43430"
> >
> >  include conf/machine/raspberrypi2.conf
> >+
> >+SERIAL_CONSOLE_raspberrypi3 = "115200 ttyS0"
> >
> 
> Why the _raspberrypi3 modifier?  Wouldn't SERIAL_CONSOLE = "115200 ttyS0" do?

...because the raspi3 MACHINE just basically includes/requires the raspi2
MACHINE, and the raspi2 MACHINE includes/requires include/rpi-base.inc, and
it's in rpi-base.inc that we find the SERIAL_CONSOLE definition.

Originally I had pulled out the SERIAL_CONSOLE from rpi-base and added it to
each of the raspi MACHINES, 3 of which were the same (AMA0) and one was ttyS0.
Then, looking over the patch set, I thought it would be cleaner to just keep
everything as it was and only add the ttyS0 to the raspi3 MACHINE (which
requires the override).

> 
> -- 
> 
> Gary Thomas |  Consulting for the
> MLB Associates  |Embedded world
> 
> -- 
> ___
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto