[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 455: Make FTS++ optional.

2012-03-29 Thread noreply
Merge authors:
  Moritz Neeb (zormit)
Related merge proposals:
  https://code.launchpad.net/~zormit/zeitgeist/fix-932989/+merge/98760
  proposed by: Moritz Neeb (zormit)
  review: Approve - Michal Hruby (mhr3)
  review: Resubmit - Moritz Neeb (zormit)

revno: 455 [merge]
committer: Seif Lotfy s...@lotfy.com
branch nick: zeitgeist
timestamp: Thu 2012-03-29 12:54:52 +0200
message:
   Make FTS++ optional.
  * Make the fts.vala extension behave if FTS++ isn't there.
modified:
  configure.ac
  extensions/Makefile.am
  extensions/fts.vala


--
lp:zeitgeist
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird

Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
To unsubscribe from this branch go to 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'configure.ac'
--- configure.ac	2012-03-20 12:29:29 +
+++ configure.ac	2012-03-29 10:54:52 +
@@ -80,6 +80,16 @@
 DBUS_SERVICES_DIR=$services_dir
 AC_SUBST(DBUS_SERVICES_DIR)
 
+
+#
+# Configure options: --disable-fts.
+#
+AC_ARG_ENABLE([fts],
+AS_HELP_STRING([--disable-fts], [Build without FTS++ extension]),
+[enable_fts=$enableval],[enable_fts=yes])
+
+AM_CONDITIONAL(HAVE_FTS, test x$enable_fts != xno)
+
 AC_CONFIG_FILES([
 	Makefile
 	src/Makefile
@@ -131,6 +141,7 @@
 Install Prefix: ${prefix}
 
   Optional dependencies
+fts++:  ${enable_fts}
 dee-icu:${with_dee_icu}
 
 EOF

=== modified file 'extensions/Makefile.am'
--- extensions/Makefile.am	2012-02-15 18:27:21 +
+++ extensions/Makefile.am	2012-03-15 21:36:10 +
@@ -1,4 +1,6 @@
+if HAVE_FTS
 SUBDIRS = fts++
+endif
 
 NULL =
 

=== modified file 'extensions/fts.vala'
--- extensions/fts.vala	2012-02-10 17:03:50 +
+++ extensions/fts.vala	2012-03-26 20:49:32 +
@@ -95,24 +95,22 @@
 
 // FIXME: shouldn't we delay this to next idle callback?
 // Get SimpleIndexer
-Bus.watch_name_on_connection (connection,
+connection.get_proxy.beginRemoteSimpleIndexer (
 INDEXER_NAME,
-BusNameWatcherFlags.AUTO_START,
-(conn) =
-{
-if (siin != null) return;
-conn.get_proxy.beginRemoteSimpleIndexer (
-org.gnome.zeitgeist.SimpleIndexer,
-/org/gnome/zeitgeist/index/activity,
-0, null, this.proxy_acquired);
-},
-() = {});
+/org/gnome/zeitgeist/index/activity,
+0, null, this.proxy_acquired);
 }
 catch (Error err)
 {
 warning (%s, err.message);
 }
 }
+
+private void proxy_not_present()
+{
+notifier.remove_monitor (new BusName (INDEXER_NAME),/org/gnome/zeitgeist/monitor/special);
+this.unload();
+}
 
 private void proxy_acquired (Object? obj, AsyncResult res)
 {
@@ -120,7 +118,15 @@
 try
 {
 siin = conn.get_proxy.endRemoteSimpleIndexer (res);
-siin_connection_failed = false;
+if((siin as DBusProxy).g_name_owner == null)
+{
+this.proxy_not_present();
+siin_connection_failed = true;
+}
+else
+{
+siin_connection_failed = false;
+}
 }
 catch (IOError err)
 {
@@ -147,6 +153,25 @@
 Not connected to SimpleIndexer);
 }
 }
+
+public override void unload ()
+{
+try
+{
+var connection = Bus.get_sync (BusType.SESSION, null);
+if (registration_id != 0)
+{
+connection.unregister_object (registration_id);
+registration_id = 0;
+}
+}
+catch (Error err)
+{
+warning (%s, err.message);
+}
+
+debug (%s, this.ref_count = %u, Log.METHOD, this.ref_count);
+}
 
 public async void search (string query_string, Variant time_range,
 Variant filter_templates, uint offset, uint count, uint result_type,

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Merge] lp:~zormit/zeitgeist/fix-932989 into lp:zeitgeist

2012-03-29 Thread noreply
The proposal to merge lp:~zormit/zeitgeist/fix-932989 into lp:zeitgeist has 
been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~zormit/zeitgeist/fix-932989/+merge/98760
-- 
https://code.launchpad.net/~zormit/zeitgeist/fix-932989/+merge/98760
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 932989] Re: Make FTS++ optional

2012-03-29 Thread Seif Lotfy
** Changed in: zeitgeist
   Status: In Progress = Fix Committed

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/932989

Title:
  Make FTS++ optional

Status in Zeitgeist Framework:
  Fix Committed

Bug description:
  * Make FTS++ optional.
  * Make the fts.vala extension behave if FTS++ isn't there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/932989/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 959615] Re: Sorting of LEAST_POPULAR_* result type

2012-03-29 Thread Siegfried Gevatter
** Changed in: zeitgeist
Milestone: None = 0.9.0

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/959615

Title:
  Sorting of LEAST_POPULAR_* result type

Status in Zeitgeist Framework:
  New

Bug description:
   // FIXME: Why are LEAST_POPULAR_* using ASC?

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/959615/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 456: indentation fix

2012-03-29 Thread noreply

revno: 456
committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
branch nick: bluebird
timestamp: Thu 2012-03-29 19:51:33 +0200
message:
  indentation fix
modified:
  src/sql.vala


--
lp:zeitgeist
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird

Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
To unsubscribe from this branch go to 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/sql.vala'
--- src/sql.vala	2012-03-26 14:38:14 +
+++ src/sql.vala	2012-03-29 17:51:33 +
@@ -101,7 +101,7 @@
 int rc = Sqlite.Database.open_v2 (
 Utils.get_database_file_path (),
 out database, flags);
-
+
 if (rc == Sqlite.OK)
 {
 try
@@ -134,7 +134,7 @@
 throw err;
 }
 }
-
+
 if (rc != Sqlite.OK)
 {
 if (rc == Sqlite.CORRUPT  retry)

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Merge] lp:~rainct/zeitgeist/ignore-ubuntuone-actor into lp:zeitgeist

2012-03-29 Thread Siegfried Gevatter
Siegfried Gevatter has proposed merging 
lp:~rainct/zeitgeist/ignore-ubuntuone-actor into lp:zeitgeist.

Requested reviews:
  Zeitgeist Framework Team (zeitgeist)

For more details, see:
https://code.launchpad.net/~rainct/zeitgeist/ignore-ubuntuone-actor/+merge/99986

mhr3_ ok, so it seems we decided to skip the u1 events when indexing
mhr3_ (they can be uniquely identified by actor)
-- 
https://code.launchpad.net/~rainct/zeitgeist/ignore-ubuntuone-actor/+merge/99986
Your team Zeitgeist Framework Team is requested to review the proposed merge of 
lp:~rainct/zeitgeist/ignore-ubuntuone-actor into lp:zeitgeist.
=== modified file 'extensions/fts++/indexer.cpp'
--- extensions/fts++/indexer.cpp	2012-03-26 16:43:07 +
+++ extensions/fts++/indexer.cpp	2012-03-29 18:05:21 +
@@ -1303,6 +1303,14 @@
 
 void Indexer::IndexEvent (ZeitgeistEvent *event)
 {
+  // Blacklist Ubuntu One events...
+  const gchar *actor;
+  actor = zeitgeist_event_get_actor (event);
+  if (strcmp(actor, dbus://com.ubuntuone.SyncDaemon.service) == 0)
+return;
+  if (strcmp(actor, dbus://org.desktopcouch.CouchDB.service) == 0)
+return;
+
   try
   {
 const gchar *val;

=== modified file 'extensions/fts++/test/test-indexer.cpp'
--- extensions/fts++/test/test-indexer.cpp	2012-03-20 12:25:59 +
+++ extensions/fts++/test/test-indexer.cpp	2012-03-29 18:05:21 +
@@ -1074,6 +1074,23 @@
   assert_nth_result_has_id (results, 2, event_id6);
 }
 
+static void
+test_index_ignore_ubuntu_one (Fixture *fix, gconstpointer data)
+{
+  guint matches;
+
+  // add test events to DBs
+  index_event (fix, create_test_event_simple (ubuntuone:uuid, failme));
+  ZeitgeistEvent *event = create_test_event_simple (file:///nice%20uri, failme);
+  zeitgeist_event_set_actor (event, dbus://com.ubuntuone.SyncDaemon.service);
+  index_event (fix, event);
+
+  GPtrArray *results = search_simple (fix, failme, NULL,
+  ZEITGEIST_RESULT_TYPE_MOST_RECENT_EVENTS, matches);
+
+  g_assert_cmpuint (results-len, ==, 0);
+}
+
 G_BEGIN_DECLS
 
 static void discard_message (const gchar *domain,
@@ -1138,6 +1155,8 @@
   g_test_add (/Zeitgeist/FTS/Indexer/Query/MostPopularSubjects, Fixture, 0,
   setup, test_query_most_popular_subjects, teardown);
   */
+  g_test_add (/Zeitgeist/FTS/Indexer/Index/IgnoreUbuntuOne, Fixture, 0,
+  setup, test_index_ignore_ubuntu_one, teardown);
 
   // get rid of the rebuilding index... messages
   g_log_set_handler (NULL, G_LOG_LEVEL_MESSAGE, discard_message, NULL);

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 961974] Re: Recover from Zeitgeist database corruption (detected at query time)

2012-03-29 Thread Siegfried Gevatter
** Summary changed:

- dash (or file lens) doesn't find file
+ Recover from Zeitgeist database corruption (detected at query time)

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/961974

Title:
  Recover from Zeitgeist database corruption (detected at query time)

Status in Unity:
  Incomplete
Status in Unity Files Lens:
  Incomplete
Status in Zeitgeist Framework:
  In Progress

Bug description:
  This is based on the checkbox test:
  1. Start gedit.
  2. Save a file named foo in your home folder.
  1. Tap super to open the dash
  2. Enter f
 - The results should contain at least the foo file and Firefox
  3. Click on the cross next to f, in the textentry
 - The f search should be canceled, bringing you back to the generic 
Search entry with the default elements

  
  I slightly modified it and instead of file called foo I have a 
hello_world_file (as foo returned far too many other results).

  Actual result:
  The file can not be found via dash (or file lens).

  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: unity 5.6.0+bzr2156ubuntu0+670 [origin: LP-PPA-unity-team-staging]
  ProcVersionSignature: Ubuntu 3.2.0-19.31-generic-pae 3.2.12
  Uname: Linux 3.2.0-19-generic-pae i686
  ApportVersion: 1.94.1-0ubuntu2
  Architecture: i386
  CompizPlugins: 
[core,composite,opengl,compiztoolbox,decor,vpswitch,snap,mousepoll,resize,place,move,wall,grid,regex,imgpng,session,gnomecompat,animation,fade,unitymtgrabhandles,workarounds,scale,expo,ezoom,unityshell]
  CrashDB: unity
  Date: Thu Mar 22 10:00:40 2012
  InstallationMedia: Ubuntu 11.10 Oneiric Ocelot - Release i386 (20111012)
  SourcePackage: unity
  UpgradeStatus: Upgraded to precise on 2012-02-17 (33 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/unity/+bug/961974/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 928324] Re: zeitgeist-fts using up 600 MB of RAM

2012-03-29 Thread Siegfried Gevatter
** Branch linked: lp:~rainct/zeitgeist/ignore-ubuntuone-actor

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/928324

Title:
  zeitgeist-fts using up 600 MB of RAM

Status in Zeitgeist Framework:
  Incomplete
Status in “zeitgeist” package in Ubuntu:
  Incomplete

Bug description:
  Using Ubuntu 12.04 amd64, up to date as of 7/2/2012
  zeitgeist-core Installed version: 0.8.99~alpha2-2

  After opening up system monitor, I noticed that /usr/share/zeitgeist
  /fts-python/fts.py was using 650 MiB of RAM. This was about 5-10
  minutes after booting the system and logging in.

  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: zeitgeist-core 0.8.99~alpha2-2
  ProcVersionSignature: Ubuntu 3.2.0-14.23-generic 3.2.3
  Uname: Linux 3.2.0-14-generic x86_64
  ApportVersion: 1.91-0ubuntu1
  Architecture: amd64
  Date: Tue Feb  7 08:38:38 2012
  InstallationMedia: Ubuntu 12.04 LTS Precise Pangolin - Alpha amd64 
(20120116.2)
  SourcePackage: zeitgeist
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/928324/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 948794] Re: Current URI field not used (FTS)

2012-03-29 Thread Siegfried Gevatter
I think this is done?

** Changed in: zeitgeist
   Status: In Progress = Fix Committed

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/948794

Title:
  Current URI field not used (FTS)

Status in Zeitgeist Framework:
  Fix Committed

Bug description:
  Keeping this as a master bug to remind us that we should be using the
  current uri field in many places now that there's actually something
  pushing MOVE_EVENTs to Zeitgeist. First place to fix would be FTS.

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/948794/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 961974] Re: Recover from Zeitgeist database corruption (detected at query time)

2012-03-29 Thread Siegfried Gevatter
[Development discussion, bug reporters feel free to ignore this]

OK, so the plan is to improve Zeitgeist's database corruption recovery.

The log provided in this bug report is for the get_last_id() query. I
don't know how many cases that'll cover, but if we want to be
comprehensive it won't be enough.

I'd prefer doing the checking at startup time, but I don't see any good way:
 a) PRAGMA integrity_check: way too slow
 b) PRAGMA quick_check: not sure if it'll catch everything? also, in my quick 
testing it scaled super-linearly (0.08s for 8MB DB, 0.16 for 13MB DB)
 c) SELECT from all tables: also likely not comprehensive enough.

The alternative would be checking all (?) queries we do for
SQLITE_CORRUPT and in that case calling Utils.retire_database. (We may
want some constraint though, to avoid ending up with 50 databases if
there's some serious file system problem with a system).

Comments?

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/961974

Title:
  Recover from Zeitgeist database corruption (detected at query time)

Status in Unity:
  Incomplete
Status in Unity Files Lens:
  Incomplete
Status in Zeitgeist Framework:
  In Progress

Bug description:
  This is based on the checkbox test:
  1. Start gedit.
  2. Save a file named foo in your home folder.
  1. Tap super to open the dash
  2. Enter f
 - The results should contain at least the foo file and Firefox
  3. Click on the cross next to f, in the textentry
 - The f search should be canceled, bringing you back to the generic 
Search entry with the default elements

  
  I slightly modified it and instead of file called foo I have a 
hello_world_file (as foo returned far too many other results).

  Actual result:
  The file can not be found via dash (or file lens).

  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: unity 5.6.0+bzr2156ubuntu0+670 [origin: LP-PPA-unity-team-staging]
  ProcVersionSignature: Ubuntu 3.2.0-19.31-generic-pae 3.2.12
  Uname: Linux 3.2.0-19-generic-pae i686
  ApportVersion: 1.94.1-0ubuntu2
  Architecture: i386
  CompizPlugins: 
[core,composite,opengl,compiztoolbox,decor,vpswitch,snap,mousepoll,resize,place,move,wall,grid,regex,imgpng,session,gnomecompat,animation,fade,unitymtgrabhandles,workarounds,scale,expo,ezoom,unityshell]
  CrashDB: unity
  Date: Thu Mar 22 10:00:40 2012
  InstallationMedia: Ubuntu 11.10 Oneiric Ocelot - Release i386 (20111012)
  SourcePackage: unity
  UpgradeStatus: Upgraded to precise on 2012-02-17 (33 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/unity/+bug/961974/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Merge] lp:~rainct/zeitgeist/least-popular-959615 into lp:zeitgeist

2012-03-29 Thread Siegfried Gevatter
Siegfried Gevatter has proposed merging 
lp:~rainct/zeitgeist/least-popular-959615 into lp:zeitgeist.

Requested reviews:
  Zeitgeist Framework Team (zeitgeist)
Related bugs:
  Bug #959615 in Zeitgeist Framework: Sorting of LEAST_POPULAR_* result type
  https://bugs.launchpad.net/zeitgeist/+bug/959615

For more details, see:
https://code.launchpad.net/~rainct/zeitgeist/least-popular-959615/+merge/100013
-- 
https://code.launchpad.net/~rainct/zeitgeist/least-popular-959615/+merge/100013
Your team Zeitgeist Framework Team is requested to review the proposed merge of 
lp:~rainct/zeitgeist/least-popular-959615 into lp:zeitgeist.
=== modified file 'extensions/fts++/indexer.cpp'
--- extensions/fts++/indexer.cpp	2012-03-26 16:43:07 +
+++ extensions/fts++/indexer.cpp	2012-03-29 19:39:19 +
@@ -1303,6 +1303,14 @@
 
 void Indexer::IndexEvent (ZeitgeistEvent *event)
 {
+  // Blacklist Ubuntu One events...
+  const gchar *actor;
+  actor = zeitgeist_event_get_actor (event);
+  if (strcmp(actor, dbus://com.ubuntuone.SyncDaemon.service) == 0)
+return;
+  if (strcmp(actor, dbus://org.desktopcouch.CouchDB.service) == 0)
+return;
+
   try
   {
 const gchar *val;

=== modified file 'extensions/fts++/test/test-indexer.cpp'
--- extensions/fts++/test/test-indexer.cpp	2012-03-20 12:25:59 +
+++ extensions/fts++/test/test-indexer.cpp	2012-03-29 19:39:19 +
@@ -1074,6 +1074,23 @@
   assert_nth_result_has_id (results, 2, event_id6);
 }
 
+static void
+test_index_ignore_ubuntu_one (Fixture *fix, gconstpointer data)
+{
+  guint matches;
+
+  // add test events to DBs
+  index_event (fix, create_test_event_simple (ubuntuone:uuid, failme));
+  ZeitgeistEvent *event = create_test_event_simple (file:///nice%20uri, failme);
+  zeitgeist_event_set_actor (event, dbus://com.ubuntuone.SyncDaemon.service);
+  index_event (fix, event);
+
+  GPtrArray *results = search_simple (fix, failme, NULL,
+  ZEITGEIST_RESULT_TYPE_MOST_RECENT_EVENTS, matches);
+
+  g_assert_cmpuint (results-len, ==, 0);
+}
+
 G_BEGIN_DECLS
 
 static void discard_message (const gchar *domain,
@@ -1138,6 +1155,8 @@
   g_test_add (/Zeitgeist/FTS/Indexer/Query/MostPopularSubjects, Fixture, 0,
   setup, test_query_most_popular_subjects, teardown);
   */
+  g_test_add (/Zeitgeist/FTS/Indexer/Index/IgnoreUbuntuOne, Fixture, 0,
+  setup, test_index_ignore_ubuntu_one, teardown);
 
   // get rid of the rebuilding index... messages
   g_log_set_handler (NULL, G_LOG_LEVEL_MESSAGE, discard_message, NULL);

=== modified file 'src/datamodel.vala'
--- src/datamodel.vala	2012-03-27 14:30:23 +
+++ src/datamodel.vala	2012-03-29 19:39:19 +
@@ -243,40 +243,39 @@
 {
 switch (result_type)
 {
-// FIXME: Why are LEAST_POPULAR_* using ASC?
 case ResultType.LEAST_RECENT_EVENTS:
 case ResultType.LEAST_RECENT_EVENT_ORIGIN:
-case ResultType.LEAST_POPULAR_EVENT_ORIGIN:
 case ResultType.LEAST_RECENT_SUBJECTS:
-case ResultType.LEAST_POPULAR_SUBJECTS:
 case ResultType.LEAST_RECENT_CURRENT_URI:
-case ResultType.LEAST_POPULAR_CURRENT_URI:
 case ResultType.LEAST_RECENT_ACTOR:
-case ResultType.LEAST_POPULAR_ACTOR:
 case ResultType.OLDEST_ACTOR:
 case ResultType.LEAST_RECENT_ORIGIN:
-case ResultType.LEAST_POPULAR_ORIGIN:
 case ResultType.LEAST_RECENT_SUBJECT_INTERPRETATION:
-case ResultType.LEAST_POPULAR_SUBJECT_INTERPRETATION:
 case ResultType.LEAST_RECENT_MIMETYPE:
-case ResultType.LEAST_POPULAR_MIMETYPE:
 return true;
 
 case ResultType.MOST_RECENT_EVENTS:
 case ResultType.MOST_RECENT_EVENT_ORIGIN:
 case ResultType.MOST_POPULAR_EVENT_ORIGIN:
+case ResultType.LEAST_POPULAR_EVENT_ORIGIN:
 case ResultType.MOST_RECENT_SUBJECTS:
 case ResultType.MOST_POPULAR_SUBJECTS:
+case ResultType.LEAST_POPULAR_SUBJECTS:
 case ResultType.MOST_RECENT_CURRENT_URI:
 case ResultType.MOST_POPULAR_CURRENT_URI:
+case ResultType.LEAST_POPULAR_CURRENT_URI:
 case ResultType.MOST_RECENT_ACTOR:
 case ResultType.MOST_POPULAR_ACTOR:
+case ResultType.LEAST_POPULAR_ACTOR:
 case ResultType.MOST_RECENT_ORIGIN:
 case ResultType.MOST_POPULAR_ORIGIN:
+case ResultType.LEAST_POPULAR_ORIGIN:
 case ResultType.MOST_RECENT_SUBJECT_INTERPRETATION:
 case ResultType.MOST_POPULAR_SUBJECT_INTERPRETATION:
+case ResultType.LEAST_POPULAR_SUBJECT_INTERPRETATION:
 case ResultType.MOST_RECENT_MIMETYPE:
 case ResultType.MOST_POPULAR_MIMETYPE:
+

[Zeitgeist] [Bug 959615] Re: Sorting of LEAST_POPULAR_* result type

2012-03-29 Thread Siegfried Gevatter
** Changed in: zeitgeist
   Importance: Undecided = Medium

** Changed in: zeitgeist
   Status: New = Confirmed

** Changed in: zeitgeist
 Assignee: (unassigned) = Siegfried Gevatter (rainct)

** Branch linked: lp:~rainct/zeitgeist/least-popular-959615

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/959615

Title:
  Sorting of LEAST_POPULAR_* result type

Status in Zeitgeist Framework:
  Confirmed

Bug description:
   // FIXME: Why are LEAST_POPULAR_* using ASC?

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/959615/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp