[Zeitgeist] [Bug 973130] Re: [UIFE] Adding landscape installer caused UI overflow
Opening an upstream task with the trivial patch as well ** Also affects: activity-log-manager Importance: Undecided Status: New ** Patch added: 01_move_to_personal_section.patch https://bugs.launchpad.net/activity-log-manager/+bug/973130/+attachment/3002071/+files/01_move_to_personal_section.patch -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/973130 Title: [UIFE] Adding landscape installer caused UI overflow Status in Activity Log Manager for Zeitgeist: New Status in “activity-log-manager” package in Ubuntu: Fix Released Status in “activity-log-manager” source package in Precise: Fix Released Bug description: The recent UIFE/FFE to add the landscape client installer (bug 961606) now causes the control-center layout to overflow and look ugly. I propose that we move the Privacy settings from the System to the Personal category. There is still an open slot there, and it makes more sense there anyway IMHO. To manage notifications about this bug go to: https://bugs.launchpad.net/activity-log-manager/+bug/973130/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 973130] Re: [UIFE] Adding landscape installer caused UI overflow
This bug was fixed in the package activity-log-manager - 0.9.4-0ubuntu2 --- activity-log-manager (0.9.4-0ubuntu2) precise; urgency=low * 01_move_to_personal_section.patch: - [UIFE] Adding landscape installer caused UI overflow (LP: #973130) -- Didier Roche didro...@ubuntu.com Wed, 04 Apr 2012 13:31:02 +0200 ** Changed in: activity-log-manager (Ubuntu Precise) Status: New = Fix Released -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/973130 Title: [UIFE] Adding landscape installer caused UI overflow Status in Activity Log Manager for Zeitgeist: New Status in “activity-log-manager” package in Ubuntu: Fix Released Status in “activity-log-manager” source package in Precise: Fix Released Bug description: The recent UIFE/FFE to add the landscape client installer (bug 961606) now causes the control-center layout to overflow and look ugly. I propose that we move the Privacy settings from the System to the Personal category. There is still an open slot there, and it makes more sense there anyway IMHO. To manage notifications about this bug go to: https://bugs.launchpad.net/activity-log-manager/+bug/973130/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 973130] Re: [UIFE] Adding landscape installer caused UI overflow
** Branch linked: lp:ubuntu/activity-log-manager -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/973130 Title: [UIFE] Adding landscape installer caused UI overflow Status in Activity Log Manager for Zeitgeist: New Status in “activity-log-manager” package in Ubuntu: Fix Released Status in “activity-log-manager” source package in Precise: Fix Released Bug description: The recent UIFE/FFE to add the landscape client installer (bug 961606) now causes the control-center layout to overflow and look ugly. I propose that we move the Privacy settings from the System to the Personal category. There is still an open slot there, and it makes more sense there anyway IMHO. To manage notifications about this bug go to: https://bugs.launchpad.net/activity-log-manager/+bug/973130/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 460: We can't auto-discard events from disabled data sources based on bus address, cause there can be ...
revno: 460
committer: Michal Hruby michal@gmail.com
branch nick: zeitgeist
timestamp: Wed 2012-04-04 19:25:15 +0200
message:
We can't auto-discard events from disabled data sources based on bus address,
cause there can be multiple sources registered for the same address - fixes an
issue with datahub
modified:
extensions/ds-registry.vala
--
lp:zeitgeist
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala 2012-03-26 18:12:03 +
+++ extensions/ds-registry.vala 2012-04-04 17:25:15 +
@@ -166,8 +166,10 @@
class DataSourceRegistry: Extension, RemoteRegistry
{
+private const string MULTIPLE_MARKER = multiple;
private HashTablestring, DataSource sources;
-private HashTablestring, GenericArrayBusName running;
+private HashTablestring, GenericArrayBusName running_ds;
+private HashTablestring, string bus_name_2_ds;
private uint registration_id;
private bool dirty;
@@ -180,7 +182,8 @@
construct
{
-running = new HashTablestring, GenericArrayBusName?(
+bus_name_2_ds = new HashTablestring, string (str_hash, str_equal);
+running_ds = new HashTablestring, GenericArrayBusName?(
str_hash, str_equal);
Variant? registry = retrieve_config (registry,
@@ -272,15 +275,26 @@
}
-var sender_array = running.lookup (unique_id);
+var sender_array = running_ds.lookup (unique_id);
if (sender_array == null)
{
-running.insert (unique_id, new GenericArrayBusName?());
-running.lookup (unique_id).add (sender);
-}
-else if (is_sender_known (sender, sender_array))
-{
-running.lookup (unique_id).add (sender);
+sender_array = new GenericArrayBusName?();
+sender_array.add (sender);
+running_ds.insert (unique_id, sender_array);
+}
+else if (!is_sender_known (sender, sender_array))
+{
+sender_array.add (sender);
+}
+
+unowned string ds_id = bus_name_2_ds.lookup (sender);
+if (ds_id == null)
+{
+bus_name_2_ds.insert (sender, unique_id);
+}
+else if (ds_id != unique_id ds_id != MULTIPLE_MARKER)
+{
+bus_name_2_ds.insert (sender, MULTIPLE_MARKER);
}
unowned DataSource? ds = sources.lookup (unique_id);
@@ -350,17 +364,21 @@
public override void pre_insert_events (GenericArrayEvent? events,
BusName? sender)
{
-foreach (string unique_id in running.get_keys())
+foreach (unowned string unique_id in running_ds.get_keys())
{
-GenericArrayBusName? bus_names = running.lookup (unique_id);
+GenericArrayBusName? bus_names = running_ds.lookup (unique_id);
if (is_sender_known (sender, bus_names))
{
var data_source = sources.lookup (unique_id);
-data_source.timestamp = Timestamp.now ();
+data_source.timestamp = Timestamp.now ();
dirty = true;
-if (!data_source.enabled)
+// if one sender registers multiple unique data sources,
+// we have to rely that it's the correct thing, otherwise
+// we can just ignore the events
+unowned string ds_id = bus_name_2_ds.lookup (sender);
+if (!data_source.enabled ds_id != MULTIPLE_MARKER)
{
for (int i = 0; i events.length; i++)
events[i] = null;
@@ -386,7 +404,7 @@
var disconnected_ds = new GenericArrayDataSource ();
{
var iter = HashTableIterstring, GenericArrayBusName? (
-running);
+running_ds);
unowned string uid;
unowned GenericArrayBusName name_arr;
while (iter.next (out uid, out name_arr))
@@ -414,11 +432,11 @@
ds.timestamp = Timestamp.now ();
dirty = true;
-if (running.lookup (uid).length == 0)
+if (running_ds.lookup (uid).length == 0)
{
debug (No remaining client running: %s [%s],
ds.name, uid);
-running.remove (uid);
+
[Zeitgeist] [Build #3383722] amd64 build of activity-log-manager 0.9.4-0ubuntu1 in ubuntu oneiric RELEASE (zeitgeist PPA)
* Source Package: activity-log-manager * Version: 0.9.4-0ubuntu1 * Architecture: amd64 * Archive: zeitgeist PPA * Component: main * State: Failed to build * Duration: 7 minutes * Build Log: https://launchpad.net/~zeitgeist/+archive/ppa/+build/3383722/+files/buildlog_ubuntu-oneiric-amd64.activity-log-manager_0.9.4-0ubuntu1_FAILEDTOBUILD.txt.gz * Builder: https://launchpad.net/builders/pluot * Source: not available If you want further information about this situation, feel free to contact a member of the Launchpad Buildd Administrators team. -- amd64 build of activity-log-manager 0.9.4-0ubuntu1 in ubuntu oneiric RELEASE https://launchpad.net/~zeitgeist/+archive/ppa/+build/3383722 ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Build #3383790] amd64 build of activity-log-manager 0.9.4-0ubuntu2 in ubuntu oneiric RELEASE (zeitgeist PPA)
* Source Package: activity-log-manager * Version: 0.9.4-0ubuntu2 * Architecture: amd64 * Archive: zeitgeist PPA * Component: main * State: Failed to build * Duration: 16 minutes * Build Log: https://launchpad.net/~zeitgeist/+archive/ppa/+build/3383790/+files/buildlog_ubuntu-oneiric-amd64.activity-log-manager_0.9.4-0ubuntu2_FAILEDTOBUILD.txt.gz * Builder: https://launchpad.net/builders/nobelium * Source: not available If you want further information about this situation, feel free to contact a member of the Launchpad Buildd Administrators team. -- amd64 build of activity-log-manager 0.9.4-0ubuntu2 in ubuntu oneiric RELEASE https://launchpad.net/~zeitgeist/+archive/ppa/+build/3383790 ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Build #3383791] i386 build of activity-log-manager 0.9.4-0ubuntu2 in ubuntu oneiric RELEASE (zeitgeist PPA)
* Source Package: activity-log-manager * Version: 0.9.4-0ubuntu2 * Architecture: i386 * Archive: zeitgeist PPA * Component: main * State: Failed to build * Duration: 5 minutes * Build Log: https://launchpad.net/~zeitgeist/+archive/ppa/+build/3383791/+files/buildlog_ubuntu-oneiric-i386.activity-log-manager_0.9.4-0ubuntu2_FAILEDTOBUILD.txt.gz * Builder: https://launchpad.net/builders/platinum * Source: not available If you want further information about this situation, feel free to contact a member of the Launchpad Buildd Administrators team. -- i386 build of activity-log-manager 0.9.4-0ubuntu2 in ubuntu oneiric RELEASE https://launchpad.net/~zeitgeist/+archive/ppa/+build/3383791 ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
