Re: [zeta-dev] PHPUnit's usage

2010-11-29 Thread Jerome Renard
Hi Bertrand,

On Mon, Nov 29, 2010 at 9:29 PM, Bertrand Dunogier  wrote:
> On 27 November 2010 11:58, Jerome Renard  wrote:
>
>> Hi Sebastian,
>>
>> On Sat, Nov 27, 2010 at 10:57 AM, Sebastian Bergmann
>>  wrote:
>> > Am 27.11.2010 10:51, schrieb Jerome Renard:
>> >> for those of you who are forced (like me) to use PHPUnit 3.4.* and can
>> >> not (or do not want to) upgrade,
>> >> you can run the following command to restore the PHPUnit 3.4.*
>> >> compatible version of UnitTest/
>> >
>> >  Why are you forced to use PHPUnit 3.4?
>>
>> Because I work on something else that seems to be incompatible with the
>> latest
>> PHPUnit stable version. And since I can not commit fixes I am stuck
>> with PHPUnit 3.4
>> Hopefully that will be fixed in a couple of weeks :)
>>
> If the something in question is eZ Publish, remember you can still fork the
> project, commit a fix, and make a pull request ;-)
>

The something in question is not eZ Publish ;)

-- 
Jérôme Renard
http://39web.fr | http://jrenard.info | http://twitter.com/jeromerenard


Re: [zeta-dev] PHPUnit's usage

2010-11-29 Thread Bertrand Dunogier
On 27 November 2010 11:58, Jerome Renard  wrote:

> Hi Sebastian,
>
> On Sat, Nov 27, 2010 at 10:57 AM, Sebastian Bergmann
>  wrote:
> > Am 27.11.2010 10:51, schrieb Jerome Renard:
> >> for those of you who are forced (like me) to use PHPUnit 3.4.* and can
> >> not (or do not want to) upgrade,
> >> you can run the following command to restore the PHPUnit 3.4.*
> >> compatible version of UnitTest/
> >
> >  Why are you forced to use PHPUnit 3.4?
>
> Because I work on something else that seems to be incompatible with the
> latest
> PHPUnit stable version. And since I can not commit fixes I am stuck
> with PHPUnit 3.4
> Hopefully that will be fixed in a couple of weeks :)
>
If the something in question is eZ Publish, remember you can still fork the
project, commit a fix, and make a pull request ;-)

-- 
Bertrand


Re: [zeta-dev] PHPUnit's usage

2010-11-27 Thread Jerome Renard
Hi Sebastian,

On Sat, Nov 27, 2010 at 10:57 AM, Sebastian Bergmann
 wrote:
> Am 27.11.2010 10:51, schrieb Jerome Renard:
>> for those of you who are forced (like me) to use PHPUnit 3.4.* and can
>> not (or do not want to) upgrade,
>> you can run the following command to restore the PHPUnit 3.4.*
>> compatible version of UnitTest/
>
>  Why are you forced to use PHPUnit 3.4?

Because I work on something else that seems to be incompatible with the latest
PHPUnit stable version. And since I can not commit fixes I am stuck
with PHPUnit 3.4
Hopefully that will be fixed in a couple of weeks :)

-- 
Jérôme Renard
http://39web.fr | http://jrenard.info | http://twitter.com/jeromerenard


Re: [zeta-dev] PHPUnit's usage

2010-11-27 Thread Sebastian Bergmann
Am 27.11.2010 10:51, schrieb Jerome Renard:
> for those of you who are forced (like me) to use PHPUnit 3.4.* and can
> not (or do not want to) upgrade,
> you can run the following command to restore the PHPUnit 3.4.*
> compatible version of UnitTest/

 Why are you forced to use PHPUnit 3.4?

-- 
Sebastian BergmannCo-Founder and Principal Consultant
http://sebastian-bergmann.de/   http://thePHP.cc/



signature.asc
Description: OpenPGP digital signature


Re: [zeta-dev] PHPUnit's usage

2010-11-27 Thread Jerome Renard
Hi all,

for those of you who are forced (like me) to use PHPUnit 3.4.* and can
not (or do not want to) upgrade,
you can run the following command to restore the PHPUnit 3.4.*
compatible version of UnitTest/

svn up -r987381 ./UnitTest

Ref : 
https://fisheye6.atlassian.com/changelog/zetacomponents/trunk/UnitTest?cs=987381

'Hope that helps :)

-- 
Jérôme Renard
http://39web.fr | http://jrenard.info | http://twitter.com/jeromerenard


Re: [zeta-dev] PHPUnit's usage

2010-08-20 Thread Patrick ALLAERT
2010/8/20 Sebastian Bergmann :
> Am 19.08.2010 21:25, schrieb apa...@derickrethans.nl:
>> Yes, definitely. I've mentioned it to Sebastian before many times as
>> well in th epast...
>
>  This would be a non-issue if the Zeta Components would use PHPUnit
>  properly.

Do you mean that if the Zeta Components would use PHPUnit properly, we
could be able to stick to PHPUnit 3.4?
Now that it relies on 3.5+, is the usage suddenly correct?
I don't understand the link between the fact (or not) of an improper
usage of PHPUnit and depending on a non stable version.

My only concern here is that I constantly have to switch PHPUnit's
version when I want to run the test suite of the ZC or from the
product built upon them.
Upgrading the product to be compatible to a non stable version of
PHPUnit is a no-go.

Am I correct saying there is 2 issues then:
1° Relying on a non stable version of PHPUnit.
2° Improper usage of PHPUnit

Regards,
Patrick


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread Jerome Renard
Hi Sebastian,

On Fri, Aug 20, 2010 at 8:11 AM, Sebastian Bergmann
 wrote:
> Am 20.08.2010 08:01, schrieb Jerome Renard:
>> Is that possible ?
>
>  That functionality is built into PHPUnit already:
>
>   * If phpunit.xml exists, it will be used.
>   * If phpunit.xml does not exist but phpunit.xml.dist exists, the
>     latter will be used
>
>  phpunit.xml.dist is under version control while phpunit.xml is not (and
>  ignored from version control as well).

Ha cool, then it seems we could get all what we need with this system and
we could get rid of the UnitTest component. Am I correct ?

-- 
Jérôme Renard
http://39web.fr | http://jrenard.info


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread Sebastian Bergmann
Am 20.08.2010 08:01, schrieb Jerome Renard:
> Is that possible ?

 That functionality is built into PHPUnit already:

   * If phpunit.xml exists, it will be used.
   * If phpunit.xml does not exist but phpunit.xml.dist exists, the
 latter will be used

 phpunit.xml.dist is under version control while phpunit.xml is not (and
 ignored from version control as well).

-- 
Sebastian BergmannCo-Founder and Principal Consultant
http://sebastian-bergmann.de/   http://thePHP.cc/



signature.asc
Description: OpenPGP digital signature


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread Jerome Renard
On Fri, Aug 20, 2010 at 7:54 AM, Sebastian Bergmann
 wrote:
> Am 20.08.2010 07:49, schrieb Tobias Schlitt:
>> Is there a chance we can replace the current UnitTest stuff with a
>> proper usage?
>
>  There is nothing in the UnitTest test runner that we need. The only
>  reason we still have it is because Derick (and maybe others) prefer
>  commandline switches over PHPUnit's XML configuration file to configure
>  the test suite (the database connection, for instance).

There are two problematics here :
1. being PHPUnit compliant
2. providing control to each user

I propose the following :
1. provide a default XML file with everything preconfigured along with
a README file explaining requirements for the database for instance
2. provide a system that loads custom phpunit XML file where everyone
can define whatever he wants.

Basically that would work that way :

if custom phpunit.xml fil existst then
load and use it
else
load and use the default one
fi

Is that possible ?

Cheers,

-- 
Jérôme Renard
http://39web.fr | http://jrenard.info


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread Sebastian Bergmann
Am 20.08.2010 07:49, schrieb Tobias Schlitt:
> Is there a chance we can replace the current UnitTest stuff with a
> proper usage?

 There is nothing in the UnitTest test runner that we need. The only
 reason we still have it is because Derick (and maybe others) prefer
 commandline switches over PHPUnit's XML configuration file to configure
 the test suite (the database connection, for instance).

-- 
Sebastian BergmannCo-Founder and Principal Consultant
http://sebastian-bergmann.de/   http://thePHP.cc/



signature.asc
Description: OpenPGP digital signature


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread Tobias Schlitt
On 08/20/2010 07:42 AM, Sebastian Bergmann wrote:
> Am 19.08.2010 21:25, schrieb apa...@derickrethans.nl:
>> Yes, definitely. I've mentioned it to Sebastian before many times as 
>> well in th epast...

>  This would be a non-issue if the Zeta Components would use PHPUnit
>  properly.

Is there a chance we can replace the current UnitTest stuff with a
proper usage?

Regards,
Toby
-- 
Tobias Schlitthttp://schlitt.infoGPG Key: 0xC462BC14
Want to hire me? Need quality assurance?http://qafoo.com
eZ Components are Zeta Components now!  http://bit.ly/9S7zbn


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread Sebastian Bergmann
Am 19.08.2010 21:25, schrieb apa...@derickrethans.nl:
> Yes, definitely. I've mentioned it to Sebastian before many times as 
> well in th epast...

 This would be a non-issue if the Zeta Components would use PHPUnit
 properly.

-- 
Sebastian BergmannCo-Founder and Principal Consultant
http://sebastian-bergmann.de/   http://thePHP.cc/



signature.asc
Description: OpenPGP digital signature


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread apache
On Thu, 19 Aug 2010, Patrick ALLAERT wrote:

> Hi zeta devs,
> 
> Would it be possible to consider using a stable version of PHPUnit in trunk?

Yes, definitely. I've mentioned it to Sebastian before many times as 
well in th epast...

Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread Jerome Renard
Hello,

On Thu, Aug 19, 2010 at 1:29 PM, Tobias Schlitt  wrote:
> Hi Patrick,
>
> On 08/19/2010 01:10 PM, Patrick ALLAERT wrote:
>
>> Would it be possible to consider using a stable version of PHPUnit in trunk?
>> Trying to run both the testsuite of the Zeta Components as well as the
>> one of the solution I am building upon the ZC is quite annoying.
>> ZC currently uses PHPUnit 3.5+ while (I guess) most of the products
>> running on it uses a stable version of PHPUnit.
>> This is making hard testing/contributing to the ZC.
>
> I agree with you here. I consider it quite important that our users and
> especially potential contributors can run our test suite easily.#
>

+1

-- 
Jérôme Renard
http://39web.fr | http://jrenard.info


Re: [zeta-dev] PHPUnit's usage

2010-08-19 Thread Tobias Schlitt
Hi Patrick,

On 08/19/2010 01:10 PM, Patrick ALLAERT wrote:

> Would it be possible to consider using a stable version of PHPUnit in trunk?
> Trying to run both the testsuite of the Zeta Components as well as the
> one of the solution I am building upon the ZC is quite annoying.
> ZC currently uses PHPUnit 3.5+ while (I guess) most of the products
> running on it uses a stable version of PHPUnit.
> This is making hard testing/contributing to the ZC.

I agree with you here. I consider it quite important that our users and
especially potential contributors can run our test suite easily.#

Regards,
Toby
-- 
Tobias Schlitthttp://schlitt.infoGPG Key: 0xC462BC14
Want to hire me? Need quality assurance?http://qafoo.com
eZ Components are Zeta Components now!  http://bit.ly/9S7zbn


[zeta-dev] PHPUnit's usage

2010-08-19 Thread Patrick ALLAERT
Hi zeta devs,

Would it be possible to consider using a stable version of PHPUnit in trunk?
Trying to run both the testsuite of the Zeta Components as well as the
one of the solution I am building upon the ZC is quite annoying.
ZC currently uses PHPUnit 3.5+ while (I guess) most of the products
running on it uses a stable version of PHPUnit.
This is making hard testing/contributing to the ZC.

Regards,
Patrick