Re: [zeta-dev] Re: [zeta-commits] svn commit: r1145100 - in /incubator/zetacomponents/trunk/Authentication: src/options/session_options.php src/session/authentication_session.php tests/session/session

2011-07-11 Thread Derick Rethans
On Mon, 11 Jul 2011, Jerome Renard wrote:

 On Mon, Jul 11, 2011 at 12:11 PM, Derick Rethans der...@apache.org wrote:
  On Mon, 11 Jul 2011, jero...@apache.org wrote:
 
  @@ -45,12 +47,16 @@
    * /code
    *
    * @property int $validity
  + *           The maximal amount of seconds the session is valid.
  + * @property int $idleTimeout
    *           The amount of seconds the session can be idle.
    * @property string $idKey
    *           The key to use in $_SESSION to hold the user ID of the user 
  who is
    *           logged in.
 
  I thought I had commented on this before, but doesn't this change the
  already existing behaviour?
 
 If you commented on this before I did not receive anything (which is weird)
 
 Normally this does not change the already existing behaviour.

And in which abnormally cases does it? (I just want to make this clear!) 
:-)
It's probably also good to add this to the tutorial!

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug

Re: [zeta-dev] Re: [zeta-commits] svn commit: r1145100 - in /incubator/zetacomponents/trunk/Authentication: src/options/session_options.php src/session/authentication_session.php tests/session/session

2011-07-11 Thread Jerome Renard
Hi Derick,

On Mon, Jul 11, 2011 at 2:28 PM, Derick Rethans der...@apache.org wrote:
 On Mon, 11 Jul 2011, Jerome Renard wrote:

 On Mon, Jul 11, 2011 at 12:11 PM, Derick Rethans der...@apache.org wrote:
  On Mon, 11 Jul 2011, jero...@apache.org wrote:
 
  @@ -45,12 +47,16 @@
    * /code
    *
    * @property int $validity
  + *           The maximal amount of seconds the session is valid.
  + * @property int $idleTimeout
    *           The amount of seconds the session can be idle.
    * @property string $idKey
    *           The key to use in $_SESSION to hold the user ID of the user 
  who is
    *           logged in.
 
  I thought I had commented on this before, but doesn't this change the
  already existing behaviour?

 If you commented on this before I did not receive anything (which is weird)

 Normally this does not change the already existing behaviour.

 And in which abnormally cases does it? (I just want to make this clear!)
 :-)

None ;), using normally is a frenchism. Furthermore the entire test
suite passes
which means nothing has been broken and the initial behaviour has been
left unchanged.

 It's probably also good to add this to the tutorial!


Ho, good idea, I'll try to do that when I have spare time.

-- 
Jérôme Renard
http://39web.fr | http://jrenard.info | http://twitter.com/jeromerenard