[ZODB-Dev] Repozo tests -- not
On Fri, Nov 20, 2009 at 1:52 PM, Jim Fulton j...@zope.com wrote:
On Fri, Nov 20, 2009 at 1:36 PM, Tres Seaver tsea...@palladion.com wrote:
...
I just checked in a stupid test to ensure that repozo can be imported.
- --- src/ZODB/scripts/tests.py (revision 105913)
+++ src/ZODB/scripts/tests.py (working copy)
@@ -26,6 +26,11 @@
(re.compile('hash=[0-9a-f]{40}'),
'hash=b16422d09fabdb45d4e4325e4b42d7d6f021d3c3')])
+class RepozoTests(unittest.TestCase):
+
+ def test_importability(self):
+ from ZODB.scripts import repozo
+
...
That test passes under ZODB 3.9.3 with Python 2.6.
It emits the same DeprecationWarning (the bug Withers fixed). I did
have to munge the 'test_suite' dinosaur as well.
Fair enough. Given that this provokes the symptom that was fixed.
I can live with this.
Well, not really fair enough. I just looked at the change that Chris
made. It has a bug
that would be caught by your test if anyone tried to port repozo to
Python 3. More
importantly, Chris' change touches non-trivial code that isn't
exercised by your test.
It *looks* OK (aside from the minor bug). We are doing users a
serious disservice
giving them such an important tool with minimal tests and no automated tests.
I'm going to back out these changes. If someone really cares about
repozo in the
slightest, they'll at least convert the existing manual test into an
automated test.
I'm pretty sure that this is a straightforward project. With an
automated version of the
manual test, I'd be comfortable reapplying Chris' change.
Is anyone willing to convert the manual test to an automated one?
Jim
--
Jim Fulton
___
For more information about ZODB, see the ZODB Wiki:
http://www.zope.org/Wikis/ZODB/
ZODB-Dev mailing list - ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] errors logged at info in ZEO's connection
Merged. Jim On Fri, Nov 20, 2009 at 5:45 PM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: It seems a bit bizarre that exceptions are logged at INFO rather than ERROR... Agreed. A simple fix and test on a branch would be appreciated. Done: http://svn.zope.org/ZODB/branches/chrisw-error_logging/ It would be great if this, too, could make it in a 3.9.4 release... Chris -- Simplistix - Content Management, Batch Processing Python Consulting - http://www.simplistix.co.uk -- Jim Fulton ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] Repozo tests -- not
Jim Fulton wrote:
On Fri, Nov 20, 2009 at 1:52 PM, Jim Fulton j...@zope.com wrote:
On Fri, Nov 20, 2009 at 1:36 PM, Tres Seaver tsea...@palladion.com wrote:
...
I just checked in a stupid test to ensure that repozo can be imported.
- --- src/ZODB/scripts/tests.py (revision 105913)
+++ src/ZODB/scripts/tests.py (working copy)
@@ -26,6 +26,11 @@
(re.compile('hash=[0-9a-f]{40}'),
'hash=b16422d09fabdb45d4e4325e4b42d7d6f021d3c3')])
+class RepozoTests(unittest.TestCase):
+
+def test_importability(self):
+from ZODB.scripts import repozo
+
...
That test passes under ZODB 3.9.3 with Python 2.6.
It emits the same DeprecationWarning (the bug Withers fixed). I did
have to munge the 'test_suite' dinosaur as well.
Fair enough. Given that this provokes the symptom that was fixed.
I can live with this.
Well, not really fair enough. I just looked at the change that Chris
made. It has a bug
that would be caught by your test if anyone tried to port repozo to
Python 3. More
importantly, Chris' change touches non-trivial code that isn't
exercised by your test.
It *looks* OK (aside from the minor bug). We are doing users a
serious disservice
giving them such an important tool with minimal tests and no automated tests.
I'm going to back out these changes. If someone really cares about
repozo in the
slightest, they'll at least convert the existing manual test into an
automated test.
I'm pretty sure that this is a straightforward project. With an
automated version of the
manual test, I'd be comfortable reapplying Chris' change.
Is anyone willing to convert the manual test to an automated one?
Can you clarify this? To me, it looks like:
- there was a small/trivial bug
- there were no tests for the existing code
- Chris fixed it, and didn't add any tests
- Noise ensued
- Tres wrote a trivial test for the trivial fix
- You now found some different problem in the same code, and want to
back out Chris' change because he didn't go and add a bunch of tests for
the rest of the code, which he didn't change.
If I have this right, I am astonished. I'm going to give you a chance to
tell me I have it all wrong before I pass judgement, though.
Martin
--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book
___
For more information about ZODB, see the ZODB Wiki:
http://www.zope.org/Wikis/ZODB/
ZODB-Dev mailing list - ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] Repozo tests -- not
Martin Aspeli wrote: - there were no tests for the existing code There are tests, they're just manual and spew a lot of output even when passing, but they do (as best I could tell) exercise the backup and restore cycle quite heavily. I ran these before and after to verify they didn't fail but did exhibit the behaviour I was trying to fix before I started and didn't fail *and* didn't exhibit the behaviour I was trying to fix after. - Tres wrote a trivial test for the trivial fix Indeed. His test exhibited the problem prior to the fix and showed it to be fixed after. (since the problem was a warning generated on import) - You now found some different problem in the same code, ...but didn't say what it is. Jim seemed to hint it was a Python 3 problem. I'd warrant there are much more serious problems to be worrying about for Python 3 first. If Python 3 compatibility is now a requirement for any patches submitted, then we're well and truly fucked. cheers, Chris -- Simplistix - Content Management, Batch Processing Python Consulting - http://www.simplistix.co.uk ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
