Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.

2012-08-26 Thread Hanno Schlichting
On Sat, Aug 25, 2012 at 4:11 PM, Tres Seaver tsea...@palladion.com wrote:
 This failure, and the others like it, indicate that the buildout has
 failed to install persistent correctly (there is nothing Windows-specific
 about the failure)::

I actually got the same error locally.

The trouble is the timestamp.py module and the TimeStamp.c extension.
During installation setuptools creates a wrapper for the extension
file. So you end up with TimeStamp.so but also a timestamp.py wrapper.
This wrapper overwrites the original timestamp.py module.

You likely have a case-sensitive file system and therefor didn't get
this problem.

I think TimeStamp.c has been there before and is imported in other
modules as from persistent.TimeStamp import TimeStamp. So we should
keep that API and use a different name for the new timestamp.py
module.

Hanno
___
For more information about ZODB, see http://zodb.org/

ZODB-Dev mailing list  -  ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev


Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.

2012-08-26 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 08/26/2012 07:05 AM, Hanno Schlichting wrote:
 On Sat, Aug 25, 2012 at 4:11 PM, Tres Seaver tsea...@palladion.com
 wrote:
 This failure, and the others like it, indicate that the buildout
 has failed to install persistent correctly (there is nothing
 Windows-specific about the failure)::
 
 I actually got the same error locally.
 
 The trouble is the timestamp.py module and the TimeStamp.c extension. 
 During installation setuptools creates a wrapper for the extension 
 file. So you end up with TimeStamp.so but also a timestamp.py
 wrapper. This wrapper overwrites the original timestamp.py module.
 
 You likely have a case-sensitive file system and therefor didn't get 
 this problem.

Whoever came up with the idea of a case-insensitive filesystem should be
shot (or at least, whoever decided to keep doing that after moving off of
DOS).

I have worked around this problem (I think) by renaming the extension
module to '_timestamp.so'.  I released a 4.0.1 to PyPI with this fix,
along with a fix for the int - long overflow on 32-bit systems.

 I think TimeStamp.c has been there before and is imported in other 
 modules as from persistent.TimeStamp import TimeStamp. So we should 
 keep that API and use a different name for the new timestamp.py 
 module.

I don't see the need for the BBB-preservation here:  I documented the
backward-incompatibility in CHANGES.txt instead.


Tres.
- -- 
===
Tres Seaver  +1 540-429-0999  tsea...@palladion.com
Palladion Software   Excellence by Designhttp://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlA6c9IACgkQ+gerLs4ltQ6ocACeIqlGWazwos+yWGaMvgMCOkQD
ZQoAn3oR2rY70a1oT6aTjLpofIVtVBNd
=GzPs
-END PGP SIGNATURE-

___
For more information about ZODB, see http://zodb.org/

ZODB-Dev mailing list  -  ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev