[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-38: --- Attachment: ZOOKEEPER-38_1.patch here's a first look at the patch. I am still in process of cleaning it up and adding javadocs. Please review and comment. Ben wil be making changes to the tests. > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, > ZOOKEEPER-38.patch, ZOOKEEPER-38_1.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-110: Attachment: ZOOKEEPER-110.patch It turns out that the original patch used the task attribute "osfamily" that is only available since ant 1.7. This patch ensures that build.xml is compatible with pre-1.7 versions. The apache license headers are also included. Please review. Thanks! > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, > ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-2) Synchronization issues in QuorumPeer and FastLeader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622723#action_12622723 ] Patrick Hunt commented on ZOOKEEPER-2: -- +1 on Mahadev's doc request. > Synchronization issues in QuorumPeer and FastLeader election > > > Key: ZOOKEEPER-2 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2 > Project: Zookeeper > Issue Type: Bug > Components: leaderElection >Reporter: Benjamin Reed >Assignee: Flavio Paiva Junqueira > Attachments: patch-le-polish, patch-le-polish, ZOOKEEPER-2.patch > > > There are a couple of cases of member variables that need to be marked > volatile or surrounded in a synchronization block. A couple of examples are: > * QuorumPeer state should be synchronous > * currentVote in QuorumPeer is marked volatile, but when it's members are > often accessed individually as if they were in an atomic unit. Such code > should be changed to get a reference to the currentVote and they access > members through that reference. > * It looks like logicalClock in FastLeaderElection should be volatile. It > should either be fixed or commented to explain why it doesn't need to be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-111) significant cleanup of existing tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622722#action_12622722 ] Patrick Hunt commented on ZOOKEEPER-111: Flavio, at least one of the tests that's failing (testHammer) seems related to a quorum problem, can you take a look? 2008-08-14 11:28:40,695 - ERROR [FollowerHandler-/127.0.0.1:2599:[EMAIL PROTECTED] - FIXMSG java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:129) at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) at java.io.BufferedInputStream.read(BufferedInputStream.java:237) at java.io.DataInputStream.readInt(DataInputStream.java:370) at org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:64) at org.apache.zookeeper.server.quorum.QuorumPacket.deserialize(QuorumPacket.java:65) at org.apache.jute.BinaryInputArchive.readRecord(BinaryInputArchive.java:109) at org.apache.zookeeper.server.quorum.FollowerHandler.run(FollowerHandler.java:279) After which the followers all seem to shutdown. The test is failing because the clients are not complete (10 clients creating 1000 nodes) even after 5 minutes. What type of hardware is this? > significant cleanup of existing tests > - > > Key: ZOOKEEPER-111 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-111 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: TEST-org.apache.zookeeper.test.AsyncTest.txt, > TEST-org.apache.zookeeper.test.QuorumTest.txt, ZOOKEEPER-111.patch, > ZOOKEEPER-111.patch, ZOOKEEPER-111.patch, ZOOKEEPER-111.patch, > ZOOKEEPER-111.patch > > > About to submit a patch that significantly cleans up existing tests. > 1) removed the need for "sleep" calls in the tests, instead I monitor the > status of the server (using the client socket "stat" command) which provides > a barrier to the client test operations. I use this barrier both when > starting and ending the test. > 2) also fixed a number of problems in the tests where the test itself was > broken. > 3) general cleanup and some refactoring to make it easier to write new tests, > maintain old, and track down issues if the test does find a problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-111) significant cleanup of existing tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622720#action_12622720 ] Patrick Hunt commented on ZOOKEEPER-111: Flavio: each zk server pre-allocates a 64m log file by default when started, the latest patch sets the pre-allocate size to 100K instead. This greatly reduces the amount of space needed to run the tests (in general each server started during the unit tests created a 64m log file) > significant cleanup of existing tests > - > > Key: ZOOKEEPER-111 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-111 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: TEST-org.apache.zookeeper.test.AsyncTest.txt, > TEST-org.apache.zookeeper.test.QuorumTest.txt, ZOOKEEPER-111.patch, > ZOOKEEPER-111.patch, ZOOKEEPER-111.patch, ZOOKEEPER-111.patch, > ZOOKEEPER-111.patch > > > About to submit a patch that significantly cleans up existing tests. > 1) removed the need for "sleep" calls in the tests, instead I monitor the > status of the server (using the client socket "stat" command) which provides > a barrier to the client test operations. I use this barrier both when > starting and ending the test. > 2) also fixed a number of problems in the tests where the test itself was > broken. > 3) general cleanup and some refactoring to make it easier to write new tests, > maintain old, and track down issues if the test does find a problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: ZOOKEEPER-110.patch Added Apache liecense header to both new files. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, > ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622670#action_12622670 ] Mahadev konar commented on ZOOKEEPER-110: - can we add apache headers to .sh files? all new files need apache headers > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622666#action_12622666 ] Andrew Kornev commented on ZOOKEEPER-110: - +1 I'll commit the patch and delete the svnant directory and its contents. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-2) Synchronization issues in QuorumPeer and FastLeader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622631#action_12622631 ] Mahadev konar commented on ZOOKEEPER-2: --- flavio - while we are at it ... can we improve the documentation with javadocs in FastLeaderElection? I am happy to open another jira for it but seems a little redundant... In particular Messenger class lacks javadocs, class workersender lacks javadocs, some of the methods in FastLeaderElection class lack javadoc as well. It will help us lesser mortals to understand leader election better with some javadocs :). > Synchronization issues in QuorumPeer and FastLeader election > > > Key: ZOOKEEPER-2 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2 > Project: Zookeeper > Issue Type: Bug > Components: leaderElection >Reporter: Benjamin Reed >Assignee: Flavio Paiva Junqueira > Attachments: patch-le-polish, patch-le-polish, ZOOKEEPER-2.patch > > > There are a couple of cases of member variables that need to be marked > volatile or surrounded in a synchronization block. A couple of examples are: > * QuorumPeer state should be synchronous > * currentVote in QuorumPeer is marked volatile, but when it's members are > often accessed individually as if they were in an atomic unit. Such code > should be changed to get a reference to the currentVote and they access > members through that reference. > * It looks like logicalClock in FastLeaderElection should be volatile. It > should either be fixed or commented to explain why it doesn't need to be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-56) Add clover support to build.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622510#action_12622510 ] Hudson commented on ZOOKEEPER-56: - Integrated in ZooKeeper-trunk #53 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/]) > Add clover support to build.xml > --- > > Key: ZOOKEEPER-56 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-56 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-56.patch, ZOOKEEPER-56.patch > > > Clover is what ASF uses for code coverage. We currently have cobertura, but > need to add support for clover (keep the existing cobertura support for > individual developers to use). Clover is run automatically by ASF Hudson. > Hadoop has support for clover in their build.xml, port their clover related > targets into zookeeper build.xml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-25) FUSE for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622509#action_12622509 ] Hudson commented on ZOOKEEPER-25: - Integrated in ZooKeeper-trunk #53 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/]) > FUSE for ZooKeeper > -- > > Key: ZOOKEEPER-25 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-25 > Project: Zookeeper > Issue Type: New Feature >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: configure.ac.patch, ZOOKEEPER-25.patch.gz, > ZOOKEEPER-25_2.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1873981&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Hudson build is back to normal: ZooKeeper-trunk #53
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/changes
[jira] Updated: (ZOOKEEPER-111) significant cleanup of existing tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-111: - Attachment: TEST-org.apache.zookeeper.test.QuorumTest.txt QuorumTest still fails in my Windows XP machine. It did run fine on a Ubuntu box. Now, something interesting that I just observed with this new patch is that the previous one was using gigabytes of data of my disk. I noticed because after I ran "ant test" with the previous patch, my OS started complaining about disk space. Once I deleted the eclipse project I regained several gigabytes of space, and after running "ant test" with this new patch, I noticed that the amount of disk space available had barely changed. I'm attaching the test logs for QuorumTest. > significant cleanup of existing tests > - > > Key: ZOOKEEPER-111 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-111 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: TEST-org.apache.zookeeper.test.AsyncTest.txt, > TEST-org.apache.zookeeper.test.QuorumTest.txt, ZOOKEEPER-111.patch, > ZOOKEEPER-111.patch, ZOOKEEPER-111.patch, ZOOKEEPER-111.patch, > ZOOKEEPER-111.patch > > > About to submit a patch that significantly cleans up existing tests. > 1) removed the need for "sleep" calls in the tests, instead I monitor the > status of the server (using the client socket "stat" command) which provides > a barrier to the client test operations. I use this barrier both when > starting and ending the test. > 2) also fixed a number of problems in the tests where the test itself was > broken. > 3) general cleanup and some refactoring to make it easier to write new tests, > maintain old, and track down issues if the test does find a problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
