[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-38: --- Comment: was deleted > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, > ZOOKEEPER-38.patch, ZOOKEEPER-38_1.patch, ZOOKEEPER-38_2.patch, > ZOOKEEPER-38_3.patch, ZOOKEEPER-38_5.patch, ZOOKEEPER-38_6.patch, > ZOOKEEPER-38_7.patch, ZOOKEEPER-38_8.patch, ZOOKEEPER-38_9.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-147) This is version of the documents with most of the [tbd...] scrubbed out
[ https://issues.apache.org/jira/browse/ZOOKEEPER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Scott updated ZOOKEEPER-147: --- Attachment: ZOOKEEPER-147.patch Here's the diff of the places where I removed the [tbd...]'s > This is version of the documents with most of the [tbd...] scrubbed out > --- > > Key: ZOOKEEPER-147 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-147 > Project: Zookeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.0.0 >Reporter: Robbie Scott > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-147.patch > > Original Estimate: 96h > Remaining Estimate: 96h > > The docs had lots of comments to myself marked [tbd..]. I scrubbed these out. > I still have a list I will work from, but the [tbd]s are probably sensible to > anyone else. For a few cases where it's obvious what a tbd is asking, I left > in in, just in case someone else wants to take a crack at fixing them, knows > the answer, etc. > The estimate below refers to how many full days I think it would take to get > all the tbd's answered and put back into the document. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-147) This is version of the documents with most of the [tbd...] scrubbed out
[ https://issues.apache.org/jira/browse/ZOOKEEPER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Scott updated ZOOKEEPER-147: --- Component/s: documentation Fix Version/s: 3.0.0 Description: The docs had lots of comments to myself marked [tbd..]. I scrubbed these out. I still have a list I will work from, but the [tbd]s are probably sensible to anyone else. For a few cases where it's obvious what a tbd is asking, I left in in, just in case someone else wants to take a crack at fixing them, knows the answer, etc. The estimate below refers to how many full days I think it would take to get all the tbd's answered and put back into the document. Affects Version/s: 3.0.0 Remaining Estimate: 96h Original Estimate: 96h Summary: This is version of the documents with most of the [tbd...] scrubbed out (was: This is version of the documents with most of the [tbd) > This is version of the documents with most of the [tbd...] scrubbed out > --- > > Key: ZOOKEEPER-147 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-147 > Project: Zookeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.0.0 >Reporter: Robbie Scott > Fix For: 3.0.0 > > Original Estimate: 96h > Remaining Estimate: 96h > > The docs had lots of comments to myself marked [tbd..]. I scrubbed these out. > I still have a list I will work from, but the [tbd]s are probably sensible to > anyone else. For a few cases where it's obvious what a tbd is asking, I left > in in, just in case someone else wants to take a crack at fixing them, knows > the answer, etc. > The estimate below refers to how many full days I think it would take to get > all the tbd's answered and put back into the document. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-147) This is version of the documents with most of the [tbd
This is version of the documents with most of the [tbd -- Key: ZOOKEEPER-147 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-147 Project: Zookeeper Issue Type: Improvement Reporter: Robbie Scott -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-21) Improve zk ctor/watcher (state transition) docs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-21: -- Attachment: ZOOKEEPER-21.patch This patch updates the docs in both forrest and javadoc. Original issues are now addressed. > Improve zk ctor/watcher (state transition) docs > --- > > Key: ZOOKEEPER-21 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-21 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-21.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1985723&group_id=209147&atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-21) Improve zk ctor/watcher (state transition) docs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-21: -- Assignee: Patrick Hunt Status: Patch Available (was: Open) > Improve zk ctor/watcher (state transition) docs > --- > > Key: ZOOKEEPER-21 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-21 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-21.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1985723&group_id=209147&atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Reminder to contributors - update docs as well as code.
Just a small reminder to contributors - if you contribute code changes, esp. API changes, be sure to review the documentation in src/docs/src/documentation/content/xdocs. Update the documentation as appropriate to reflect your changes and commit as part of your patch. Regards, Patrick
[jira] Updated: (ZOOKEEPER-146) Allow clients to retrieve the list of hosts/servers from a URL
[ https://issues.apache.org/jira/browse/ZOOKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-146: -- Attachment: ZOOKEEPER-146.patch This patch: * Creates a new HostsProvider interface with one method (getHosts()) and two implementations of this method, StringHostsProvider and URLHostsProvider that return the list of hosts from either of those sources. The StringHostsProvider provides the same functionality that there currently is, and URL will go grab the string from http/file/etc. * Creates two new constructors for ZooKeeper to use URLs rather than strings. * Provides unit tests for the two new concrete classes. The patch doesn't change much of the inner workings of the ZooKeeper or ClientCnxn class, just grabs the string from the provider. It would be possible to improve disconnect behavior by checking to see if there are new hosts available before connecting. > Allow clients to retrieve the list of hosts/servers from a URL > -- > > Key: ZOOKEEPER-146 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-146 > Project: Zookeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.0.0 >Reporter: Jakob Homan >Assignee: Jakob Homan > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-146.patch > > > As I suggested in ZOOKEEPER-107, it would be nice to allow clients to specify > their hosts strings via a URL so that this can change dynamically. For > instance, obtain the current list of hosts from a webpage or a file on disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-146) Allow clients to retrieve the list of hosts/servers from a URL
[ https://issues.apache.org/jira/browse/ZOOKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-146: -- Status: Patch Available (was: Open) > Allow clients to retrieve the list of hosts/servers from a URL > -- > > Key: ZOOKEEPER-146 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-146 > Project: Zookeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.0.0 >Reporter: Jakob Homan >Assignee: Jakob Homan > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-146.patch > > > As I suggested in ZOOKEEPER-107, it would be nice to allow clients to specify > their hosts strings via a URL so that this can change dynamically. For > instance, obtain the current list of hosts from a webpage or a file on disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-146) Allow clients to retrieve the list of hosts/servers from a URL
Allow clients to retrieve the list of hosts/servers from a URL -- Key: ZOOKEEPER-146 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-146 Project: Zookeeper Issue Type: Improvement Components: java client Affects Versions: 3.0.0 Reporter: Jakob Homan Assignee: Jakob Homan Fix For: 3.0.0 As I suggested in ZOOKEEPER-107, it would be nice to allow clients to specify their hosts strings via a URL so that this can change dynamically. For instance, obtain the current list of hosts from a webpage or a file on disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-38: --- Attachment: ZOOKEEPER-38_9.patch the last patch went stale with commiting of ZOOKEEPER-139. > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, > ZOOKEEPER-38.patch, ZOOKEEPER-38_1.patch, ZOOKEEPER-38_2.patch, > ZOOKEEPER-38_3.patch, ZOOKEEPER-38_5.patch, ZOOKEEPER-38_6.patch, > ZOOKEEPER-38_7.patch, ZOOKEEPER-38_8.patch, ZOOKEEPER-38_9.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-145) write detailed release notes for users migrating from 2.x to 3.0
write detailed release notes for users migrating from 2.x to 3.0 Key: ZOOKEEPER-145 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-145 Project: Zookeeper Issue Type: Task Components: c client, documentation, java client Affects Versions: 3.0.0 Reporter: Patrick Hunt Priority: Critical Fix For: 3.0.0 We need to write detailed release notes that detail how c and java client API users as well as zk server administrators migrate from 2.x to 3.x zookeeper release. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-124) StatCallback is broken in trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-124: -- Assignee: (was: Patrick Hunt) > StatCallback is broken in trunk > --- > > Key: ZOOKEEPER-124 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-124 > Project: Zookeeper > Issue Type: Bug > Components: java client, server, tests > Environment: Linux corner-cube 2.6.24-19-generic #1 SMP Fri Jul 11 > 23:41:49 UTC 2008 i686 GNU/Linux > java version "1.6.0_06" > Java(TM) SE Runtime Environment (build 1.6.0_06-b02) > Java HotSpot(TM) Client VM (build 10.0-b22, mixed mode, sharing) >Reporter: Stu Hood > Fix For: 3.0.0 > > Attachments: stat-callback-fail-test.diff, stat-callback-test.diff > > > StatCallback appears to be broken in trunk. I'll attach a patch for AsyncTest > that triggers the behaviour. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-124) StatCallback is broken in trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634672#action_12634672 ] Patrick Hunt commented on ZOOKEEPER-124: Stu, can you tell me if this issue was addressed with the fix for ZOOKEEPER-137 ? > StatCallback is broken in trunk > --- > > Key: ZOOKEEPER-124 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-124 > Project: Zookeeper > Issue Type: Bug > Components: java client, server, tests > Environment: Linux corner-cube 2.6.24-19-generic #1 SMP Fri Jul 11 > 23:41:49 UTC 2008 i686 GNU/Linux > java version "1.6.0_06" > Java(TM) SE Runtime Environment (build 1.6.0_06-b02) > Java HotSpot(TM) Client VM (build 10.0-b22, mixed mode, sharing) >Reporter: Stu Hood >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: stat-callback-fail-test.diff, stat-callback-test.diff > > > StatCallback appears to be broken in trunk. I'll attach a patch for AsyncTest > that triggers the behaviour. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-144) add tostring support for watcher event, and enums for event type/state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan reassigned ZOOKEEPER-144: - Assignee: Jakob Homan > add tostring support for watcher event, and enums for event type/state > -- > > Key: ZOOKEEPER-144 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-144 > Project: Zookeeper > Issue Type: Improvement > Components: java client >Reporter: Patrick Hunt >Assignee: Jakob Homan >Priority: Minor > > it would be great if we had toString capability on watcher event, and enums > for type/state. the logs would certainly benefit (when fixing this try to > update any places where we are logging event information) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-18) keeper state inconsistency
[ https://issues.apache.org/jira/browse/ZOOKEEPER-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-18. --- Resolution: Fixed Hadoop Flags: [Incompatible change] This was fixed as part of ZOOKEEPER-139, changed value was removed > keeper state inconsistency > -- > > Key: ZOOKEEPER-18 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-18 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1979772&group_id=209147&atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-144) add tostring support for watcher event, and enums for event type/state
add tostring support for watcher event, and enums for event type/state -- Key: ZOOKEEPER-144 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-144 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Priority: Minor it would be great if we had toString capability on watcher event, and enums for type/state. the logs would certainly benefit (when fixing this try to update any places where we are logging event information) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-139) Create Enums for WatcherEvent's KeeperState and EventType
[ https://issues.apache.org/jira/browse/ZOOKEEPER-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-139: --- Resolution: Fixed Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed, Incompatible change]) Status: Resolved (was: Patch Available) Committed revision 699114. > Create Enums for WatcherEvent's KeeperState and EventType > - > > Key: ZOOKEEPER-139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-139 > Project: Zookeeper > Issue Type: Sub-task >Affects Versions: 3.0.0 >Reporter: Jakob Homan >Assignee: Jakob Homan > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-139.patch, ZOOKEEPER-139.patch, > ZOOKEEPER-139.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-139) Create Enums for WatcherEvent's KeeperState and EventType
[ https://issues.apache.org/jira/browse/ZOOKEEPER-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-139: --- Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change]) I reviewed the patch and ran tests. Looks good, I will commit. > Create Enums for WatcherEvent's KeeperState and EventType > - > > Key: ZOOKEEPER-139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-139 > Project: Zookeeper > Issue Type: Sub-task >Affects Versions: 3.0.0 >Reporter: Jakob Homan >Assignee: Jakob Homan > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-139.patch, ZOOKEEPER-139.patch, > ZOOKEEPER-139.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-139) Create Enums for WatcherEvent's KeeperState and EventType
[ https://issues.apache.org/jira/browse/ZOOKEEPER-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634659#action_12634659 ] Mahadev konar commented on ZOOKEEPER-139: - +1... the patch looks good... > Create Enums for WatcherEvent's KeeperState and EventType > - > > Key: ZOOKEEPER-139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-139 > Project: Zookeeper > Issue Type: Sub-task >Affects Versions: 3.0.0 >Reporter: Jakob Homan >Assignee: Jakob Homan > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-139.patch, ZOOKEEPER-139.patch, > ZOOKEEPER-139.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-139) Create Enums for WatcherEvent's KeeperState and EventType
[ https://issues.apache.org/jira/browse/ZOOKEEPER-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-139: --- Hadoop Flags: [Incompatible change] > Create Enums for WatcherEvent's KeeperState and EventType > - > > Key: ZOOKEEPER-139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-139 > Project: Zookeeper > Issue Type: Sub-task >Affects Versions: 3.0.0 >Reporter: Jakob Homan >Assignee: Jakob Homan > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-139.patch, ZOOKEEPER-139.patch, > ZOOKEEPER-139.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-142) Provide Javadoc as to the maximum size of the data byte array that may be stored within a znode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-142: --- Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision 699104. The issue of whether semantics are correct has been created as jira ZOOKEEPER-143 > Provide Javadoc as to the maximum size of the data byte array that may be > stored within a znode > --- > > Key: ZOOKEEPER-142 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-142 > Project: Zookeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.0.0 >Reporter: Jakob Homan >Assignee: Jakob Homan >Priority: Trivial > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-142.patch > > > Currently there is nothing in the API documentation as to the maximum size of > the data in a znode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-143) Exceeding max data node size causes disconnect
Exceeding max data node size causes disconnect -- Key: ZOOKEEPER-143 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-143 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Priority: Minor The server will disconnect the client if the max node size is exceeded. See ZOOKEEPER-142 We should consider whether disconnect is warranted (142 has added documentation for this to the java client) We should also document this in the main forrest based docs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-142) Provide Javadoc as to the maximum size of the data byte array that may be stored within a znode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-142: --- Hadoop Flags: [Reviewed] +1 on patch > Provide Javadoc as to the maximum size of the data byte array that may be > stored within a znode > --- > > Key: ZOOKEEPER-142 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-142 > Project: Zookeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.0.0 >Reporter: Jakob Homan >Assignee: Jakob Homan >Priority: Trivial > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-142.patch > > > Currently there is nothing in the API documentation as to the maximum size of > the data in a znode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634616#action_12634616 ] mahadev edited comment on ZOOKEEPER-38 at 9/25/08 2:00 PM: - here is an updated patch. I cleared the patch with nice javadocs and more testing. Fixed a few bugs i found during the testing. bq. In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the configuration methods. (This same comment applies to Leader and QuorumPeer i am not sure abt this. did i remove something? bq. In FileSnapLog.deserialize() if the snapshot is bad, you should try an earlier snapshot. (We should add a test case for this) you are right... i would rather have it as another jira since this would be an improved over our earilier versions and would help getting this in without more delay :). bq. SnapLog should really be called Snapshot since it does not have a log component done. bq. In FileTxnLog.getLogFiles() you should add a comment to the first (fzxid > logZxid) check that you are taking advantage of the fact that the files are sorted, so the last time this condition is true will be for the log file that has snapshotZxid. done. bq. In FileTxnLog.getLastLoggedZxid() the comment is a bit unclear. I think this method will also have a problem if the last logfile consists of a single corrupt entry. done... thats is true... I will open another jira for this as well. bq. In FileTxnLog.truncate() you may need to delete files as well if the zxid you are truncing to is in a log file before the last file done. bq. TxnLogCompletion is not used and should be removed done. bq. The Util class has some methods that are not used that should be removed. done. was (Author: mahadev): here is an updated patch. I cleared the patch with nice javadocs and more testing. Fixed a few bugs i found during the testing. bq. In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the configuration methods. (This same comment applies to Leader and QuorumPeer i am not sure abt this. did i remove something? bq. In FileSnapLog.deserialize() if the snapshot is bad, you should try an earlier snapshot. (We should add a test case for this) you are right... i would rather have it as another jira since this would be an improved over our earilier versions and would help getting this in without more delay :). bq. SnapLog should really be called Snapshot since it does not have a log component done. bq. In FileTxnLog.getLogFiles() you should add a comment to the first (fzxid > logZxid) check that you are taking advantage of the fact that the files are sorted, so the last time this condition is true will be for the log file that has snapshotZxid. done. bq. In FileTxnLog.getLastLoggedZxid() the comment is a bit unclear. I think this method will also have a problem if the last logfile consists of a single corrupt entry. done... thats is true... I will open another jira for this as well. bq. In FileTxnLog.truncate() you may need to delete files as well if the zxid you are truncing to is in a log file before the last file done. bq. TxnLogCompletion is not used and should be removed done. bq. The Util class has some methods that are not used that should be removed. done. [ Show » ] Benjamin Reed - 24/Sep/08 12:50 PM This looks great Mahadev. Just small comments: * In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the configuration methods. (This same comment applies to Leader and QuorumPeer * In FileSnapLog.deserialize() if the snapshot is bad, you should try an earlier snapshot. (We should add a test case for this) * SnapLog should really be called Snapshot since it does not have a log component * In FileTxnLog.getLogFiles() you should add a comment to the first (fzxid > logZxid) check that you are taking advantage of the fact that the files are sorted, so the last time this condition is true will be for the log file that has snapshotZxid. * In FileTxnLog.getLastLoggedZxid() the comment is a bit unclear. I think this method will also have a problem if the last logfile consists of a single corrupt entry. * In FileTxnLog.truncate() you may need to delete files as well if the zxid you are truncing to is in a log file before the last file * TxnLogCompletion is not used and should be removed * The Util class has some methods that are not used that should be removed. > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://is
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-38: --- Status: Patch Available (was: Open) > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, > ZOOKEEPER-38.patch, ZOOKEEPER-38_1.patch, ZOOKEEPER-38_2.patch, > ZOOKEEPER-38_3.patch, ZOOKEEPER-38_5.patch, ZOOKEEPER-38_6.patch, > ZOOKEEPER-38_7.patch, ZOOKEEPER-38_8.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-38: --- Hadoop Flags: [Incompatible change] > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, > ZOOKEEPER-38.patch, ZOOKEEPER-38_1.patch, ZOOKEEPER-38_2.patch, > ZOOKEEPER-38_3.patch, ZOOKEEPER-38_5.patch, ZOOKEEPER-38_6.patch, > ZOOKEEPER-38_7.patch, ZOOKEEPER-38_8.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-38: --- Attachment: ZOOKEEPER-38_8.patch here is an updated patch. I cleared the patch with nice javadocs and more testing. Fixed a few bugs i found during the testing. bq. In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the configuration methods. (This same comment applies to Leader and QuorumPeer i am not sure abt this. did i remove something? bq. In FileSnapLog.deserialize() if the snapshot is bad, you should try an earlier snapshot. (We should add a test case for this) you are right... i would rather have it as another jira since this would be an improved over our earilier versions and would help getting this in without more delay :). bq. SnapLog should really be called Snapshot since it does not have a log component done. bq. In FileTxnLog.getLogFiles() you should add a comment to the first (fzxid > logZxid) check that you are taking advantage of the fact that the files are sorted, so the last time this condition is true will be for the log file that has snapshotZxid. done. bq. In FileTxnLog.getLastLoggedZxid() the comment is a bit unclear. I think this method will also have a problem if the last logfile consists of a single corrupt entry. done... thats is true... I will open another jira for this as well. bq. In FileTxnLog.truncate() you may need to delete files as well if the zxid you are truncing to is in a log file before the last file done. bq. TxnLogCompletion is not used and should be removed done. bq. The Util class has some methods that are not used that should be removed. done. [ Show » ] Benjamin Reed - 24/Sep/08 12:50 PM This looks great Mahadev. Just small comments: * In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the configuration methods. (This same comment applies to Leader and QuorumPeer * In FileSnapLog.deserialize() if the snapshot is bad, you should try an earlier snapshot. (We should add a test case for this) * SnapLog should really be called Snapshot since it does not have a log component * In FileTxnLog.getLogFiles() you should add a comment to the first (fzxid > logZxid) check that you are taking advantage of the fact that the files are sorted, so the last time this condition is true will be for the log file that has snapshotZxid. * In FileTxnLog.getLastLoggedZxid() the comment is a bit unclear. I think this method will also have a problem if the last logfile consists of a single corrupt entry. * In FileTxnLog.truncate() you may need to delete files as well if the zxid you are truncing to is in a log file before the last file * TxnLogCompletion is not used and should be removed * The Util class has some methods that are not used that should be removed. > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, > ZOOKEEPER-38.patch, ZOOKEEPER-38_1.patch, ZOOKEEPER-38_2.patch, > ZOOKEEPER-38_3.patch, ZOOKEEPER-38_5.patch, ZOOKEEPER-38_6.patch, > ZOOKEEPER-38_7.patch, ZOOKEEPER-38_8.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-136: - Status: Open (was: Patch Available) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-137) client watcher objects can lose events
[
https://issues.apache.org/jira/browse/ZOOKEEPER-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634473#action_12634473
]
Hudson commented on ZOOKEEPER-137:
--
Integrated in ZooKeeper-trunk #94 (See
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/94/])
> client watcher objects can lose events
> --
>
> Key: ZOOKEEPER-137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-137
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.0.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-137.patch
>
>
> if a single watcher (A) is registered on a single node for both a getdata and
> exists watch the second watch event may be lost:
> 1) getdata("node", A)
> 2) setdata("node"...)
> 3) exists("node", A)
> 4) delete("node"...)
> if watch events for 2 is processed on the client (zookeeper.java, zkwatcher)
> after 3 completes then the zkwatcher process event method will clear the
> watch and the subsequent operation's (4) event will be ignored
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-93) Create Documentation for Zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634474#action_12634474 ] Hudson commented on ZOOKEEPER-93: - Integrated in ZooKeeper-trunk #94 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/94/]) > Create Documentation for Zookeeper > -- > > Key: ZOOKEEPER-93 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-93 > Project: Zookeeper > Issue Type: Task > Components: documentation >Affects Versions: 3.0.0 > Environment: N/A >Reporter: Robbie Scott >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-93.tar.gz > > Original Estimate: 0.02h > Remaining Estimate: 0.02h > > Initial version of the documentation, migrated from source forge. > Reorganizing, expanding. Initial goal is to port Source Forge documentation > into Forrest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-117) threading issues in Leader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634472#action_12634472 ] Hudson commented on ZOOKEEPER-117: -- Integrated in ZooKeeper-trunk #94 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/94/]) > threading issues in Leader election > --- > > Key: ZOOKEEPER-117 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-117 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Flavio Paiva Junqueira > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-117.patch, ZOOKEEPER-117.patch > > > Leader.lead() creates a new thread that can never terminate (short of > restarting vm) > naked notifyall in lead() method - what is the condition variable? Best if > set inside the sync block -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Hudson build is back to normal: ZooKeeper-trunk #94
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/94/changes
[jira] Updated: (ZOOKEEPER-127) Use of non-standard election ports in config breaks services
[ https://issues.apache.org/jira/browse/ZOOKEEPER-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-127: - Status: Patch Available (was: Open) > Use of non-standard election ports in config breaks services > > > Key: ZOOKEEPER-127 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-127 > Project: Zookeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.0.0 >Reporter: Mark Harwood >Assignee: Flavio Paiva Junqueira >Priority: Minor > Fix For: 3.0.0 > > Attachments: mhPortChanges.patch, ZOOKEEPER-127.patch, > ZOOKEEPER-127.patch, ZOOKEEPER-127.patch, ZOOKEEPER-127.patch, > ZOOKEEPER-127.patch, ZOOKEEPER-127.patch > > > In QuorumCnxManager.toSend there is a call to create a connection as follows: > channel = SocketChannel.open(new InetSocketAddress(addr, port)); > Unfortunately "addr" is the ip address of a remote server while "port" is the > electionPort of *this* server. > As an example, given this configuration (taken from my zoo.cfg) > server.1=10.20.9.254:2881 > server.2=10.20.9.9:2882 > server.3=10.20.9.254:2883 > Server 3 was observed trying to make a connection to host 10.20.9.9 on port > 2883 and obviously failing. > In tests where all machines use the same electionPort this bug would not > manifest itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-127) Use of non-standard election ports in config breaks services
[ https://issues.apache.org/jira/browse/ZOOKEEPER-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-127: - Attachment: ZOOKEEPER-127.patch This last patch improves the FLE unit test, and deals with a couple of corner cases in the FastLeaderElection implementation. > Use of non-standard election ports in config breaks services > > > Key: ZOOKEEPER-127 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-127 > Project: Zookeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.0.0 >Reporter: Mark Harwood >Assignee: Flavio Paiva Junqueira >Priority: Minor > Fix For: 3.0.0 > > Attachments: mhPortChanges.patch, ZOOKEEPER-127.patch, > ZOOKEEPER-127.patch, ZOOKEEPER-127.patch, ZOOKEEPER-127.patch, > ZOOKEEPER-127.patch, ZOOKEEPER-127.patch > > > In QuorumCnxManager.toSend there is a call to create a connection as follows: > channel = SocketChannel.open(new InetSocketAddress(addr, port)); > Unfortunately "addr" is the ip address of a remote server while "port" is the > electionPort of *this* server. > As an example, given this configuration (taken from my zoo.cfg) > server.1=10.20.9.254:2881 > server.2=10.20.9.9:2882 > server.3=10.20.9.254:2883 > Server 3 was observed trying to make a connection to host 10.20.9.9 on port > 2883 and obviously failing. > In tests where all machines use the same electionPort this bug would not > manifest itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
