[jira] Updated: (ZOOKEEPER-6) List of problem identifiers in zookeeper.h
[
https://issues.apache.org/jira/browse/ZOOKEEPER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Paiva Junqueira updated ZOOKEEPER-6:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
+1 and committed
List of problem identifiers in zookeeper.h
--
Key: ZOOKEEPER-6
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-6
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.0.0
Attachments: ZOOKEEPER-6.patch
Submitted on behalf of Jacob. Is is possible for us to address this in the
next release? Will cause b/w compatibility issues for c client users but
sounds like a good idea to fix now.
I've attached a file with the problem identifiers. All of these
identifiers are unprotected by a ZOO_ (or something similar) prefix.
I've also looked at zookeeper.jute.h and the names of some these structs
are really unfortunate -- theyre sure to collide with some headers e.g.
Stat. There's also some exceptions to the consistent naming scheme --
op_result_t, String_vector, Id_vector are the ones I noticed.
file ---
These enum constants are unprotected:
typedef enum
{LOG_LEVEL_ERROR=1,LOG_LEVEL_WARN=2,LOG_LEVEL_INFO=3,LOG_LEVEL_DEBUG=4}
ZooLogLevel;
extern ZOOAPI const int PERM_READ;
extern ZOOAPI const int PERM_WRITE;
extern ZOOAPI const int PERM_CREATE;
extern ZOOAPI const int PERM_DELETE;
extern ZOOAPI const int PERM_ADMIN;
extern ZOOAPI const int PERM_ALL;
extern ZOOAPI struct Id ANYONE_ID_UNSAFE;
extern ZOOAPI struct Id AUTH_IDS;
extern ZOOAPI struct ACL_vector OPEN_ACL_UNSAFE;
extern ZOOAPI struct ACL_vector READ_ACL_UNSAFE;
extern ZOOAPI struct ACL_vector CREATOR_ALL_ACL;
extern ZOOAPI const int EPHEMERAL;
extern ZOOAPI const int SEQUENCE;
extern ZOOAPI const int EXPIRED_SESSION_STATE;
extern ZOOAPI const int AUTH_FAILED_STATE;
extern ZOOAPI const int CONNECTING_STATE;
extern ZOOAPI const int ASSOCIATING_STATE;
extern ZOOAPI const int CONNECTED_STATE;
extern ZOOAPI const int CREATED_EVENT;
extern ZOOAPI const int DELETED_EVENT;
extern ZOOAPI const int CHANGED_EVENT;
extern ZOOAPI const int CHILD_EVENT;
extern ZOOAPI const int SESSION_EVENT;
extern ZOOAPI const int NOTWATCHING_EVENT;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-8) Stat enchaned to include num of children and size
[ https://issues.apache.org/jira/browse/ZOOKEEPER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-8: - Status: Open (was: Patch Available) Sure, I'll look at cppunit that we already have and see what we can do. Stat enchaned to include num of children and size - Key: ZOOKEEPER-8 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-8 Project: Zookeeper Issue Type: Bug Components: c client, java client Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.0.0 Attachments: ZOOKEEPER-8_1.patch, ZOOKEEPER-8_1.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1886743group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-6) List of problem identifiers in zookeeper.h
[
https://issues.apache.org/jira/browse/ZOOKEEPER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635749#action_12635749
]
Hudson commented on ZOOKEEPER-6:
Integrated in ZooKeeper-trunk #99 (See
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/99/])
List of problem identifiers in zookeeper.h
--
Key: ZOOKEEPER-6
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-6
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.0.0
Attachments: ZOOKEEPER-6.patch
Submitted on behalf of Jacob. Is is possible for us to address this in the
next release? Will cause b/w compatibility issues for c client users but
sounds like a good idea to fix now.
I've attached a file with the problem identifiers. All of these
identifiers are unprotected by a ZOO_ (or something similar) prefix.
I've also looked at zookeeper.jute.h and the names of some these structs
are really unfortunate -- theyre sure to collide with some headers e.g.
Stat. There's also some exceptions to the consistent naming scheme --
op_result_t, String_vector, Id_vector are the ones I noticed.
file ---
These enum constants are unprotected:
typedef enum
{LOG_LEVEL_ERROR=1,LOG_LEVEL_WARN=2,LOG_LEVEL_INFO=3,LOG_LEVEL_DEBUG=4}
ZooLogLevel;
extern ZOOAPI const int PERM_READ;
extern ZOOAPI const int PERM_WRITE;
extern ZOOAPI const int PERM_CREATE;
extern ZOOAPI const int PERM_DELETE;
extern ZOOAPI const int PERM_ADMIN;
extern ZOOAPI const int PERM_ALL;
extern ZOOAPI struct Id ANYONE_ID_UNSAFE;
extern ZOOAPI struct Id AUTH_IDS;
extern ZOOAPI struct ACL_vector OPEN_ACL_UNSAFE;
extern ZOOAPI struct ACL_vector READ_ACL_UNSAFE;
extern ZOOAPI struct ACL_vector CREATOR_ALL_ACL;
extern ZOOAPI const int EPHEMERAL;
extern ZOOAPI const int SEQUENCE;
extern ZOOAPI const int EXPIRED_SESSION_STATE;
extern ZOOAPI const int AUTH_FAILED_STATE;
extern ZOOAPI const int CONNECTING_STATE;
extern ZOOAPI const int ASSOCIATING_STATE;
extern ZOOAPI const int CONNECTED_STATE;
extern ZOOAPI const int CREATED_EVENT;
extern ZOOAPI const int DELETED_EVENT;
extern ZOOAPI const int CHANGED_EVENT;
extern ZOOAPI const int CHILD_EVENT;
extern ZOOAPI const int SESSION_EVENT;
extern ZOOAPI const int NOTWATCHING_EVENT;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-144) add tostring support for watcher event, and enums for event type/state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-144: -- Status: Patch Available (was: Open) add tostring support for watcher event, and enums for event type/state -- Key: ZOOKEEPER-144 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-144 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Jakob Homan Priority: Minor Fix For: 3.0.0 Attachments: ZOOKEEPER-144.patch it would be great if we had toString capability on watcher event, and enums for type/state. the logs would certainly benefit (when fixing this try to update any places where we are logging event information) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-146) Allow clients to retrieve the list of hosts/servers from a URL
[ https://issues.apache.org/jira/browse/ZOOKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635829#action_12635829 ] Jakob Homan commented on ZOOKEEPER-146: --- OK, I wait to see if anything happens with the C version and if so, updated with Patrick's comments at that point. Allow clients to retrieve the list of hosts/servers from a URL -- Key: ZOOKEEPER-146 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-146 Project: Zookeeper Issue Type: Improvement Components: java client Affects Versions: 3.0.0 Reporter: Jakob Homan Assignee: Jakob Homan Fix For: 3.1.0 Attachments: ZOOKEEPER-146.patch As I suggested in ZOOKEEPER-107, it would be nice to allow clients to specify their hosts strings via a URL so that this can change dynamically. For instance, obtain the current list of hosts from a webpage or a file on disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-114) cleanup ugly event messages in zookeeper client
[
https://issues.apache.org/jira/browse/ZOOKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635830#action_12635830
]
Jakob Homan commented on ZOOKEEPER-114:
---
This was fixed in the printing/logging cleanup of ZOOKEEPER-144.
cleanup ugly event messages in zookeeper client
---
Key: ZOOKEEPER-114
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-114
Project: Zookeeper
Issue Type: Improvement
Components: java client
Reporter: Patrick Hunt
Assignee: Jakob Homan
Priority: Trivial
Fix For: 3.0.0
Cleanup the event messages output by the java command line client:
The java client ZooKeeper.java has a process method in MyWatcher that prints
raw event information to the console. Many new users find this confusing (esp
since state changes have a null path).
public void process(WatcherEvent event) {
System.err.println(event.getPath() + : + event.getState() + -
+ event.getType());
}
If this is a state change we should print that, if it's an event we should
print that (state change doesn't have a path). Somewhere in the message we
should also indicate that the client received a watch notification from the
server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-38: --- Attachment: ZOOKEEPER-38_11.patch the last patch had a problem with compiling jmx ... since the jmx build is broken is didnt realize that I broke the jmx build with my patch... headers (version+) in log/snap files Key: ZOOKEEPER-38 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.0.0 Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, ZOOKEEPER-38_1.patch, ZOOKEEPER-38_10.patch, ZOOKEEPER-38_11.patch, ZOOKEEPER-38_2.patch, ZOOKEEPER-38_3.patch, ZOOKEEPER-38_5.patch, ZOOKEEPER-38_6.patch, ZOOKEEPER-38_7.patch, ZOOKEEPER-38_8.patch, ZOOKEEPER-38_9.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1961767group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-8) Stat enchaned to include num of children and size
[ https://issues.apache.org/jira/browse/ZOOKEEPER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-8: - Status: Patch Available (was: Open) I looked at the c tests and they are all mock based. I'll open another jira for the c tests - that we should have tests that run against actual java server. Resubmitting this patch. Stat enchaned to include num of children and size - Key: ZOOKEEPER-8 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-8 Project: Zookeeper Issue Type: Bug Components: c client, java client Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.0.0 Attachments: ZOOKEEPER-8_1.patch, ZOOKEEPER-8_1.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1886743group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-147) This is version of the documents with most of the [tbd...] scrubbed out
[ https://issues.apache.org/jira/browse/ZOOKEEPER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-147: --- Attachment: ZOOKEEPER-147.patch Updated Robbie's patch to move todo.txt into documentation dir as TODO.txt and fixed a merge issue. This is version of the documents with most of the [tbd...] scrubbed out --- Key: ZOOKEEPER-147 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-147 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.0.0 Reporter: Robbie Scott Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-147.patch, ZOOKEEPER-147.patch, ZOOKEEPER-147.patch Original Estimate: 96h Remaining Estimate: 96h The docs had lots of comments to myself marked [tbd..]. I scrubbed these out. I still have a list I will work from, but the [tbd]s are probably sensible to anyone else. For a few cases where it's obvious what a tbd is asking, I left in in, just in case someone else wants to take a crack at fixing them, knows the answer, etc. The estimate below refers to how many full days I think it would take to get all the tbd's answered and put back into the document. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-147) This is version of the documents with most of the [tbd...] scrubbed out
[ https://issues.apache.org/jira/browse/ZOOKEEPER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-147: --- Attachment: (was: ZOOKEEPER-147.patch) This is version of the documents with most of the [tbd...] scrubbed out --- Key: ZOOKEEPER-147 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-147 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.0.0 Reporter: Robbie Scott Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-147.patch, ZOOKEEPER-147.patch Original Estimate: 96h Remaining Estimate: 96h The docs had lots of comments to myself marked [tbd..]. I scrubbed these out. I still have a list I will work from, but the [tbd]s are probably sensible to anyone else. For a few cases where it's obvious what a tbd is asking, I left in in, just in case someone else wants to take a crack at fixing them, knows the answer, etc. The estimate below refers to how many full days I think it would take to get all the tbd's answered and put back into the document. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-144) add tostring support for watcher event, and enums for event type/state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-144: --- Hadoop Flags: [Reviewed] looks good +1, like the improvement to the zk client (zookeepermain) watch output. add tostring support for watcher event, and enums for event type/state -- Key: ZOOKEEPER-144 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-144 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Jakob Homan Priority: Minor Fix For: 3.0.0 Attachments: ZOOKEEPER-144.patch it would be great if we had toString capability on watcher event, and enums for type/state. the logs would certainly benefit (when fixing this try to update any places where we are logging event information) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-144) add tostring support for watcher event, and enums for event type/state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-144: --- Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision 700664. add tostring support for watcher event, and enums for event type/state -- Key: ZOOKEEPER-144 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-144 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Jakob Homan Priority: Minor Fix For: 3.0.0 Attachments: ZOOKEEPER-144.patch it would be great if we had toString capability on watcher event, and enums for type/state. the logs would certainly benefit (when fixing this try to update any places where we are logging event information) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-114) cleanup ugly event messages in zookeeper client
[
https://issues.apache.org/jira/browse/ZOOKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt resolved ZOOKEEPER-114.
Resolution: Fixed
Hadoop Flags: [Reviewed]
Verified fixed as part of 144 - now have nice logging of events in command line
client.
cleanup ugly event messages in zookeeper client
---
Key: ZOOKEEPER-114
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-114
Project: Zookeeper
Issue Type: Improvement
Components: java client
Reporter: Patrick Hunt
Assignee: Jakob Homan
Priority: Trivial
Fix For: 3.0.0
Cleanup the event messages output by the java command line client:
The java client ZooKeeper.java has a process method in MyWatcher that prints
raw event information to the console. Many new users find this confusing (esp
since state changes have a null path).
public void process(WatcherEvent event) {
System.err.println(event.getPath() + : + event.getState() + -
+ event.getType());
}
If this is a state change we should print that, if it's an event we should
print that (state change doesn't have a path). Somewhere in the message we
should also indicate that the client received a watch notification from the
server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
