[jira] Updated: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim P. Dementiev updated ZOOKEEPER-182:
-
Attachment: ZOOKEEPER-182-UnitTests-Init-AddressString.patch
Contains new tests for zookeeper_init() function:
testNullAddressString, estEmptyAddressString, testOneSpaceAddressString,
testTwoSpacesAddressString
zookeeper_init accepts empty host-port string and returns valid pointer to
zhandle_t.
-
Key: ZOOKEEPER-182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182
Project: Zookeeper
Issue Type: Bug
Components: c client
Environment: Linux
Reporter: Maxim P. Dementiev
Attachments: ZOOKEEPER-182-UnitTests-Init-AddressString.patch
Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this:
void testEmptyAddressString()
{
zh=zookeeper_init(,0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-184) tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions.
tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions. Key: ZOOKEEPER-184 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-184 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Some compilation environments provide implicit inclusion of certain system headers. But any way it's not a reason to exploit it in platform-independent projects. TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-115) Potential NPE in QuorumCnxManager
[
https://issues.apache.org/jira/browse/ZOOKEEPER-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Paiva Junqueira resolved ZOOKEEPER-115.
--
Resolution: Fixed
This issue has been resolved by the patch of jira 127.
Potential NPE in QuorumCnxManager
-
Key: ZOOKEEPER-115
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-115
Project: Zookeeper
Issue Type: Bug
Components: quorum
Reporter: Patrick Hunt
Assignee: Flavio Paiva Junqueira
Attachments: ZOOKEEPER-115.patch
Findbugs flagged this, notice that we are checking for null after using the
reference.
if (senderWorkerMap.get(s.socket().getInetAddress()) != null) {
senderWorkerMap.get(s.socket().getInetAddress()).finish();
}
/*
* Start new worker thread with a clean state.
*/
if (s != null) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim P. Dementiev updated ZOOKEEPER-182:
-
Attachment: ZOOKEEPER-182.patch
Attachment ZOOKEEPER-182.patch: if we check the input string for , we may
check for NULL first - there is no any drawback.
I think it's good idea to check for NULL and exit with an appropriate error
than do a coredump.
But in any case we have to check the input string before pass it to strdup().
zookeeper_init accepts empty host-port string and returns valid pointer to
zhandle_t.
-
Key: ZOOKEEPER-182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182
Project: Zookeeper
Issue Type: Bug
Components: c client
Environment: Linux
Reporter: Maxim P. Dementiev
Attachments: ZOOKEEPER-182-UnitTests-Init-AddressString.patch,
ZOOKEEPER-182.patch
Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this:
void testEmptyAddressString()
{
zh=zookeeper_init(,0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-184) tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-184: - Attachment: ZOOKEEPER-184.patch The patch is obvious: include corresponding system header. tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions. Key: ZOOKEEPER-184 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-184 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Attachments: ZOOKEEPER-184.patch Some compilation environments provide implicit inclusion of certain system headers. But any way it's not a reason to exploit it in platform-independent projects. TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639023#action_12639023
]
dememax edited comment on ZOOKEEPER-182 at 10/13/08 4:14 AM:
Attachment ZOOKEEPER-182-UnitTests-Init-AddressString.patch contains new tests
for zookeeper_init() function:
testNullAddressString, estEmptyAddressString, testOneSpaceAddressString,
testTwoSpacesAddressString
was (Author: dememax):
Contains new tests for zookeeper_init() function:
testNullAddressString, estEmptyAddressString, testOneSpaceAddressString,
testTwoSpacesAddressString
zookeeper_init accepts empty host-port string and returns valid pointer to
zhandle_t.
-
Key: ZOOKEEPER-182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182
Project: Zookeeper
Issue Type: Bug
Components: c client
Environment: Linux
Reporter: Maxim P. Dementiev
Attachments: ZOOKEEPER-182-UnitTests-Init-AddressString.patch
Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this:
void testEmptyAddressString()
{
zh=zookeeper_init(,0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-183) Array subscript is above array bounds in od_completion(), src/cli.c.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-183: - Comment: was deleted Array subscript is above array bounds in od_completion(), src/cli.c. Key: ZOOKEEPER-183 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-183 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Having: char buf[4096*16]; Present: buf[sizeof(buf)]=0; Must be: buf[sizeof(buf)-1]=0; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-138) c client watcher objects can lose events
[ https://issues.apache.org/jira/browse/ZOOKEEPER-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-138: -- Assignee: Benjamin Reed (was: Patrick Hunt) Ben said he would take a look at this as part of the autoreset of watches work he's doing. I'm concerned that this change would be pretty late for 3.0, perhaps we should consider moving to 3.1? (not an incompatible change afaik). c client watcher objects can lose events Key: ZOOKEEPER-138 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-138 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0 Reporter: Patrick Hunt Assignee: Benjamin Reed Fix For: 3.0.0 if a single watcher (A) is registered on a single node for both a getdata and exists watch the second watch event may be lost: 1) getdata(node, A) 2) setdata(node...) 3) exists(node, A) 4) delete(node...) if watch events for 2 is processed on the client (zookeeper.java, zkwatcher) after 3 completes then the zkwatcher process event method will clear the watch and the subsequent operation's (4) event will be ignored -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-145) write detailed release notes for users migrating from 2.x to 3.0
[ https://issues.apache.org/jira/browse/ZOOKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639159#action_12639159 ] Patrick Hunt commented on ZOOKEEPER-145: I talked with hadoop core (owen) and they have a releasenotes.xml file in forrest docs to capture this. I will add the file, document changelog issues, and add section to capture upgrade notes. 1) api changes 2) release layout changes 3) documentation location changes 4) java - package struct, jakobs changes for enums 5) c - anything here? 6) on disk data format changes - mahadev's changes to acl storage, upgrade utility write detailed release notes for users migrating from 2.x to 3.0 Key: ZOOKEEPER-145 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-145 Project: Zookeeper Issue Type: Task Components: c client, documentation, java client Affects Versions: 3.0.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.0.0 We need to write detailed release notes that detail how c and java client API users as well as zk server administrators migrate from 2.x to 3.x zookeeper release. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-33) Better ACL management
[ https://issues.apache.org/jira/browse/ZOOKEEPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-33: --- Status: Patch Available (was: Open) Better ACL management - Key: ZOOKEEPER-33 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-33 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.0.0 Attachments: ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1945175group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-185) Improved version of FLETest
Improved version of FLETest --- Key: ZOOKEEPER-185 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185 Project: Zookeeper Issue Type: Improvement Components: leaderElection Affects Versions: 3.0.0 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-33) Better ACL management
[ https://issues.apache.org/jira/browse/ZOOKEEPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639277#action_12639277 ] Mahadev konar commented on ZOOKEEPER-33: just to make sure the patch uploaded at 5:53 pm is the latest one... the jira does not show it as the last patch... Better ACL management - Key: ZOOKEEPER-33 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-33 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.0.0 Attachments: ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1945175group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-33) Better ACL management
[ https://issues.apache.org/jira/browse/ZOOKEEPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-33: --- Attachment: ZOOKEEPER-33.patch forgot to add the test... Better ACL management - Key: ZOOKEEPER-33 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-33 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.0.0 Attachments: ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1945175group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-33) Better ACL management
[ https://issues.apache.org/jira/browse/ZOOKEEPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639279#action_12639279 ] Mahadev konar commented on ZOOKEEPER-33: the patch uploaded at 06:59 PM is the latest now :) ... Better ACL management - Key: ZOOKEEPER-33 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-33 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.0.0 Attachments: ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1945175group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-33) Better ACL management
[ https://issues.apache.org/jira/browse/ZOOKEEPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-33: --- Status: Open (was: Patch Available) -1 Sorry Mahadev, two small issues (one is super trivial :) 1) convertLongs should be called covertLong since there is only a single Long being converted 2) convertAcls should use a MapListACL, Long to convert an ACL list to a long, otherwise that could become an expensive method when more than a few different ACLs are used. Note, that Map does not need to be serialized and can be deserialized with the MapLong,ListACL Better ACL management - Key: ZOOKEEPER-33 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-33 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.0.0 Attachments: ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1945175group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-33) Better ACL management
[ https://issues.apache.org/jira/browse/ZOOKEEPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-33: --- Attachment: ZOOKEEPER-33.patch attaching the patch with ben's comments 1) fixed 2) fixed Better ACL management - Key: ZOOKEEPER-33 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-33 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.0.0 Attachments: ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch, ZOOKEEPER-33.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1945175group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
