Hudson build is back to normal: ZooKeeper-trunk #226

[Apache Hudson Server]

See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/226/changes

[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-309:
---

Status: Open  (was: Patch Available)

Cancelling patch - needs tests. I suggest that tests be added for ACLs in 
general (not just this api) -- the cppunits are missing any kind of acl testing.

 core dump using zoo_get_acl() 
 --

 Key: ZOOKEEPER-309
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.0.1, 3.0.0, 3.1.0
Reporter: Chris Darroch
 Fix For: 3.1.1, 3.2.0

 Attachments: zookeeper.c.patch


 The zookeeper_process() function incorrectly calls the c.acl_result member of 
 the completion_list_t structure when handling the completion from a 
 synchronous zoo_get_acl() request.  The c.acl_result member is set to 
 SYNCHRONOUS_MARKER, which is a null pointer.
 The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-310) Coverity report on issues in C client code

[Patrick Hunt (JIRA)]

Coverity report on issues in C client code
--

 Key: ZOOKEEPER-310
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-310
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.1.0
Reporter: Patrick Hunt
Priority: Minor
 Fix For: 3.2.0


Coverity found the following issues in the c code thatwe should look at/resolve:

1) zookeeper.c

Event unterminated_case: This case (value 0) is not terminated by a 'break' 
statement.
717 case 0:
718 errno = EHOSTDOWN;
Event fallthrough: The above case falls through to this one.
719 case -1:

Event unterminated_case: This case (value 0) is not terminated by a 'break' 
statement.
739 case 0:
740 errno = EHOSTDOWN;
Event fallthrough: The above case falls through to this one.
741 case -1:

Event negative_return_fn: Called negative-returning function socket(2, 1, 0)
Event var_assign: NEGATIVE return value of socket assigned to signed variable 
zh-fd
1099zh-fd = socket(PF_INET, SOCK_STREAM, 0);
Event negative_returns: Tracked variable zh-fd was passed to a negative sink.
1100setsockopt(zh-fd, IPPROTO_TCP, TCP_NODELAY, on, 
sizeof(int));

Event deref_ptr: Directly dereferenced pointer cptr-buffer
1308cptr-buffer-curr_offset = get_buffer_len(oa);
Event check_after_deref: Pointer cptr-buffer dereferenced before NULL check
1309if (!cptr-buffer) {


cli.c

Event returned_null: Function strchr returned NULL value (checked 4 out of 5 
times)
Event var_assigned: Variable ptr assigned to NULL return value from strchr
532 char *ptr = strchr(buffer, '\n');
Event dereference: Dereferencing NULL value ptr 


recordio.c

Event alloc_fn: Called allocation function malloc
Event var_assign: Assigned variable buff to storage returned from 
malloc(12U)
284 struct buff_struct *buff = malloc(sizeof(struct buff_struct));
Event leaked_storage: Variable buff goes out of scope
At conditional (1): !(ia != NULL) taking true path 
285 if (!ia) return 0;

Event alloc_fn: Called allocation function malloc
Event var_assign: Assigned variable buff to storage returned from 
malloc(12U)
301 struct buff_struct *buff = malloc(sizeof(struct buff_struct));
Event leaked_storage: Variable buff goes out of scope
At conditional (1): !(oa != NULL) taking true path
302 if (!oa) return 0;



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.