[jira] Updated: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-371: - Attachment: zookeeper-371.patch this patch enables jdiff for zookeeper. Tnx! to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698818#action_12698818 ] Benjamin Reed commented on ZOOKEEPER-371: - shouldn't this be generated rather than checked in? to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-224) Deploy ZooKeeper 3.0.0 to a Maven Repository
[ https://issues.apache.org/jira/browse/ZOOKEEPER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698871#action_12698871 ] Todd Greenwood-Geer commented on ZOOKEEPER-224: --- https://issues.apache.org/jira/browse/HADOOP-3305 The hadoop issue(HADOOP-3305) has been resolved, and it appears that hadoop-core has been deployed to maven. Is there any possibility of deploying zookeeper to maven? Deploy ZooKeeper 3.0.0 to a Maven Repository Key: ZOOKEEPER-224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-224 Project: Zookeeper Issue Type: Task Components: build Affects Versions: 3.0.0 Reporter: Hiram Chirino Assignee: Patrick Hunt Priority: Critical I've created the maven poms needed for the 3.0.0 release. The directory structure and artifacts located at: http://people.apache.org/~chirino/zk-repo/ aka people.apache.org:/x1/users/chirino/public_html/zk-repo Just need sto get GPG signed by the project KEY and deployed to: people.apache.org:/www/people.apache.org/repo/m2-ibiblio-rsync-repository Who's the current ZooKeeper release manager? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-337: --- Status: Open (was: Patch Available) improve logging in leader election lookForLeader method when address resolution fails - Key: ZOOKEEPER-337 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337 Project: Zookeeper Issue Type: Improvement Components: quorum Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.2.0 Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch, ZOOKEEPER-337.patch leader election has the following code: requestPacket.setSocketAddress(server.addr); LOG.info(Server address: + server.addr); this should be switched to have the info log first, set sock addr second. The reason for this is that if the setSocketAddress fails sun is not printing the address used. As a result it's verfy difficult to debug this issue. If we log the server address first, then if the setsockaddr fails we'll see both the address of the server and the exception detail (right now we just see the exception detail which does not include the invlaid address in invalidaddressexception). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-337: --- Status: Patch Available (was: Open) resubmitting - already bound address issue in one of the tests (false positive) that I hadn't touched. improve logging in leader election lookForLeader method when address resolution fails - Key: ZOOKEEPER-337 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337 Project: Zookeeper Issue Type: Improvement Components: quorum Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.2.0 Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch, ZOOKEEPER-337.patch leader election has the following code: requestPacket.setSocketAddress(server.addr); LOG.info(Server address: + server.addr); this should be switched to have the info log first, set sock addr second. The reason for this is that if the setSocketAddress fails sun is not printing the address used. As a result it's verfy difficult to debug this issue. If we log the server address first, then if the setsockaddr fails we'll see both the address of the server and the exception detail (right now we just see the exception detail which does not include the invlaid address in invalidaddressexception). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-374) Uninitialized struct variable in C causes warning which is treated as an error
[
https://issues.apache.org/jira/browse/ZOOKEEPER-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698968#action_12698968
]
Patrick Hunt commented on ZOOKEEPER-374:
Interesting, with gcc (Ubuntu 4.3.2-1ubuntu12) 4.3.2
this warning is not output by the compiler. Seems that the newer version
of the compiler is able to determine that auth is only accessed (written/read)
when the following
condition is true:
if(cert!=NULL certLen!=0){
as a result it doesn't complain in this instance on my system.
I'll submit a patch for this to work on older gccs.
Uninitialized struct variable in C causes warning which is treated as an error
--
Key: ZOOKEEPER-374
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-374
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.1.1
Environment: i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc.
build 5490)
Reporter: Nitay Joffe
Priority: Trivial
Fix For: 3.2.0
nitay-joffes-macbook-pro:c nitay$ pwd
/Users/nitay/code/zookeeper/src/c
nitay-joffes-macbook-pro:c nitay$ make
make all-am
/bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
-I./include -I./tests -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo
-MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c'
|| echo './'`src/zookeeper.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests
-I./generated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF
.deps/zookeeper.Tpo -c src/zookeeper.c -fno-common -DPIC -o .libs/zookeeper.o
cc1: warnings being treated as errors
src/zookeeper.c: In function 'zoo_add_auth':
src/zookeeper.c:2378: warning: 'auth.buff' may be used uninitialized in this
function
src/zookeeper.c:2378: warning: 'auth.len' may be used uninitialized in this
function
make[1]: *** [zookeeper.lo] Error 1
make: *** [all] Error 2
Need to set auth.buff and auth.len to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-367) RecoveryTest failure - unreasonable length IOException
[ https://issues.apache.org/jira/browse/ZOOKEEPER-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-367: Status: Patch Available (was: Open) RecoveryTest failure - unreasonable length IOException Key: ZOOKEEPER-367 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-367 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.0 Environment: ubuntu 8.10 intrpid ibex, jvm 1.6.0_10 Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Critical Fix For: 3.2.0 Attachments: invalid1.tar.gz, invalidsnap.tar.gz, rec.tar.gz, rep2.tar.gz, TEST-org.apache.zookeeper.test.RecoveryTest.txt, ZOOKEEPER-367.patch, ZOOKEEPER-367.patch during local testing I received the attached recoverytest failure -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699034#action_12699034 ] Giridharan Kesavan commented on ZOOKEEPER-371: -- Please correct me if I'm wrong. patch contains api for 3.1.1(zookeeper_3.1.1.xml) and tha api-xml target would generate the api doc for 3.2.0(trunk version) This 3.1.1 api doc is required to compare the api changes b/w 3.1.1 and 3.2.0. Thanks, to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699037#action_12699037 ] Mahadev konar commented on ZOOKEEPER-371: - giri, I think what ben meant was -- run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go? to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-371: - Status: Patch Available (was: Open) patch build stuck on hudson for more that 10Hrs. I killed the patch build. Resubmitting the patch to hudson. tnx to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-374) Uninitialized struct variable in C causes warning which is treated as an error
[ https://issues.apache.org/jira/browse/ZOOKEEPER-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-374: -- Assignee: Patrick Hunt Uninitialized struct variable in C causes warning which is treated as an error -- Key: ZOOKEEPER-374 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-374 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.1 Environment: i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490) Reporter: Nitay Joffe Assignee: Patrick Hunt Priority: Trivial Fix For: 3.2.0 Attachments: ZOOKEEPER-374.patch nitay-joffes-macbook-pro:c nitay$ pwd /Users/nitay/code/zookeeper/src/c nitay-joffes-macbook-pro:c nitay$ make make all-am /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fno-common -DPIC -o .libs/zookeeper.o cc1: warnings being treated as errors src/zookeeper.c: In function 'zoo_add_auth': src/zookeeper.c:2378: warning: 'auth.buff' may be used uninitialized in this function src/zookeeper.c:2378: warning: 'auth.len' may be used uninitialized in this function make[1]: *** [zookeeper.lo] Error 1 make: *** [all] Error 2 Need to set auth.buff and auth.len to zero. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
