[jira] Commented: (ZOOKEEPER-376) ant test target re-compiles cppunit code every time
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705924#action_12705924 ] Mahadev konar commented on ZOOKEEPER-376: - what will happen if I change Makefile.am and the old Makefile still exist? Will it just run the old makefile or regenrate the Makefile again? Also, what happens if I change the configure.ac and the old Makefile still exists? These are valid concerns since the patch process will just apply the patch (incase we make a change to just Makefile.am) and since the Makefile will already exist (because of the last build process) we have to make sure that makefile is regenerated... ant test target re-compiles cppunit code every time --- Key: ZOOKEEPER-376 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376 Project: Zookeeper Issue Type: Bug Components: build, c client Affects Versions: 3.2.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.2.0 Attachments: ZOOKEEPER-376.patch Giri, can you take a look at this: 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor) Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-384) keeper exceptions missing path
[ https://issues.apache.org/jira/browse/ZOOKEEPER-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706058#action_12706058 ] Hudson commented on ZOOKEEPER-384: -- Integrated in ZooKeeper-trunk #300 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/300/]) . keeper exceptions missing path (phunt via mahadev) keeper exceptions missing path -- Key: ZOOKEEPER-384 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-384 Project: Zookeeper Issue Type: Bug Components: java client Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.2.0 Attachments: ZOOKEEPER-384.patch keeper exceptions thrown by the java client don't include path, having path helps in debugging. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-237) Add a Chroot request
[ https://issues.apache.org/jira/browse/ZOOKEEPER-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706090#action_12706090 ] Benjamin Reed commented on ZOOKEEPER-237: - could the chroot be done entirely in the client library? it's basically just prepending a prefix to all the requests and stripping the prefix off on watches. Add a Chroot request Key: ZOOKEEPER-237 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-237 Project: Zookeeper Issue Type: New Feature Components: c client, java client, server Reporter: Benjamin Reed Priority: Minor Fix For: 3.2.0 It would be nice to be able to root ZooKeeper handles at specific points in the namespace, so that applications that use ZooKeeper can work in their own rooted subtree. For example, if ops decides that application X can use the subtree /apps/X and application Y can use the subtree /apps/Y, X can to a chroot to /apps/X and then all its path references can be rooted at /apps/X. Thus when X creates the path /myid, it will actually be creating the path /apps/X/myid. There are two ways we can expose this mechanism: 1) We can simply add a chroot(String path) API, or 2) we can integrate into a service identifier scheme for example zk://server1:2181,server2:2181/my/root. I like the second form personally. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-390) zookeeper url scheme
zookeeper url scheme Key: ZOOKEEPER-390 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-390 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed we need a URL scheme for zookeeper. i think such a scheme could encode various forms of server lists as well as chroot. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706097#action_12706097 ] Benjamin Reed commented on ZOOKEEPER-107: - i agree with everything you are saying and yes to all the questions. it's not as strange as it sounds. today we have to pre-populate the cluster config. it would just be that now rather than creating a file with vi we would need to use a utility to create an initial snapshot that has the config in it. i think this would also help with some deployment errors by tightly tying the data with the cluster config. the previously mentioned utility would also allow you to avoid having to start with a single node cluster and growing from there. Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-390) zookeeper url scheme
[ https://issues.apache.org/jira/browse/ZOOKEEPER-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706102#action_12706102 ] Benjamin Reed commented on ZOOKEEPER-390: - I propose that the zookeeper URL has the following forms: zk://host:port,host:port,.../path and zk:URL!/path so if you construct a ZooKeeper object with zk://h1:2181,h2:2181,h3:2181/apps/myapp would create a ZooKeeper object pointed at the cluster made up of h1, h2, and h3 rooted at /apps/myapp. for backwards compatibility if we construct with h1:2181,h2:2181,h3:2181, it will be equivalent to zk://h1:2181,h2:2181,h3:2181/. if the list of hosts that make up the service are stored in the url http://abc.com/zkServers.txt, zk:http://abc.com/zkServers.txt!/ would be used to construct a ZooKeeper object. zookeeper url scheme Key: ZOOKEEPER-390 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-390 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed we need a URL scheme for zookeeper. i think such a scheme could encode various forms of server lists as well as chroot. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706122#action_12706122 ] Mahadev konar commented on ZOOKEEPER-107: - Henry, one thing I would like to point out is that please post a concrete proposal (since this invloves the core internals of zookeeper) before you start working on this, so that their is agreement and no wasted effort... Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-146) Allow clients to retrieve the list of hosts/servers from a URL
[ https://issues.apache.org/jira/browse/ZOOKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-146: -- Assignee: (was: Jakob Homan) Un-assigning myself as it looks like some work is being done and I don't want to appear to be blocking it or such. Will keep watching to see if there is some way I can help out. Allow clients to retrieve the list of hosts/servers from a URL -- Key: ZOOKEEPER-146 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-146 Project: Zookeeper Issue Type: Improvement Components: java client Affects Versions: 3.0.0 Reporter: Jakob Homan Fix For: 3.2.0 Attachments: ZOOKEEPER-146.patch As I suggested in ZOOKEEPER-107, it would be nice to allow clients to specify their hosts strings via a URL so that this can change dynamically. For instance, obtain the current list of hosts from a webpage or a file on disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706219#action_12706219 ] Henry Robinson commented on ZOOKEEPER-107: -- I agree with pretty much everything I've read here, (in particular, the importance of getting consensus!), but wanted to clarify my initial comment a bit. Rather than choose between strategies 1 and 2 as outlined by Benjamin, I think there's a hybrid approach needed. If a node is a member of a quorate cluster, then the most up to date membership information should be available to it in a znode. I think this is the most elegant approach, and is trivially achieved by pushing join/leave requests through the atomic broadcast pipeline. If a node is joining the cluster, it needs to be able to bootstrap the location of the cluster from somewhere. There therefore needs to be a externally available resource containing a list of machines in the cluster that is at least accurate for one machine (as a joining node will try all servers in that list in turn). When I say available at some URI, this is what I mean. Currently, this information is kept statically at a URI that addresses conf/zoo.cfg on the local filesystem. I suggest generalising that to a general URI. One nice property is that it then does not tie a cluster to a particular machine, as the URI provides a level of indirection. It is then the cluster administrator's responsibility to keep this URI up-to-date (although of course this should be automated), possibly via a client that just pulls membership information from the cluster periodically. As I said earlier, it's only important for the contents of this list to have one node in common with the true membership of the cluster, so it's allowed to get a bit out of sync. We can certainly easily imagine ways that ZK can help here. Of course the URI must be highly available, but it also has to exist, otherwise we could have 'orphaned' clusters that are running on machines whose identity we don't necessarily know. The URI can be a front for almost any scheme we like - periodic heartbeating of live nodes is one. The format of this file can be anything at all - from a serialised snapshot to a list of ip:port pairs, as long as it contains enough information for a client to find the cluster. Personally I would prefer human readable, simple formats. To talk about recovery for a moment: when a node recovers from a crash and rejoins the cluster, it can help the cluster elect a master if the cluster is current non-quorate. This is because it was originally part of the cluster, and therefore the protocol guarantees that a quorum of nodes including the recovering one will have seen all committed proposals (this is important to correctness). If the node was not originally a member of the cluster, it must not help get a master elected as it cannot be part of a quorum. Similarly, a node cannot query the cluster to find out if it was originally a member because the quorum required to do so might not exist. Therefore every node that ever successfully joins a cluster must store this fact in its own persistent storage, as only it can know whether it is permitted to help run the election. Finally, the startup problem. Given a URI, nodes can bootstrap themselves onto a cluster simply by being told to start in startup mode. Alternatively, a single node can be distinguished (again, in the URI contents perhaps) which will start in single-node mode and process join requests one-by-one. Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-386) improve java cli shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-386: Status: Patch Available (was: Open) +1 to the patch .. the only nit being that the patch has a large number of formatting changes which makes it hard to read through the changes in the patch. Please make sure you get rid of formatting changes from further on so that its easier to review. improve java cli shell -- Key: ZOOKEEPER-386 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-386 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Henry Robinson Priority: Minor Fix For: 3.2.0 Attachments: jline-0.9.94.jar, patch.txt, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch copied from the following comments by Vegard https://issues.apache.org/jira/browse/ZOOKEEPER-364?focusedCommentId=12696002page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696002 Possible improvements: Default host list to localhost:2181 when not given. Don't print a ton of debug, it looks like both cli_mt and zkCli.sh does this. Make a simple ls that lists subnodes one line at a time and a simple cat that lists only the node content, simple put etc. Shell with gnu readline capabilities and tab completion on node names would be a big improvement of usability during testing and debugging. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-386) improve java cli shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706256#action_12706256 ] Patrick Hunt commented on ZOOKEEPER-386: FYI: in general no gratuitous changes to the formatting. Also tabs are not allowed for indentation. I think what happened here was that there were significant changes to the source. btw Mahadev - you can run svn diff or git diff with the -w option and it will show you the diff with whitespace changes ignored. I find that helpful in these situations. improve java cli shell -- Key: ZOOKEEPER-386 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-386 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Henry Robinson Priority: Minor Fix For: 3.2.0 Attachments: jline-0.9.94.jar, patch.txt, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch copied from the following comments by Vegard https://issues.apache.org/jira/browse/ZOOKEEPER-364?focusedCommentId=12696002page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696002 Possible improvements: Default host list to localhost:2181 when not given. Don't print a ton of debug, it looks like both cli_mt and zkCli.sh does this. Make a simple ls that lists subnodes one line at a time and a simple cat that lists only the node content, simple put etc. Shell with gnu readline capabilities and tab completion on node names would be a big improvement of usability during testing and debugging. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-386) improve java cli shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706257#action_12706257 ] Patrick Hunt commented on ZOOKEEPER-386: afaik hudson bot can't test the patch - there's a separate jar file not part of the patch itself... improve java cli shell -- Key: ZOOKEEPER-386 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-386 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Henry Robinson Priority: Minor Fix For: 3.2.0 Attachments: jline-0.9.94.jar, patch.txt, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch copied from the following comments by Vegard https://issues.apache.org/jira/browse/ZOOKEEPER-364?focusedCommentId=12696002page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696002 Possible improvements: Default host list to localhost:2181 when not given. Don't print a ton of debug, it looks like both cli_mt and zkCli.sh does this. Make a simple ls that lists subnodes one line at a time and a simple cat that lists only the node content, simple put etc. Shell with gnu readline capabilities and tab completion on node names would be a big improvement of usability during testing and debugging. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-386) improve java cli shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706258#action_12706258 ] Mahadev konar commented on ZOOKEEPER-386: - i understand that ... i just want it run through rat and findbugs ... the last patch it pulled was the jar file and not the patch file improve java cli shell -- Key: ZOOKEEPER-386 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-386 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Henry Robinson Priority: Minor Fix For: 3.2.0 Attachments: jline-0.9.94.jar, patch.txt, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch copied from the following comments by Vegard https://issues.apache.org/jira/browse/ZOOKEEPER-364?focusedCommentId=12696002page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696002 Possible improvements: Default host list to localhost:2181 when not given. Don't print a ton of debug, it looks like both cli_mt and zkCli.sh does this. Make a simple ls that lists subnodes one line at a time and a simple cat that lists only the node content, simple put etc. Shell with gnu readline capabilities and tab completion on node names would be a big improvement of usability during testing and debugging. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-386) improve java cli shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706261#action_12706261 ] Henry Robinson commented on ZOOKEEPER-386: -- Formatting comments understood - hopefully I've got Eclipse under control now... improve java cli shell -- Key: ZOOKEEPER-386 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-386 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Henry Robinson Priority: Minor Fix For: 3.2.0 Attachments: jline-0.9.94.jar, patch.txt, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch copied from the following comments by Vegard https://issues.apache.org/jira/browse/ZOOKEEPER-364?focusedCommentId=12696002page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696002 Possible improvements: Default host list to localhost:2181 when not given. Don't print a ton of debug, it looks like both cli_mt and zkCli.sh does this. Make a simple ls that lists subnodes one line at a time and a simple cat that lists only the node content, simple put etc. Shell with gnu readline capabilities and tab completion on node names would be a big improvement of usability during testing and debugging. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-386) improve java cli shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706292#action_12706292 ] Hadoop QA commented on ZOOKEEPER-386: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407297/ZOOKEEPER-386.patch against trunk revision 771563. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/62/testReport/ Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/62/console This message is automatically generated. improve java cli shell -- Key: ZOOKEEPER-386 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-386 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Henry Robinson Priority: Minor Fix For: 3.2.0 Attachments: jline-0.9.94.jar, patch.txt, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch, ZOOKEEPER-386.patch copied from the following comments by Vegard https://issues.apache.org/jira/browse/ZOOKEEPER-364?focusedCommentId=12696002page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696002 Possible improvements: Default host list to localhost:2181 when not given. Don't print a ton of debug, it looks like both cli_mt and zkCli.sh does this. Make a simple ls that lists subnodes one line at a time and a simple cat that lists only the node content, simple put etc. Shell with gnu readline capabilities and tab completion on node names would be a big improvement of usability during testing and debugging. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
