Build failed in Hudson: ZooKeeper-trunk #516
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/516/ -- [...truncated 163860 lines...] [junit] 2009-11-02 10:50:57,000 - INFO [SessionTracker:sessiontrackeri...@143] - SessionTrackerImpl exited loop! [junit] 2009-11-02 10:50:57,005 - INFO [main:zookee...@505] - Closing session: 0x124b484c87d [junit] 2009-11-02 10:50:57,005 - INFO [main:clientc...@1081] - Closing ClientCnxn for session: 0x124b484c87d [junit] 2009-11-02 10:50:57,006 - INFO [ProcessThread:-1:preprequestproces...@384] - Processed session termination request for id: 0x124b484c87d [junit] 2009-11-02 10:50:57,007 - INFO [SyncThread:0:nioserverc...@834] - closing session:0x124b484c87d NIOServerCnxn: java.nio.channels.SocketChannel[connected local=/127.0.0.1:11225 remote=/127.0.0.1:41017] [junit] 2009-11-02 10:50:57,008 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@974] - Exception while closing send thread for session 0x124b484c87d : Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4] [junit] 2009-11-02 10:50:57,108 - INFO [main:clientc...@1067] - Disconnecting ClientCnxn for session: 0x124b484c87d [junit] 2009-11-02 10:50:57,108 - INFO [main:zookee...@513] - Session: 0x124b484c87d closed [junit] 2009-11-02 10:50:57,108 - INFO [main-EventThread:clientcnxn$eventthr...@525] - EventThread shut down [junit] 2009-11-02 10:50:57,109 - INFO [main:clientb...@397] - tearDown starting [junit] 2009-11-02 10:50:57,109 - INFO [main:clientb...@409] - fdcount after test is: 42 [junit] 2009-11-02 10:50:57,109 - INFO [main:zookee...@505] - Closing session: 0x124b484c87d [junit] 2009-11-02 10:50:57,109 - INFO [main:clientc...@1081] - Closing ClientCnxn for session: 0x124b484c87d [junit] 2009-11-02 10:50:57,110 - INFO [main:clientc...@1067] - Disconnecting ClientCnxn for session: 0x124b484c87d [junit] 2009-11-02 10:50:57,110 - INFO [main:zookee...@513] - Session: 0x124b484c87d closed [junit] 2009-11-02 10:50:57,110 - INFO [main:clientb...@374] - STOPPING server [junit] 2009-11-02 10:50:57,110 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@236] - NIOServerCnxn factory exited run method [junit] 2009-11-02 10:50:57,111 - INFO [main:finalrequestproces...@319] - shutdown of request processor complete [junit] 2009-11-02 10:50:57,111 - INFO [SyncThread:0:syncrequestproces...@134] - SyncRequestProcessor exited! [junit] 2009-11-02 10:50:57,111 - INFO [ProcessThread:-1:preprequestproces...@119] - PrepRequestProcessor exited loop! [junit] ensureOnly:[] [junit] 2009-11-02 10:50:57,114 - INFO [main:clientb...@428] - FINISHED testWatcherAutoResetDisabledWithGlobal [junit] 2009-11-02 10:50:57,115 - INFO [main:clientb...@338] - STARTING testWatcherAutoResetDisabledWithLocal [junit] 2009-11-02 10:50:57,120 - INFO [main:clientb...@367] - STARTING server [junit] 2009-11-02 10:50:57,121 - INFO [main:zookeeperser...@160] - Created server [junit] 2009-11-02 10:50:57,121 - INFO [main:nioservercnxn$fact...@122] - binding to port 11226 [junit] 2009-11-02 10:50:57,122 - INFO [main:filetxnsnap...@208] - Snapshotting: 0 [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2009-11-02 10:50:57,124 - INFO [NIOServerCxn.Factory:11226:nioserverc...@699] - Processing stat command from /127.0.0.1:52006 [junit] 2009-11-02 10:50:57,124 - WARN [NIOServerCxn.Factory:11226:nioserverc...@495] - Exception causing close of session 0x0 due to java.io.IOException: Responded to info probe [junit] 2009-11-02 10:50:57,124 - INFO [NIOServerCxn.Factory:11226:nioserverc...@834] - closing session:0x0 NIOServerCnxn: java.nio.channels.SocketChannel[connected local=/127.0.0.1:11226 remote=/127.0.0.1:52006] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2009-11-02 10:50:57,125 - INFO [main:clientb...@359] - Initial fdcount is: 42 [junit] 2009-11-02 10:50:57,126 - INFO [main:clientb...@363] - Client test setup finished [junit] 2009-11-02 10:50:57,126 - INFO [main:zookee...@372] - Initiating client connection, connectString=127.0.0.1:11226 sessionTimeout=5000 watcher=org.apache.zookeeper.test.watchertest$mywatc...@1ca209e [junit] 2009-11-02 10:50:57,126 - INFO [main-SendThread():clientcnxn$sendthr...@880] - Attempting connection to server /127.0.0.1:11226 [junit] 2009-11-02 10:50:57,127 - INFO [main-SendThread(localhost:11226):clientcnxn$sendthr...@796] - Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:52007 remote=localhost/127.0.0.1:11226] [junit] 2009-11-02
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Dudziak updated ZOOKEEPER-537: - Attachment: build.patch The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Dudziak updated ZOOKEEPER-537: - Affects Version/s: (was: 3.2.1) 3.3.0 Status: Patch Available (was: Open) This is a patch to the build.xml in trunk to add the generation of a separate src jar file. The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772642#action_12772642 ] Hadoop QA commented on ZOOKEEPER-537: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423846/build.patch against trunk revision 831486. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 184 release audit warnings (more than the trunk's current 182 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/43/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/43/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/43/console This message is automatically generated. The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-537: --- Status: Open (was: Patch Available) Thomas there are at least a couple of outstanding comments not addressed by this patch, specifically there is interest to not change the existing jar file as it is currently used for those non-maven users.. I put forth the idea to have a separate set of jars for bin/src/jdoc (btw, I don't see the jdoc jar in your patch, isn't that something you had mentioned would be useful?) https://issues.apache.org/jira/browse/ZOOKEEPER-537?focusedCommentId=12761052page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12761052 https://issues.apache.org/jira/browse/ZOOKEEPER-537?focusedCommentId=12763561page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12763561 Do you see an issue with what I'm suggesting? The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772679#action_12772679 ] Mahadev konar commented on ZOOKEEPER-537: - thomas, After reading hiram's comments on this jira, do you still think this is a problem and needs to get fixed? https://issues.apache.org/jira/browse/ZOOKEEPER-537?focusedCommentId=12767931page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12767931 is the link to his comments. The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772680#action_12772680 ] Thomas Dudziak commented on ZOOKEEPER-537: -- @Mahadev: Yes - see my reply above. His comparison to GWT does not apply as afaik you don't typically depend on the GWT builds as libraries. The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772682#action_12772682 ] Thomas Dudziak commented on ZOOKEEPER-537: -- @Patrick: I'll tweak it. The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-519) Followerhandler should close the socket if it gets an exception on a write.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-519:
Status: Patch Available (was: Open)
Followerhandler should close the socket if it gets an exception on a write.
---
Key: ZOOKEEPER-519
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-519
Project: Zookeeper
Issue Type: Bug
Reporter: Mahadev konar
Assignee: Mahadev konar
Fix For: 3.3.0
Attachments: ZOOKEEPER-519.patch
We noticed this in our tests -
{code}
java.net.SocketException: Broken pipe
at java.net.SocketOutputStream.socketWrite0(Native Method)
at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92)
at java.net.SocketOutputStream.write(SocketOutputStream.java:136)
at java.io.BufferedOutputStream.write(BufferedOutputStream.java:105)
at java.io.DataOutputStream.write(DataOutputStream.java:90)
at java.io.FilterOutputStream.write(FilterOutputStream.java:80)
at
org.apache.jute.BinaryOutputArchive.writeBuffer(BinaryOutputArchive.java:122)
at org.apache.zookeeper.server.DataNode.serialize(DataNode.java:126)
at
org.apache.jute.BinaryOutputArchive.writeRecord(BinaryOutputArchive.java:126)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:878)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at org.apache.zookeeper.server.DataTree.serialize(DataTree.java:940)
at
org.apache.zookeeper.server.util.SerializeUtils.serializeSnapshot(SerializeUtils.java:102)
at
org.apache.zookeeper.server.ZooKeeperServer.serializeSnapshot(ZooKeeperServer.java:269)
at
org.apache.zookeeper.server.quorum.FollowerHandler.run(FollowerHandler.java:263)
{code}
So the followerhandler got an exception while writing to the socket but the
follower was still waiting on the socket for a read and got a read timeout
after 60 seconds or so. To just make sure we handle this rightly, we should
close the socket at the followerhandler when we get an excpetion, so that the
follower immediately recognizes that its disconnected from the leader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-519) Followerhandler should close the socket if it gets an exception on a write.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-519:
Attachment: ZOOKEEPER-519.patch
a simple fix. I dont think a test is easy to right for this.
Followerhandler should close the socket if it gets an exception on a write.
---
Key: ZOOKEEPER-519
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-519
Project: Zookeeper
Issue Type: Bug
Reporter: Mahadev konar
Fix For: 3.3.0
Attachments: ZOOKEEPER-519.patch
We noticed this in our tests -
{code}
java.net.SocketException: Broken pipe
at java.net.SocketOutputStream.socketWrite0(Native Method)
at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92)
at java.net.SocketOutputStream.write(SocketOutputStream.java:136)
at java.io.BufferedOutputStream.write(BufferedOutputStream.java:105)
at java.io.DataOutputStream.write(DataOutputStream.java:90)
at java.io.FilterOutputStream.write(FilterOutputStream.java:80)
at
org.apache.jute.BinaryOutputArchive.writeBuffer(BinaryOutputArchive.java:122)
at org.apache.zookeeper.server.DataNode.serialize(DataNode.java:126)
at
org.apache.jute.BinaryOutputArchive.writeRecord(BinaryOutputArchive.java:126)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:878)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at org.apache.zookeeper.server.DataTree.serialize(DataTree.java:940)
at
org.apache.zookeeper.server.util.SerializeUtils.serializeSnapshot(SerializeUtils.java:102)
at
org.apache.zookeeper.server.ZooKeeperServer.serializeSnapshot(ZooKeeperServer.java:269)
at
org.apache.zookeeper.server.quorum.FollowerHandler.run(FollowerHandler.java:263)
{code}
So the followerhandler got an exception while writing to the socket but the
follower was still waiting on the socket for a read and got a read timeout
after 60 seconds or so. To just make sure we handle this rightly, we should
close the socket at the followerhandler when we get an excpetion, so that the
follower immediately recognizes that its disconnected from the leader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-519) Followerhandler should close the socket if it gets an exception on a write.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772723#action_12772723
]
Hadoop QA commented on ZOOKEEPER-519:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423855/ZOOKEEPER-519.patch
against trunk revision 831486.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/44/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/44/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/44/console
This message is automatically generated.
Followerhandler should close the socket if it gets an exception on a write.
---
Key: ZOOKEEPER-519
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-519
Project: Zookeeper
Issue Type: Bug
Reporter: Mahadev konar
Assignee: Mahadev konar
Fix For: 3.3.0
Attachments: ZOOKEEPER-519.patch
We noticed this in our tests -
{code}
java.net.SocketException: Broken pipe
at java.net.SocketOutputStream.socketWrite0(Native Method)
at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92)
at java.net.SocketOutputStream.write(SocketOutputStream.java:136)
at java.io.BufferedOutputStream.write(BufferedOutputStream.java:105)
at java.io.DataOutputStream.write(DataOutputStream.java:90)
at java.io.FilterOutputStream.write(FilterOutputStream.java:80)
at
org.apache.jute.BinaryOutputArchive.writeBuffer(BinaryOutputArchive.java:122)
at org.apache.zookeeper.server.DataNode.serialize(DataNode.java:126)
at
org.apache.jute.BinaryOutputArchive.writeRecord(BinaryOutputArchive.java:126)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:878)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at
org.apache.zookeeper.server.DataTree.serializeNode(DataTree.java:890)
at org.apache.zookeeper.server.DataTree.serialize(DataTree.java:940)
at
org.apache.zookeeper.server.util.SerializeUtils.serializeSnapshot(SerializeUtils.java:102)
at
org.apache.zookeeper.server.ZooKeeperServer.serializeSnapshot(ZooKeeperServer.java:269)
at
org.apache.zookeeper.server.quorum.FollowerHandler.run(FollowerHandler.java:263)
{code}
So the followerhandler got an exception while writing to the socket but the
follower was still waiting on the socket for a read and got a read timeout
after 60 seconds or so. To just make sure we handle this rightly, we should
close the socket at the followerhandler when we get an excpetion, so that the
follower immediately recognizes that its disconnected from the leader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Dudziak updated ZOOKEEPER-537: - Attachment: (was: build.patch) The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Dudziak updated ZOOKEEPER-537: - Attachment: build.patch Updated patch that creates additional -bin, -src, -javadoc jars. The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server sent stats not being updated
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-558: --- Attachment: ZOOKEEPER-558.patch This patch addresses the sent count issue (counter update was missing), additionally I addressed a number of session establishment/teardown issues that I found while fixing this: 1) better logging of session est/teardown, much of this was based on user feedback such as ZOOKEEPER-565 ZOOKEEPER-564 Much of this was cleaning up the log text and using common terminology for the messages themselves 1.1) some of 1) required better error handling. A lot of the changed code was throwing general IOExceptions, rather than throwing more specific exceptions allowing higher layer code to properly report the issue. 2) while closing a client connection the connection close response was not always sent to the client 3) in some cases the server would not close the connection (closeconn buffer was not being queued) properly. this would happen anyway when the client closed the connection, but the server should do the right thing regardless 4) calling close more than once just returns after the first call 5) added testableWaitForShutdown to ZooKeeper to allow tests to validate that the client has shutdown all threads (this is test only) 6) reading a client sockets now reads the entire request in one shot if possible. previously we would re-poll the selector after reading the length header. server sent stats not being updated - Key: ZOOKEEPER-558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.0 Attachments: ZOOKEEPER-558.patch the server and connection sent stat is not being updated. if you run stat on the client port the sent packets is much lower than it should be seems that sendbuffer is not updating the stats when it shortcircuits the send. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server sent stats not being updated
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-558: --- Status: Patch Available (was: Open) server sent stats not being updated - Key: ZOOKEEPER-558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.0 Attachments: ZOOKEEPER-558.patch the server and connection sent stat is not being updated. if you run stat on the client port the sent packets is much lower than it should be seems that sendbuffer is not updating the stats when it shortcircuits the send. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server sent stats not being updated
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772814#action_12772814 ] Hadoop QA commented on ZOOKEEPER-558: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423863/ZOOKEEPER-558.patch against trunk revision 831486. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/45/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/45/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/45/console This message is automatically generated. server sent stats not being updated - Key: ZOOKEEPER-558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.0 Attachments: ZOOKEEPER-558.patch the server and connection sent stat is not being updated. if you run stat on the client port the sent packets is much lower than it should be seems that sendbuffer is not updating the stats when it shortcircuits the send. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-568) SyncRequestProcessor snapping too frequently - counts non-log events as log events
SyncRequestProcessor snapping too frequently - counts non-log events as log events -- Key: ZOOKEEPER-568 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Patrick Hunt Fix For: 3.3.0 Noticed the following issues in SyncRequestProcessor 1) logCount is incremented even for non-log events (say getData) txnlog should return indication if request was logged or not (if hdr ==null it returns) also: 2) move r.nextInt below logCount++ (ie if an actual log event) 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server sent stats not being updated
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-558: --- Status: Open (was: Patch Available) server sent stats not being updated - Key: ZOOKEEPER-558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.0 Attachments: ZOOKEEPER-558.patch the server and connection sent stat is not being updated. if you run stat on the client port the sent packets is much lower than it should be seems that sendbuffer is not updating the stats when it shortcircuits the send. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-568) SyncRequestProcessor snapping too frequently - counts non-log events as log events
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772822#action_12772822 ] Patrick Hunt commented on ZOOKEEPER-568: move traceMask into isTraceEnabled check SyncRequestProcessor snapping too frequently - counts non-log events as log events -- Key: ZOOKEEPER-568 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Patrick Hunt Fix For: 3.3.0 Noticed the following issues in SyncRequestProcessor 1) logCount is incremented even for non-log events (say getData) txnlog should return indication if request was logged or not (if hdr ==null it returns) also: 2) move r.nextInt below logCount++ (ie if an actual log event) 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
