[jira] Commented: (ZOOKEEPER-615) wrong javadoc for create with a sequence flag
[ https://issues.apache.org/jira/browse/ZOOKEEPER-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788818#action_12788818 ] Hadoop QA commented on ZOOKEEPER-615: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427527/ZOOKEEPER-615.patch against trunk revision 888216. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/21/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/21/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/21/console This message is automatically generated. wrong javadoc for create with a sequence flag - Key: ZOOKEEPER-615 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-615 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-615.patch The javadoc for create with a sequence flag mentions a suffix of \_i but the true suffix is just i and no \_. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-617) improve cluster setup documentation in forrest
improve cluster setup documentation in forrest -- Key: ZOOKEEPER-617 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-617 Project: Zookeeper Issue Type: Bug Components: documentation Reporter: Patrick Hunt Fix For: 3.3.0 http://hadoop.apache.org/zookeeper/docs/current/zookeeperAdmin.html#sc_zkMulitServerSetup 1) the config file is missing line returns 2) call out setting up the myid file as it's own bullet, otw it's too easy to miss 3) we should make sure the values we use in examples are consistent, and resonable defaults -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1277#action_1277
]
Mahadev konar commented on ZOOKEEPER-458:
-
it still fails in the same place and with the same back trace:
{quote}
0 0x2adc6886c225 in free () from /lib/libc.so.6
#1 0x004053fb in __gnu_cxx::new_allocatorstd::string::deallocate
(this=0x7fff42e84c88, __p=0x3e7) at
/usr/include/c++/4.3/ext/new_allocator.h:98
#2 0x00405855 in std::_Deque_basestd::string,
std::allocatorstd::string ::_M_deallocate_node (this=0x7fff42e84c88,
__p=0x3e7) at /usr/include/c++/4.3/bits/stl_deque.h:454
#3 0x00405886 in std::_Deque_basestd::string,
std::allocatorstd::string ::_M_destroy_nodes (this=0x7fff42e84c88,
__nstart=0x1854368, __nfinish=0x1854370)
at /usr/include/c++/4.3/bits/stl_deque.h:557
#4 0x0040592b in ~_Deque_base (this=0x7fff42e84c88) at
/usr/include/c++/4.3/bits/stl_deque.h:480
#5 0x004059a8 in ~deque (this=0x7fff42e84c88) at
/usr/include/c++/4.3/bits/stl_deque.h:776
#6 0x004059fa in ~Message (this=0x7fff42e84c80) at
/usr/include/cppunit/Message.h:39
#7 0x004351bc in Zookeeper_simpleSystem::testConnectIndex1
(this=0x184fde0) at /homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:846
#8 0x00431cc6 in CppUnit::TestCallerZookeeper_simpleSystem::runTest
(this=0x1850040) at /usr/include/cppunit/TestCaller.h:166
#9 0x0045bb6a in CppUnit::TestCaseMethodFunctor::operator() ()
#10 0x00466d54 in CppUnit::DefaultProtector::protect ()
#11 0x004685cf in CppUnit::ProtectorChain::protect ()
#12 0x00463622 in CppUnit::TestResult::protect ()
#13 0x0045b92a in CppUnit::TestCase::run ()
#14 0x00469173 in CppUnit::TestComposite::doRunChildTests ()
#15 0x00469096 in CppUnit::TestComposite::run ()
#16 0x00469173 in CppUnit::TestComposite::doRunChildTests ()
#17 0x00469096 in CppUnit::TestComposite::run ()
#18 0x00462e7a in CppUnit::TestResult::runTest ()
#19 0x004653d2 in CppUnit::TestRunner::run ()
#20 0x004047ea in main (argc=1, argv=0x7fff42e85918) at
/homes/mahadev/zookeeper-trunk/src/c/tests/TestDriver.cc:152
{quote}
connect_index in zookeeper handle might get out of bound.
-
Key: ZOOKEEPER-458
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch
connect_index in zookeeper handle might get out of bound. the zokoeeper_init
method checks for index == count and sets it to zero. If the index becomes
greater than count, then it will go out of bounds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-618) hudson not reporting failures correctly
hudson not reporting failures correctly --- Key: ZOOKEEPER-618 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-618 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Priority: Critical See http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/612/ this test failed however there is no indication in the hudson page why it failed. Looking at the raw console output I see [junit] Running org.apache.zookeeper.test.QuorumTest [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec [junit] Test org.apache.zookeeper.test.QuorumTest FAILED (timeout) So it seems there is an error in hudson reporting. Giri can you look into this? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-619) hudson test failure in QuorumTest -- timeout error
hudson test failure in QuorumTest -- timeout error -- Key: ZOOKEEPER-619 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-619 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Patrick Hunt Priority: Critical Fix For: 3.3.0 Hudson is not reporting this correctly but: http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/612/ [junit] 2009-12-03 08:46:27,297 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:11301:leaderelect...@109] - 5 - 2 [junit] Running org.apache.zookeeper.test.QuorumTest [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec [junit] Test org.apache.zookeeper.test.QuorumTest FAILED (timeout) [junit] 2009-12-03 08:46:28,390 - INFO [main:portassignm...@31] - assigning port 11221 [junit] 2009-12-03 08:46:28,393 - INFO [main:portassignm...@31] - assigning port 11222 [junit] Running org.apache.zookeeper.test.QuorumZxidSyncTest but this makes no sense - how is this a timeout? One concern is - perhaps this is a deadlock? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-620) hudson is not reporting compiler warning correctly
hudson is not reporting compiler warning correctly -- Key: ZOOKEEPER-620 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-620 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Fix For: 3.3.0 http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/590/warningsResult/HIGH/ If you click on any of these links you will see that these are not compiler warnings: http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/590/warningsResult/HIGH/file.-1602148846/ Giri can you take a look at these and resolve? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-586) c client does not compile under cygwin
[ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-586: -- Assignee: Patrick Hunt c client does not compile under cygwin -- Key: ZOOKEEPER-586 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch the c client fails to compile under cygwin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Hudson build is back to normal: ZooKeeper-trunk #615
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/615/
Re: [VOTE] Release ZooKeeper 3.2.2 (candidate 1)
+1 Ran Java and Python tests on OS X 10.6 and RHEL5, all pass. (I did discover that the Python tests don't run on Python 2.4 due to the use of 'all', but this is not something that needs fixing for the release). On Wed, Dec 9, 2009 at 9:18 PM, stack st...@duboce.net wrote: +1 Put it under hbase and ran a loading on a small cluster. Completed. Checked out doc. Looks right on cursory glance. St.Ack On Tue, Dec 8, 2009 at 2:32 PM, Patrick Hunt ph...@apache.org wrote: I've created a second candidate build for ZooKeeper 3.2.2. This is a bug fix release addressing 13 issues (three critical) -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 3pm pacific time, Friday, December 11.*** http://people.apache.org/~phunt/zookeeper-3.2.2-candidate-1/http://people.apache.org/%7Ephunt/zookeeper-3.2.2-candidate-1/ http://people.apache.org/%7Ephunt/zookeeper-3.2.2-candidate-1/ Should we release this? Patrick
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789055#action_12789055 ] Steven Cheng commented on ZOOKEEPER-458: I'm out of ideas for now, can't find anything obvious Mahadev, I will think about it some more. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789070#action_12789070
]
Mahadev konar commented on ZOOKEEPER-458:
-
I tried increasing the timer on waitForConnected to 20 seconds on so and it
seems to pass the tests 4-5 times in a row. So does look like a race condition
somewhere.
{code}
bool waitForConnected(zhandle_t *zh) {
-time_t expires = time(0) + 10;
+time_t expires = time(0) + 20;
while(!connected time(0) expires) {
yield(zh, 1);
{code}
But all the other tests work with a timeout of 10 seconds, so I am really
suspicious of the timer being the problem.
connect_index in zookeeper handle might get out of bound.
-
Key: ZOOKEEPER-458
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch
connect_index in zookeeper handle might get out of bound. the zokoeeper_init
method checks for index == count and sets it to zero. If the index becomes
greater than count, then it will go out of bounds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789148#action_12789148 ] Steven Cheng commented on ZOOKEEPER-458: Hmm.. I tried with a lower timeout on my computer and couldn't get the failure. I'll look around the timer stuff. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
