[jira] Updated: (ZOOKEEPER-664) BookKeeper API documentation

2010-02-12 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-664:
-

Assignee: Flavio Paiva Junqueira
  Status: Patch Available  (was: Open)

 BookKeeper API documentation
 

 Key: ZOOKEEPER-664
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-664
 Project: Zookeeper
  Issue Type: Improvement
  Components: contrib-bookkeeper
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-664.patch


 Review and improve BookKeeper API documentation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-664) BookKeeper API documentation

2010-02-12 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-664:
-

Attachment: ZOOKEEPER-664.patch

 BookKeeper API documentation
 

 Key: ZOOKEEPER-664
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-664
 Project: Zookeeper
  Issue Type: Improvement
  Components: contrib-bookkeeper
Reporter: Flavio Paiva Junqueira
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-664.patch


 Review and improve BookKeeper API documentation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-668) Close method in LedgerInputStream doesn't do anything

2010-02-12 Thread Flavio Paiva Junqueira (JIRA)
Close method in LedgerInputStream doesn't do anything
-

 Key: ZOOKEEPER-668
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-668
 Project: Zookeeper
  Issue Type: Bug
Reporter: Flavio Paiva Junqueira
 Fix For: 3.3.0


I think we should remove the close call in LedgerInputStream. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-665) Add BookKeeper streaming documentation

2010-02-12 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-665:
-

Assignee: Flavio Paiva Junqueira
  Status: Patch Available  (was: Open)

 Add BookKeeper streaming documentation 
 ---

 Key: ZOOKEEPER-665
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-665
 Project: Zookeeper
  Issue Type: Improvement
  Components: contrib-bookkeeper
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-665.patch




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-668) Close method in LedgerInputStream doesn't do anything

2010-02-12 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-668:
-

Attachment: ZOOKEEPER-668.patch

Removed the empty method.

 Close method in LedgerInputStream doesn't do anything
 -

 Key: ZOOKEEPER-668
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-668
 Project: Zookeeper
  Issue Type: Bug
Reporter: Flavio Paiva Junqueira
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-668.patch


 I think we should remove the close call in LedgerInputStream. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-668) Close method in LedgerInputStream doesn't do anything

2010-02-12 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-668:
-

Assignee: Flavio Paiva Junqueira
  Status: Patch Available  (was: Open)

 Close method in LedgerInputStream doesn't do anything
 -

 Key: ZOOKEEPER-668
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-668
 Project: Zookeeper
  Issue Type: Bug
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-668.patch


 I think we should remove the close call in LedgerInputStream. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-668) Close method in LedgerInputStream doesn't do anything

2010-02-12 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12833056#action_12833056
 ] 

Benjamin Reed commented on ZOOKEEPER-668:
-

perhaps we should add javadoc stating that the ledger handle will not be 
closed. For example BufferedInputStream.close() closes the underlying stream, 
so there is some ambiguity if we do not close it.

 Close method in LedgerInputStream doesn't do anything
 -

 Key: ZOOKEEPER-668
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-668
 Project: Zookeeper
  Issue Type: Bug
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-668.patch


 I think we should remove the close call in LedgerInputStream. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-635) Server supports listening on a specified network address

2010-02-12 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12833131#action_12833131
 ] 

Benjamin Reed commented on ZOOKEEPER-635:
-

+1 looks good

 Server supports listening on a specified network address
 

 Key: ZOOKEEPER-635
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-635
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.2.1
Reporter: Steve Chu
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-635.patch, ZOOKEEPER-635.patch, 
 ZOOKEEPER-635.patch


 The issue in maililist is located:
 http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200912.mbox/%3c4ac0d28c0912210242g58230a9ds1c55361561c70...@mail.gmail.com%3e
 I have checked the server size code, seems no this option provided. This 
 feature is useful when we have more than two network interfaces, one for 
 Internet and others for intranet. We want to run ZooKeeper in our intranet 
 and not be exposed  to outside world.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-667) java client doesn't allow ipv6 numeric connect string

2010-02-12 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12833137#action_12833137
 ] 

Benjamin Reed commented on ZOOKEEPER-667:
-

requiring the port for ipv6 sounds ok to me. i think we can support both for 
almost free: it turns out that the following are equivalent:

InetAddress.getByName([::1])
InetAddress.getByName(::1)

the trick is that we have not look for a port if there is a ] after the last :

 java client doesn't allow ipv6 numeric connect string
 -

 Key: ZOOKEEPER-667
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-667
 Project: Zookeeper
  Issue Type: Bug
  Components: java client
Affects Versions: 3.2.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0


 The java client doesn't handle ipv6 numeric addresses as they are colon (:) 
 delmited. After splitting the host/port on : we look for the port as the 
 second entry in the array rather than the last entry in the array.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)
watchedevent tostring should clearly output the state/type/path
---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.2, 3.1.2
Reporter: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0


the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-669:
--

Assignee: Patrick Hunt

 watchedevent tostring should clearly output the state/type/path
 ---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.2, 3.2.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0


 the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-670) zkpython leading to segfault on zookeeper server restart

2010-02-12 Thread Lei Zhang (JIRA)
zkpython leading to segfault on zookeeper server restart


 Key: ZOOKEEPER-670
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-670
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.2, 3.2.1
 Environment: CentOS w/ Python 2.4
Reporter: Lei Zhang


Zookeeper client using zkpython segfaults on zookeeper server restart. It is 
reliably reproducible using the attached script zk.py.
I'm able to stop segfault using the attached patch voyager.patch, but zkpython 
seems to have deeper issue on its use of watcher_dispatch - on zookeeper server 
restart, I see up to 6 invocation of watcher_dispatch while my script is simply 
sleeping in the main thread. This can't be right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-670) zkpython leading to segfault on zookeeper server restart

2010-02-12 Thread Lei Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei Zhang updated ZOOKEEPER-670:


Attachment: voyager.patch
zk.py

 zkpython leading to segfault on zookeeper server restart
 

 Key: ZOOKEEPER-670
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-670
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1, 3.2.2
 Environment: CentOS w/ Python 2.4
Reporter: Lei Zhang
 Attachments: voyager.patch, zk.py


 Zookeeper client using zkpython segfaults on zookeeper server restart. It is 
 reliably reproducible using the attached script zk.py.
 I'm able to stop segfault using the attached patch voyager.patch, but 
 zkpython seems to have deeper issue on its use of watcher_dispatch - on 
 zookeeper server restart, I see up to 6 invocation of watcher_dispatch while 
 my script is simply sleeping in the main thread. This can't be right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-670) zkpython leading to segfault on zookeeper server restart

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-670:
---

Priority: Critical  (was: Major)

 zkpython leading to segfault on zookeeper server restart
 

 Key: ZOOKEEPER-670
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-670
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1, 3.2.2
 Environment: CentOS w/ Python 2.4
Reporter: Lei Zhang
Assignee: Henry Robinson
Priority: Critical
 Fix For: 3.3.0

 Attachments: voyager.patch, zk.py


 Zookeeper client using zkpython segfaults on zookeeper server restart. It is 
 reliably reproducible using the attached script zk.py.
 I'm able to stop segfault using the attached patch voyager.patch, but 
 zkpython seems to have deeper issue on its use of watcher_dispatch - on 
 zookeeper server restart, I see up to 6 invocation of watcher_dispatch while 
 my script is simply sleeping in the main thread. This can't be right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-670) zkpython leading to segfault on zookeeper server restart

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-670:
---

Fix Version/s: 3.3.0
 Assignee: Henry Robinson

Henry can you take a look at this one?

 zkpython leading to segfault on zookeeper server restart
 

 Key: ZOOKEEPER-670
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-670
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1, 3.2.2
 Environment: CentOS w/ Python 2.4
Reporter: Lei Zhang
Assignee: Henry Robinson
 Fix For: 3.3.0

 Attachments: voyager.patch, zk.py


 Zookeeper client using zkpython segfaults on zookeeper server restart. It is 
 reliably reproducible using the attached script zk.py.
 I'm able to stop segfault using the attached patch voyager.patch, but 
 zkpython seems to have deeper issue on its use of watcher_dispatch - on 
 zookeeper server restart, I see up to 6 invocation of watcher_dispatch while 
 my script is simply sleeping in the main thread. This can't be right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-669:
---

Attachment: (was: ZOOKEEPER-669.patch)

 watchedevent tostring should clearly output the state/type/path
 ---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.2, 3.2.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-669.patch, ZOOKEEPER-669.patch


 the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-669:
---

Attachment: ZOOKEEPER-669.patch

this patch cleans up tostring and provides all available information

no test change - exercising this method already covered in the test code

 watchedevent tostring should clearly output the state/type/path
 ---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.2, 3.2.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-669.patch, ZOOKEEPER-669.patch


 the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-669:
---

Attachment: ZOOKEEPER-669.patch

this patch cleans up tostring and provides all available information

no test change - exercising this method already covered in the test code

 watchedevent tostring should clearly output the state/type/path
 ---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.2, 3.2.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-669.patch, ZOOKEEPER-669.patch


 the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-669:
---

Comment: was deleted

(was: this patch cleans up tostring and provides all available information

no test change - exercising this method already covered in the test code)

 watchedevent tostring should clearly output the state/type/path
 ---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.2, 3.2.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-669.patch


 the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-669:
---

Comment: was deleted

(was: this patch cleans up tostring and provides all available information

no test change - exercising this method already covered in the test code)

 watchedevent tostring should clearly output the state/type/path
 ---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.2, 3.2.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-669.patch


 the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-669:
---

Attachment: (was: ZOOKEEPER-669.patch)

 watchedevent tostring should clearly output the state/type/path
 ---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.2, 3.2.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-669.patch


 the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path

2010-02-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-669:
---

Status: Patch Available  (was: Open)

 watchedevent tostring should clearly output the state/type/path
 ---

 Key: ZOOKEEPER-669
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.2, 3.1.2
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-669.patch


 the current tostring method is broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.