[jira] Resolved: (ZOOKEEPER-926) Fork Hadoop common's test-patch.sh and modify for Zookeeper

2010-11-09 Thread Nigel Daley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nigel Daley resolved ZOOKEEPER-926.
---

Resolution: Fixed

Committed. Resolving this issue for now.  Open new issues for further 
fixes/enhancements.

 Fork Hadoop common's test-patch.sh and modify for Zookeeper
 ---

 Key: ZOOKEEPER-926
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-926
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Nigel Daley
Assignee: Nigel Daley
 Fix For: 3.4.0

 Attachments: ZOOKEEPER-926.patch


 Zookeeper currently uses the test-patch.sh script from the Hadoop nightly 
 dir.  This is now out of date.  I propose we just copy the updated one in 
 Hadoop common and then modify for ZK.  This will also help as ZK moves out of 
 Hadoop to it's own TLP.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-926) Fork Hadoop common's test-patch.sh and modify for Zookeeper

2010-11-08 Thread Nigel Daley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nigel Daley updated ZOOKEEPER-926:
--

Attachment: ZOOKEEPER-926.patch

Initial patch to replace the old test-patch file.  Further changes will be 
needed.

 Fork Hadoop common's test-patch.sh and modify for Zookeeper
 ---

 Key: ZOOKEEPER-926
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-926
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Nigel Daley
 Attachments: ZOOKEEPER-926.patch


 Zookeeper currently uses the test-patch.sh script from the Hadoop nightly 
 dir.  This is now out of date.  I propose we just copy the updated one in 
 Hadoop common and then modify for ZK.  This will also help as ZK moves out of 
 Hadoop to it's own TLP.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [VOTE] Release ZooKeeper 3.1.0 (candidate 3)

2009-02-09 Thread Nigel Daley

+1.

On Feb 6, 2009, at 2:50 PM, Patrick Hunt wrote:

I've created a new candidate (rc3) that fixes an issue raised by a  
user (thanks Tom!) during review:

https://issues.apache.org/jira/browse/ZOOKEEPER-302
The release notes were also updated to reflect this change.

Otw there are no other changes.

*** Please download, test and VOTE before the
*** vote closes EOD on Wednesday February 11.***

http://people.apache.org/~phunt/zookeeper-3.1.0-candidate-3/

Should we release this?

Patrick





[jira] Created: (ZOOKEEPER-241) Build of a distro fails after clean target is run

2008-11-26 Thread Nigel Daley (JIRA)
Build of a distro fails after clean target is run
-

 Key: ZOOKEEPER-241
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-241
 Project: Zookeeper
  Issue Type: Bug
  Components: build
Affects Versions: 3.0.1
Reporter: Nigel Daley
Priority: Critical


When the ZooKeeper distro is downloaded, if the clean target is run, it deletes 
the .revision file:

{quote}
clean:
  [delete] Deleting directory /home/foo/zookeeper-3.0.1/build
  [delete] Deleting directory /home/foo/zookeeper-3.0.1/src/java/generated
  [delete] Deleting directory /home/foo/zookeeper-3.0.1/src/c/generated
  [delete] Deleting directory /home/foo/zookeeper-3.0.1/.revision
{quote}

This causes subsequent builds in the distro to fail with:

{quote}
compile-main:
   [javac] Compiling 73 source files to /home/foo/zookeeper-3.0.1/build/classes
   [javac] 
/home/foo/zookeeper-3.0.1/src/java/main/org/apache/zookeeper/Version.java:21: 
package org.apache.zookeeper.version does not exist
   [javac] public class Version implements org.apache.zookeeper.version.Info{
   [javac] ^
   ...
{quote}




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



RE: [VOTE] Release ZooKeeper 3.0.1 (candidate 1)

2008-11-26 Thread Nigel Daley

+1.  Signature and MD5 check out.  Unit tests pass.

I filed https://issues.apache.org/jira/browse/ZOOKEEPER-241 but don't  
think it's a blocker for this release (it's not a regression from 3.0)


Nige

On 11/24/08 5:50 PM, Patrick Hunt [EMAIL PROTECTED] wrote:

From: Patrick Hunt [EMAIL PROTECTED]
Date: November 24, 2008 5:50:24 PM PST
To: zookeeper-dev@hadoop.apache.org
Subject: [VOTE] Release ZooKeeper 3.0.1 (candidate 1)


I've created a second candidate build for ZooKeeper 3.0.1.

*** Please download, test and VOTE before the
*** vote closes EOD on Friday, November 28.***

http://people.apache.org/~phunt/zookeeper-3.0.1-candidate-1/

The only change to rc1 from rc0 is adding a missing apache license  
header to a source file:

https://issues.apache.org/jira/browse/ZOOKEEPER-232

Should we release this?

Patrick


Re: [VOTE] Release ZooKeeper 3.0.0 (candidate 0)

2008-10-23 Thread Nigel Daley

+1.  Very nice job for a first release of *Apache* ZooKeeper!

Nige

On Oct 21, 2008, at 11:29 PM, Patrick Hunt wrote:

I've created a candidate build for the first Apache release of  
ZooKeeper - version 3.0.0.


*** Please download, test and VOTE before the
*** vote closes EOD on Friday, October 24.***

http://people.apache.org/~phunt/zookeeper-3.0.0-candidate-0/

Patrick





[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-24 Thread Nigel Daley (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616583#action_12616583
 ] 

Nigel Daley commented on ZOOKEEPER-83:
--

+1 for staying with Ant and creating maven artifacts.

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.