[jira] Commented: (ZOOKEEPER-414) zkServer.sh is duplicated in a couple of places
[ https://issues.apache.org/jira/browse/ZOOKEEPER-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777336#action_12777336 ] Steven Cheng commented on ZOOKEEPER-414: Current list of zkServer.sh files: ./src/contrib/zkpython/src/test/zkServer.sh ./src/contrib/rest/src/test/zkServer.sh ./src/c/tests/zkServer.sh ./src/recipes/queue/src/c/tests/zkServer.sh ./src/recipes/lock/src/c/tests/zkServer.sh ./bin/zkServer.sh All of the extra ones are for testing. Looked into this a bit, main difference between bin/zkServer.sh and the testing scripts is that the testing scripts delete the zookeeper data. I'm guessing that it wouldn't be helpful to have zkServer.sh delete? One option is to create bin/testzkServer.sh that handles the deleting and calls zkServer.sh as needed. Then a conf file just needs to be created and the test suites can be hooked in to the new script. zkServer.sh is duplicated in a couple of places --- Key: ZOOKEEPER-414 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-414 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Mahadev konar Fix For: 3.3.0 we have zkServer.sh in 4 different places. some differ only in whitespace. it would be much more maintainable if there were only one version that everything used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-414) zkServer.sh is duplicated in a couple of places
[ https://issues.apache.org/jira/browse/ZOOKEEPER-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777340#action_12777340 ] Mahadev konar commented on ZOOKEEPER-414: - we should go with the second one. The first one would just be a disaster waiting to happen :). zkServer.sh is duplicated in a couple of places --- Key: ZOOKEEPER-414 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-414 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Mahadev konar Fix For: 3.3.0 we have zkServer.sh in 4 different places. some differ only in whitespace. it would be much more maintainable if there were only one version that everything used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-414) zkServer.sh is duplicated in a couple of places
[ https://issues.apache.org/jira/browse/ZOOKEEPER-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777342#action_12777342 ] Mahadev konar commented on ZOOKEEPER-414: - I meant having a testzkServer.sh that calls zkServer.sh, also we should think about putting the testzkserver.sh in src/java/test and not in bin so that it doesnt cause any confusion for folks. zkServer.sh is duplicated in a couple of places --- Key: ZOOKEEPER-414 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-414 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Mahadev konar Fix For: 3.3.0 we have zkServer.sh in 4 different places. some differ only in whitespace. it would be much more maintainable if there were only one version that everything used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-414) zkServer.sh is duplicated in a couple of places
[ https://issues.apache.org/jira/browse/ZOOKEEPER-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711398#action_12711398 ] Mahadev konar commented on ZOOKEEPER-414: - agreed... . zkServer.sh is duplicated in a couple of places --- Key: ZOOKEEPER-414 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-414 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Mahadev konar Fix For: 3.3.0 we have zkServer.sh in 4 different places. some differ only in whitespace. it would be much more maintainable if there were only one version that everything used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
