[jira] Commented: (ZOOKEEPER-507) Improve error handling of BookKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781816#action_12781816 ] Flavio Paiva Junqueira commented on ZOOKEEPER-507: -- We also need to split this patch into two. There are really two major issue being solved here: new client code and ledger aggregation support. > Improve error handling of BookKeeper client > --- > > Key: ZOOKEEPER-507 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Utkarsh Srivastava > Attachments: ZOOKEEPER-507.patch > > > Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) Improve error handling of BookKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781779#action_12781779 ] Mahadev konar commented on ZOOKEEPER-507: - ben, will you be adding javadocs to the classes? > Improve error handling of BookKeeper client > --- > > Key: ZOOKEEPER-507 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Utkarsh Srivastava > Attachments: ZOOKEEPER-507.patch > > > Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) Improve error handling of BookKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779258#action_12779258 ] Hadoop QA commented on ZOOKEEPER-507: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422953/ZOOKEEPER-507.patch against trunk revision 881623. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 36 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/4/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/4/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/4/console This message is automatically generated. > Improve error handling of BookKeeper client > --- > > Key: ZOOKEEPER-507 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Utkarsh Srivastava > Attachments: ZOOKEEPER-507.patch > > > Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) Improve error handling of BookKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778650#action_12778650 ] Hadoop QA commented on ZOOKEEPER-507: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422953/ZOOKEEPER-507.patch against trunk revision 835618. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 36 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/65/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/65/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/65/console This message is automatically generated. > Improve error handling of BookKeeper client > --- > > Key: ZOOKEEPER-507 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Utkarsh Srivastava > Attachments: ZOOKEEPER-507.patch > > > Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) Improve error handling of BookKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774113#action_12774113 ] Flavio Paiva Junqueira commented on ZOOKEEPER-507: -- One small comment at this point is that we have no lib folder under bookkeeper, and Pat tells me that putting under PROJECT_ROOT/src/java/lib is not ok. So, it doesn't compile without modifying build.xml. I see two options: # We create a bookkeeper/src/java/lib folder and add the netty jar. In this case, we edit build.xml to set its classpath appropriately; # We make it use ivy and fetch from a repository. Another point is that for the new bookie classes, I haven't seen javadocs or comments at all. I think it would be great to have some in there. > Improve error handling of BookKeeper client > --- > > Key: ZOOKEEPER-507 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Utkarsh Srivastava > Attachments: ZOOKEEPER-507.patch > > > Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) Improve error handling of BookKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773639#action_12773639 ] Flavio Paiva Junqueira commented on ZOOKEEPER-507: -- Sorry for the delay, I'll be reviewing this shortly. > Improve error handling of BookKeeper client > --- > > Key: ZOOKEEPER-507 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira > Attachments: ZOOKEEPER-507.patch > > > Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) Improve error handling of BookKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768918#action_12768918 ] Utkarsh Srivastava commented on ZOOKEEPER-507: -- We've been using this modified version of bookkeeper for some time with good results in terms of both stability and performance. This patch incorporates a couple of major changes, so its better reviewed as a whole, rather than as a diff. The two major changes are: i) Rewrite of the client library to deal with error cases, and generally iron out a lot of bugs. ii) Enhancing the bookie server to deal with a large number of open ledgers by multiplexing them into a common number of files. An added dependency is netty, a jboss project for network i/o. Netty is under an Apache 2.0 license, and the jar can be grabbed from http://repository.jboss.com/maven2/org/jboss/netty/netty/3.1.2.GA/netty-3.1.2.GA.jar > Improve error handling of BookKeeper client > --- > > Key: ZOOKEEPER-507 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira > Attachments: ZOOKEEPER-507.patch > > > Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
