[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777878#action_12777878 ] Hudson commented on ZOOKEEPER-550: -- Integrated in ZooKeeper-trunk #536 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/536/]) Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777231#action_12777231 ] Patrick Hunt commented on ZOOKEEPER-550: Good job. Great to see another recipe implemented as part of the release artifact, this will make our user's lives easier! Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776370#action_12776370 ] Mahadev konar commented on ZOOKEEPER-550: - by installing zookeeper library I meant doing a make install and installing it in standard path of your system. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776770#action_12776770 ] Steven Cheng commented on ZOOKEEPER-550: Haven't done a make install yet with zookeeper so that part should be ok, I'll try applying the patch to a fresh checkout Mahadev. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776854#action_12776854 ] Steven Cheng commented on ZOOKEEPER-550: Just tried with a fresh checkout. The recipes depend on the libraries being in src/c which only happens if you run make in that directory. Also src/recipes/lock/src/c/tests/zkServer.sh does not have execute permissions on a fresh checkout, src/recipes/queue/src/c/tests/zkServer.sh also won't have permission because it's in a patch. What would be a good solution to the library issue? I noticed that the c client test builds to build/test/test-cppunit, the recipe tests could get the library from there instead of src/c? Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775327#action_12775327 ] Hadoop QA commented on ZOOKEEPER-550: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424442/ZOOKEEPER-550.patch against trunk revision 833938. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 64 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 192 release audit warnings (more than the trunk's current 186 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/58/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/58/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/58/console This message is automatically generated. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12771513#action_12771513 ] Mahadev konar commented on ZOOKEEPER-550: - cancelling patch to address the above. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770382#action_12770382 ] Hadoop QA commented on ZOOKEEPER-550: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423133/ZOOKEEPER-550.patch against trunk revision 828216. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 60 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 185 release audit warnings (more than the trunk's current 179 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/39/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/39/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/39/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/39/console This message is automatically generated. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768362#action_12768362 ] Hadoop QA commented on ZOOKEEPER-550: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422495/ZOOKEEPER-550.patch against trunk revision 826787. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/35/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/35/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/35/console This message is automatically generated. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768418#action_12768418 ] Steven Cheng commented on ZOOKEEPER-550: Java version seems good, still missing the C version that I'm working on. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768471#action_12768471 ] Mahadev konar commented on ZOOKEEPER-550: - the java patch looks good Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766720#action_12766720 ] Steven Cheng commented on ZOOKEEPER-550: Thank you for the feedback Mahadev: 1) Updated the README.txt 2) I'll revise it to make it more clear. 3) A return is done after the delete in remove() and take(), only the client that deletes the node can return the data, all others will get a NoNodeException. If different exception is thrown then it will exit the method. The loop can only continue if NoNodeExceptions are thrown, these are only thrown when another client has remove()d or take()n the node. 4) The current patch takes in an acl, I mostly copied this handling from the lock recipe, is there more handling I should add? I would like to integrate more of the common pieces of the lock recipe into the queue but I think I will leave this to later. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766749#action_12766749 ] Mahadev konar commented on ZOOKEEPER-550: - bq. 1) Updated the README.txt are you sure you update the README? I could not find the content on ZCONNECTIONLOSS bq. 4) The current patch takes in an acl, I mostly copied this handling from the lock recipe, is there more handling I should add? that should be fine! Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12765848#action_12765848 ] Patrick Hunt commented on ZOOKEEPER-550: I would submit both under this jira (java/c). Doesn't mean someone couldn't provide feedback on the java now though. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12765373#action_12765373 ] Hadoop QA commented on ZOOKEEPER-550: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421903/ZOOKEEPER-550.patch against trunk revision 824981. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/24/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/24/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/24/console This message is automatically generated. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12764764#action_12764764 ] Steven Cheng commented on ZOOKEEPER-550: Thanks, great idea, I'll change it. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12764502#action_12764502 ] Henry Robinson commented on ZOOKEEPER-550: -- Looks good! In offer(...) - would it be better to catch the NoNodeException and create the root then, rather than requiring an RPC every time? Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
