[jira] Commented: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12841812#action_12841812 ] Hudson commented on ZOOKEEPER-579: -- Integrated in ZooKeeper-trunk #715 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/715/]) . zkpython needs more test coverage for ACL code paths (henry via mahadev) zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch, zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12841472#action_12841472 ] Patrick Hunt commented on ZOOKEEPER-579: Mahadev can you take a look at this, are you still experiencing issues in test(s)? zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12836070#action_12836070 ] Hadoop QA commented on ZOOKEEPER-579: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12434938/zookeeper-579.patch against trunk revision 911716. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/66/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/66/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/66/console This message is automatically generated. zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831206#action_12831206 ] Mahadev konar commented on ZOOKEEPER-579: - +1 the patch looks good. ll run zkpython tests and post the results here. henry, you might want to start adding comments to the zookeeper.c file so that its easier for other developers to work on it in case someone wants to pick it up. zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831217#action_12831217 ] Henry Robinson commented on ZOOKEEPER-579: -- It is a problem that the build is considered successful even though tests fail... I should make a new JIRA to fix that. What version of Python are you using? Both of those tests pass fine for me on Python 2.6, but it's possible that this is a version-related error. zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.