[jira] Commented: (ZOOKEEPER-588) remove unnecessary/annoying log of tostring error in Request.toString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12790088#action_12790088 ] Hudson commented on ZOOKEEPER-588: -- Integrated in ZooKeeper-trunk #625 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/]) remove unnecessary/annoying log of tostring error in Request.toString() --- Key: ZOOKEEPER-588 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-588 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-588.patch Why are we logging this? It's unnecessary and just annoying afaict. We should remove it entirely. 2009-11-18 05:37:29,312 WARN org.apache.zookeeper.server.Request: Ignoring exception during toString java.nio.BufferUnderflowException at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:127) at java.nio.ByteBuffer.get(ByteBuffer.java:675) at org.apache.zookeeper.server.Request.toString(Request.java:199) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.server.quorum.CommitProcessor.processRequest(CommitProcessor.java:167) at org.apache.zookeeper.server.quorum.FollowerRequestProcessor.run(FollowerRequestProcessor.java:68) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-588) remove unnecessary/annoying log of tostring error in Request.toString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782057#action_12782057 ] Patrick Hunt commented on ZOOKEEPER-588: I always do that for multi-line conditional, I think it makes it easier to find the block bounds remove unnecessary/annoying log of tostring error in Request.toString() --- Key: ZOOKEEPER-588 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-588 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-588.patch Why are we logging this? It's unnecessary and just annoying afaict. We should remove it entirely. 2009-11-18 05:37:29,312 WARN org.apache.zookeeper.server.Request: Ignoring exception during toString java.nio.BufferUnderflowException at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:127) at java.nio.ByteBuffer.get(ByteBuffer.java:675) at org.apache.zookeeper.server.Request.toString(Request.java:199) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.server.quorum.CommitProcessor.processRequest(CommitProcessor.java:167) at org.apache.zookeeper.server.quorum.FollowerRequestProcessor.run(FollowerRequestProcessor.java:68) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
