[jira] Commented: (ZOOKEEPER-635) Server supports listening on a specified network address
[ https://issues.apache.org/jira/browse/ZOOKEEPER-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836084#action_12836084 ] Hadoop QA commented on ZOOKEEPER-635: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435665/ZOOKEEPER-635.patch against trunk revision 912052. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 44 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/119/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/119/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/119/console This message is automatically generated. > Server supports listening on a specified network address > > > Key: ZOOKEEPER-635 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-635 > Project: Zookeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.2.1 >Reporter: Steve Chu >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-635.patch, ZOOKEEPER-635.patch, > ZOOKEEPER-635.patch > > > The issue in maililist is located: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200912.mbox/%3c4ac0d28c0912210242g58230a9ds1c55361561c70...@mail.gmail.com%3e > I have checked the server size code, seems no this option provided. This > feature is useful when we have more than two network interfaces, one for > Internet and others for intranet. We want to run ZooKeeper in our intranet > and not be exposed to outside world. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-635) Server supports listening on a specified network address
[ https://issues.apache.org/jira/browse/ZOOKEEPER-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833131#action_12833131 ] Benjamin Reed commented on ZOOKEEPER-635: - +1 looks good > Server supports listening on a specified network address > > > Key: ZOOKEEPER-635 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-635 > Project: Zookeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.2.1 >Reporter: Steve Chu >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-635.patch, ZOOKEEPER-635.patch, > ZOOKEEPER-635.patch > > > The issue in maililist is located: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200912.mbox/%3c4ac0d28c0912210242g58230a9ds1c55361561c70...@mail.gmail.com%3e > I have checked the server size code, seems no this option provided. This > feature is useful when we have more than two network interfaces, one for > Internet and others for intranet. We want to run ZooKeeper in our intranet > and not be exposed to outside world. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-635) Server supports listening on a specified network address
[ https://issues.apache.org/jira/browse/ZOOKEEPER-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831162#action_12831162 ] Benjamin Reed commented on ZOOKEEPER-635: - i think clientPortBindAddress is good. it's kind of confusing to have two variables that do the same thing, especially since people are used to using ip addresses and hostnames interchangably. for the test i would use NetworkInterface.getInterfaces and use IP addresses. > Server supports listening on a specified network address > > > Key: ZOOKEEPER-635 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-635 > Project: Zookeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.2.1 >Reporter: Steve Chu >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-635.patch, ZOOKEEPER-635.patch > > > The issue in maililist is located: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200912.mbox/%3c4ac0d28c0912210242g58230a9ds1c55361561c70...@mail.gmail.com%3e > I have checked the server size code, seems no this option provided. This > feature is useful when we have more than two network interfaces, one for > Internet and others for intranet. We want to run ZooKeeper in our intranet > and not be exposed to outside world. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-635) Server supports listening on a specified network address
[ https://issues.apache.org/jira/browse/ZOOKEEPER-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831011#action_12831011 ] Patrick Hunt commented on ZOOKEEPER-635: I wrote the docs first, then during impl noticed that the two funnel down to the same code. I thought about it a bit and convinced myself that having two variable made it more understandable to the user, so I didn't change it from my original approach. I could go either way though. What would you call it if there's just one? clientPortBindAddress and just spec in the docs that it's either ip addr or name? Re the testing I was concerned that I could not get reproduceable tests if I tried tying it to a particular interface. Do you know (think of) a bulletproof approach? Something that will work in all cases, incl ipv6 (esp where the hosts file might cause problems) > Server supports listening on a specified network address > > > Key: ZOOKEEPER-635 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-635 > Project: Zookeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.2.1 >Reporter: Steve Chu >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-635.patch, ZOOKEEPER-635.patch > > > The issue in maililist is located: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200912.mbox/%3c4ac0d28c0912210242g58230a9ds1c55361561c70...@mail.gmail.com%3e > I have checked the server size code, seems no this option provided. This > feature is useful when we have more than two network interfaces, one for > Internet and others for intranet. We want to run ZooKeeper in our intranet > and not be exposed to outside world. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-635) Server supports listening on a specified network address
[ https://issues.apache.org/jira/browse/ZOOKEEPER-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803432#action_12803432 ] Hadoop QA commented on ZOOKEEPER-635: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431052/ZOOKEEPER-635.patch against trunk revision 901510. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/48/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/48/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/48/console This message is automatically generated. > Server supports listening on a specified network address > > > Key: ZOOKEEPER-635 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-635 > Project: Zookeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.2.1 >Reporter: Steve Chu >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-635.patch, ZOOKEEPER-635.patch > > > The issue in maililist is located: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200912.mbox/%3c4ac0d28c0912210242g58230a9ds1c55361561c70...@mail.gmail.com%3e > I have checked the server size code, seems no this option provided. This > feature is useful when we have more than two network interfaces, one for > Internet and others for intranet. We want to run ZooKeeper in our intranet > and not be exposed to outside world. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-635) Server supports listening on a specified network address
[ https://issues.apache.org/jira/browse/ZOOKEEPER-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803410#action_12803410 ] Hadoop QA commented on ZOOKEEPER-635: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431049/ZOOKEEPER-635.patch against trunk revision 901510. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/46/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/46/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/46/console This message is automatically generated. > Server supports listening on a specified network address > > > Key: ZOOKEEPER-635 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-635 > Project: Zookeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.2.1 >Reporter: Steve Chu >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-635.patch > > > The issue in maililist is located: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200912.mbox/%3c4ac0d28c0912210242g58230a9ds1c55361561c70...@mail.gmail.com%3e > I have checked the server size code, seems no this option provided. This > feature is useful when we have more than two network interfaces, one for > Internet and others for intranet. We want to run ZooKeeper in our intranet > and not be exposed to outside world. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
