[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909607#action_12909607 ] Hudson commented on ZOOKEEPER-733: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899047#action_12899047 ] Patrick Hunt commented on ZOOKEEPER-733: Ben, did you make changes to allow the max worker limit to be configured? If so can you either update the patch or create a new jira with the changes? use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899101#action_12899101 ] Benjamin Reed commented on ZOOKEEPER-733: - we should commit the patch as is. trying to add features to it and maintain the patch fresh is too unwieldy! use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899141#action_12899141 ] Patrick Hunt commented on ZOOKEEPER-733: That's fine, but in that case create a JIRA to track (if you have a patch all the better), so we don't lose the thought. thanks. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[
https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12896996#action_12896996
]
Sergey Doroshenko commented on ZOOKEEPER-733:
-
I noticed that NettyServerCnxn class contains big copy-paste of all 4-letter
commands and checkFourLetterWord method is also almost identical to one in
NIOServerCnxn. The only difference is:
1) commands in NettyCnxn don't extendThread
2) checkFourLetterWord methods differ in I/O a bit. But big if (len==someCmd)
{ start someCmd } part is the same.
So, questions:
1) is there any practical reason for commands in NIOCnxn being Threads? If no,
they are identical with ones from NettyCnxn, so we could move all commands to
ServerCnxn superclass
2) big part of checkFourLetterWord (IO-unrelated one, described above) could
also be moved to superclass
use netty to handle client connections
--
Key: ZOOKEEPER-733
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733
Project: Zookeeper
Issue Type: Improvement
Components: server
Reporter: Benjamin Reed
Assignee: Patrick Hunt
Fix For: 3.4.0
Attachments: accessive.jar, flowctl.zip, moved.zip,
QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch,
ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch,
ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch,
ZOOKEEPER-733.patch, ZOOKEEPER-733.patch
we currently have our own asynchronous NIO socket engine to be able to handle
lots of clients with a single thread. over time the engine has become more
complicated. we would also like the engine to use multiple threads on
machines with lots of cores. plus, we would like to be able to support things
like SSL. if we switch to netty, we can simplify our code and get the
previously mentioned benefits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894667#action_12894667 ] Hadoop QA commented on ZOOKEEPER-733: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449497/ZOOKEEPER-733.patch against trunk revision 980576. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 68 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/100/console This message is automatically generated. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893025#action_12893025 ] Benjamin Reed commented on ZOOKEEPER-733: - i ran this on 40 machines simulating 900 clients. the benchmark went well without problems. the results don't show any real significant performance improvements (or degradations). use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893027#action_12893027 ] Jeff Hammerbacher commented on ZOOKEEPER-733: - Hey Ben, One motivation for the move to Netty was performance-related: bq. we would also like the engine to use multiple threads on machines with lots of cores. Did your benchmarks run on a machine with multiple cores? Any evidence of utilization of multiple cores would be of interest to me. Thanks, Jeff use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12889909#action_12889909 ] Patrick Hunt commented on ZOOKEEPER-733: while testing I did notice a problem - closed client connections are staying in time_wait state for a long period of time. this test was done by starting the server, then connecting a java NIO based client using the shell, then quitting the shell using quit. Is this the shell or Netty? In netty factory we are setting the linger time to 2 sec, however this doesn't seem to be used? According to netstat the socket is held in time_wait for much longer than 2 sec. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888562#action_12888562 ] Hadoop QA commented on ZOOKEEPER-733: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449488/ZOOKEEPER-733.patch against trunk revision 963957. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 73 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/145/console This message is automatically generated. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888597#action_12888597 ] Hadoop QA commented on ZOOKEEPER-733: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449497/ZOOKEEPER-733.patch against trunk revision 963957. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 68 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/146/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/146/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/146/console This message is automatically generated. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12878607#action_12878607 ] Kapil Thangavelu commented on ZOOKEEPER-733: Hi folks, I just wanted to note that we're really interested in the netty integration esp. to allow for secure communications. We don't have much by way of java developers, but we are available to help out with testing. We've successfully run our client test suite against the netty patch applied to trunk. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12878631#action_12878631 ] Patrick Hunt commented on ZOOKEEPER-733: Great, thanks for the fb Kapil. There's still one serious issue that we know about with the patch, it's due to the way netty handles buffering. Our old server nio code does flow control by disabling read on the inbound sockets, but netty aggressively buffers which means that the data's already been read by the time we disable read. We're working on a solution for that. Subsequently we'll have some addl work re documentation and such. Also need to test out encryption (ssl) support on the channels. It's in progress but I've been distracted by other things (incl the upcoming summit). After that we also need to add netty support on the java client side, I'm not sure what we'll do on the c client (to add ssl encrypt/cert support) but if you have any ideas on that we'd appreciate the help. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Attachments: accessive.jar, flowctl.zip, moved.zip, QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[
https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873097#action_12873097
]
Patrick Hunt commented on ZOOKEEPER-733:
Ben that fixes SessionTest for me, but not QuorumTest. I modified QT to use
that same mechanism but it still fails.
For some reason the new session (using existing sessionid/pass) gets a moved
exception. Note that these clients are connecting to diff servers. Perhaps
that's the issue (timing)?
{noformat}
2010-05-28 11:10:25,419 - INFO [main:junit4zktestrunner$loggedinvokemet...@49]
- RUNNING TEST METHOD testSessionMoved
2010-05-28 11:10:25,420 - INFO [main:zookee...@375] - Initiating client
connection, connectString=127.0.0.1:11354 sessionTimeout=3
watcher=org.apache.zookeeper.test.quorumtes...@5c1d29c1
2010-05-28 11:10:25,421 - INFO [main-SendThread():clientcnxn$sendthr...@1007]
- Opening socket connection to server /127.0.0.1:11354
2010-05-28 11:10:25,442 - INFO
[main-SendThread(localhost:11354):clientcnxn$sendthr...@915] - Socket
connection established to localhost/127.0.0.1:11354, initiating session
2010-05-28 11:10:25,443 - INFO [New I/O server worker
#51-1:zookeeperser...@795] - Client attempting to establish new session at
/127.0.0.1:41741
2010-05-28 11:10:25,463 - WARN [QuorumPeer:0.0.0.0/0.0.0.0:11354:follo...@120]
- Got zxid 0x10001 expected 0x1
2010-05-28 11:10:25,465 - WARN [QuorumPeer:0.0.0.0/0.0.0.0:11357:follo...@120]
- Got zxid 0x10001 expected 0x1
2010-05-28 11:10:25,492 - WARN [QuorumPeer:0.0.0.0/0.0.0.0:11355:follo...@120]
- Got zxid 0x10001 expected 0x1
2010-05-28 11:10:25,493 - WARN [QuorumPeer:0.0.0.0/0.0.0.0:11356:follo...@120]
- Got zxid 0x10001 expected 0x1
2010-05-28 11:10:25,625 - INFO [CommitProcessor:1:zookeeperser...@571] -
Established session 0x128e01b97ab with negotiated timeout 3 for client
/127.0.0.1:41741
2010-05-28 11:10:25,625 - INFO
[main-SendThread(localhost:11354):clientcnxn$sendthr...@685] -
readConnectRestult 36
0x[0,0,0,0,0,0,75,30,1,28,ffe0,1b,ff97,ffab,0,0,0,0,0,10,ffd7,ffe2,ffd1,39,18,fff1,fff3,ff8c,d,3,ff9a,ffe8,21,43,ffef,13,]
2010-05-28 11:10:25,625 - INFO
[main-SendThread(localhost:11354):clientcnxn$sendthr...@708] - Session
establishment complete on server localhost/127.0.0.1:11354, sessionid =
0x128e01b97ab, negotiated timeout = 3
2010-05-28 11:10:25,647 - INFO [main:zookee...@438] - Initiating client
connection, connectString=127.0.0.1:11355 sessionTimeout=3
watcher=org.apache.zookeeper.test.quorumtes...@1cacd5d4
sessionId=128e01b97ab sessionPasswd=hidden
2010-05-28 11:10:25,648 - INFO [main-SendThread():clientcnxn$sendthr...@1007]
- Opening socket connection to server /127.0.0.1:11355
2010-05-28 11:10:25,649 - INFO
[main-SendThread(localhost:11355):clientcnxn$sendthr...@915] - Socket
connection established to localhost/127.0.0.1:11355, initiating session
2010-05-28 11:10:25,650 - INFO [New I/O server worker
#52-2:zookeeperser...@788] - Client attempting to renew session
0x128e01b97ab at /127.0.0.1:45500
2010-05-28 11:10:25,654 - INFO [ProcessThread:-1:preprequestproces...@405] -
Got user-level KeeperException when processing sessionid:0x128e01b97ab
type:setData cxid:0x1 zxid:0xfffe txntype:unknown reqpath:/ Error
Path:null Error:KeeperErrorCode = Session moved
2010-05-28 11:10:25,691 - INFO
[main-SendThread(localhost:11355):clientcnxn$sendthr...@1125] - Unable to read
additional data from server sessionid 0x128e01b97ab, likely server has
closed socket, closing socket connection and attempting reconnect
2010-05-28 11:10:25,692 - INFO [CommitProcessor:2:nettyserverc...@73] - close
128e01b97ab
2010-05-28 11:10:25,692 - INFO [CommitProcessor:2:nettyserverc...@80] - close
in progress 128e01b97ab
2010-05-28 11:10:25,794 - INFO [main:junit4zktestrunner$loggedinvokemet...@53]
- TEST METHOD FAILED testSessionMoved
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode =
ConnectionLoss for /
at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1127)
at
org.apache.zookeeper.test.QuorumTest.testSessionMoved(QuorumTest.java:204)
{noformat}
line 204 for me is
zknew.setData(/, new byte[1], -1);
use netty to handle client connections
--
Key: ZOOKEEPER-733
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733
Project: Zookeeper
Issue Type: Improvement
Reporter: Benjamin Reed
Attachments: accessive.jar, moved.zip, ZOOKEEPER-733.patch,
ZOOKEEPER-733.patch
we currently have our own
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872281#action_12872281 ] Benjamin Reed commented on ZOOKEEPER-733: - i figured out the timing issue for ACLTest. if you look at how NIOServerCnxn handles the readConnectRequest, you will notice that it disables the receipt of packets until the connect request is processed successfully. if you do that with netty, the ACLTest should work. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Attachments: accessive.jar, moved.zip, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
