[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909610#action_12909610 ] Hudson commented on ZOOKEEPER-775: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909619#action_12909619 ] Sudipto Das commented on ZOOKEEPER-775: --- I am traveling and will return on Sept 21st. I will be away from my email for most of the period. I will get back whenever I get a chance. -- Best Regards Sudipto -- Sudipto Das PhD Candidate CS @ UCSB Santa Barbara, CA 93106, USA http://www.cs.ucsb.edu/~sudipto A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12900507#action_12900507 ] Patrick Hunt commented on ZOOKEEPER-775: Awesome job everyone, really psyched to see this get in! A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899797#action_12899797 ] Ivan Kelly commented on ZOOKEEPER-775: -- 1. You can't convey executableness in a patch afaik, but when this is to be submitted the submitter shall do it. 2. I think just specifying that protobuf is needed should be enough. Many linux distros already package it. 3. We're currently looking into the tr1 issue. We've hit across this issue with some older distros, but this should all be available from gcc 4.0 onwards, which is 3 years old. The optional use of boost is an option we will be looking into though. 4. I prefer the all lower case for c++ code, as this is generally the approach most open source projects take. For example, everything in /usr/include/c++ is lowercase. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[
https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899930#action_12899930
]
Mahadev konar commented on ZOOKEEPER-775:
-
also,
should I remove this file:
{code}
client/src/main/cpp/ltmain.sh
{code}
what about licensing on these files
{code}
client/src/main/cpp/m4
client/src/main/cpp/m4/ax_doxygen.m4
client/src/main/cpp/m4/ax_jni_include_dir.m4
{code}
is it ok to distribute them via apache?
A large scale pub/sub system
Key: ZOOKEEPER-775
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775
Project: Zookeeper
Issue Type: New Feature
Components: contrib
Reporter: Benjamin Reed
Assignee: Benjamin Reed
Fix For: 3.4.0
Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch,
ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch,
ZOOKEEPER-775_3.patch
we have developed a large scale pub/sub system based on ZooKeeper and
BookKeeper.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899939#action_12899939 ] Ivan Kelly commented on ZOOKEEPER-775: -- p12.pass is needed for testing, it's something to do with setting up ssl on the server. ltmain.sh has already been removed from internal svn. ax_doxygen.m4 has a license: # # Copyright (c) 2009 Oren Ben-Kiki o...@ben-kiki.org # # Copying and distribution of this file, with or without modification, are # permitted in any medium without royalty provided the copyright notice # and this notice are preserved. This file is offered as-is, without any # warranty. ax_jni_include_dir.m4 should be removed. Ill probably do a submission tonight for other reasons, so ill remove it at that stage. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12900093#action_12900093 ] Erwin Tam commented on ZOOKEEPER-775: - Mahadev, we've been using the internal hedwig/apache svn branch for making changes, at least until things are committed to Apache's SVN. You can grab the latest changes there and incorporate them perhaps with your modifications. http://svn.corp.yahoo.com/view/yahoo/yrl/hedwig/apache/ Ivan is correct, the p12.pass file is just a dummy password file used for testing SSL connections between client and server. We need that otherwise the unit tests would fail. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899724#action_12899724 ] Michi Mutsuzaki commented on ZOOKEEPER-775: --- ## scripts/ directory - Some scripts under ./scripts don't have the executable bit set. - I prefer not to use file extension (analyze instead of analyze.py). We might decide to use some other language later on. ## doc/ directory - Add instruction to set up local maven repository in build.txt: $ mkdir -p $HOME/.m2/repository $ export M2_REPO=$HOME/.m2/repository - Add instruction to install protobuf in build.txt. wget http://protobuf.googlecode.com/files/protobuf-2.3.0.tar.gz tar xfvz protobuf-2.3.0.tar.gz cd protobuf-2.3.0 ./configure ; make ; sudo make install cd java mvn install ## client directory - I couldn't compile cpp client. we should use a compile time flag to check whether tr1 is available, and if not, fall back to boost. This page describes how to do that: http://www.codesynthesis.com/~boris/blog/2010/05/24/smart-pointers-in-boost-tr1-cxx-x0/ If this is too much hassle, maybe we can just use boost instead of tr1 for now. - Should the c++ client follow the same naming convention as java for file names (publisherimpl.h vs PublisherImpl.h)? A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897194#action_12897194 ] Ivan Kelly commented on ZOOKEEPER-775: -- I've removed ltmain.sh from the svn repo. The patch builds fine on trunk, but I did have some problems running the tests which I resolved by upping the file descriptor limits. testOwnershipChange(org.apache.hedwig.server.topics.TestZkTopicManager) seems to be failing consistently. C++ client builds. Some work still needs to be done to make testing it easier (requires a manual start of a server control daemon currently). These are fairly minor things, and I think it's more important to get hedwig into trunk. So... +1 A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897581#action_12897581 ] Benjamin Reed commented on ZOOKEEPER-775: - i believe the NOTICE file is consistent with: http://apache.org/legal/src-headers.html#header-existingcopyright A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[
https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897121#action_12897121
]
Mahadev konar commented on ZOOKEEPER-775:
-
also, you might want to get rid of this:
{code}
+% Developer's Guide
+% Yang Zhang
{code}
in src/contrib/hedwig/doc/dev.txt
Other than that this looks good.
One question about protobufs, is it apache license? What all are we committing
in zookeeper svn thats related to protobufs?
A large scale pub/sub system
Key: ZOOKEEPER-775
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775
Project: Zookeeper
Issue Type: New Feature
Components: contrib
Reporter: Benjamin Reed
Assignee: Benjamin Reed
Fix For: 3.4.0
Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch,
ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch,
ZOOKEEPER-775_3.patch
we have developed a large scale pub/sub system based on ZooKeeper and
BookKeeper.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897122#action_12897122 ] Mahadev konar commented on ZOOKEEPER-775: - sorry I am reviewing and making sure I am uploading my comments, it would have been better for me to write it down in a file and then uploaded at the same time :). - make sure that you list the files which need to be executable in svn. While committing the svn executable flag is usually lost. So, you will have to provide with a list of files that need to have special svn flags. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897126#action_12897126 ] Mahadev konar commented on ZOOKEEPER-775: - one more comment :) - we are checking in some autogenerated files like ltmain.sh and others. Why do we need tocommit those? A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894666#action_12894666 ] Hadoop QA commented on ZOOKEEPER-775: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450515/ZOOKEEPER-775.patch against trunk revision 980576. -1 @author. The patch appears to contain 14 @author tags which the ZooKeeper community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 143 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 32 release audit warnings (more than the trunk's current 18 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/99/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/99/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/99/console This message is automatically generated. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892803#action_12892803 ] Mahadev konar commented on ZOOKEEPER-775: - erwin/ben, Would it be possible for you to convert the documentation into forrest? Documentaiton as part of the release and accessible via website docs will really help adoption of hedwig. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892860#action_12892860 ] Benjamin Reed commented on ZOOKEEPER-775: - can we do the forrest doc as a separate patch? it's already quite large as it is. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12875487#action_12875487 ] Hadoop QA commented on ZOOKEEPER-775: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446057/libs_2.zip against trunk revision 947063. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/113/console This message is automatically generated. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[
https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874119#action_12874119
]
Patrick Hunt commented on ZOOKEEPER-775:
My initial feedback:
The build fails with proto buff errors. I already have protobuf installed for
other reasons, can't mvn pull down the protobuf version it needs vs relying on
the system wide libs?
Including the bk/zk jar files in server/lib is a really bad practice. Why do we
have to do this vs using versions built from the current tree? If we have to do
ths we should also indicate that this is not a release version - typically in
mvn this means putting something like SNAPSHOT into the name of the jars.
The README should have a tiny bit of text describing, at a very high level,
what hedwig is.
The contents of the scripts directory are not executable by default, we should
either fix this in the patch or note it for committer to fix at commit time.
ZooKeeperTestBase.java has windows eol characters. Perhaps run dos2unix on all
the files and refresh the patch? (looks like all the tests suffer from this?)
RAT identified the following files which seem like they should have license
headers added:
{quote}
./formatter.xml
./pom.xml
./client/pom.xml
./client/src/main/cpp/Makefile
./client/src/main/cpp/log4cpp.conf
./client/src/main/resources/log4j.properties
./doc/build.txt
./doc/dev.txt
./doc/doc.txt
./doc/user.txt
./protocol/Makefile
./protocol/pom.xml
./protocol/src/main/protobuf/PubSubProtocol.proto
./scripts/analyze.py
./scripts/hw.bash
./scripts/quote
./server/pom.xml
{quote}
A large scale pub/sub system
Key: ZOOKEEPER-775
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775
Project: Zookeeper
Issue Type: New Feature
Components: contrib
Reporter: Benjamin Reed
Assignee: Benjamin Reed
Fix For: 3.4.0
Attachments: libs.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch
we have developed a large scale pub/sub system based on ZooKeeper and
BookKeeper.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874137#action_12874137 ] Benjamin Reed commented on ZOOKEEPER-775: - i would like to fix the build once we have it in the subversion repository. should i just remove the README? i'm not sure it is worth expanding since it would duplicate text in the docs directory i'll fix the scripts and the dos2unix with respect to the headers, i notice that configs, docs, and Makefiles don't have the license header in the zk repository, which leaves: ./pom.xml ./client/pom.xml ./protocol/pom.xml ./protocol/src/main/protobuf/PubSubProtocol.proto ./scripts/analyze.py ./scripts/hw.bash ./scripts/quote ./server/pom.xml is it okay if i just do those? A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874160#action_12874160 ] Patrick Hunt commented on ZOOKEEPER-775: bq. i would like to fix the build once we have it in the subversion repository. by this I take it you mean removing the libs? Ok, but we should name the lib jars with SNAPSHOT as part of the initial commit to avoid any confusion (that's not a problem, right?) bq. readme It's good to have the readme even if it's a bit short/duplicative. Provides a common hook for new users. bq. licenses rat found all that, what you are suggesting is inline with core, so those exceptions sound fine. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Assignee: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872219#action_12872219 ] Ivan Kelly commented on ZOOKEEPER-775: -- This patch doesn't include the ssl cert server.p12 as it's binary. This causes some tests to fail. Perhaps you should add it to libs.zip? A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871274#action_12871274 ] Hadoop QA commented on ZOOKEEPER-775: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445481/libs.zip against trunk revision 947063. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/106/console This message is automatically generated. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868549#action_12868549 ] Patrick Hunt commented on ZOOKEEPER-775: Ben you planning to make these changes or looking for help? (package/build), anything else that needs to be done that you know of? A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Fix For: 3.4.0 Attachments: hedwig.tar.gz we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868732#action_12868732 ] Benjamin Reed commented on ZOOKEEPER-775: - sorry, i should have listed the todos: 1) we need to agree on a package name. i propose org.apache.hedwig. i can fix the package references when we decide. (the package is currently in the com.yahoo namespace) 2) we need to figure out where to put it. i'm assuming contrib/hedwig 3) finally, we need to integrate into the build. this is a bit harder for me. we currently build hedwig with maven pulling zookeeper and bookkeeper from repositories. i'm not sure how to integrate into our current zookeeper build. so, if some one could take this last one, i would appreciate it. A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Fix For: 3.4.0 Attachments: hedwig.tar.gz we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868740#action_12868740 ] Patrick Hunt commented on ZOOKEEPER-775: bq. 1) we need to agree on a package name. i propose org.apache.hedwig. i can fix the package references when we decide. (the package is currently in the com.yahoo namespace) sounds good (similar to what we did with bk) bq. 2) we need to figure out where to put it. i'm assuming contrib/hedwig agree bq. 3) finally, we need to integrate into the build. this is a bit harder for me. we currently build hedwig with maven pulling zookeeper and bookkeeper from repositories. i'm not sure how to integrate into our current zookeeper build. so, if some one could take this last one, i would appreciate it. why don't we punt on this for now. just add a README.txt that explains that maven is used for the build. we can support maven for build/dev now and at some point add a simple build.xml that handles the packaging for the release. (if you agree add a JIRA for this task (build.xml) assigned to 3.4.0) A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Fix For: 3.4.0 Attachments: hedwig.tar.gz we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
