[jira] Commented: (ZOOKEEPER-788) Add server id to message logs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880122#action_12880122 ] Hadoop QA commented on ZOOKEEPER-788: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447440/ZOOKEEPER-778.patch against trunk revision 953041. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/86/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/86/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/86/console This message is automatically generated. Add server id to message logs - Key: ZOOKEEPER-788 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-788 Project: Zookeeper Issue Type: Improvement Components: contrib Affects Versions: 3.3.1 Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Trivial Fix For: 3.4.0 Attachments: ZOOKEEPER-778.patch As discussed on IRC. The log visualisation needs some way of determining which server made which log. If the log segment is taken for a time period where no elections take place, there is no way to determine the id of the server. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-788) Add server id to message logs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880163#action_12880163 ] Flavio Paiva Junqueira commented on ZOOKEEPER-788: -- +1, looks good for me. Add server id to message logs - Key: ZOOKEEPER-788 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-788 Project: Zookeeper Issue Type: Improvement Components: contrib Affects Versions: 3.3.1 Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Trivial Fix For: 3.4.0 Attachments: ZOOKEEPER-778.patch As discussed on IRC. The log visualisation needs some way of determining which server made which log. If the log segment is taken for a time period where no elections take place, there is no way to determine the id of the server. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-788) Add server id to message logs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12879842#action_12879842 ] Hadoop QA commented on ZOOKEEPER-788: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447362/ZOOKEEPER-778.patch against trunk revision 953041. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/85/console This message is automatically generated. Add server id to message logs - Key: ZOOKEEPER-788 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-788 Project: Zookeeper Issue Type: Improvement Components: contrib Affects Versions: 3.3.1 Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Trivial Fix For: 3.4.0 Attachments: ZOOKEEPER-778.patch As discussed on IRC. The log visualisation needs some way of determining which server made which log. If the log segment is taken for a time period where no elections take place, there is no way to determine the id of the server. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
