[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-112: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed revision 692534. src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-112.patch, ZOOKEEPER-112.patch, ZOOKEEPER-112.patch src/java/main ZooKeeper.java has a method public void disconnect() that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-112: --- Attachment: ZOOKEEPER-112.patch renamed zkstub per ben's suggestion src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-112.patch, ZOOKEEPER-112.patch, ZOOKEEPER-112.patch src/java/main ZooKeeper.java has a method public void disconnect() that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-112: --- Attachment: ZOOKEEPER-112.patch This is the same as the last patch + it has a change to remove the processWatchEvent(event) from the public api of ZooKeeper.java client class. Basically I have a (private) nested class that implements the Watcher.process(event) method and I provide an instance of that class to the client cnxn. ZooKeeper client public intf is very clean at this point. src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-112.patch, ZOOKEEPER-112.patch src/java/main ZooKeeper.java has a method public void disconnect() that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-112: --- Status: Patch Available (was: Open) src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-112.patch, ZOOKEEPER-112.patch src/java/main ZooKeeper.java has a method public void disconnect() that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-112: --- Fix Version/s: 3.0.0 Moving to 3.0.0 src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 src/java/main ZooKeeper.java has a method public void disconnect() that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
