[jira] Updated: (ZOOKEEPER-134) findbugs cleanup

2008-09-04 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-134:


Hadoop Flags: [Reviewed]

 findbugs cleanup
 

 Key: ZOOKEEPER-134
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
 Project: Zookeeper
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.0.0

 Attachments: ZOOKEEPER-134.patch


 cleaned up a number of findbugs warnings, in particular:
 1) added @overrides appropriately
 2) import cleanups
 3) log or document many empty blocks
 4) resource cleanup (usually by adding finally blocks)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-134) findbugs cleanup

2008-09-04 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-134:


Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed revision 692164.

 findbugs cleanup
 

 Key: ZOOKEEPER-134
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
 Project: Zookeeper
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.0.0

 Attachments: ZOOKEEPER-134.patch


 cleaned up a number of findbugs warnings, in particular:
 1) added @overrides appropriately
 2) import cleanups
 3) log or document many empty blocks
 4) resource cleanup (usually by adding finally blocks)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.