[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Darroch updated ZOOKEEPER-273: Description: One should be able to build Zookeeper C client libs on a machine without CPPUNIT installation. A simple fix is to remove from configure.ac the following line: M_PATH_CPPUNIT(1.10.2) was: One should be able to build Zookeeper C client libs on a machine without CPPUNIT installation. A simple fix is to remove from configure.ac the following line: M_PATH_CPPUNIT(1.10.2) Affects Version/s: 3.1.0 Fix Version/s: (was: 3.1.0) 3.2.0 As of 3.1.0 release, this doesn't seem to work as advertised: ./configure --without-cppunit make ... aclocal:configure.ac:36: warning: macro `AM_PATH_CPPUNIT' not found in library ... Makefile.am:68: wildcard tests/*.cc: non-POSIX variable name Makefile.am:68: (probably a GNU make extension) Makefile.am:68: wildcard tests/*.h: non-POSIX variable name Makefile.am:68: (probably a GNU make extension) Makefile.am:77: shell cat tests/wrappers.opt: non-POSIX variable name Makefile.am:77: (probably a GNU make extension) Makefile.am:90: shell cat tests/wrappers-mt.opt: non-POSIX variable name Makefile.am:90: (probably a GNU make extension) ... configure.ac:36: error: possibly undefined macro: AM_PATH_CPPUNIT If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. make: *** [configure] Error 1 > Zookeeper c client build should not depend on CPPUNIT > - > > Key: ZOOKEEPER-273 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.1.0 >Reporter: Runping Qi >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: patch_zookeeper_273.txt, ZOOKEEPER-273.patch, > ZOOKEEPER-273.patch > > > One should be able to build Zookeeper C client libs on a machine without > CPPUNIT installation. > A simple fix is to remove from configure.ac the following line: > M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-273: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. Thanks pat and runping. > Zookeeper c client build should not depend on CPPUNIT > - > > Key: ZOOKEEPER-273 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Runping Qi >Assignee: Patrick Hunt > Fix For: 3.1.0 > > Attachments: patch_zookeeper_273.txt, ZOOKEEPER-273.patch, > ZOOKEEPER-273.patch > > > One should be able to build Zookeeper C client libs on a machine without > CPPUNIT installation. > A simple fix is to remove from configure.ac the following line: > M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-273: Attachment: ZOOKEEPER-273.patch +1 ... changed the readme to reflect the new option for building the c library. > Zookeeper c client build should not depend on CPPUNIT > - > > Key: ZOOKEEPER-273 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Runping Qi >Assignee: Patrick Hunt > Fix For: 3.1.0 > > Attachments: patch_zookeeper_273.txt, ZOOKEEPER-273.patch, > ZOOKEEPER-273.patch > > > One should be able to build Zookeeper C client libs on a machine without > CPPUNIT installation. > A simple fix is to remove from configure.ac the following line: > M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-273: --- Attachment: ZOOKEEPER-273.patch this patch conditionally excludes cppunit ./configure --without-cppunit will eliminate the check for cppunit. (check is on by default) Self documenting - ./configure --help will list the available options - without-cppunit is included there. I verified that the build works in both cases - and that unit tests pass if option is not used. > Zookeeper c client build should not depend on CPPUNIT > - > > Key: ZOOKEEPER-273 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Runping Qi > Fix For: 3.1.0 > > Attachments: patch_zookeeper_273.txt, ZOOKEEPER-273.patch > > > One should be able to build Zookeeper C client libs on a machine without > CPPUNIT installation. > A simple fix is to remove from configure.ac the following line: > M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-273: --- Assignee: Patrick Hunt Status: Patch Available (was: Open) > Zookeeper c client build should not depend on CPPUNIT > - > > Key: ZOOKEEPER-273 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Runping Qi >Assignee: Patrick Hunt > Fix For: 3.1.0 > > Attachments: patch_zookeeper_273.txt, ZOOKEEPER-273.patch > > > One should be able to build Zookeeper C client libs on a machine without > CPPUNIT installation. > A simple fix is to remove from configure.ac the following line: > M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-273: --- Fix Version/s: 3.1.0 Status: Open (was: Patch Available) Unfortunately this patch removes cppunit entirely from ac, we need cppunit for the tests. Rather this patch should make cppunit an option for configure - ie "on" by default, with a commmand line option to configure to turn off. I think there is a std way to do this in ac. > Zookeeper c client build should not depend on CPPUNIT > - > > Key: ZOOKEEPER-273 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Runping Qi > Fix For: 3.1.0 > > Attachments: patch_zookeeper_273.txt > > > One should be able to build Zookeeper C client libs on a machine without > CPPUNIT installation. > A simple fix is to remove from configure.ac the following line: > M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Runping Qi updated ZOOKEEPER-273: - Attachment: patch_zookeeper_273.txt > Zookeeper c client build should not depend on CPPUNIT > - > > Key: ZOOKEEPER-273 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Runping Qi > Attachments: patch_zookeeper_273.txt > > > One should be able to build Zookeeper C client libs on a machine without > CPPUNIT installation. > A simple fix is to remove from configure.ac the following line: > M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Runping Qi updated ZOOKEEPER-273: - Status: Patch Available (was: Open) Simply commented out the line and the problem is fixed. > Zookeeper c client build should not depend on CPPUNIT > - > > Key: ZOOKEEPER-273 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Runping Qi > Attachments: patch_zookeeper_273.txt > > > One should be able to build Zookeeper C client libs on a machine without > CPPUNIT installation. > A simple fix is to remove from configure.ac the following line: > M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
