[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.

2009-02-27 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-330:


  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

I just committed this. Thanks chris.

> zookeeper standalone server does not startup with just a port and datadir.
> --
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0
>Reporter: Mahadev konar
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch, ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the 
> starting of zookeeperserver with just the port and datadir.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.

2009-02-26 Thread Chris Darroch (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Darroch updated ZOOKEEPER-330:


Attachment: ZOOKEEPER-330.patch

Sorry I didn't catch the problem with src/c/tests/zkServer.sh invoking 
ZooKeeperMain directly.

The only issue I had with your proposed patch here is that the original problem 
I encountered in ZOOKEEPER-326 returns -- if you start a standalone server 
using QuorumPeerMain, it ignores tickTime settings there again.  This 
contradicts the information here:

http://hadoop.apache.org/zookeeper/docs/r3.1.0/zookeeperStarted.html#sc_InstallingSingleMode

and it also just would be nice, I think, for the standard zkServer.sh (which 
uses QuorumPeerMain) and standard config file to work fully for standalone 
installations out of the box.

My revisions in the attached patch allow ZooKeeperMain to take a single config 
file as an alternate set of arguments, in which case it works like 
QuorumPeerMain.  This seems to resolve both my original issue, support the 
addition of a command-line tickTime argument as per your patch, and allow the 
src/c/tests/zkServer.sh script to work as-is.

> zookeeper standalone server does not startup with just a port and datadir.
> --
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0
>Reporter: Mahadev konar
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch, ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the 
> starting of zookeeperserver with just the port and datadir.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.

2009-02-24 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-330:


Status: Patch Available  (was: Open)

> zookeeper standalone server does not startup with just a port and datadir.
> --
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0
>Reporter: Mahadev konar
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the 
> starting of zookeeperserver with just the port and datadir.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.

2009-02-24 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-330:


Attachment: ZOOKEEPER-330.patch

this patch fixes the issue. 
ZOOKEEPER-326 made the ZookeeperServerMain args to take just a config file 
rather than its initial semantics of taking a clientport and datadir.

The ZookeeperServerMain class now takes the same arguments that it did earlier 
with an additional optional argument of ticktime.

so the command will look like 
ZooKeeperServerMain port datadir [ticktime]
ticktime being optional.

If users want to use a config file for a standalone server they can use 

QuorumPeerMain configfile


> zookeeper standalone server does not startup with just a port and datadir.
> --
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0
>Reporter: Mahadev konar
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the 
> starting of zookeeperserver with just the port and datadir.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.