[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-458: Fix Version/s: (was: 3.3.0) 3.4.0 this is quite critical but we wont be able to fix this before 3.3 deadline. Moving it to 3.4. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.4.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-458:
Status: Open (was: Patch Available)
I spent some time debugging this. This is the stack trace from the core dump:
{quote}
#0 0x2b101d67f6e3 in ?? () from /lib/libc.so.6
#1 0x2b101d680e98 in ?? () from /lib/libc.so.6
#2 0x2b101d681276 in free () from /lib/libc.so.6
#3 0x00407b4e in __wrap_free (p=0xc03d80) at
/homes/mahadev/zookeeper-trunk/src/c/tests/LibCMocks.cc:197
#4 0x00441197 in free_buffer (b=0xbff8d0) at
/homes/mahadev/zookeeper-trunk/src/c/src/zookeeper.c:763
#5 0x00441aa5 in destroy_completion_entry (c=0xc02dd0) at
/homes/mahadev/zookeeper-trunk/src/c/src/zookeeper.c:2048
#6 0x00441dc2 in process_completions (zh=0xc02920) at
/homes/mahadev/zookeeper-trunk/src/c/src/zookeeper.c:1727
#7 0x004457a8 in zookeeper_process (zh=0xc02920, events=-1912149552)
at /homes/mahadev/zookeeper-trunk/src/c/src/zookeeper.c:1974
#8 0x004316dd in yield (zh=0xc02920, seconds=1) at
/homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:107
#9 0x00433406 in watchCtx::waitForConnected (this=0x7fff8e06f100,
zh=0xc02920) at /homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:165
#10 0x0043448d in Zookeeper_simpleSystem::testConnectIndex1
(this=0xbfdaa0) at /homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:846
#11 0x00431a02 in CppUnit::TestCallerZookeeper_simpleSystem::runTest
(this=0xbfdd00) at /usr/include/cppunit/TestCaller.h:166
#12 0x004566fa in CppUnit::TestCaseMethodFunctor::operator() ()
#13 0x004618e4 in CppUnit::DefaultProtector::protect ()
#14 0x0046315f in CppUnit::ProtectorChain::protect ()
#15 0x0045e1b2 in CppUnit::TestResult::protect ()
#16 0x004564ba in CppUnit::TestCase::run ()
#17 0x00463d03 in CppUnit::TestComposite::doRunChildTests ()
#18 0x00463c26 in CppUnit::TestComposite::run ()
#19 0x00463d03 in CppUnit::TestComposite::doRunChildTests ()
#20 0x00463c26 in CppUnit::TestComposite::run ()
#21 0x0045da0a in CppUnit::TestResult::runTest ()
#22 0x0045ff62 in CppUnit::TestRunner::run ()
{quote}
I tried debugging but could not find much time.
Steven,
can you take a look and see if you find something obvious?
connect_index in zookeeper handle might get out of bound.
-
Key: ZOOKEEPER-458
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch
connect_index in zookeeper handle might get out of bound. the zokoeeper_init
method checks for index == count and sets it to zero. If the index becomes
greater than count, then it will go out of bounds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch Maybe free_buffer is getting called twice on the same structure, changed patch to null out the buffer field. If free_buffer is getting called twice, we should see a __wrap_free ... p = 0 in the backtrace. It's also possible that the buffer is getting free'd since buffer is shared with the iarchive zookeeper.c:1781 but I couldn't find any paths where the iarchive buffer is free'd by manually tracing through. One thing I am confused about is that the segfault happens at the end of the testConnectIndex1 test, but the path that it is taking is processing outstanding synchronous completions. The only synchronous completion that could be there is the zoo_exists call, but this was completed at the beginning of the test, before the server was stopped. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch Really looks like something with free... maybe this patch will be able to catch it better... marks the buffer node by setting len=-1 and checks it later. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch This patch, rather. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-458: Status: Patch Available (was: Open) connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-458: Status: Open (was: Patch Available) connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-458: Status: Open (was: Patch Available) the tests pass for me on linux. ill try hudson again to see if the failure is consistent or not. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch Sorry Mahadev, for some reason an old patch got uploaded instead. I'll make sure to double-check next time. I changed the tests so that a server was available and then disconnects, these ones pass for me. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Status: Patch Available (was: Open) connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch This patch ensures that 0 = connect_index addrs_count whenever connect_index is set to a non-zero value. Includes two tests that this property is maintained over disconnects. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-458: Fix Version/s: (was: 3.2.1) moving it to 3.3 since its not a regression and the connect_index will always be sane but the code just needs to put in extra checks for that. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
