Re: An interest in increasing the DI'ness of ZooKeeper?
Will Do. On Fri, Jul 18, 2008 at 1:40 PM, Benjamin Reed [EMAIL PROTECTED] wrote: This sounds great. I would suggest opening a Jira to work out the proposal and track the patch. ben Hiram Chirino wrote: Yep, I've looked that the test cases. In short to make that public API more DI friendly, we should: * Decouple the current configuration system from the public API. I see stuff like ZooKeeperServer being coupled to ServerConfig a bit. * Allow the use of setter injection in addition to constructor injection. This is the most important thing needed to let spring more easily configure the objects. Regards, Hiram On Fri, Jul 18, 2008 at 12:53 PM, Mahadev Konar [EMAIL PROTECTED] wrote: Hi Hiram, Thanks for your feedback. Its great to hear from our users. About your question regarding injecting zookeeper servers in applications, we do have public api' that support creating zookeeper servers in an embedding application. Take a look at our test cases where we create zookeeper servers via the public api. Is this what you were looking for or I misunderstood the reference? Mahadev -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Hiram Chirino Sent: Friday, July 18, 2008 9:07 AM To: zookeeper-dev@hadoop.apache.org Subject: An interest in increasing the DI'ness of ZooKeeper? Hi Guys, First off, great project! I think ZooKeeper is a fabulous idea. I can see folks wanting to embedd ZK servers in their products too. I could see the ActiveMQ project embedding it for several reasons. And with that in mind, I think it would be awesome of ZK tried to use more dependency injection (DI) to configure it's objects. That way and embedding project could directly configure it with java code, or use Spring or Guice etc. etc. If you guys are interested in supporting this use case, I'd be happy to start contributing patches to make that happen. -- Regards, Hiram Blog: http://hiramchirino.com Open Source SOA http://open.iona.com -- Regards, Hiram Blog: http://hiramchirino.com Open Source SOA http://open.iona.com
Re: An interest in increasing the DI'ness of ZooKeeper?
+1 :) I'm a fellow ActiveMQ hacker too and would love to see ZK included with ActiveMQ. Dependency Injection can really help keep your code simple but leaving it flexible so it can be used in many different ways. Here's some links on DI http://martinfowler.com/articles/injection.html http://www.theserverside.com/tt/articles/article.tss?l=SpringFramework 2008/7/18 Hiram Chirino [EMAIL PROTECTED]: Hi Guys, First off, great project! I think ZooKeeper is a fabulous idea. I can see folks wanting to embedd ZK servers in their products too. I could see the ActiveMQ project embedding it for several reasons. And with that in mind, I think it would be awesome of ZK tried to use more dependency injection (DI) to configure it's objects. That way and embedding project could directly configure it with java code, or use Spring or Guice etc. etc. If you guys are interested in supporting this use case, I'd be happy to start contributing patches to make that happen. -- Regards, Hiram Blog: http://hiramchirino.com Open Source SOA http://open.iona.com -- James --- http://macstrac.blogspot.com/ Open Source Integration http://open.iona.com
Re: An interest in increasing the DI'ness of ZooKeeper?
Yep, I've looked that the test cases. In short to make that public API more DI friendly, we should: * Decouple the current configuration system from the public API. I see stuff like ZooKeeperServer being coupled to ServerConfig a bit. * Allow the use of setter injection in addition to constructor injection. This is the most important thing needed to let spring more easily configure the objects. Regards, Hiram On Fri, Jul 18, 2008 at 12:53 PM, Mahadev Konar [EMAIL PROTECTED] wrote: Hi Hiram, Thanks for your feedback. Its great to hear from our users. About your question regarding injecting zookeeper servers in applications, we do have public api' that support creating zookeeper servers in an embedding application. Take a look at our test cases where we create zookeeper servers via the public api. Is this what you were looking for or I misunderstood the reference? Mahadev -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Hiram Chirino Sent: Friday, July 18, 2008 9:07 AM To: zookeeper-dev@hadoop.apache.org Subject: An interest in increasing the DI'ness of ZooKeeper? Hi Guys, First off, great project! I think ZooKeeper is a fabulous idea. I can see folks wanting to embedd ZK servers in their products too. I could see the ActiveMQ project embedding it for several reasons. And with that in mind, I think it would be awesome of ZK tried to use more dependency injection (DI) to configure it's objects. That way and embedding project could directly configure it with java code, or use Spring or Guice etc. etc. If you guys are interested in supporting this use case, I'd be happy to start contributing patches to make that happen. -- Regards, Hiram Blog: http://hiramchirino.com Open Source SOA http://open.iona.com -- Regards, Hiram Blog: http://hiramchirino.com Open Source SOA http://open.iona.com
Re: An interest in increasing the DI'ness of ZooKeeper?
Yeah mainly. Ideally only your main class deals with configuration parsing and it constructs all the zk server objects using the public api which is DI friendly. For example, I think we should move the main() method out of the ZooKeeperServer class. On Fri, Jul 18, 2008 at 1:11 PM, Benjamin Reed [EMAIL PROTECTED] wrote: Can you be a bit more specific and what kind of injection you are talking about? Are you just talking about the server configuration? thanx ben Hiram Chirino wrote: Hi Guys, First off, great project! I think ZooKeeper is a fabulous idea. I can see folks wanting to embedd ZK servers in their products too. I could see the ActiveMQ project embedding it for several reasons. And with that in mind, I think it would be awesome of ZK tried to use more dependency injection (DI) to configure it's objects. That way and embedding project could directly configure it with java code, or use Spring or Guice etc. etc. If you guys are interested in supporting this use case, I'd be happy to start contributing patches to make that happen. -- Regards, Hiram Blog: http://hiramchirino.com Open Source SOA http://open.iona.com
Re: An interest in increasing the DI'ness of ZooKeeper?
This sounds great. I would suggest opening a Jira to work out the proposal and track the patch. ben Hiram Chirino wrote: Yep, I've looked that the test cases. In short to make that public API more DI friendly, we should: * Decouple the current configuration system from the public API. I see stuff like ZooKeeperServer being coupled to ServerConfig a bit. * Allow the use of setter injection in addition to constructor injection. This is the most important thing needed to let spring more easily configure the objects. Regards, Hiram On Fri, Jul 18, 2008 at 12:53 PM, Mahadev Konar [EMAIL PROTECTED] wrote: Hi Hiram, Thanks for your feedback. Its great to hear from our users. About your question regarding injecting zookeeper servers in applications, we do have public api' that support creating zookeeper servers in an embedding application. Take a look at our test cases where we create zookeeper servers via the public api. Is this what you were looking for or I misunderstood the reference? Mahadev -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Hiram Chirino Sent: Friday, July 18, 2008 9:07 AM To: zookeeper-dev@hadoop.apache.org Subject: An interest in increasing the DI'ness of ZooKeeper? Hi Guys, First off, great project! I think ZooKeeper is a fabulous idea. I can see folks wanting to embedd ZK servers in their products too. I could see the ActiveMQ project embedding it for several reasons. And with that in mind, I think it would be awesome of ZK tried to use more dependency injection (DI) to configure it's objects. That way and embedding project could directly configure it with java code, or use Spring or Guice etc. etc. If you guys are interested in supporting this use case, I'd be happy to start contributing patches to make that happen. -- Regards, Hiram Blog: http://hiramchirino.com Open Source SOA http://open.iona.com
