Build failed in Hudson: ZooKeeper-trunk #24
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/24/changes Changes: [phunt] Fixed ZOOKEEPER-75, addressed some license issues and also removed the cobertura library (gpl). Moved from junit 4.1 to junit 4.4 at the same time (tests still pass). -- [...truncated 34 lines...] A src/java/main A src/java/main/org A src/java/main/org/apache A src/java/main/org/apache/zookeeper AUsrc/java/main/org/apache/zookeeper/ZooKeeper.java AUsrc/java/main/org/apache/zookeeper/ClientCnxn.java AUsrc/java/main/org/apache/zookeeper/Version.java A src/java/main/org/apache/zookeeper/version A src/java/main/org/apache/zookeeper/version/util AUsrc/java/main/org/apache/zookeeper/version/util/VerGen.java A src/java/main/org/apache/zookeeper/server AUsrc/java/main/org/apache/zookeeper/server/SessionTracker.java AUsrc/java/main/org/apache/zookeeper/server/WatchManager.java AUsrc/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java AUsrc/java/main/org/apache/zookeeper/server/NIOServerCnxn.java AUsrc/java/main/org/apache/zookeeper/server/LogFormatter.java A src/java/main/org/apache/zookeeper/server/quorum AUsrc/java/main/org/apache/zookeeper/server/quorum/Election.java AU src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java AU src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java AUsrc/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java AUsrc/java/main/org/apache/zookeeper/server/quorum/QuorumStats.java AU src/java/main/org/apache/zookeeper/server/quorum/AckRequestProcessor.java AU src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java AU src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java AU src/java/main/org/apache/zookeeper/server/quorum/FollowerSessionTracker.java AUsrc/java/main/org/apache/zookeeper/server/quorum/Vote.java AU src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java AUsrc/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java AU src/java/main/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java AUsrc/java/main/org/apache/zookeeper/server/quorum/FollowerHandler.java AUsrc/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java AUsrc/java/main/org/apache/zookeeper/server/quorum/Follower.java AUsrc/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java AUsrc/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java AUsrc/java/main/org/apache/zookeeper/server/quorum/Leader.java AU src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java A src/java/main/org/apache/zookeeper/server/package.html AUsrc/java/main/org/apache/zookeeper/server/PurgeTxnLog.java AUsrc/java/main/org/apache/zookeeper/server/DataNode.java AUsrc/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java A src/java/main/org/apache/zookeeper/server/auth AU src/java/main/org/apache/zookeeper/server/auth/IPAuthenticationProvider.java AUsrc/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java AU src/java/main/org/apache/zookeeper/server/auth/HostAuthenticationProvider.java AU src/java/main/org/apache/zookeeper/server/auth/AuthenticationProvider.java AU src/java/main/org/apache/zookeeper/server/auth/DigestAuthenticationProvider.java AUsrc/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java AUsrc/java/main/org/apache/zookeeper/server/TraceFormatter.java AUsrc/java/main/org/apache/zookeeper/server/ServerStats.java AUsrc/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java AUsrc/java/main/org/apache/zookeeper/server/ZooTrace.java AUsrc/java/main/org/apache/zookeeper/server/RequestProcessor.java AUsrc/java/main/org/apache/zookeeper/server/Request.java AUsrc/java/main/org/apache/zookeeper/server/DataTree.java AUsrc/java/main/org/apache/zookeeper/server/ByteBufferInputStream.java AUsrc/java/main/org/apache/zookeeper/server/ZooKeeperServer.java AUsrc/java/main/org/apache/zookeeper/server/ServerConfig.java AUsrc/java/main/org/apache/zookeeper/server/ServerCnxn.java A src/java/main/org/apache/zookeeper/server/util AUsrc/java/main/org/apache/zookeeper/server/util/Profiler.java AUsrc/java/main/org/apache/zookeeper/ZooDefs.java AUsrc/java/main/org/apache/zookeeper/AsyncCallback.java AUsrc/java/main/org/apache/zookeeper/KeeperException.java AUsrc/java/main/org/apache/zookeeper/Watcher.java AUsrc/java/main/org/apache/zookeeper/ServerAdminClient.java A
[jira] Updated: (ZOOKEEPER-76) Commit 677109 removed the cobertura library, but not the build targets.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-76: -- Resolution: Invalid Assignee: Patrick Hunt Status: Resolved (was: Patch Available) Thanks for the patch and the feedback, however this was intentional. Notice that I added a README.txt in the lib/cobertura directory directing ppl how to d/l cobertura and run the build target. After moving to Apache committers have access to an Apache license for Clover however contributors (non-comitters) do not. I left this target in place to allow anyone access to a coverage tool. > Commit 677109 removed the cobertura library, but not the build targets. > --- > > Key: ZOOKEEPER-76 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Jakob Homan >Assignee: Patrick Hunt > Attachments: delcobertura.patch > > > Cobertura library removed due to licensing issues, but the code-coverage ant > targets were left in. Have deleted them and created patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-77) NPE in jute toCSVString code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614007#action_12614007 ] Patrick Hunt commented on ZOOKEEPER-77: --- According to the stack trace the line causing the problem is: a_.writeString(path,"path"); in watcher event. Should it ever be the case that the path can be null? We should look at the static code analysis output to see if this is flagged. > NPE in jute toCSVString code > > > Key: ZOOKEEPER-77 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-77 > Project: Zookeeper > Issue Type: Bug > Components: jute >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > > As reported by user: > From: Martin Schaaf <[EMAIL PROTECTED]> > List-Id: > FYI today I found this NPE in the logs. After this Exception an Error > event was thrown. > java.lang.NullPointerException > at com.yahoo.jute.Utils.toCSVString(Utils.java:128) > at com.yahoo.jute.CsvOutputArchive.writeString(CsvOutputArchive.java: > 95) > at com.yahoo.zookeeper.proto.WatcherEvent.toString(WatcherEvent.java: > 60) > at net.sf.katta.zk.ZKClient.process(ZKClient.java:404) > at com.yahoo.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:264) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-77) NPE in jute toCSVString code
NPE in jute toCSVString code Key: ZOOKEEPER-77 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-77 Project: Zookeeper Issue Type: Bug Components: jute Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 As reported by user: From: Martin Schaaf <[EMAIL PROTECTED]> List-Id: FYI today I found this NPE in the logs. After this Exception an Error event was thrown. java.lang.NullPointerException at com.yahoo.jute.Utils.toCSVString(Utils.java:128) at com.yahoo.jute.CsvOutputArchive.writeString(CsvOutputArchive.java: 95) at com.yahoo.zookeeper.proto.WatcherEvent.toString(WatcherEvent.java: 60) at net.sf.katta.zk.ZKClient.process(ZKClient.java:404) at com.yahoo.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:264) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Thrift interface
FUSE support is tracked by the following JIRA https://issues.apache.org/jira/browse/ZOOKEEPER-25 a patch is attached to the JIRA containing the feature. It's a big(ger) set of code so I've given it time for review. Should be committed soon and will be part of 3.0. I started working on script support just before we got accepted to Apache, which put that onto the back burner for a bit. We have a design and I implemented a very basic prototype using SWIG that supports perl/python/ruby/php/tcl. I'll be picking scripting support up again once the Apache migration is mostly complete. Patrick Benjamin Reed wrote: Hi Chris, We have talked about using Thrift for our serialization layer (I thought we had a Jira opened for it, but I cannot find it). Thrift RPC is a different story. You would lose watch callbacks. I think it would also be hard to support sessions and thus ephemeral nodes. Finally, your client and server throughput would be quite low since clients wouldn't be able to pipeline requests (it appears you can only have one request outstanding at a time) and servers have to dedicate a thread to service a request. ZooKeeper clients are more than simple RPC dispatchers they also do session maintenance and completion processing, so you need something a bit more sophisticated at the client. I assume you want this to get bindings for other languages. We have SWIG and FUSE bindings for this. If you really want thrift, I think there is a combo solution: implement a standalone service, thrift server and zk client, and run it on each ZooKeeper server. ben Chris Smith wrote: Hi, I'm currently thinking about implementing a Thrift interface for ZooKeeper, and wanted to get some opinions on it before I start. I can basically see two possible ways to implement it: * A standalone service which implements both a ZooKeeper client and a Thrift server, and basically acts as a proxy between the two * Integrate the Thrift server with the ZooKeeper server, so that ZK servers themselves handle the Thrift connections I think the former is probably nicer from a development stand-point, but the latter seems better from an end-user stand-point. Has anyone else thought about doing this (or actually done it!), and does anyone have any preferences/comments with regard to the above options? Cheers, Chris Smith
[jira] Commented: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614016#action_12614016 ] Patrick Hunt commented on ZOOKEEPER-16: --- Are we validating that the path is not null? See ZOOKEEPER-77 which seems to be throwing an NPE due to null path. > Need to do path validation > -- > > Key: ZOOKEEPER-16 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 > Project: Zookeeper > Issue Type: Bug > Components: c client, java client, server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1963141&group_id=209147&atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (ZOOKEEPER-76) Commit 677109 removed the cobertura library, but not the build targets.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reopened ZOOKEEPER-76: --- Hrm. For whatever reason the build was successful before the commit, however now it's failing due to not being able to find cobertura jar. (I had run the test target successfully on the patch, weird). I'm reopening this to see if I can fix (otw I'll apply the submitted patch). > Commit 677109 removed the cobertura library, but not the build targets. > --- > > Key: ZOOKEEPER-76 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Jakob Homan >Assignee: Patrick Hunt > Attachments: delcobertura.patch > > > Cobertura library removed due to licensing issues, but the code-coverage ant > targets were left in. Have deleted them and created patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-76) Commit 677109 removed the cobertura library, but not the build targets.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-76: --- Attachment: Zookeeper-76_1.patch i just did this as in the patch which amkes the tests work fine. -- getting rid of cobertura in the classpath. > Commit 677109 removed the cobertura library, but not the build targets. > --- > > Key: ZOOKEEPER-76 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Jakob Homan >Assignee: Patrick Hunt > Attachments: delcobertura.patch, Zookeeper-76_1.patch > > > Cobertura library removed due to licensing issues, but the code-coverage ant > targets were left in. Have deleted them and created patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-76) Commit 677109 removed the cobertura library, but not the build targets.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-76: -- Attachment: ZOOKEEPER-76.patch This patch (ZOOKEEPER-76.patch) pushes the taskdef into the target, so it won't be run unless one of the cobertura targets is specifically run (then obv the jar needs to be in place). Please review/vote and I will commit. > Commit 677109 removed the cobertura library, but not the build targets. > --- > > Key: ZOOKEEPER-76 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Jakob Homan >Assignee: Patrick Hunt > Attachments: delcobertura.patch, ZOOKEEPER-76.patch, > Zookeeper-76_1.patch > > > Cobertura library removed due to licensing issues, but the code-coverage ant > targets were left in. Have deleted them and created patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-76) Commit 677109 removed the cobertura library, but not the build targets.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614056#action_12614056 ] Mahadev konar commented on ZOOKEEPER-76: pats patch seems better.. +1 on pat's patch ... > Commit 677109 removed the cobertura library, but not the build targets. > --- > > Key: ZOOKEEPER-76 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Jakob Homan >Assignee: Patrick Hunt > Attachments: delcobertura.patch, ZOOKEEPER-76.patch, > Zookeeper-76_1.patch > > > Cobertura library removed due to licensing issues, but the code-coverage ant > targets were left in. Have deleted them and created patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-76) Commit 677109 removed the cobertura library, but not the build targets.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-76. --- Resolution: Fixed Fix Version/s: 3.0.0 Hadoop Flags: [Reviewed] Fixed in 677371 using ZOOKEEPER-76.patch > Commit 677109 removed the cobertura library, but not the build targets. > --- > > Key: ZOOKEEPER-76 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Jakob Homan >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: delcobertura.patch, ZOOKEEPER-76.patch, > Zookeeper-76_1.patch > > > Cobertura library removed due to licensing issues, but the code-coverage ant > targets were left in. Have deleted them and created patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Porting the Sourceforge wiki to Apache
I've started filling in a few pages on the Apache wiki: http://wiki.apache.org/hadoop/ZooKeeper In general the Hadoop structure looks good, I plan to follow that where it makes sense. There are a number of pages that need to be moved over from SF, however there are some pages which are more suited as documentation, and those will be added to svn under trunk/src/docs (need to be converted to forrest compatible format). If anyone has comments let me know. I'll be moving the pages over the next few days, after which we should be in good shape to start "turning off the lights" over at SF. Doug tells me there is a way to convert the SF site to "readonly" mode, where we point ppl to the apache site. There are a few new pages I added like "PoweredBy" and "FAQ" that you'll see on the ZK wiki frontpage (link above), feel free to start filling those in. Regards, Patrick
[jira] Commented: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614121#action_12614121 ] Andrew Kornev commented on ZOOKEEPER-39: The watcher processing is now done in multiple steps: 1) when application issues a zokeeper query with watcher enabled, a temporary watcher registration is created and stored along with the completion entry in the completion queue. 2) upon succesful response from the server, the watcher registration is moved from the completion queue to the watcher object map. If the server returns an error the watcher registration is discarded. 3) when a watch event arrives, the client uses the watcher map to determine if there are watchers set on the znode (using the znode path as the key). It then calles the watcher callback passing in the watcher context along with the znode path and the event type info. 4) the watcher object is deleted from the map prior to calling the application watcher in the step 3) > Use Watcher objects rather than boolean on read operations > -- > > Key: ZOOKEEPER-39 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-39.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1962501&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
