[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Status: Patch Available (was: Open) Attached are the patches for the db file header and the CRC [ZOOKEEPER-32] features, and the unit tests. The patches are generated against the latest code in Source Forge SVN. The patch introduces a new zookeeper package: the persistence layer. The package declares a number of public (zookeeper server scope) interfaces: TxnLogFactory, DBInfo, LogReader and LogWriter. The ZooKeeperServer, SyncProcessor and QuorumPeer classes are now relying exclusively on these interfaces to perform snapshotting and logging operations. All of the existing persistence-related code has been factored out to the new package peristence.log which provides the implementations of the above public interfaces. The persistence.ProviderRegistry class is used during the server initialization to obtain an instance of TxnLogFactory based on the user-provided URI. From that moment on, the server uses the factory to access LogReader and LogWriter interfaces. This is my strong belief that this design improves decoulping and separation of concerns. As a result this will allow us to provide new implementations of the persistence layer more easily. Also, this is a step toward improved testability and simpler code structure, which ideally should make it easier for people to contribute to the project. > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: db-header-crc-1.patch, db-header-crc-unittest.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Attachment: db-header-crc-unittest.patch db-header-crc-1.patch > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: db-header-crc-1.patch, db-header-crc-unittest.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-28) Incompatible client and server list detection
[ https://issues.apache.org/jira/browse/ZOOKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604338#action_12604338 ] Andrew Kornev commented on ZOOKEEPER-28: Flavio, I'm guessing you'd want to modify the client's connection handshake protocol by adding the server list information to it. Please take a look at the prime_connection() function in zookeeper.c. This is where the handshake is implemented. There is a theoretical possibility in the case where the list of zookeeper nodes gets rather long, the send() call would be able to write the whole marshalled buffer to the socket, which will result in a connection failure (see lines 850-851 in zookeeper.c). Also, please make sure to update the unit tests because this change will break some of them (for example, c\tests\TestZookeeperInit.cc). On the server side, I'd like to make sure the server implementation is going to be backward compatible. In other words, the old clients should still be able to connect to the server. > Incompatible client and server list detection > - > > Key: ZOOKEEPER-28 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-28 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client, server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1937084&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-28) Incompatible client and server list detection
[ https://issues.apache.org/jira/browse/ZOOKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604340#action_12604340 ] Andrew Kornev commented on ZOOKEEPER-28: Oops, a typo. Should read: "the send() call would *NOT* be able to write the whole marshalled buffer..." > Incompatible client and server list detection > - > > Key: ZOOKEEPER-28 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-28 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client, server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1937084&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-28) Incompatible client and server list detection
[ https://issues.apache.org/jira/browse/ZOOKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev reassigned ZOOKEEPER-28: -- Assignee: Flavio Paiva Junqueira (was: Andrew Kornev) > Incompatible client and server list detection > - > > Key: ZOOKEEPER-28 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-28 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client, server >Reporter: Patrick Hunt >Assignee: Flavio Paiva Junqueira > Fix For: 3.0.0 > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1937084&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository after initial import
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608578#action_12608578 ] Andrew Kornev commented on ZOOKEEPER-45: To Mahadev, Pat and other hadoop admirers: I'd like to keep the changelogs for java, c and "other stuff that is not either c or java" in their respective subdirectories. The fact that all those components released in a single package should have no bearing on the location of a source file within the source hierarchy. Or, put in a different way, no one would seriously consider a proposal to move all of the c and java source files under the same directory just because they end up in the same release tar file. Having said that, I support the idea of having a top level "CHANGES.txt" for changes that are not specific to any component (for example, addition of a new contributed component, creation of a new top level source dir, modification of sample config file, etc). > Restructure the SVN repository after initial import > --- > > Key: ZOOKEEPER-45 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45 > Project: Zookeeper > Issue Type: Task > Components: build >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch > > > SVN and the ant build have to be updated after the initial import from > SourceForge (see INFRA-1644) in order to get us aligned with Apache release > process/collateral and some general cleanup of the repository. Please > review/comment on the following: > I intend to follow these steps: > 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to > hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk) > 2) change the java package prefix from com.yahoo to org.apache > 3) update the license headers in all source files > 4) replace LICENSE file in root dir with Apache LICENSE file > 5) add attribution NOTICE file to root dir > 6) update the README file appropriately > 7) create a new "src" directory in the zk root > 8) move root "c" directory into src > 9) move root "java" directory into src > 10) create root "docs" directory > 11) create src/docs directory > 12) rename src/java/src to src/java/main > 13) move root "test" directory to src/java/test > 14) build.xml will be updated appropriately for all the moves. it will also > be updated with apache specific targets similar to what exists in hadoop > (such as building the forrest documentation). > steps 10&11 are required for zk documentation storage. src/docs is the > location of all documentation in "forrest xml" format - the documentation > source/originals (what you edit when you change the docs). the ant script is > setup to build docs (forrest) into the root docs directory. these files are > also committed to svn (both docs and src/docs). later, during a release > process, the files in the root docs directory are checked out onto the system > hosting the apache web site and pushed to the mirrors. > I'll submit patches for any changes/additions of files. However I suspect > that the directory move operations in SVN will not have an accompanying patch > - this "script" is the documentation of what will be changed (comments added > for any deviation). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository after initial import
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608579#action_12608579 ] Andrew Kornev commented on ZOOKEEPER-45: BTW, this config here http://www.apache.org/dev/svn-eol-style.txt is missing an entry for *.cc which is a valid C++ extention. *.cc = svn:eol-style=native > Restructure the SVN repository after initial import > --- > > Key: ZOOKEEPER-45 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45 > Project: Zookeeper > Issue Type: Task > Components: build >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch > > > SVN and the ant build have to be updated after the initial import from > SourceForge (see INFRA-1644) in order to get us aligned with Apache release > process/collateral and some general cleanup of the repository. Please > review/comment on the following: > I intend to follow these steps: > 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to > hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk) > 2) change the java package prefix from com.yahoo to org.apache > 3) update the license headers in all source files > 4) replace LICENSE file in root dir with Apache LICENSE file > 5) add attribution NOTICE file to root dir > 6) update the README file appropriately > 7) create a new "src" directory in the zk root > 8) move root "c" directory into src > 9) move root "java" directory into src > 10) create root "docs" directory > 11) create src/docs directory > 12) rename src/java/src to src/java/main > 13) move root "test" directory to src/java/test > 14) build.xml will be updated appropriately for all the moves. it will also > be updated with apache specific targets similar to what exists in hadoop > (such as building the forrest documentation). > steps 10&11 are required for zk documentation storage. src/docs is the > location of all documentation in "forrest xml" format - the documentation > source/originals (what you edit when you change the docs). the ant script is > setup to build docs (forrest) into the root docs directory. these files are > also committed to svn (both docs and src/docs). later, during a release > process, the files in the root docs directory are checked out onto the system > hosting the apache web site and pushed to the mirrors. > I'll submit patches for any changes/additions of files. However I suspect > that the directory move operations in SVN will not have an accompanying patch > - this "script" is the documentation of what will be changed (comments added > for any deviation). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-55) build.xml failes to retrieve a release number from SVN and the ant target "dist" fails
build.xml failes to retrieve a release number from SVN and the ant target "dist" fails -- Key: ZOOKEEPER-55 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-55 Project: Zookeeper Issue Type: Bug Components: build Reporter: Andrew Kornev Assignee: Andrew Kornev Due to the recent directory layout change, 1) the ant target "svn-revision" fails to retrieve the release number, 2) the ant target "dist" fails to create the distribution package. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-55) build.xml failes to retrieve a release number from SVN and the ant target "dist" fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-55: --- Status: Patch Available (was: Open) > build.xml failes to retrieve a release number from SVN and the ant target > "dist" fails > -- > > Key: ZOOKEEPER-55 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-55 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Andrew Kornev >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-55.patch > > > Due to the recent directory layout change, > 1) the ant target "svn-revision" fails to retrieve the release number, > 2) the ant target "dist" fails to create the distribution package. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-55) build.xml failes to retrieve a release number from SVN and the ant target "dist" fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-55: --- Attachment: ZOOKEEPER-55.patch The patch fixes the first problem by correcting the path on the directory whose revision number is retreived. The second problem was also caused by invalid paths used to produce the tar files. > build.xml failes to retrieve a release number from SVN and the ant target > "dist" fails > -- > > Key: ZOOKEEPER-55 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-55 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Andrew Kornev >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-55.patch > > > Due to the recent directory layout change, > 1) the ant target "svn-revision" fails to retrieve the release number, > 2) the ant target "dist" fails to create the distribution package. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-55) build.xml failes to retrieve a release number from SVN and the ant target "dist" fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-55: --- Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision 672058 > build.xml failes to retrieve a release number from SVN and the ant target > "dist" fails > -- > > Key: ZOOKEEPER-55 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-55 > Project: Zookeeper > Issue Type: Bug > Components: build >Reporter: Andrew Kornev >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-55.patch > > > Due to the recent directory layout change, > 1) the ant target "svn-revision" fails to retrieve the release number, > 2) the ant target "dist" fails to create the distribution package. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-47) io thread still around after a EXPIRED_SESSION or AUTH_FAILED event is received
[ https://issues.apache.org/jira/browse/ZOOKEEPER-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608625#action_12608625 ] Andrew Kornev commented on ZOOKEEPER-47: But that's exactly what the do_io does! It check if the zhandle_t state is unrecoverable and terminates if it is. > io thread still around after a EXPIRED_SESSION or AUTH_FAILED event is > received > --- > > Key: ZOOKEEPER-47 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-47 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Benjamin Reed > > If a session expires, the zhandle_t becomes invalid and useless; however, the > io thread keeps going. > do_io in mt_adaptor.c needs to check the return code of zookeeper_interest > and zookeeper_process and get out of the loop if the handle is invalid. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Attachment: (was: db-header-crc-unittest.patch) > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Attachment: (was: db-header-crc-1.patch) > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Status: Patch Available (was: Open) > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Attachment: ZOOKEEPER-38.patch The same patch but is now built against the apache SVN. Please review. > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Attachment: ZOOKEEPER-38.patch Uploading the patch (fixed the paths for the property changes) > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-39: --- Attachment: ZOOKEEPER-39.patch This patch implements the new watcher "object" API. Internally, it uses a map to maintain the mapping between the znode path and watcher function/context. Every time a watch event arrives the client delegates event processing to an associated watcher object if one exists. The patch also includes a suite of unit tests for both single- and multithreaded libraries as well as for the Sync and Async APIs. > Use Watcher objects rather than boolean on read operations > -- > > Key: ZOOKEEPER-39 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-39.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1962501&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-39: --- Status: Patch Available (was: Open) > Use Watcher objects rather than boolean on read operations > -- > > Key: ZOOKEEPER-39 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-39.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1962501&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-66) Add NullWatcher, a watcher that does nothing
[ https://issues.apache.org/jira/browse/ZOOKEEPER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610882#action_12610882 ] Andrew Kornev commented on ZOOKEEPER-66: I concur with Flavio: application must implement a watcher. At the very least you'd want to know about the session events such as connect, disconnect, and especially session expiration and athentication failure. The latter two cannot be automatically recovered from and must be handled by the application in a certain way (a new ZooKeeper object must be instantiated). > Add NullWatcher, a watcher that does nothing > > > Key: ZOOKEEPER-66 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-66 > Project: Zookeeper > Issue Type: New Feature > Components: java client >Reporter: Anthony Urso >Priority: Minor > Attachments: nullwatcher.diff > > > I found that I was repeating this code all over the place. Here is a > NullWatcher class, a Watcher that does nothing at all. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-59) Synchronized block in NIOServerCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611754#action_12611754
]
Andrew Kornev commented on ZOOKEEPER-59:
I agree with Flavio's comment in
https://issues.apache.org/jira/browse/ZOOKEEPER-59?focusedCommentId=12611527#action_12611527
: incInProcess() should be called prior to calling first request processor.
Also, getInProcess() should be a synchronized method. Even better solution
would be to make requestsInProcess an atomic integer: there is really no need
to synchronize on the ZooKeeper instance to update/access the variable.
Having said that, I don't think this will fix the the timeout problem. From
what I saw in the server logs during my investigation of a similar incident was
that the server was still receiving and processing client requests (in other
words, the counters we're trying to fix here didn't cause throttling). The
problem was that the responses weren't being sent to the client which was
causing the client to timeout.
> Synchronized block in NIOServerCnxn
> ---
>
> Key: ZOOKEEPER-59
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-59
> Project: Zookeeper
> Issue Type: Bug
> Components: server
>Reporter: Flavio Paiva Junqueira
>Assignee: Benjamin Reed
> Attachments: ZOOKEEPER-59_1.patch, ZOOKEEPER-59_2.patch
>
>
> There are two synchronized blocks locking on different objects, and to me
> they should be guarded by the same object. Here are the parts of the code I'm
> talking about:
> {noformat}
> [EMAIL PROTECTED]
> ...
> synchronized (this) {
> outstandingRequests++;
> // check throttling
> if (zk.getInProcess() > factory.outstandingLimit) {
> disableRecv();
> // following lines should not be needed since we are
> already
> // reading
> // } else {
> // enableRecv();
> }
> }
> {noformat}
> {noformat}
> [EMAIL PROTECTED]
> ...
> synchronized (this.factory) {
> outstandingRequests--;
> // check throttling
> if (zk.getInProcess() < factory.outstandingLimit
> || outstandingRequests < 1) {
> sk.selector().wakeup();
> enableRecv();
> }
> }
> {noformat}
> I think the second one is correct, and the first synchronized block should be
> guarded by "this.factory".
> This could be related to issue ZOOKEEPER-57, but I have no concrete
> indication that this is the case so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-70) Add skeleton forrest doc structure for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-70: --- Status: Patch Available (was: Open) > Add skeleton forrest doc structure for ZooKeeper > > > Key: ZOOKEEPER-70 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-70 > Project: Zookeeper > Issue Type: Task > Components: documentation >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-70.tar.gz, ZOOKEEPER-70_1.patch, > ZOOKEEPER-70_2.patch > > > Add a skeleton forrest doc structure for ZooKeeper. > Doug has suggested using hbase as a starting point. > Note: I noticed that forrest doesn't work with java6, it will run with java5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-70) Add skeleton forrest doc structure for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-70: --- Attachment: ZOOKEEPER-70_2.patch The patch fixes the problem with the build.xml: on Windows, the extention .bat must be specified explicitely when using the ant task. Other than that, the patch looks good and I was able to generate a site (with most of the links broken) > Add skeleton forrest doc structure for ZooKeeper > > > Key: ZOOKEEPER-70 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-70 > Project: Zookeeper > Issue Type: Task > Components: documentation >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-70.tar.gz, ZOOKEEPER-70_1.patch, > ZOOKEEPER-70_2.patch > > > Add a skeleton forrest doc structure for ZooKeeper. > Doug has suggested using hbase as a starting point. > Note: I noticed that forrest doesn't work with java6, it will run with java5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612208#action_12612208 ] Andrew Kornev commented on ZOOKEEPER-38: While JIRA comments is not the best place to discuss basics of object-oriented design, I'd like to point out that interfaces are not about "pluggability" and the number of potential implementations is not an indication of whether or not an interface should be introduced. I highly recommend the reviewer take another look at Design Patterns by GoF (chapters 1 and 2) and Emergent Design by Scott L. Bain just to name a few (both of them are available on Safari). I also recommend the reviewer take a look at the unit tests included with the patch. There, one can see how loose coupling (achieved thru the use of interfaces, among other things) improves testability of the code. It is now possible to unit test classes individually and in isolation -- something that has never been possible with the existing zookeeper code before. Wrt point 4, I'll update the code to use the URL class instead. Wrt point 5, if I understand the question correctly, what if we want to run multiple zookeeper servers within the same JVM and you want to be able to associate different providers with each of those servers? Besides, we get this feature essentially for free. There is one extra line of code (the while() statement) that deals with loading multiple providers. > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-70) Add skeleton forrest doc structure for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612220#action_12612220 ] Andrew Kornev commented on ZOOKEEPER-70: +1 > Add skeleton forrest doc structure for ZooKeeper > > > Key: ZOOKEEPER-70 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-70 > Project: Zookeeper > Issue Type: Task > Components: documentation >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-70.tar.gz, ZOOKEEPER-70_1.patch, > ZOOKEEPER-70_2.patch > > > Add a skeleton forrest doc structure for ZooKeeper. > Doug has suggested using hbase as a starting point. > Note: I noticed that forrest doesn't work with java6, it will run with java5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-70) Add skeleton forrest doc structure for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-70: --- Attachment: ZOOKEEPER-70_2.patch The pre-1.7 ant task doesn't recongnize "winnt" as a valid os family id. Use "windows" instead. > Add skeleton forrest doc structure for ZooKeeper > > > Key: ZOOKEEPER-70 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-70 > Project: Zookeeper > Issue Type: Task > Components: documentation >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-70.tar.gz, ZOOKEEPER-70_1.patch, > ZOOKEEPER-70_2.patch, ZOOKEEPER-70_2.patch > > > Add a skeleton forrest doc structure for ZooKeeper. > Doug has suggested using hbase as a starting point. > Note: I noticed that forrest doesn't work with java6, it will run with java5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Attachment: ZOOKEEPER-38.patch Added more javadocs, use the URI class for passing provider URLs, implemented support for terminating the server if the database files format is not supported (wrong version). > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, > ZOOKEEPER-38.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-25) FUSE for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-25: --- Attachment: configure.ac.patch This patch replaces the existing FUSE configure.ac: the configure.ac script uses some macros that are not supported by the pre-2.61 autoconf tools. It's safe to drop the macros from the script for the sake of compatibility with autotools 2.59. The C client is also compatible with version 2.59. Other than that I was able to build and run FUSE with zookeeper without any problems. +1 > FUSE for ZooKeeper > -- > > Key: ZOOKEEPER-25 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-25 > Project: Zookeeper > Issue Type: New Feature >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: configure.ac.patch, ZOOKEEPER-25.patch.gz > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1873981&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-25) FUSE for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-25: --- Status: Patch Available (was: Open) > FUSE for ZooKeeper > -- > > Key: ZOOKEEPER-25 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-25 > Project: Zookeeper > Issue Type: New Feature >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: configure.ac.patch, ZOOKEEPER-25.patch.gz > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1873981&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614121#action_12614121 ] Andrew Kornev commented on ZOOKEEPER-39: The watcher processing is now done in multiple steps: 1) when application issues a zokeeper query with watcher enabled, a temporary watcher registration is created and stored along with the completion entry in the completion queue. 2) upon succesful response from the server, the watcher registration is moved from the completion queue to the watcher object map. If the server returns an error the watcher registration is discarded. 3) when a watch event arrives, the client uses the watcher map to determine if there are watchers set on the znode (using the znode path as the key). It then calles the watcher callback passing in the watcher context along with the znode path and the event type info. 4) the watcher object is deleted from the map prior to calling the application watcher in the step 3) > Use Watcher objects rather than boolean on read operations > -- > > Key: ZOOKEEPER-39 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-39.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1962501&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614787#action_12614787 ] Andrew Kornev commented on ZOOKEEPER-81: The JMX instrumentation code relies on the MXBean feature that is available only since Java 6. The build.xml conditionally includes the JMX code only when compiled under Java 6. > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615374#action_12615374 ] Andrew Kornev commented on ZOOKEEPER-81: I don't think you actually build the jmx code under 1.5 -- build.xml silently excludes the java\jmx directory from the build. > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615704#action_12615704 ] Andrew Kornev commented on ZOOKEEPER-81: Long story short -- MXBean is a runtime dependency. Some internal machinery for handling user defined MXBeans is missing in Java 5. For details please refer to http://java.sun.com/javase/6/docs/technotes/guides/jmx/enhancements.html. The second bullet on the top says: ??MXBeans have been added. MXBeans are MBeans that provide a convenient way to bundle related values together without requiring clients to be specially configured to handle the bundles. A defined set of MXBeans already existed in the J2SE 5.0 platform, but Java SE 6 introduces an API to allow you to program your own custom MXBeans.?? Although there is absolutely nothing wrong with your patch, would you be terribly disappointed if I leave the things the way they are and simply close this jira as "won't fix"? :-) > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615741#action_12615741 ] Andrew Kornev commented on ZOOKEEPER-81: Would you like to verify whether or not there is a Java 6 runtime dependency? Would you be willing to contribute a patch (including this change) to break such a dependency? Would you be interested in implementing additional JMX beans? You can find some ideas here http://sourceforge.net/tracker/index.php?func=detail&aid=1894138&group_id=209147&atid=1008547 .Things like enabling/disabling tracing thru a JMX Console seem to be useful. > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev closed ZOOKEEPER-81. -- > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-81: --- Resolution: Fixed Status: Resolved (was: Patch Available) > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615760#action_12615760 ] Andrew Kornev commented on ZOOKEEPER-81: Committed! Thanks Hiram! > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616599#action_12616599 ] Andrew Kornev commented on ZOOKEEPER-39: No, this patch doesn't take care of ZOOKEEPER-50, which is a bug in the Java client code. This patch is for the C client only. > Use Watcher objects rather than boolean on read operations > -- > > Key: ZOOKEEPER-39 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-39.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1962501&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-26) monitoring and management via JMX
[ https://issues.apache.org/jira/browse/ZOOKEEPER-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev resolved ZOOKEEPER-26. Resolution: Won't Fix Fix Version/s: (was: 3.0.0) This feature was implemented and commited prior to the apache move. > monitoring and management via JMX > - > > Key: ZOOKEEPER-26 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-26 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1894138&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (ZOOKEEPER-26) monitoring and management via JMX
[ https://issues.apache.org/jira/browse/ZOOKEEPER-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev closed ZOOKEEPER-26. -- > monitoring and management via JMX > - > > Key: ZOOKEEPER-26 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-26 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Andrew Kornev > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1894138&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev reassigned ZOOKEEPER-38: -- Assignee: Benjamin Reed (was: Andrew Kornev) How's the cracking been going so far? > headers (version+) in log/snap files > > > Key: ZOOKEEPER-38 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, > ZOOKEEPER-38.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-32) CRCs for ZooKeeper data
[ https://issues.apache.org/jira/browse/ZOOKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev reassigned ZOOKEEPER-32: -- Assignee: Benjamin Reed (was: Andrew Kornev) Part of ZOOKEEPER-38 patch > CRCs for ZooKeeper data > --- > > Key: ZOOKEEPER-32 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-32 > Project: Zookeeper > Issue Type: New Feature > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1945106&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616664#action_12616664 ] Andrew Kornev commented on ZOOKEEPER-39: Verified the patch builds and the unit tests run successfully. > Use Watcher objects rather than boolean on read operations > -- > > Key: ZOOKEEPER-39 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-39.patch, ZOOKEEPER-39_license.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1962501&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev closed ZOOKEEPER-39. -- > Use Watcher objects rather than boolean on read operations > -- > > Key: ZOOKEEPER-39 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-39.patch, ZOOKEEPER-39_license.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1962501&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-39: --- Resolution: Fixed Status: Resolved (was: Patch Available) Patch committed > Use Watcher objects rather than boolean on read operations > -- > > Key: ZOOKEEPER-39 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 > Project: Zookeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Andrew Kornev > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-39.patch, ZOOKEEPER-39_license.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1962501&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620329#action_12620329 ] Andrew Kornev commented on ZOOKEEPER-110: - I'd like to point out that the hadoop's solution is non-portable. The task will fail on Windows -- it won't be able to find the executable "sh.exe". By the way, this portability issue was one of the reasons we had to use svnant. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-56) Add clover support to build.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622334#action_12622334 ] Andrew Kornev commented on ZOOKEEPER-56: +1, looks good! > Add clover support to build.xml > --- > > Key: ZOOKEEPER-56 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-56 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-56.patch, ZOOKEEPER-56.patch > > > Clover is what ASF uses for code coverage. We currently have cobertura, but > need to add support for clover (keep the existing cobertura support for > individual developers to use). Clover is run automatically by ASF Hudson. > Hadoop has support for clover in their build.xml, port their clover related > targets into zookeeper build.xml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622666#action_12622666 ] Andrew Kornev commented on ZOOKEEPER-110: - +1 I'll commit the patch and delete the svnant directory and its contents. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-110: Attachment: ZOOKEEPER-110.patch It turns out that the original patch used the task attribute "osfamily" that is only available since ant 1.7. This patch ensures that build.xml is compatible with pre-1.7 versions. The apache license headers are also included. Please review. Thanks! > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, > ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev resolved ZOOKEEPER-110. - Resolution: Fixed Hadoop Flags: [Reviewed] Commited the patch, deleted the svnant directory. Thanks, Jakob! > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, > ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
