[jira] Updated: (ZOOKEEPER-34) Optimize string deserialization
[ https://issues.apache.org/jira/browse/ZOOKEEPER-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-34: -- Fix Version/s: (was: 3.1.0) 3.2.0 Optimize string deserialization --- Key: ZOOKEEPER-34 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-34 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Fix For: 3.2.0 Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1952497group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-146) Allow clients to retrieve the list of hosts/servers from a URL
[ https://issues.apache.org/jira/browse/ZOOKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-146: --- Fix Version/s: (was: 3.1.0) 3.2.0 Allow clients to retrieve the list of hosts/servers from a URL -- Key: ZOOKEEPER-146 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-146 Project: Zookeeper Issue Type: Improvement Components: java client Affects Versions: 3.0.0 Reporter: Jakob Homan Assignee: Jakob Homan Fix For: 3.2.0 Attachments: ZOOKEEPER-146.patch As I suggested in ZOOKEEPER-107, it would be nice to allow clients to specify their hosts strings via a URL so that this can change dynamically. For instance, obtain the current list of hosts from a webpage or a file on disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-148) add jdiff support to zookeeper release process
[ https://issues.apache.org/jira/browse/ZOOKEEPER-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-148: --- Fix Version/s: (was: 3.1.0) 3.2.0 add jdiff support to zookeeper release process -- Key: ZOOKEEPER-148 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-148 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Patrick Hunt Priority: Minor Fix For: 3.2.0 Add jdiff support to enable detailed release notes on changes to java. Hadoop just added code for including that in the build: HADOOP-2421. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-149) c interface is missing tests against java server (mock only)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-149: -- Assignee: Benjamin Reed (was: Patrick Hunt) Ben is looking at system test as part of ZOOKEEPER-215 c interface is missing tests against java server (mock only) Key: ZOOKEEPER-149 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-149 Project: Zookeeper Issue Type: Improvement Components: c client Reporter: Patrick Hunt Assignee: Benjamin Reed Fix For: 3.1.0 The c client interface has unit tests but they are against mock server implementations only. We need to add tests for the c interface against live java server. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-177) needed: docs for JMX
[ https://issues.apache.org/jira/browse/ZOOKEEPER-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-177: -- Assignee: Patrick Hunt needed: docs for JMX Key: ZOOKEEPER-177 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-177 Project: Zookeeper Issue Type: Improvement Components: documentation, jmx Reporter: Robbie Scott Assignee: Patrick Hunt Fix For: 3.1.0 I don't know if this should be part of the logging section in the zookeeper admin guide (see JIRA ZOOKEEPER-166 ) but, per Patrick, related to security, ack, yea another doc, is the documentation of the JMX support that zk has -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-195) Configuration information is spread across too many docs. Consolidate into one
[ https://issues.apache.org/jira/browse/ZOOKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-195: --- Fix Version/s: (was: 3.1.0) 3.2.0 Configuration information is spread across too many docs. Consolidate into one -- Key: ZOOKEEPER-195 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-195 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.0.0 Reporter: Robbie Scott Priority: Minor Fix For: 3.2.0 Attachments: ZOOKEEPER-195.patch Original Estimate: 1h Remaining Estimate: 1h There are definition lists of the configuration parameters in both the getting started guide and in the admin guide. It should probably only exist in the administration guide in the configuration parameters section. Note that in the getting started guide, definitions of config params can be found in both - Installing and Running ZooKeeper in Single Server Mode - Running Replicated ZooKeeper -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-216) Improve logging in C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-216: --- Fix Version/s: (was: 3.1.0) 3.2.0 Improve logging in C client --- Key: ZOOKEEPER-216 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-216 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.0.0 Reporter: Patrick Hunt Fix For: 3.2.0 While debugging a client issue we saw multiple areas for improvement in C logging. It might be a good idea to also move to log4c. Anyone have experience with this? multithread an issue? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-240) Yet another npe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-240. Resolution: Fixed Assignee: Patrick Hunt fixed as part of ZOOKEEPER-268 Yet another npe --- Key: ZOOKEEPER-240 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-240 Project: Zookeeper Issue Type: Bug Components: java client Affects Versions: 3.0.1 Reporter: Flavio Paiva Junqueira Assignee: Patrick Hunt Fix For: 3.1.0 java.lang.NullPointerException at org.apache.jute.Utils.toCSVBuffer(Utils.java:234) at org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101) at org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586) at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-254) there is currently no way for a user to test session expiration in their code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-254: -- Assignee: Benjamin Reed Ben said he had an idea - to document in faq. there is currently no way for a user to test session expiration in their code - Key: ZOOKEEPER-254 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-254 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Benjamin Reed Fix For: 3.1.0 There's currently no way for a user to test session expiration in their code. We don't have any unit/system tests that verify our code handles session expiration properly. There should be a way to test session expiration. I did notice that we have the ability to terminate a session using JMX mbean interface, however I'm not sure if this is useful in an automated testing context. Even if it is we should provide a wrapper for testing purposes - and add tests to our codebase which uses it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-234) Eliminate using statics to initialize the sever. Should allow server to be more embeddable in OSGi enviorments.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-234:
---
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 734847.
Eliminate using statics to initialize the sever. Should allow server to be
more embeddable in OSGi enviorments.
Key: ZOOKEEPER-234
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-234
Project: Zookeeper
Issue Type: Improvement
Components: server
Reporter: Hiram Chirino
Assignee: Patrick Hunt
Fix For: 3.1.0
Attachments: ZOOKEEPER-234_step1.patch, ZOOKEEPER-234_step3.patch
Patrick request I open up this in issue in this [email
thread|http://n2.nabble.com/ActiveMQ-is-now-using-ZooKeeper-td1573272.html]
The main culprit I've noticed is:
{code}
ServerStats.registerAsConcrete();
{code}
But there may be others.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-177) needed: docs for JMX
[ https://issues.apache.org/jira/browse/ZOOKEEPER-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-177: --- Attachment: ZOOKEEPER-177.patch This addresses the desc/comments in this jira so far. In particular I've documented the JMX management capabilities and also detailed the objects available. Also updated the zkServer to properly start a locally manageable zk instance. (point to sun docs for more details). needed: docs for JMX Key: ZOOKEEPER-177 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-177 Project: Zookeeper Issue Type: Improvement Components: documentation, jmx Reporter: Robbie Scott Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-177.patch I don't know if this should be part of the logging section in the zookeeper admin guide (see JIRA ZOOKEEPER-166 ) but, per Patrick, related to security, ack, yea another doc, is the documentation of the JMX support that zk has -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-253) documentation of DataWatcher state transition is misleading regarding auto watch reset on reconnect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-253: --- Attachment: ZOOKEEPER-253.patch This patch updates the forrest doc to correctly discuss watch re-establishment during re-sync to a server in the cluster. documentation of DataWatcher state transition is misleading regarding auto watch reset on reconnect --- Key: ZOOKEEPER-253 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-253 Project: Zookeeper Issue Type: Bug Components: documentation Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-253.patch the example code has case SyncConnected: // Everything is happy. Lets kick things off // again by checking the existence of the znode break; this is misleading - it should indicate that the watches are automatically reset and therefor no call to exists is necessary also fix this in the same doc (looks like its old detail, no longer valid), indicate that autoreset will happen on reconnect. If the client-side ZooKeeper libraries can reestablish the communication channel to ZooKeeper, DataMonitor simply kicks everything off again with the call to ZooKeeper.exists(). If it gets an event for a znode, it calls ZooKeeper.exists() to find out what has changed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-253) documentation of DataWatcher state transition is misleading regarding auto watch reset on reconnect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-253: --- Status: Patch Available (was: Open) documentation of DataWatcher state transition is misleading regarding auto watch reset on reconnect --- Key: ZOOKEEPER-253 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-253 Project: Zookeeper Issue Type: Bug Components: documentation Affects Versions: 3.0.1, 3.0.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-253.patch the example code has case SyncConnected: // Everything is happy. Lets kick things off // again by checking the existence of the znode break; this is misleading - it should indicate that the watches are automatically reset and therefor no call to exists is necessary also fix this in the same doc (looks like its old detail, no longer valid), indicate that autoreset will happen on reconnect. If the client-side ZooKeeper libraries can reestablish the communication channel to ZooKeeper, DataMonitor simply kicks everything off again with the call to ZooKeeper.exists(). If it gets an event for a znode, it calls ZooKeeper.exists() to find out what has changed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-273: --- Fix Version/s: 3.1.0 Status: Open (was: Patch Available) Unfortunately this patch removes cppunit entirely from ac, we need cppunit for the tests. Rather this patch should make cppunit an option for configure - ie on by default, with a commmand line option to configure to turn off. I think there is a std way to do this in ac. Zookeeper c client build should not depend on CPPUNIT - Key: ZOOKEEPER-273 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Runping Qi Fix For: 3.1.0 Attachments: patch_zookeeper_273.txt One should be able to build Zookeeper C client libs on a machine without CPPUNIT installation. A simple fix is to remove from configure.ac the following line: M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-275) Bug in FastLeaderElection
[ https://issues.apache.org/jira/browse/ZOOKEEPER-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666786#action_12666786 ] Patrick Hunt commented on ZOOKEEPER-275: What do you mean by kill qcnxmanager? During the kill is the code explicitly closing the port? It might be that the socket isn't being closed explicitly? (relies on gc?) Ensure that the code will explicitly close the port if killed. If you're done on this issue you might consider submitting the patch for review. Bug in FastLeaderElection - Key: ZOOKEEPER-275 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-275 Project: Zookeeper Issue Type: Bug Components: leaderElection Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.1.0 Attachments: ZOOKEEPER-275.patch I found an execution in which leader election does not make progress. Here is the problematic scenario: - We have an ensemble of 3 servers, and we start only 2; - We let them elect a leader, and then crash the one with lowest id, say S_1 (call the other S_2); - We restart the crashed server. Upon restarting S_1, S_2 has its logical clock more advanced, and S_1 has its logical clock set to 1. Once S_1 receives a notification from S_2, it notices that it is in the wrong round and it advances its logical clock to the same value as S_1. Now, the problem comes exactly in this point because in the current code S_1 resets its vote to its initial vote (its own id and zxid). Since S_2 has already notified S_1, it won't do it again, and we are stuck. The patch I'm submitting fixes this problem by setting the vote of S_1 to the one received if it satisfies the total order predicate (received zxid is higher or received zxid is the same and received id is higher). Related to this problem, I noticed that by trying to avoid unnecessary notification duplicates, there could be scenarios in which a server fails before electing a leader and restarts before leader election succeeds. This could happen, for example, when there isn't enough servers available and one available crashes and restarts. I fixed this problem in the attached patch by allowing a server to send a new batch of notifications if there is at least one outgoing queue of pending notifications empty. This is ok because we space out consecutive batches of notifications. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-263) document connection host:port as comma separated list in forrest docs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-263: --- Attachment: ZOOKEEPER-263.patch Updated documentation to better reflect host connection string syntax/semantics. document connection host:port as comma separated list in forrest docs - Key: ZOOKEEPER-263 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-263 Project: Zookeeper Issue Type: Improvement Components: c client, documentation, java client Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-263.patch The java API docs talk about the host:port comma separated list, however the forrest docs don't mention this. it's confusing for users, they don't know that the connection string can be a list of host:port comma separated. We should mention in the programmer guide, perhaps even in the overview/started (mention in passing and reference the prog guide for full detail). Also the java doc should be updated, right now we have a see also in the short constructor, to make it more explicit we should copy/paste the docs. The c client should also be updated to detail that it's a comma separated list of host:port (similar to java). Right host we just say host, need to be more explicit as to the format of the string. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-269) connectionloss - add more documentation to detail
[ https://issues.apache.org/jira/browse/ZOOKEEPER-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-269: --- Attachment: ZOOKEEPER-269.patch Added doc details per the bug desc/comments. Kept things fairly high level - don't want to talk about api details in forrest, really need those in doxy/javadoc. connectionloss - add more documentation to detail -- Key: ZOOKEEPER-269 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-269 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-269.patch discussion with user, this should be better documented: -- There are basically 2 cases where you can see connectionloss: 1) you call an operation on a session that is no longer alive 2) you are disconnected from a server when there are pending async operations to that server (you made an async request which has not yet completed) Patrick Kevin Burton wrote: Can this be thrown when using multiple servers as long as 1 of them is online? Trying to figure out of I should try some type of reconnect if a single machine fails instead of failing altogether. Kevin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-269) connectionloss - add more documentation to detail
[ https://issues.apache.org/jira/browse/ZOOKEEPER-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-269: --- Assignee: Patrick Hunt Status: Patch Available (was: Open) connectionloss - add more documentation to detail -- Key: ZOOKEEPER-269 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-269 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.0.1, 3.0.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-269.patch discussion with user, this should be better documented: -- There are basically 2 cases where you can see connectionloss: 1) you call an operation on a session that is no longer alive 2) you are disconnected from a server when there are pending async operations to that server (you made an async request which has not yet completed) Patrick Kevin Burton wrote: Can this be thrown when using multiple servers as long as 1 of them is online? Trying to figure out of I should try some type of reconnect if a single machine fails instead of failing altogether. Kevin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-277) Define PATH_SEPARATOR
[ https://issues.apache.org/jira/browse/ZOOKEEPER-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-277: --- Component/s: tests server java client documentation c client Define PATH_SEPARATOR - Key: ZOOKEEPER-277 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-277 Project: Zookeeper Issue Type: Improvement Components: c client, documentation, java client, server, tests Reporter: Nitay Joffe Priority: Trivial We should define a constant for PATH_SEPARATOR = / and use that throughout the code rather than the hardcoded /. Users can be told to use this constant to be safe in case of future changes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-278) Create a test jar
[ https://issues.apache.org/jira/browse/ZOOKEEPER-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667842#action_12667842 ] Patrick Hunt commented on ZOOKEEPER-278: We've pushed a bunch of common test functionality into ClientBase, including much of the setup/teardown. However there are still some cases where we could do better. ;-) 3.1 is adding system test support so hopefully this will get better as we move things that are really system tests into system test and out of unit test. Create a test jar - Key: ZOOKEEPER-278 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-278 Project: Zookeeper Issue Type: Improvement Components: tests Reporter: Nitay Joffe Priority: Minor I am working on integrating ZooKeeper into HBase. I've found myself copying a lot of the test infrastructure code from places like zk.t.QuorumTest to create classes like MiniZooKeeper so that I can test my new additions in HBase. I think things would be a lot easier if we shipped a ZooKeeper test jar for others to use. Additionally, I think we should clean up the test code a bit so that the tests use some common infrastructure rather than each doing its own setup/teardown of a ZK cluster. I believe this is how things are done for testing Hadoop things HBase. For more context, see hbase-1144.patch in https://issues.apache.org/jira/browse/HBASE-1144 I would do this myself but I can't currently contribute to Apache projects other than HBase because of company issues. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-16: -- Status: Patch Available (was: Open) Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Affects Versions: 3.0.1, 3.0.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch, ZOOKEEPER-16.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-16: -- Attachment: ZOOKEEPER-16.patch Remerged against the mainline. Not declaring throws IAE because it's a runtime exception - but I did document in the javadoc for the effected methods. Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch, ZOOKEEPER-16.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-69) ZooKeeper logo
[ https://issues.apache.org/jira/browse/ZOOKEEPER-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-69: -- Hadoop Flags: [Reviewed] Marking as reviewed - approved by community. Ben will update forrest docs to have small icon. Ben will commit the image original into svn under zookeeper/logo ZooKeeper logo -- Key: ZOOKEEPER-69 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-69 Project: Zookeeper Issue Type: Wish Components: documentation Reporter: Flavio Paiva Junqueira Assignee: Benjamin Reed Priority: Minor Fix For: 3.1.0 Attachments: pbzk.gif, zk_logo_use.png, zk_logo_use2.png, zookeeper-sketch.jpg I think we need a cool logo for the project. The ones I've seen so far are a little lame, and that includes the one I've created for SourceForge. If anyone on this list has an idea or knows of anyone with some art skills, plese add a commento to this Jira. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-276) Bookkeeper contribution
[ https://issues.apache.org/jira/browse/ZOOKEEPER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-276: -- Assignee: Flavio Paiva Junqueira Bookkeeper contribution --- Key: ZOOKEEPER-276 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-276 Project: Zookeeper Issue Type: New Feature Reporter: Luca Telloli Assignee: Flavio Paiva Junqueira Attachments: ZOOKEEPER-276.patch BookKeeper is a system to reliably log streams of records. In BookKeeper, servers are bookies, log streams are ledgers, and each unit of a log (aka record) is a ledger entry. BookKeeper is designed to be reliable; bookies, the servers that store ledgers can be byzantine, which means that some subset of the bookies can fail, corrupt data, discard data, but as long as there are enough correctly behaving servers the service as a whole behaves correctly; the meta data for BookKeeper is stored in ZooKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-276) Bookkeeper contribution
[ https://issues.apache.org/jira/browse/ZOOKEEPER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-276: --- Fix Version/s: 3.1.0 Bookkeeper contribution --- Key: ZOOKEEPER-276 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-276 Project: Zookeeper Issue Type: New Feature Reporter: Luca Telloli Assignee: Flavio Paiva Junqueira Fix For: 3.1.0 Attachments: ZOOKEEPER-276.patch BookKeeper is a system to reliably log streams of records. In BookKeeper, servers are bookies, log streams are ledgers, and each unit of a log (aka record) is a ledger entry. BookKeeper is designed to be reliable; bookies, the servers that store ledgers can be byzantine, which means that some subset of the bookies can fail, corrupt data, discard data, but as long as there are enough correctly behaving servers the service as a whole behaves correctly; the meta data for BookKeeper is stored in ZooKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-215) expand system test environment
[ https://issues.apache.org/jira/browse/ZOOKEEPER-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-215: --- Status: Open (was: Patch Available) Found some issues with this. In particular the docs. I'll upload a new patch for that (also license issues). But there is still an issue with running the tests. ant is not picking up the system tests. perhaps add the ability to run system tests to the fatjar? expand system test environment -- Key: ZOOKEEPER-215 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-215 Project: Zookeeper Issue Type: New Feature Components: tests Reporter: Patrick Hunt Assignee: Benjamin Reed Fix For: 3.1.0 Attachments: ZOOKEEPER-215.patch, ZOOKEEPER-215.patch Currently our system tests are lumped in with our unit tests. It would be great to have a system test environment where we could run larger scale testing. Say you have 20 hosts, and you would like to test a serving ensemble with 7 servers and 100 clients running particular operations. It should be easy to test this scenario. Additionally during the test it should be possible to simulate serving node failure, etc... I've had a brief conversation with Ben about this and he's going to take this JIRA. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12668546#action_12668546 ] Patrick Hunt commented on ZOOKEEPER-281: A web search seems to indicate that there are problems with doxygen's autoconf integration: http://www.nabble.com/aclocal-1.9-and-aclocal-1.10-are-failing-while-aclocal-1.7-is-not-td18647659.html can you try editing acinclude.m4 line 79 to look like: if test $DX_FLAG_$[DX_CURRENT_FEATURE$$1] = 1; then and retry? autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Attachments: autoreconf.log autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-16: -- Attachment: ZOOKEEPER-16.patch Included Ben's suggestion regarding c client check. Also fixed a test broken by other commit. Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch, ZOOKEEPER-16.patch, ZOOKEEPER-16.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-260) document the recommended values for server id's
[ https://issues.apache.org/jira/browse/ZOOKEEPER-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-260: --- Attachment: ZOOKEEPER-260.patch Made a small change (removed unnecessary implementation detail from user docs), otw looks good. document the recommended values for server id's --- Key: ZOOKEEPER-260 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-260 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.0.0, 3.0.1 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.1.0 Attachments: ZOOKEEPER-260.patch, ZOOKEEPER-260.patch currently we do nto doucment the recommended values for server id's. we should document that. For some large values of server id's we might get negative session's and also might get duplicate sessions from two servers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-215) expand system test environment
[ https://issues.apache.org/jira/browse/ZOOKEEPER-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-215: --- Attachment: ZOOKEEPER-215.patch fixes a small typo in the patch expand system test environment -- Key: ZOOKEEPER-215 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-215 Project: Zookeeper Issue Type: New Feature Components: tests Reporter: Patrick Hunt Assignee: Benjamin Reed Fix For: 3.1.0 Attachments: ZOOKEEPER-215.patch, ZOOKEEPER-215.patch, ZOOKEEPER-215.patch, ZOOKEEPER-215.patch, ZOOKEEPER-215.patch, ZOOKEEPER-215.patch Currently our system tests are lumped in with our unit tests. It would be great to have a system test environment where we could run larger scale testing. Say you have 20 hosts, and you would like to test a serving ensemble with 7 servers and 100 clients running particular operations. It should be easy to test this scenario. Additionally during the test it should be possible to simulate serving node failure, etc... I've had a brief conversation with Ben about this and he's going to take this JIRA. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-215) expand system test environment
[ https://issues.apache.org/jira/browse/ZOOKEEPER-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-215: --- Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed revision 739475. expand system test environment -- Key: ZOOKEEPER-215 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-215 Project: Zookeeper Issue Type: New Feature Components: tests Reporter: Patrick Hunt Assignee: Benjamin Reed Fix For: 3.1.0 Attachments: ZOOKEEPER-215.patch, ZOOKEEPER-215.patch, ZOOKEEPER-215.patch, ZOOKEEPER-215.patch, ZOOKEEPER-215.patch, ZOOKEEPER-215.patch Currently our system tests are lumped in with our unit tests. It would be great to have a system test environment where we could run larger scale testing. Say you have 20 hosts, and you would like to test a serving ensemble with 7 servers and 100 clients running particular operations. It should be easy to test this scenario. Additionally during the test it should be possible to simulate serving node failure, etc... I've had a brief conversation with Ben about this and he's going to take this JIRA. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-229) improve documentation regarding user's responsibility to cleanup datadir (snaps/logs)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-229: --- Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed revision 739480. improve documentation regarding user's responsibility to cleanup datadir (snaps/logs) - Key: ZOOKEEPER-229 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-229 Project: Zookeeper Issue Type: Improvement Components: documentation, server Affects Versions: 3.0.0 Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.1.0 Attachments: ZOOKEEPER-229.patch, ZOOKEEPER-229.patch It's not very obvious in the docs that the operator of the zk server is responsible for managing the files in the datadir: http://hadoop.apache.org/zookeeper/docs/r3.0.0/zookeeperAdmin.html#File+Management specifically removing the old snaps/transactionallogs we need to make this more obvious, perhaps call it out in the quickstart (note pointing to this document) Perhaps we should include example script and cron as well (docs) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-231) Quotas in zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-231: --- Status: Open (was: Patch Available) there are a number of issues I found, I have an updated patch in progress Quotas in zookeeper --- Key: ZOOKEEPER-231 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-231 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.0.0 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.1.0 Attachments: ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch creating quota's in zookeeper so that a runaway application does not bring down the zookeeper cluster. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-231) Quotas in zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-231: --- Status: Patch Available (was: Open) Quotas in zookeeper --- Key: ZOOKEEPER-231 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-231 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.0.0 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.1.0 Attachments: ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch creating quota's in zookeeper so that a runaway application does not bring down the zookeeper cluster. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-220) programming guide watches section should clarify server/clientlib role in data/child watch maint.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-220: --- Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed revision 740141. programming guide watches section should clarify server/clientlib role in data/child watch maint. - Key: ZOOKEEPER-220 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-220 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.1.0 Environment: http://hadoop.apache.org/zookeeper/docs/r3.0.0/zookeeperProgrammers.html#ch_zkWatchesonly Reporter: Patrick Hunt Assignee: Benjamin Reed Fix For: 3.1.0 Attachments: ZOOKEEPER-220.patch, ZOOKEEPER-220.patch http://hadoop.apache.org/zookeeper/docs/r3.0.0/zookeeperProgrammers.html#ch_zkWatches The server is maintaining two lists, it's not really clear in some sections that it's the server, esp as in v3 the client is also maintaining it's own list(s). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-287) high cpu utilization caused by nioserver factory thread
high cpu utilization caused by nioserver factory thread --- Key: ZOOKEEPER-287 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-287 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.0.1 Environment: Linux 2.6.9-67.ELsmp #1 SMP Wed Nov 7 13:58:04 EST 2007 i686 i686 i386 GNU/Linux the servers were running in vmware vms java version 1.6.0_06 Java(TM) SE Runtime Environment (build 1.6.0_06-b02) Java HotSpot(TM) Client VM (build 10.0-b22, mixed mode) Reporter: Patrick Hunt Priority: Critical a user reported that a long running server, part of a 2 server ensemble, started using 100%cpu (1 server of the ensemble, the other was fine). mahadev tracked it down to a thread in the server running epoll in a tight loop - the thread was the nio server factory thread that selects on client fds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-281: --- Attachment: ZOOKEEPER-281.patch fix to acinclude.m4 to see if doxygen issue can be resolved. autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Attachments: autoreconf.log, ZOOKEEPER-281.patch autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-281: --- Attachment: configure.gz sample configure script is attached at configure.gz, generated using patched acinclude file autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Attachments: autoreconf.log, configure.gz, ZOOKEEPER-281.patch autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-289) add debug messages to nioserver select loop.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-289: --- Attachment: ZOOKEEPER-289.patch changed the sock==null to be a warning since this is a very bad/unlikely case. also updated the message to include the session id to help in debugging. add debug messages to nioserver select loop. Key: ZOOKEEPER-289 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-289 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.0.0, 3.0.1 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.1.0 Attachments: ZOOKEEPER-289.patch, ZOOKEEPER-289.patch add some debug messages for any unexpected behaviour on select i/o in NIOServerCnxn. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-246) review error code definition in both source and docs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-246: --- Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed]) review error code definition in both source and docs Key: ZOOKEEPER-246 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-246 Project: Zookeeper Issue Type: Improvement Components: c client, documentation, java client Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-246.patch, ZOOKEEPER-246.patch, ZOOKEEPER-246.patch A number of users have mentioned that our use of calculated values for error codes makes it very difficult to track error reports from the logs. In both c/java we have: int ERROR = 100 int X_ERROR= ERROR + 1 int Y_ERROR= ERROR + 2 etc... which makes it difficult to grep/search for 101 and find these references. A number of users have mentioned that having non-calculated values (ie X_ERROR=101) would make it easier. I personally find calculated constants like this an anti-pattern. We should convert these values to non-calculated at a minimum, perhaps even redefine them as enums if possible. Also documentation, esp in the c code (the names btw c and java don't match btw) is lacking. We need to beef up docs in this area. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-291: --- Attachment: ZOOKEEPER-291.patch I added tests (that failed w/o the changes) to verify that legacy code will work ok using the deprecated constants in switch case statements. Also added tests to make sure the new enums work too :-) regression for legacy code using KeeperException.Code constants (due to 246) Key: ZOOKEEPER-291 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291 Project: Zookeeper Issue Type: Bug Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-291.patch In 246 the old constants were deprecated and replace with enum. In the process usage of the orig constants was broken for switch statements, cases require compiletime constants. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-295) prevent multiple namespace pollution by C API
[ https://issues.apache.org/jira/browse/ZOOKEEPER-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-295: --- Fix Version/s: 4.0.0 sounds good for 4 prevent multiple namespace pollution by C API - Key: ZOOKEEPER-295 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-295 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Fix For: 4.0.0 The ZOOKEEPER-6 issue touched on the problem of namespace pollution by the ZooKeeper C API; this report was closed but I don't think the problem has actually been substantially resolved. There are multiple namespaces to consider. First, the names of the C include files should ideally have a common prefix, e.g., zoo_recordio.h, or else be concatenated into a single zookeeper.h file. The zookeeper.jute.h include file has a reasonably good name in this regard. Second, all macros should ideally have a common prefix, e.g., ZOO_ or ZK_ or ZOOKEEPER_. Currently many exported constants (not macros) have the ZOO_ prefix, such as ZOO_PERM_READ, but error codes have a Z prefix, e.g., ZOK, ZNOTEMPTY. Third, all functions should ideally have a common prefix, e.g., zoo_ or zk_ or zookeeper_. Many do already, but there is some variation, such as zookeeper_init(), zookeeper_process(), and there are also a large number of functions which have no prefix. These include many of the functions defined in recordio.h and zookeeper.jute.h, such as get_buffer() and serialize_Id(). Many others are simply used internally within the ZooKeeper C library and not declared in an external include file, but still pollute the caller's namespace, e.g., get_xid(), process_completions(), adaptor_init(), etc. All external symbols in the libraries should have a common prefix. Fourth, all structure and type definitions should also have a common prefix, again, zoo_ or zk_ or zookeeper_. This is especially true of structures which currently have very generic names such as Id, Stat, and ACL from zookeeper.jute.h; buffer, iarchive, and oarchive from recordio.h; and clientid_t and watcher_fn from zookeeper.h. The zhandle_t structure should also be renamed to have the same prefix, e.g., zoo_handle_t. The ZOOKEEPER-6 report includes the comment that the names in zookeeper.jute.h will be difficult to change because they affect the Java code and that there should be limited exposure since jute naming starts with caps. It would be nice to think so, but I fear that a structure named Id or Stat is going to be pretty darn commonplace in other people's code. I would strongly recommend revising the entire set file, function, macro, type and structure names for 4.0.0. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-297) centralize version numbering in the source/build
centralize version numbering in the source/build Key: ZOOKEEPER-297 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.1.0 Reporter: Patrick Hunt Priority: Minor Fix For: 3.2.0 There are now three locations in the source repository that store the version number of the code: 1) build.xml 2) configure.ac 3) zookeeper_version.h these all have to be managed when releasing/branching/etc... would be better if there were just one place - at the very least the configure.ac should be used to generate the version for zookeeper_version.h. Can we do a better job (ie less) at this? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-298) some excecutables (scripts typ.) are not marked as such in tar generated by ant tar
some excecutables (scripts typ.) are not marked as such in tar generated by ant tar - Key: ZOOKEEPER-298 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-298 Project: Zookeeper Issue Type: Bug Components: build Affects Versions: 3.1.0 Reporter: Patrick Hunt Fix For: 3.2.0 The configure scripts in src/c, the zkServer.sh in src/c/test, and some of the other scripts are not marked as executable when running ant tar. The build.xml should be updated to mark appropriately. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)
zk jmx code is calling printStackTrace when creating bean name (should not be) -- Key: ZOOKEEPER-300 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Reporter: Patrick Hunt Fix For: 3.2.0 remove printStackTrace from zk jmx code (review the rest of the code at the same time) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670960#action_12670960 ] Patrick Hunt commented on ZOOKEEPER-300: in the case of malformedobjectnameexception we should also catch/rethrow this exception at a low enough level such that we can log (WARN) the name that was invalid (sun doesn't include that in the error message and it would be useful) zk jmx code is calling printStackTrace when creating bean name (should not be) -- Key: ZOOKEEPER-300 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Reporter: Patrick Hunt Fix For: 3.2.0 remove printStackTrace from zk jmx code (review the rest of the code at the same time) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-302) Quote values in JMX ObjectNames
[ https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-302: --- Attachment: ZOOKEEPER-302.patch modified tom's patch a bit: 1) only quote if the addr is an ipv6 addr 2) I don't think getclientport needs to be quoted (ie values) -- otw thinks like the time/date stamp would also fail (removed this from my patch) 3) removed the printstacktrace calls in mbeanregistry - replaced with proper error handling/logging. Quote values in JMX ObjectNames Key: ZOOKEEPER-302 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Reporter: Tom White Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch Some characters are not allowed in ObjectName values and need quoting, see http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html. This came up with IPv6 addresses which contain a colon character. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames
[ https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671262#action_12671262 ] Patrick Hunt commented on ZOOKEEPER-302: oops - the latest patch is ZOOKEEPER-302.patch (all caps version) be sure to review that one not the orig (all lower) Quote values in JMX ObjectNames Key: ZOOKEEPER-302 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Reporter: Tom White Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch Some characters are not allowed in ObjectName values and need quoting, see http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html. This came up with IPv6 addresses which contain a colon character. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames
[ https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671278#action_12671278 ] Patrick Hunt commented on ZOOKEEPER-302: the extra log/rethrow is just there because sun messed up on malformedobjectnameexceptin - they don't include the name that was malformed, which makes debugging hard. So -- I log then rethrow, the calling code will actually log the exception and then handle in some way - this log is just for context when reviewing the log. I could have wrapped the exception with another, but I didn't want to do that for this patch... I think we really need to take a hard look at this mbeanregistry stuff anyway, it will probably go away in the end... Quote values in JMX ObjectNames Key: ZOOKEEPER-302 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Reporter: Tom White Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch Some characters are not allowed in ObjectName values and need quoting, see http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html. This came up with IPv6 addresses which contain a colon character. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-302) Quote values in JMX ObjectNames
[ https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-302: --- Fix Version/s: 3.1.0 Assignee: Patrick Hunt Quote values in JMX ObjectNames Key: ZOOKEEPER-302 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Reporter: Tom White Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch Some characters are not allowed in ObjectName values and need quoting, see http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html. This came up with IPv6 addresses which contain a colon character. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-274) Document options to connect Jconsole remotely
[ https://issues.apache.org/jira/browse/ZOOKEEPER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-274: --- Component/s: jmx Document options to connect Jconsole remotely - Key: ZOOKEEPER-274 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-274 Project: Zookeeper Issue Type: Improvement Components: jmx Reporter: Flavio Paiva Junqueira Priority: Minor Here is the command I used: java -cp .:./zookeeper-dev.jar:/usr/local/apache-log4j-1.2.15/log4j-1.2.15.jar -Dlog4j.configuration=log4j_console.properties -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=12122 -Dcom.sun.management.jmxremote.local.only=false -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false org.apache.zookeeper.server.quorum.QuorumPeerMain zoo.cfg In addition to the ones in jira 234, we also need the following to connect remotely: -Dcom.sun.management.jmxremote.port -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false This command assumes no authentication or secure connection through ssl. To use authentication, other options are necessary, such as the password file: -Dcom.sun.management.jmxremote.password.file In general, I found the following page a good source of information on this topic: http://java.sun.com/javase/6/docs/technotes/guides/management/agent.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-309: --- Status: Open (was: Patch Available) Cancelling patch - needs tests. I suggest that tests be added for ACLs in general (not just this api) -- the cppunits are missing any kind of acl testing. core dump using zoo_get_acl() -- Key: ZOOKEEPER-309 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1, 3.0.0, 3.1.0 Reporter: Chris Darroch Fix For: 3.1.1, 3.2.0 Attachments: zookeeper.c.patch The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request. The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer. The attached patch removes this call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-310) Coverity report on issues in C client code
Coverity report on issues in C client code
--
Key: ZOOKEEPER-310
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-310
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.1.0
Reporter: Patrick Hunt
Priority: Minor
Fix For: 3.2.0
Coverity found the following issues in the c code thatwe should look at/resolve:
1) zookeeper.c
Event unterminated_case: This case (value 0) is not terminated by a 'break'
statement.
717 case 0:
718 errno = EHOSTDOWN;
Event fallthrough: The above case falls through to this one.
719 case -1:
Event unterminated_case: This case (value 0) is not terminated by a 'break'
statement.
739 case 0:
740 errno = EHOSTDOWN;
Event fallthrough: The above case falls through to this one.
741 case -1:
Event negative_return_fn: Called negative-returning function socket(2, 1, 0)
Event var_assign: NEGATIVE return value of socket assigned to signed variable
zh-fd
1099zh-fd = socket(PF_INET, SOCK_STREAM, 0);
Event negative_returns: Tracked variable zh-fd was passed to a negative sink.
1100setsockopt(zh-fd, IPPROTO_TCP, TCP_NODELAY, on,
sizeof(int));
Event deref_ptr: Directly dereferenced pointer cptr-buffer
1308cptr-buffer-curr_offset = get_buffer_len(oa);
Event check_after_deref: Pointer cptr-buffer dereferenced before NULL check
1309if (!cptr-buffer) {
cli.c
Event returned_null: Function strchr returned NULL value (checked 4 out of 5
times)
Event var_assigned: Variable ptr assigned to NULL return value from strchr
532 char *ptr = strchr(buffer, '\n');
Event dereference: Dereferencing NULL value ptr
recordio.c
Event alloc_fn: Called allocation function malloc
Event var_assign: Assigned variable buff to storage returned from
malloc(12U)
284 struct buff_struct *buff = malloc(sizeof(struct buff_struct));
Event leaked_storage: Variable buff goes out of scope
At conditional (1): !(ia != NULL) taking true path
285 if (!ia) return 0;
Event alloc_fn: Called allocation function malloc
Event var_assign: Assigned variable buff to storage returned from
malloc(12U)
301 struct buff_struct *buff = malloc(sizeof(struct buff_struct));
Event leaked_storage: Variable buff goes out of scope
At conditional (1): !(oa != NULL) taking true path
302 if (!oa) return 0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-303) Bin scripts don't work on Mac
[
https://issues.apache.org/jira/browse/ZOOKEEPER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-303:
---
Affects Version/s: 3.1.0
Fix Version/s: 3.2.0
Bin scripts don't work on Mac
-
Key: ZOOKEEPER-303
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-303
Project: Zookeeper
Issue Type: Bug
Components: scripts
Affects Versions: 3.1.0
Environment: Mac OS X
Reporter: Tom White
Assignee: Tom White
Fix For: 3.2.0
Attachments: zookeeper-303.patch
Macs don't support the -f option in readlink
{noformat}
$ bin/zkServer.sh start
JMX enabled by default
readlink: illegal option -- f
usage: readlink [-n] [file ...]
{noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-202) Phantom ephemeral node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-202: --- Fix Version/s: 3.0.0 Phantom ephemeral node -- Key: ZOOKEEPER-202 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-202 Project: Zookeeper Issue Type: Bug Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.0.0 One of our users has observed that an ephemeral znode had gone away once its creator had disconnected according to the leader, but one follower believed that it existed long after the znode had been deleted. Apparently the follower was never going to delete it. Because the leader wouldn't recognize the znode as an existing one, any attempt to delete the znode failed. We have to investigate if this is related to any known bug, although, to my knowledge, this is the first time it happens. It is important to note that the user was running an older version of our code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-327) document effects (latency) of storing large amounts of data in znodes
document effects (latency) of storing large amounts of data in znodes - Key: ZOOKEEPER-327 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-327 Project: Zookeeper Issue Type: Improvement Components: documentation Reporter: Patrick Hunt Priority: Minor Fix For: 3.1.1, 3.2.0 znodes have max 1mb of data storage. using zk to store large amounts of data can negatively impact latency as seen by clients - the server needs to serve the data. often it's a better idea to store a token (say a uri) in the znode pointing to a large data block stored elsewhere (filesystem? memcached, etc...) this offloads zk and reduces latency impact we should have details of this in the forrest docs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-329) document how to integrate 3rd party authentication into ZK server ACLs
document how to integrate 3rd party authentication into ZK server ACLs -- Key: ZOOKEEPER-329 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-329 Project: Zookeeper Issue Type: Improvement Components: documentation Reporter: Patrick Hunt Priority: Minor Fix For: 3.1.1, 3.2.0 the docs mention that zk supports pluggable auth schemes but doesn't detail the API/examples. We should add this to the docs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-324) do not materialize strings in the server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12676829#action_12676829 ] Patrick Hunt commented on ZOOKEEPER-324: there's another issue related to this. we have multiple instances of the same string instantiated in various parts of the code (issue regardless of string vs byte representation) if canonicalize (like String intern) we can save significant amounts of memory. For example registering watches on a node (each client registering would use the same string, vs currently using diff strings). We just need to ensure the String/byte[] is immutable (not an issue with string) do not materialize strings in the server Key: ZOOKEEPER-324 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-324 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed We convert paths and authentication information to strings rather than byte[] even though we could work just as well with byte[] for our needs since we don't really interpret the strings. we are just doing basic pattern matching. the only really string manipulations we do with paths is to look for '/', but we could easily to that with byte[] since we use utf8 encoding for the strings. by not materializing the strings we save time doing the serializations and also space since most (almost all) of our strings are ASCII and thus just one byte. we could probably get by without even changing the jute spec if we make the generated classes check for a flag to see whether strings should be treated as byte[] or String. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-99) All MXBeans interfaces that don't use complex paramters need to be renamed as MBean interaces.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677437#action_12677437 ] Patrick Hunt commented on ZOOKEEPER-99: --- Hi Eric, I'm not an expert on jmx, but I believe the original contributors of this code used mxbeans for a reason. In particular: See this blog post by one of the authors of mxbeans: http://weblogs.java.net/blog/emcmanus/archive/2006/02/what_is_an_mxbe.html Going forward, it will generally be a good idea to write an MXBean wherever you would write a Standard MBean today. http://java.sun.com/javase/6/docs/api/javax/management/MXBean.html The MXBean concept provides a simple way to code an MBean that only references a predefined set of types, the ones defined by javax.management.openmbean. In this way, you can be sure that your MBean will be usable by any client, including remote clients, without any requirement that the client have access to model-specific classes representing the types of your MBeans. http://marxsoftware.blogspot.com/2008/06/jmx-mxbean.html MXBeans in Java SE 6: Bundling Values without Special JMX Client Configurations recommends using MXBeans in any Java SE 6 application where Standard MBeans may have been used before moving to Java SE 6. This blog post also shows that in some cases JMX UIs render the bean fields better with mxbeans than with std mbeans Can you explain a bit about why ZooKeeper cannot be embedded into JBoss currently? Doesn't JBoss support MXBeans? This was standardized in java6, no? (that mxbeans are included in 1.6). From what I read it seems like moving from mx - standard mbeans is a step back. But I'd like to understand the problems seen with JBoss. If you can include some code/config that I could easily deploy into JBoss I'd be happy to try it out myself - perhaps we could include this in our testing regime so that we maintain compatibility going forward. ps. we dropped java5 support in 3.1, we now only support java6, so the original description of the jira is stale. See ZOOKEEPER-210 All MXBeans interfaces that don't use complex paramters need to be renamed as MBean interaces. --- Key: ZOOKEEPER-99 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-99 Project: Zookeeper Issue Type: Bug Components: jmx Reporter: Hiram Chirino Attachments: ZOOKEEPER-99.patch All the MXBean interfaces that I've looked at are standard MBean interfaces. The interface names should get renamed to MBean instaead of MXBean. That way the server can also run on a the Java 1.5 Platform. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-99) All MXBeans interfaces that don't use complex paramters need to be renamed as MBean interaces.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677452#action_12677452 ] Patrick Hunt commented on ZOOKEEPER-99: --- I'd still like to try this out regardless of priority. Can you attach the basic configuration (ear file?) that I would need to try this out? I'd do it myself but I'm not familiar with JBoss and it would take some time to reproduce what you've already done. All MXBeans interfaces that don't use complex paramters need to be renamed as MBean interaces. --- Key: ZOOKEEPER-99 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-99 Project: Zookeeper Issue Type: Bug Components: jmx Reporter: Hiram Chirino Attachments: ZOOKEEPER-99.patch All the MXBean interfaces that I've looked at are standard MBean interfaces. The interface names should get renamed to MBean instaead of MXBean. That way the server can also run on a the Java 1.5 Platform. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-331) Create a privacy policy for the ZooKeeper website
Create a privacy policy for the ZooKeeper website - Key: ZOOKEEPER-331 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-331 Project: Zookeeper Issue Type: Task Components: documentation Reporter: Patrick Hunt Priority: Minor It would be great to collect analytics about the visitors to the website and to do so, we need to create a privacy policy that tells visitors what we will collect. See HADOOP-5190 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-311) handle small path lengths in zoo_create()
[
https://issues.apache.org/jira/browse/ZOOKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt reassigned ZOOKEEPER-311:
--
Assignee: Chris Darroch
handle small path lengths in zoo_create()
-
Key: ZOOKEEPER-311
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-311
Project: Zookeeper
Issue Type: Improvement
Components: c client
Affects Versions: 3.0.0, 3.0.1, 3.1.0
Reporter: Chris Darroch
Assignee: Chris Darroch
Priority: Minor
Fix For: 4.0.0
Attachments: ZOOKEEPER-311.patch, ZOOKEEPER-311.patch
The synchronous completion for zoo_create() contains the following code:\\
{noformat}
if (sc-u.str.str_len strlen(res.path)) {
len = strlen(res.path);
} else {
len = sc-u.str.str_len-1;
}
if (len 0) {
memcpy(sc-u.str.str, res.path, len);
sc-u.str.str[len] = '\0';
}
{noformat}
In the case where the max_realpath_len argument to zoo_create() is 0, none of
this code executes, which is OK. In the case where max_realpath_len is 1, a
user might expect their buffer to be filled with a null terminator, but
again, nothing will happen (even if strlen(res.path) is 0, which is unlikely
since new node's will have paths longer than /).
The name of the argument to zoo_create() is also a little misleading, as is
its description (the maximum length of real path you would want) in
zookeeper.h, and the example usage in the Programmer's Guide:
{noformat}
int rc = zoo_create(zh,/xyz,value, 5, CREATE_ONLY, ZOO_EPHEMERAL,
buffer, sizeof(buffer)-1);
{noformat}
In fact this value should be the actual length of the buffer, including space
for the null terminator. If the user supplies a max_realpath_len of 10 and a
buffer of 11 bytes, and strlen(res.path) is 10, the code will truncate the
returned value to 9 bytes and put the null terminator in the second-last
byte, leaving the final byte of the buffer unused.
It would be better, I think, to rename the realpath and max_realpath_len
arguments to something like path_buffer and path_buffer_len, akin to
zoo_set(). The path_buffer_len would be treated as the full length of the
buffer (as the code does now, in fact, but the docs suggest otherwise).
The code in the synchronous completion could then be changed as per the
attached patch.
Since this would change, slightly, the behaviour or contract of the API, I
would be inclined to suggest waiting until 4.0.0 to implement this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-319) add locking around auth info in zhandle_t
[ https://issues.apache.org/jira/browse/ZOOKEEPER-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-319: -- Assignee: Chris Darroch add locking around auth info in zhandle_t - Key: ZOOKEEPER-319 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-319 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-319.patch, ZOOKEEPER-319.patch, ZOOKEEPER-319.patch Looking over the zookeeper.c code it appears to me that the zoo_add_auth() function may be called at any time by the user in their main thread. This function alters the elements of the auth_info structure in the zhandle_t structure. Meanwhile, the IO thread may read those elements at any time in such functions as send_auth_info() and auth_completion_func(). It seems important, then, to add a lock which prevents data being read by the IO thread while only partially changed by the user's thread. The attached patch add such a lock. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-318) remove locking in zk_hashtable.c or add locking in collect_keys()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-318: -- Assignee: Chris Darroch remove locking in zk_hashtable.c or add locking in collect_keys() - Key: ZOOKEEPER-318 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-318 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.2.0, 4.0.0 Attachments: ZOOKEEPER-318.patch From a review of zk_hashtable.c it appears to me that all functions which manipulate the hashtables are called from the IO thread, and therefore any need for locking is obviated. If I'm wrong about that, then I think at a minimum collect_keys() should acquire a lock in the same manner as collect_session_watchers(). Both iterate over hashtable contents (in the latter case using copy_table()). However, from what I can see, the only function (besides the init/destroy functions used when creating a zhandle_t) called from the completion thread is deliverWatchers(), which simply iterates over a delivery list created from the hashtables by collectWatchers(). The activateWatcher() function contains comments which describe it being called by the completion thread, but in fact it is called by the IO thread in zookeeper_process(). I believe all calls to collectWatchers(), activateWatcher(), and collect_keys() are made by the IO thread in zookeeper_interest(), zookeeper_process(), check_events(), send_set_watches(), and handle_error(). Note that queue_session_event() is aliased as PROCESS_SESSION_EVENT, but appears only in handle_error() and check_events(). Also note that handle_error() is called only in zookeeper_process() and handle_socket_error_msg(), which is used only by the IO thread, so far as I can see. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-332) c client issues (memory leaks) reported by valgrind
c client issues (memory leaks) reported by valgrind --- Key: ZOOKEEPER-332 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-332 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0 Reporter: Patrick Hunt Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: valgrind_mt.out Attaching valgrind log files. 1) getpwuid_r doesn't seem like it's due to us 2) the rest seem to be valid -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-332) c client issues (memory leaks) reported by valgrind
[ https://issues.apache.org/jira/browse/ZOOKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-332: --- Attachment: valgrind_mt.out c client issues (memory leaks) reported by valgrind --- Key: ZOOKEEPER-332 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-332 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0 Reporter: Patrick Hunt Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: valgrind_mt.out Attaching valgrind log files. 1) getpwuid_r doesn't seem like it's due to us 2) the rest seem to be valid -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-332) c client issues (memory leaks) reported by valgrind
[ https://issues.apache.org/jira/browse/ZOOKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677502#action_12677502 ] Patrick Hunt commented on ZOOKEEPER-332: btw, ran valgrind like: valgrind --malloc-fill=aa --free-fill=bb --log-file=valgrind_mt.out --leak-check=yes ./zktest-mt c client issues (memory leaks) reported by valgrind --- Key: ZOOKEEPER-332 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-332 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0 Reporter: Patrick Hunt Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: valgrind_mt.out, valgrind_st.out Attaching valgrind log files. 1) getpwuid_r doesn't seem like it's due to us 2) the rest seem to be valid -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-332) c client issues (memory leaks) reported by valgrind
[ https://issues.apache.org/jira/browse/ZOOKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-332: --- Attachment: valgrind_st.out c client issues (memory leaks) reported by valgrind --- Key: ZOOKEEPER-332 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-332 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0 Reporter: Patrick Hunt Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: valgrind_mt.out, valgrind_st.out Attaching valgrind log files. 1) getpwuid_r doesn't seem like it's due to us 2) the rest seem to be valid -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Priority: Critical
Fix For: 3.1.1, 3.2.0
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*) (ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher() (TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-332) c client issues (memory leaks) reported by valgrind
[ https://issues.apache.org/jira/browse/ZOOKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678804#action_12678804 ] Patrick Hunt commented on ZOOKEEPER-332: perhaps a new jira to update the makefile to include valgrind/helgrind support? it can load the exceptions that we know about explicitly... just a thought. c client issues (memory leaks) reported by valgrind --- Key: ZOOKEEPER-332 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-332 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0 Reporter: Patrick Hunt Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: valgrind_mt.out, valgrind_st.out Attaching valgrind log files. 1) getpwuid_r doesn't seem like it's due to us 2) the rest seem to be valid -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-279) Variable expansion in zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-279:
---
Fix Version/s: 3.2.0
3.1.1
Variable expansion in zoo.cfg
-
Key: ZOOKEEPER-279
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
Project: Zookeeper
Issue Type: Improvement
Affects Versions: 3.1.0
Reporter: Nitay Joffe
Priority: Minor
Fix For: 3.1.1, 3.2.0
Attachments: HBaseQPC.java, zookeeper-279.patch
We would like to define certain parts of ZooKeeper's configuration using
variables that get substituted. For example, we want the ZooKeeper quorum to
be able to use a dataDir configured per user. In other words, something like:
tickTime=2000
dataDir=/tmp/zookeeper-${user.name}
clientPort=2181
initLimit=5
syncLimit=2
server.1=zoo1:2888:3888
server.2=zoo2:2888:3888
server.3=zoo3:2888:3888
I think Java already has a system for configuration that allows something
like this using Properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-279) Variable expansion in zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt reassigned ZOOKEEPER-279:
--
Assignee: Jean-Daniel Cryans
Variable expansion in zoo.cfg
-
Key: ZOOKEEPER-279
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
Project: Zookeeper
Issue Type: Improvement
Affects Versions: 3.1.0
Reporter: Nitay Joffe
Assignee: Jean-Daniel Cryans
Priority: Minor
Fix For: 3.1.1, 3.2.0
Attachments: HBaseQPC.java, zookeeper-279.patch
We would like to define certain parts of ZooKeeper's configuration using
variables that get substituted. For example, we want the ZooKeeper quorum to
be able to use a dataDir configured per user. In other words, something like:
tickTime=2000
dataDir=/tmp/zookeeper-${user.name}
clientPort=2181
initLimit=5
syncLimit=2
server.1=zoo1:2888:3888
server.2=zoo2:2888:3888
server.3=zoo3:2888:3888
I think Java already has a system for configuration that allows something
like this using Properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-279) Variable expansion in zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-279:
---
Attachment: zookeeper-279.patch
Updated the patch to successfully apply against the latest codebase.
+1 - will be committed for 3.1.1/3.2 releases.
Variable expansion in zoo.cfg
-
Key: ZOOKEEPER-279
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
Project: Zookeeper
Issue Type: Improvement
Affects Versions: 3.1.0
Reporter: Nitay Joffe
Assignee: Jean-Daniel Cryans
Priority: Minor
Fix For: 3.1.1, 3.2.0
Attachments: HBaseQPC.java, zookeeper-279.patch, zookeeper-279.patch
We would like to define certain parts of ZooKeeper's configuration using
variables that get substituted. For example, we want the ZooKeeper quorum to
be able to use a dataDir configured per user. In other words, something like:
tickTime=2000
dataDir=/tmp/zookeeper-${user.name}
clientPort=2181
initLimit=5
syncLimit=2
server.1=zoo1:2888:3888
server.2=zoo2:2888:3888
server.3=zoo3:2888:3888
I think Java already has a system for configuration that allows something
like this using Properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-279) Allow specialization of quorum config parsing (e.g. variable expansion in zoo.cfg)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-279:
---
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 750597. (3.1 branch)
Committed revision 750599. (mainline - 3.2)
Thanks Jean-Daniel!
Allow specialization of quorum config parsing (e.g. variable expansion in
zoo.cfg)
--
Key: ZOOKEEPER-279
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
Project: Zookeeper
Issue Type: Improvement
Affects Versions: 3.1.0
Reporter: Nitay Joffe
Assignee: Jean-Daniel Cryans
Priority: Minor
Fix For: 3.1.1, 3.2.0
Attachments: HBaseQPC.java, zookeeper-279.patch, zookeeper-279.patch
We would like to define certain parts of ZooKeeper's configuration using
variables that get substituted. For example, we want the ZooKeeper quorum to
be able to use a dataDir configured per user. In other words, something like:
tickTime=2000
dataDir=/tmp/zookeeper-${user.name}
clientPort=2181
initLimit=5
syncLimit=2
server.1=zoo1:2888:3888
server.2=zoo2:2888:3888
server.3=zoo3:2888:3888
I think Java already has a system for configuration that allows something
like this using Properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-329) document how to integrate 3rd party authentication into ZK server ACLs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-329: --- Fix Version/s: (was: 3.1.1) document how to integrate 3rd party authentication into ZK server ACLs -- Key: ZOOKEEPER-329 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-329 Project: Zookeeper Issue Type: Improvement Components: documentation Reporter: Patrick Hunt Priority: Minor Fix For: 3.2.0 the docs mention that zk supports pluggable auth schemes but doesn't detail the API/examples. We should add this to the docs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-333:
---
Attachment: helgrind_mt.out.gz
This latest gzip'd helgrind output file is from svn trunk:
At revision 751008.
Note: the tests hang at the following step:
Zookeeper_operations::testOperationsAndDisconnectConcurrently1^CKilled
I had to ctrl-c the test to stop. Perhaps this means helgrind is tickling a bad
problem(s)? We should re run helgrind after resolving the basic issues
currently in the log, and see if this hang still occurrs. Perhaps you guys
could also look at the test in question to see if anything catches your eye?
The test should not be failing.
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Critical
Fix For: 3.1.1, 3.2.0
Attachments: helgrind_mt.out, helgrind_mt.out.gz
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*)
(ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher()
(TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679677#action_12679677
]
Patrick Hunt commented on ZOOKEEPER-333:
ps. I'm on ubuntu intrepid ibex latest, single core cpu.
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Critical
Fix For: 3.1.1, 3.2.0
Attachments: helgrind_mt.out, helgrind_mt.out.gz
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*)
(ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher()
(TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680956#action_12680956 ] Patrick Hunt commented on ZOOKEEPER-78: --- I agree with Mahadev -- we want to encourage ppl to provide (interoperable) implementations for both c/java. However the JIRA should be updated to have both java and c client component listed. Should we add a new recipe component? added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-60) Get cppunit tests running as part of Hudson CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-60: - Assignee: (was: Patrick Hunt) Giri said me may look into this. There are a few pre-reqs to running the cppunit tests: 1) run ant jar from the trunk first a) generates c/java source for jute, necessary to build/run the c/tests b) run autoconf -if from the src/c dir c) run ./configure from the src/c/dir 2) cppunit is required to run the tests 3) on redhat I had to install autoconf 2.59_2, automake 1.9.4, cppunit 1.12.0 and used gcc 3 (3.4.2 to be exact) in order to run autoreconf/configure/make 4) from src/c run make run-check to run the tests make check will just compile the tests 5) the tests assume that the jar file for the server has been built a) some mock based tests are run that don't use the server jar b) some server based tests are run that do require the jar - see zkServer.sh in the test directory, run by the unit harness 6) afaik the only output of the tests is to the console (success/failure) there are two tests run by make, zktest_st and zktest_mt for the single and multi threaded tests respectively Get cppunit tests running as part of Hudson CI -- Key: ZOOKEEPER-60 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-60 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Patrick Hunt Investigate if it is possible to run cppunit tests as part of Hudson. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-309: --- Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1, good to see we are testing acls now in c client. ;-) Committed revision 752729. Committed revision 752730. core dump using zoo_get_acl() -- Key: ZOOKEEPER-309 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Mahadev konar Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request. The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer. The attached patch removes this call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-87) Follower does not shut itself down if its too far behind the leader.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-87: -- Component/s: quorum Follower does not shut itself down if its too far behind the leader. Key: ZOOKEEPER-87 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-87 Project: Zookeeper Issue Type: Bug Components: quorum Reporter: Mahadev konar Assignee: Mahadev konar Priority: Critical Fix For: 3.2.0 Currently, the follower if lagging behind keeps sending pings to the leader it will stay alive and will keep getting further and further behind the leader. The follower should shut itself down if it is not able to keep up to the leader within some limit so that gurantee of updates can be made to the clients connected to different servers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-30) Hooks for atomic broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-30: -- Component/s: quorum Hooks for atomic broadcast protocol --- Key: ZOOKEEPER-30 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-30 Project: Zookeeper Issue Type: New Feature Components: quorum Reporter: Patrick Hunt Assignee: Mahadev konar Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1938788group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-152) Improve unit tests for leader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-152: --- Component/s: quorum Improve unit tests for leader election -- Key: ZOOKEEPER-152 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-152 Project: Zookeeper Issue Type: Improvement Components: quorum Reporter: Flavio Paiva Junqueira Priority: Minor There are two possible tasks here: 1- Change the algorithm tested on QuorumTest.java; 2- Add tests for the other supported algorithms. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-166) Content needed: Logging
[ https://issues.apache.org/jira/browse/ZOOKEEPER-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-166: --- Component/s: documentation Content needed: Logging - Key: ZOOKEEPER-166 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-166 Project: Zookeeper Issue Type: Sub-task Components: documentation Reporter: Robbie Scott Original Estimate: 8h Remaining Estimate: 8h Content/information needed on Logging, from the point of view of the ZooKeeper Administrator -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-164) Content needed: Administering
[ https://issues.apache.org/jira/browse/ZOOKEEPER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-164: --- Component/s: documentation Content needed: Administering --- Key: ZOOKEEPER-164 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-164 Project: Zookeeper Issue Type: Sub-task Components: documentation Reporter: Robbie Scott Original Estimate: 8h Remaining Estimate: 8h Content/Information needed on the day to day running, management, administering of a ZooKeeper deployment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-162) Content needed: Provisioning
[ https://issues.apache.org/jira/browse/ZOOKEEPER-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-162: --- Component/s: documentation Content needed: Provisioning Key: ZOOKEEPER-162 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-162 Project: Zookeeper Issue Type: Sub-task Components: documentation Reporter: Robbie Scott Original Estimate: 8h Remaining Estimate: 8h I need the content for the ZooKeeper Admin guide, for the section on Provisioning your zookeeper deployment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-237) Add a Chroot request
[ https://issues.apache.org/jira/browse/ZOOKEEPER-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-237: --- Component/s: server java client c client Add a Chroot request Key: ZOOKEEPER-237 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-237 Project: Zookeeper Issue Type: New Feature Components: c client, java client, server Reporter: Benjamin Reed Priority: Minor It would be nice to be able to root ZooKeeper handles at specific points in the namespace, so that applications that use ZooKeeper can work in their own rooted subtree. For example, if ops decides that application X can use the subtree /apps/X and application Y can use the subtree /apps/Y, X can to a chroot to /apps/X and then all its path references can be rooted at /apps/X. Thus when X creates the path /myid, it will actually be creating the path /apps/X/myid. There are two ways we can expose this mechanism: 1) We can simply add a chroot(String path) API, or 2) we can integrate into a service identifier scheme for example zk://server1:2181,server2:2181/my/root. I like the second form personally. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-236: --- Component/s: server quorum SSL Support for Atomic Broadcast protocol - Key: ZOOKEEPER-236 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236 Project: Zookeeper Issue Type: New Feature Components: quorum, server Reporter: Benjamin Reed Priority: Minor We should have the ability to use SSL to authenticate and encrypt the traffic between ZooKeeper servers. For the most part this is a very easy change. We would probably only want to support this for TCP based leader elections. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-235) SSL Support for clients
[ https://issues.apache.org/jira/browse/ZOOKEEPER-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-235: --- Component/s: server java client c client SSL Support for clients --- Key: ZOOKEEPER-235 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-235 Project: Zookeeper Issue Type: New Feature Components: c client, java client, server Reporter: Benjamin Reed Priority: Minor ZooKeeper should be able to support SSL for ZooKeeper clients. As part of the implementation we should also add an X509AuthenticationProvider so that client side certifications can be used for authentication. The tricky part of the implementation will be integrating with the non-blocking NIO calls that we use. There are various web pages that describe how to do it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-233) Create a slimer jar for clients to reduce thier disk footprint.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-233: --- Component/s: java client build Create a slimer jar for clients to reduce thier disk footprint. --- Key: ZOOKEEPER-233 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-233 Project: Zookeeper Issue Type: New Feature Components: build, java client Reporter: Hiram Chirino Priority: Trivial Fix For: 3.2.0 Patrick request I open up this in issue in this [email thread|http://n2.nabble.com/ActiveMQ-is-now-using-ZooKeeper-td1573272.html] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-270) remove NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-270: --- Component/s: server java client remove NoSyncConnected in KeeperState - it's not used anywhere in the codebase. Key: ZOOKEEPER-270 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-270 Project: Zookeeper Issue Type: Bug Components: java client, server Reporter: Mahadev konar Fix For: 3.2.0 ZOOKEEPER-265 makes some constants deprecated. We should remove the deprecated stuff int the next release. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-238) HostAuthenicationProvider should be removed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-238: --- Component/s: server HostAuthenicationProvider should be removed --- Key: ZOOKEEPER-238 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-238 Project: Zookeeper Issue Type: Bug Components: server Reporter: Benjamin Reed I think the way the HostAuthenticationProvider is implemented could cause serious performance problems if DNS is slow or broken. The problem is that we need to do a reverse hostname resolution during connection establishment. I suggest it be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-282) the getchildren api in zookeeper should return an iterator.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-282: --- Component/s: server java client c client the getchildren api in zookeeper should return an iterator. --- Key: ZOOKEEPER-282 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-282 Project: Zookeeper Issue Type: Improvement Components: c client, java client, server Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Mahadev konar -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-300: --- Component/s: jmx zk jmx code is calling printStackTrace when creating bean name (should not be) -- Key: ZOOKEEPER-300 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300 Project: Zookeeper Issue Type: Bug Components: jmx Affects Versions: 3.1.0 Reporter: Patrick Hunt Fix For: 3.2.0 remove printStackTrace from zk jmx code (review the rest of the code at the same time) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-321) optmize session tracking in zookeeper.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-321: --- Component/s: server java client c client Fix Version/s: 3.2.0 optmize session tracking in zookeeper. -- Key: ZOOKEEPER-321 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-321 Project: Zookeeper Issue Type: New Feature Components: c client, java client, server Reporter: Mahadev konar Fix For: 3.2.0 sometimes a lot of zookeeper clients are read only. For such clients we do not need the session tracking in zookeeper. Getting rid of session tracking for such clients will help us sclae much better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-322) move examples out of docs into contrib/examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-322: --- Component/s: documentation Fix Version/s: 3.2.0 move examples out of docs into contrib/examples - Key: ZOOKEEPER-322 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-322 Project: Zookeeper Issue Type: Improvement Components: documentation Reporter: Mahadev konar Fix For: 3.2.0 move examples out of docs into contrib/examples -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-325) FLENewEpoch test fails.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-325: --- Component/s: quorum FLENewEpoch test fails. --- Key: ZOOKEEPER-325 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-325 Project: Zookeeper Issue Type: Bug Components: quorum Affects Versions: 3.1.0 Environment: linux 2.6.9-5.ELsmp Reporter: Mahadev konar Fix For: 3.2.0 Attachments: TEST-org.apache.zookeeper.test.FLENewEpochTest.txt FLENewEpochTest fails quite frequently on my machine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-237) Add a Chroot request
[ https://issues.apache.org/jira/browse/ZOOKEEPER-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-237: --- Fix Version/s: 3.2.0 Add a Chroot request Key: ZOOKEEPER-237 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-237 Project: Zookeeper Issue Type: New Feature Components: c client, java client, server Reporter: Benjamin Reed Priority: Minor Fix For: 3.2.0 It would be nice to be able to root ZooKeeper handles at specific points in the namespace, so that applications that use ZooKeeper can work in their own rooted subtree. For example, if ops decides that application X can use the subtree /apps/X and application Y can use the subtree /apps/Y, X can to a chroot to /apps/X and then all its path references can be rooted at /apps/X. Thus when X creates the path /myid, it will actually be creating the path /apps/X/myid. There are two ways we can expose this mechanism: 1) We can simply add a chroot(String path) API, or 2) we can integrate into a service identifier scheme for example zk://server1:2181,server2:2181/my/root. I like the second form personally. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-62) Generally improve logging to enable debuggability in the field.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-62: -- Fix Version/s: 3.2.0 Generally improve logging to enable debuggability in the field. --- Key: ZOOKEEPER-62 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-62 Project: Zookeeper Issue Type: Improvement Components: c client, java client, server Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: zoo-log.tgz We need to improve our logging to enable debugging of field issues. Flavio, assigning to you as you are currently looking at some client/server issues that could benefit from better logging. Please attach patches if you see potential areas for improvement. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-59) Synchronized block in NIOServerCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-59:
--
Fix Version/s: 3.2.0
Whatever happened with this patch? Seems to have gotten dropped. re-investigate
for 3.2
Synchronized block in NIOServerCnxn
---
Key: ZOOKEEPER-59
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-59
Project: Zookeeper
Issue Type: Bug
Components: server
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
Fix For: 3.2.0
Attachments: ZOOKEEPER-59.patch
There are two synchronized blocks locking on different objects, and to me
they should be guarded by the same object. Here are the parts of the code I'm
talking about:
{noformat}
nioservercnxn.readrequ...@444
...
synchronized (this) {
outstandingRequests++;
// check throttling
if (zk.getInProcess() factory.outstandingLimit) {
disableRecv();
// following lines should not be needed since we are
already
// reading
// } else {
// enableRecv();
}
}
{noformat}
{noformat}
nioservercnxn.sendrespo...@740
...
synchronized (this.factory) {
outstandingRequests--;
// check throttling
if (zk.getInProcess() factory.outstandingLimit
|| outstandingRequests 1) {
sk.selector().wakeup();
enableRecv();
}
}
{noformat}
I think the second one is correct, and the first synchronized block should be
guarded by this.factory.
This could be related to issue ZOOKEEPER-57, but I have no concrete
indication that this is the case so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
