[Zope-CMF] GenericSetup: bbq branch
Hi,
I took a look at the GS branch from the bbq sprint:
svn://svn.zope.org/repos/main/GenericSetup/branches/tseaver-bbq_sprint
or in the browser:
http://svn.zope.org/GenericSetup/branches/tseaver-bbq_sprint/
With this post I hope to spread a small beam of light on some failing
tests and get some motion on this branch again.
There are failing tests in the test_zcml.py file, along these lines:
$ bin/zopectl test -s Products.GenericSetup -m test_zcml
...
File
"/home/maurits/instances/plone3/Products/GenericSetup/tests/test_zcml.py",
line 197, in Products.GenericSetup.tests.test_zcml.test_registerUpgradeSteps
Failed example:
step1.title
Expected:
u'Bar Upgrade Step 1'
Got:
u'Foo Upgrade Step 1'
Probably the main authors of that branch already know why this fails.
The problem there is that the upgrade steps are in the wrong order.
And the part of the code that is tested here does not do anything with
the sortkey. So the upgrade steps end up in the wrong order.
I do not know if this means that the tests need to be changed or if
the underlying code needs to be changed. If the tests simply need
changing, then this may be a start. Instead of this:
>>> from Products.GenericSetup.upgrade import _upgrade_registry
>>> profile_steps = _upgrade_registry.getUpgradeStepsForProfile('default')
do this:
>>> from Products.GenericSetup.upgrade import _upgrade_registry
>>> from Products.GenericSetup.upgrade import listUpgradeSteps
>>> profile_steps = listUpgradeSteps(_upgrade_registry, 'default', '1.0')
The reason is that the listUpgradeSteps function looks to be the only
function that actually does anything with the sortkey. I might be
wrong.
I have diff here that does this and fixes up some more related tests:
http://paste.plone.org/14641
Or the most important part of that test file in new form:
http://paste.plone.org/14642
But that introduces new errors like this:
step1.handler
AttributeError: 'dict' object has no attribute 'handler'
These are unavoidable when you use the listUpgradeSteps function
though, as that returns a list with a list of dicts which indeed have
no 'handler' attribute.
I hope this report helps someone who has more clue. ;-) Maybe I can
take another look later. At any rate, the branch looks very useful
and I want it in trunk yesterday. :)
--
Maurits van Rees | http://maurits.vanrees.org/ [NL]
Work | http://zestsoftware.nl/
"Do not worry about your difficulties in computers,
I can assure you mine are still greater."
___
Zope-CMF maillist - Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf
See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] CMF Tests: 11 OK
Summary of messages to the cmf-tests list. Period Tue May 15 12:00:00 2007 UTC to Wed May 16 12:00:00 2007 UTC. There were 11 messages: 11 from CMF Unit Tests. Tests passed OK --- Subject: OK : CMF-1.5 Zope-2.7 Python-2.3.6 : Linux From: CMF Unit Tests Date: Tue May 15 21:26:28 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004983.html Subject: OK : CMF-1.5 Zope-2.8 Python-2.3.6 : Linux From: CMF Unit Tests Date: Tue May 15 21:28:01 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004984.html Subject: OK : CMF-1.5 Zope-2.9 Python-2.4.4 : Linux From: CMF Unit Tests Date: Tue May 15 21:29:31 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004985.html Subject: OK : CMF-1.6 Zope-2.8 Python-2.3.6 : Linux From: CMF Unit Tests Date: Tue May 15 21:31:02 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004986.html Subject: OK : CMF-1.6 Zope-2.9 Python-2.4.4 : Linux From: CMF Unit Tests Date: Tue May 15 21:32:33 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004987.html Subject: OK : CMF-2.0 Zope-2.9 Python-2.4.4 : Linux From: CMF Unit Tests Date: Tue May 15 21:34:04 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004988.html Subject: OK : CMF-2.0 Zope-2.10 Python-2.4.4 : Linux From: CMF Unit Tests Date: Tue May 15 21:35:35 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004989.html Subject: OK : CMF-2.1 Zope-2.10 Python-2.4.4 : Linux From: CMF Unit Tests Date: Tue May 15 21:37:06 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004990.html Subject: OK : CMF-2.1 Zope-trunk Python-2.4.4 : Linux From: CMF Unit Tests Date: Tue May 15 21:38:37 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004991.html Subject: OK : CMF-trunk Zope-2.10 Python-2.4.4 : Linux From: CMF Unit Tests Date: Tue May 15 21:40:08 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004992.html Subject: OK : CMF-trunk Zope-trunk Python-2.4.4 : Linux From: CMF Unit Tests Date: Tue May 15 21:41:39 EDT 2007 URL: http://mail.zope.org/pipermail/cmf-tests/2007-May/004993.html ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: GenericSetup: remove columns from catalog.xml
Jens Vagelpohl, on 2007-05-15: > The mailing list is a bad place for patches. True. > Please file a collector issue in the CMF collector and attach your > patches there. Done: http://www.zope.org/Collectors/CMF/483 -- Maurits van Rees | http://maurits.vanrees.org/ [NL] Work | http://zestsoftware.nl/ "Do not worry about your difficulties in computers, I can assure you mine are still greater." ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] CMF Collector: Open Issues
The following supporters have open issues assigned to them in this collector (http://www.zope.org/Collectors/CMF). Assigned and Open dreamcatcher - "setChainForPortalTypes doesn't allow to set default chain", [Accepted] http://www.zope.org/Collectors/CMF/475 mhammond - "Windows DevelopmentMode penalty in CMFCore.DirectoryView", [Accepted] http://www.zope.org/Collectors/CMF/366 Pending / Deferred Issues - "FSPropertiesObject.py cannot handle multiline input for lines, text attributes", [Deferred] http://www.zope.org/Collectors/CMF/271 - "Can't invalidate skin items in a RAMCacheManager", [Pending] http://www.zope.org/Collectors/CMF/343 - "workflow notify success should be after reindex", [Deferred] http://www.zope.org/Collectors/CMF/389 - "Possible bug when using a BTreeFolder Member folder", [Pending] http://www.zope.org/Collectors/CMF/441 - "purge_old in runAllImportSteps not working", [Pending] http://www.zope.org/Collectors/CMF/455 - "Danger from Caching Policy Manager", [Pending] http://www.zope.org/Collectors/CMF/460 - "properties setup handler: support for non-ascii strings", [Pending] http://www.zope.org/Collectors/CMF/468 - "GenericSetup does not handle non-ascii data well", [Pending] http://www.zope.org/Collectors/CMF/471 - "autocreation of catalog indexes", [Pending] http://www.zope.org/Collectors/CMF/472 - "[GS] Error when choosing initial_configuration ", [Pending] http://www.zope.org/Collectors/CMF/473 - "Workflows are missing a description attribute", [Pending] http://www.zope.org/Collectors/CMF/480 - "Member deletion fails when using PAS-based user folder", [Pending] http://www.zope.org/Collectors/CMF/481 - "Bug in TypesTool.listActions", [Pending] http://www.zope.org/Collectors/CMF/482 Pending / Deferred Features - "Favorite.py: queries and anchors in remote_url", [Pending] http://www.zope.org/Collectors/CMF/26 - "DefaultDublinCore should have Creator property", [Pending] http://www.zope.org/Collectors/CMF/61 - "Document.py: universal newlines", [Pending] http://www.zope.org/Collectors/CMF/174 - "portal_type is undefined in initialization code", [Pending] http://www.zope.org/Collectors/CMF/248 - "CMFTopic Does Not Cache", [Deferred] http://www.zope.org/Collectors/CMF/295 - "Wishlist: a flag that tags the selected action.", [Pending] http://www.zope.org/Collectors/CMF/301 - "CMFDefault should make use of allowCreate()", [Pending] http://www.zope.org/Collectors/CMF/340 - "Nested Skins", [Deferred] http://www.zope.org/Collectors/CMF/377 - "CatalogVariableProvider code + tests", [Pending] http://www.zope.org/Collectors/CMF/378 - "CMF needs View-based TypeInformation", [Pending] http://www.zope.org/Collectors/CMF/437 - "New getNextEvent Method", [Pending] http://www.zope.org/Collectors/CMF/462 - " Support 'remove' attribute for nodes in skins.xml", [Pending] http://www.zope.org/Collectors/CMF/479 ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
