[Zope-CMF] Re: [dev] five_template slots
On 3/26/06, yuppie [EMAIL PROTECTED] wrote: This is the latest revision from the CMF 1.6 branch: http://svn.zope.org/CMF/branches/1.6/CMFDefault/browser/five_template.pt?rev=40122 It is shipped with CPS 3.4 and was never changed since the initial checkin. None of your changes are used in CPS 3.4. Then I do not know what my changes are. No, because it didn't work, which is why I replaced it. Wrong. You are using the old CMF five_template in CPS 3.4. I'm getting extremely annoyed by your attitude here, when you are not prepared to explain what the problems are, what changes was made and when, but evidently want to blame them on me, but aren't listening to what I'm saying. I suggest you clearly describe exactly what you think is the problem, and make a suggestion to fix that, without any claims that anything has been broken by anyone, unless you can point out the exact checkin that the breakage happened and explain exactly why it is broken. -- Lennart Regebro, Nuxeo http://www.nuxeo.com/ CPS Content Management http://www.cps-project.org/ ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: [dev] five_template slots
Hi Lennart! Lennart Regebro wrote: On 3/26/06, yuppie y.2006_-E2EsyBC0hj3+aS/[EMAIL PROTECTED] wrote: This is the latest revision from the CMF 1.6 branch: http://svn.zope.org/CMF/branches/1.6/CMFDefault/browser/five_template.pt?rev=40122 It is shipped with CPS 3.4 and was never changed since the initial checkin. None of your changes are used in CPS 3.4. Then I do not know what my changes are. No, because it didn't work, which is why I replaced it. Wrong. You are using the old CMF five_template in CPS 3.4. I'm getting extremely annoyed by your attitude here, when you are not prepared to explain what the problems are, what changes was made and when, but evidently want to blame them on me, but aren't listening to what I'm saying. I'm listening, but not everything you say makes sense to me. And I don't want to blame anybody for that change. I just want to understand why the new five_template is better than the old one. And if it is not better, revert the change before the final release. I suggest you clearly describe exactly what you think is the problem, and make a suggestion to fix that, without any claims that anything has been broken by anyone, unless you can point out the exact checkin that the breakage happened and explain exactly why it is broken. These two checkins http://svn.zope.org/CMF/trunk/CMFDefault/skin/?rev=38594view=rev http://svn.zope.org/CMF/trunk/CMFDefault/skin/?rev=38595view=rev replaced the five_template for CMF 2.0 and trunk. In my last mail I added links to the two versions before and after that change: http://svn.zope.org/CMF/branches/1.6/CMFDefault/browser/five_template.pt?rev=40122 http://svn.zope.org/CMF/trunk/CMFDefault/skin/five_template.pt?rev=38594 That change contained two parts: 1.) Mapping 'style_slot' to 'css_slot' instead of 'style_slot'. You agreed in http://mail.zope.org/pipermail/zope-cmf/2006-March/024221.html that this was a bug and I fixed it yesterday. 2.) Adding two slots 'base' and 'header'. AFAICS these are CMF specific slots. If I did get you right you agree that providing CMF specific slots is not a good idea and CPS 3.4 / CalZope don't use these slots. This second part did not 'break' anything, but it encourages people to use CMF specific slots in views. So if we agree that providing CMF specific slots is no improvement I propose to remove them. Peace! Yuppie ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: [dev] five_template slots
On 3/26/06, yuppie [EMAIL PROTECTED] wrote: I'm listening, but not everything you say makes sense to me. And I don't want to blame anybody for that change. I just want to understand why the new five_template is better than the old one. And if it is not better, revert the change before the final release. I'm not sure what new means any more. As I remember, I fixed some problems with it becuase I had fixed them in CMFonFive, and the copy that was in CMF was old. One was that the CMF template inserted an empty line first in the page. Thats one problem I remember clearly. 1.) Mapping 'style_slot' to 'css_slot' instead of 'style_slot'. You agreed in http://mail.zope.org/pipermail/zope-cmf/2006-March/024221.html that this was a bug and I fixed it yesterday. Yup. No breakage going on, it's simply that the CPS css_slot (which I wrongly assumed was a CMF slot) has been replaced by the new standard style_slot, and C;FonFive was not updated on this when CPS was updated on it. 2.) Adding two slots 'base' and 'header'. AFAICS these are CMF specific slots. If I did get you right you agree that providing CMF specific slots is not a good idea and CPS 3.4 / CalZope don't use these slots. Right, so we can remove them. -- Lennart Regebro, Nuxeo http://www.nuxeo.com/ CPS Content Management http://www.cps-project.org/ ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: [dev] five_template slots
On 3/25/06, yuppie [EMAIL PROTECTED] wrote: Because 'css_slot' never existed in CMF, it's even gone in CPS. OK, then it's bug. Using nonexistent slots doesn't raise errors so it might not be that obvious, but the content of 'style_slot' gets lost if it is mapped to 'css_slot'. Strange, works for me here and now. I use style_slot in my templates for CalZope, and they work fine in CPS 3.4. Well, they *do* use body so we can't change that. I meant the browser view templates in CMFDefault. Oh, I don't know anything about them. -- Lennart Regebro, Nuxeo http://www.nuxeo.com/ CPS Content Management http://www.cps-project.org/ ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: [dev] five_template slots
IIRC the idea was to have a template usable from standard Zope 3 views that expected the standard Zope 3 slots, and css_slot was one of those. But I'll let Lennart answer, I've never really touched this stuff. Florent yuppie wrote: Hi! A while ago the five_template for the trunk / CMF 2.0 was replaced by the one from CMFonFive. I still have some difficulties understanding the rationale behind that change. I never got an answer to this mail: http://mail.zope.org/pipermail/zope-cmf/2006-January/023746.html AFAICS there are two use cases for the five_template: 1.) Provide generic slots used in Five and Zope 3 The five_template shipped with Five provides two slots: 'style_slot' and 'body'. The old CMF five_template did provide the same two slots. The new five_template maps 'style_slot' to a non-existent 'css_slot'. 2.) Provide cmf specific slots in @@standard_macros/page The new five_template provides 'base' and 'header', mapping them to the corresponding slots in main_template. 'body' is mapped to 'main', so all slots in main_template can be filled via the five_template. I'm not sure if we really should support that use case. At least it is less important than the first use case. Issues: --- - mapping 'style_slot' to 'css_slot' is an obvious bug, that change should be reverted - the 'header' slot behaves different than in main_template: main_template provides default content for 'header', the five_template 'header' is empty by default. I'd like to keep that in sync, but maybe we should remove the default content from main_template. Most skin templates override the 'header' slot anyway. - the Five 'body' slot doesn't map very well to the CMF 'main' slot: 'header' *and* 'main' would match better. Proposal: - 1.) Add a new 'body' slot in main_template that wraps around the 'header' and the 'main' slot. You can either use 'body' *or* 'header' and 'main'. 2.) Remove the default content in main_template's 'header' slot. 3.) Replace five_template by something like this: metal:macro metal:define-macro=page html metal:use-macro=context/main_template/macros/master head metal:slot metal:fill-slot=base metal:slot metal:define-slot=base / /metal:slot metal:slot metal:fill-slot=style_slot metal:slot metal:define-slot=style_slot / /metal:slot /head body metal:slot metal:fill-slot=body metal:slot metal:define-slot=body metal:slot metal:define-slot=header / metal:slot metal:define-slot=main / /metal:slot /metal:slot /body /html /metal:macro 4.) Change the browser view templates to use 'main' instead of 'body' (that no longer maps to 'main'). Any feedback is welcome. If there are no objections I'd like to make the proposed changes on Saturday, before the 2.0-beta2 release. Cheers, Yuppie ___ Zope-CMF maillist - [EMAIL PROTECTED] http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests -- Florent Guillaume, Nuxeo (Paris, France) Director of RD +33 1 40 33 71 59 http://nuxeo.com [EMAIL PROTECTED] ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
